Skip to contentSkip to conversation

package/criu: fix comment condition

PATCH In review Michael Nosthoff via buildroot 2 participants 3 messages Oct 28, 2024 – Nov 13, 2024

lore
Share & tools
lore

Michael Nosthoff via buildroot

author
#0 lore raw

PATCH 1/1 package/criu: fix comment condition

in e97fc89e7b a dependency on host-gcc >= 7 was added but for the comment the condition was not correctly inverted.

Fixes e97fc89e7b ("package/protobuf-c: bump to version 1.5.0")
Signed-off-by Michael Nosthoff <[email protected]>
---
 package/criu/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/criu/Config.in +1 -1
index 90bb18d355..a56dbe56ff 100644
@@ -50,4 +50,4 @@ comment "criu needs a glibc or musl toolchain w/ threads, host gcc >= 7, gcc >=
 		|| !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_18 \
 		|| BR2_TOOLCHAIN_USES_UCLIBC || !BR2_INSTALL_LIBSTDCPP \
 		|| BR2_STATIC_LIBS || !BR2_USE_WCHAR \
-		|| BR2_HOST_GCC_AT_LEAST_7
+		|| !BR2_HOST_GCC_AT_LEAST_7
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#1 lore raw
Quoted 9 lines · On Mon, 28 Oct 2024 13:44:13 +0100 Michael Nosthoff via buildroot…

in e97fc89e7b a dependency on host-gcc >= 7 was added but for the comment the condition was not correctly inverted.

Fixes e97fc89e7b ("package/protobuf-c: bump to version 1.5.0")
Signed-off-by Michael Nosthoff <[email protected]>
---
 package/criu/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Good catch: applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Michael Nosthoff via buildroot
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Michael" == Michael Nosthoff via buildroot <[email protected]> writes:

in e97fc89e7b a dependency on host-gcc >= 7 was added but for the comment the condition was not correctly inverted.

Fixes e97fc89e7b ("package/protobuf-c: bump to version 1.5.0")
Signed-off-by Michael Nosthoff <[email protected]>

Committed to 2024.02.x and 2024.08.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot