Skip to contentSkip to conversation

drm/i915: disable DMC idle states for Intel UHD Graphics 620

PATCH In review Steven 'Steve' Kendall 4 participants 4 messages Nov 11, 2022 – Nov 14, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: disable DMC idle states for Intel UHD Graphics 620

Some machines with Intel UHD Graphics 620 (8086:5917) such as Dell Latitude 7490 are unable to wake from sleep. Disable DMC for Intel UHD Graphics 620.

---
 drivers/gpu/drm/i915/i915_pci.c | 14 ++++++++++++++
 include/drm/i915_pciids.h       |  6 +++++-
 2 files changed, 19 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +14 -0
index cd4487a1d3be..ea148be46b14 100644
@@ -697,6 +697,10 @@ static const struct intel_device_info skl_gt4_info = {
 	.gt = 4,
 };
 
+#define GEN9_DMCLESS_FEATURES \
+	GEN9_FEATURES, \
+	.__runtime.has_dmc = 0
+
 #define GEN9_LP_FEATURES \
 	GEN(9), \
 	.is_lp = 1, \
@@ -753,6 +757,10 @@ static const struct intel_device_info glk_info = {
 	GEN9_FEATURES, \
 	PLATFORM(INTEL_KABYLAKE)
 
+#define KBL_DMCLESS_PLATFORM \
+	GEN9_DMCLESS_FEATURES, \
+	PLATFORM(INTEL_KABYLAKE)
+
 static const struct intel_device_info kbl_gt1_info = {
 	KBL_PLATFORM,
 	.gt = 1,
@@ -763,6 +771,11 @@ static const struct intel_device_info kbl_gt2_info = {
 	.gt = 2,
 };
 
+static const struct intel_device_info dmcless_kbl_gt2_info = {
+	KBL_DMCLESS_PLATFORM,
+	.gt = 2,
+};
+
 static const struct intel_device_info kbl_gt3_info = {
 	KBL_PLATFORM,
 	.gt = 3,
@@ -1202,6 +1215,7 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_GLK_IDS(&glk_info),
 	INTEL_KBL_GT1_IDS(&kbl_gt1_info),
 	INTEL_KBL_GT2_IDS(&kbl_gt2_info),
+	DMCLESS_INTEL_KBL_GT2_IDS(&dmcless_kbl_gt2_info),
 	INTEL_KBL_GT3_IDS(&kbl_gt3_info),
 	INTEL_KBL_GT4_IDS(&kbl_gt3_info),
 	INTEL_AML_KBL_GT2_IDS(&kbl_gt2_info),
include/drm/i915_pciids.h +5 -1
index 4a4c190f7698..93bea60772ff 100644
@@ -420,11 +420,15 @@
 	INTEL_KBL_ULT_GT2_IDS(info), \
 	INTEL_KBL_ULX_GT2_IDS(info), \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
-	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
 	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
 	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
 	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
 
+#define DMCLESS_INTEL_KBL_GT2_IDS(info) \
+	INTEL_KBL_ULT_GT2_IDS(info), \
+	INTEL_KBL_ULX_GT2_IDS(info), \
+	INTEL_VGA_DEVICE(0x5917, info) /* Mobile GT2 */
+
 #define INTEL_KBL_ULT_GT3_IDS(info) \
 	INTEL_VGA_DEVICE(0x5926, info) /* ULT GT3 */
 
Signature · 1 line
2.38.1.431.g37b22c650d-goog
#1 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: disable DMC idle states for Intel UHD Graphics 620

== Series Details ==

== Series Details ==

Series: drm/i915: disable DMC idle states for Intel UHD Graphics 620
URL : https://patchwork.freedesktop.org/series/110830/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12371 -> Patchwork_110830v1
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_110830v1 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_110830v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/index.html

Participating hosts (41 -> 40)
------------------------------

Additional (1): fi-tgl-dsi
Missing (2): fi-ctg-p8600 fi-kbl-x1275

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_110830v1:

### IGT changes ###

#### Possible regressions ####

* igt@i915_module_load@load:
- fi-bdw-gvtdvm: [PASS][1] -> [DMESG-WARN][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/fi-bdw-gvtdvm/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/fi-bdw-gvtdvm/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_110830v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][3] -> [INCOMPLETE][4] ([i915#4785])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/fi-hsw-4770/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@migrate:
- bat-adlp-4: [PASS][5] -> [INCOMPLETE][6] ([i915#7308] / [i915#7348])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/bat-adlp-4/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-adlp-4/igt@i915_selftest@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [PASS][7] -> [FAIL][8] ([i915#6298])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html

* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][9] ([fdo#109271] / [i915#4312] / [i915#5594])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/fi-hsw-4770/igt@[email protected]
- bat-adlp-4: NOTRUN -> [FAIL][10] ([i915#4312])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-adlp-4/igt@[email protected]
- fi-bdw-gvtdvm: NOTRUN -> [FAIL][11] ([i915#4312])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/fi-bdw-gvtdvm/igt@[email protected]

#### Possible fixes ####

* igt@fbdev@read:
- {bat-rpls-2}: [SKIP][12] ([i915#2582]) -> [PASS][13] +4 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/bat-rpls-2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-rpls-2/igt@[email protected]

* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][14] ([i915#2867]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/bat-rplp-1/igt@gem_exec_suspend@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-rplp-1/igt@gem_exec_suspend@[email protected]

* igt@i915_module_load@load:
- {bat-dg2-8}: [FAIL][16] ([i915#7328]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/bat-dg2-8/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-dg2-8/igt@[email protected]

* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][18] ([i915#6367]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/bat-rpls-1/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-rpls-1/igt@i915_selftest@[email protected]
- {bat-adln-1}: [DMESG-FAIL][20] ([i915#6997]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/bat-adln-1/igt@i915_selftest@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-adln-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- {bat-kbl-2}: [INCOMPLETE][22] ([i915#4817]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/bat-kbl-2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-kbl-2/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- {bat-rpls-2}: [SKIP][24] ([i915#1849]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/bat-rpls-2/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-rpls-2/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- {bat-rpls-2}: [SKIP][26] ([fdo#109295] / [i915#1845] / [i915#3708]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12371/bat-rpls-2/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/bat-rpls-2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6949]: https://gitlab.freedesktop.org/drm/intel/issues/6949
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7058]: https://gitlab.freedesktop.org/drm/intel/issues/7058
[i915#7308]: https://gitlab.freedesktop.org/drm/intel/issues/7308
[i915#7328]: https://gitlab.freedesktop.org/drm/intel/issues/7328
[i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7498]: https://gitlab.freedesktop.org/drm/intel/issues/7498

Build changes
-------------

* Linux: CI_DRM_12371 -> Patchwork_110830v1

CI-20190529: 20190529
CI_DRM_12371: 3abfcf048c08ca9c7bbaba0c57c699453fd37a2e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7051: 7da9f813cdacb80d4471fc6ddb493bae9c46913d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110830v1: 3abfcf048c08ca9c7bbaba0c57c699453fd37a2e @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

872f2b09f7a2 drm/i915: disable DMC idle states for Intel UHD Graphics 620

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110830v1/index.html

maintainer
#2 lore raw
In reply to Steven 'Steve' Kendall
Quoted 3 lines · Steven 'Steve' Kendall

Some machines with Intel UHD Graphics 620 (8086:5917) such as Dell Latitude 7490 are unable to wake from sleep. Disable DMC for Intel UHD Graphics 620.

Cc some more folks

The patch at hand seems like too heavy a hammer. But this needs attention.

BR,
Jani.

Quoted 74 lines
---
 drivers/gpu/drm/i915/i915_pci.c | 14 ++++++++++++++
 include/drm/i915_pciids.h       |  6 +++++-
 2 files changed, 19 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +14 -0
index cd4487a1d3be..ea148be46b14 100644
@@ -697,6 +697,10 @@ static const struct intel_device_info skl_gt4_info = {
 	.gt = 4,
 };
 
+#define GEN9_DMCLESS_FEATURES \
+	GEN9_FEATURES, \
+	.__runtime.has_dmc = 0
+
 #define GEN9_LP_FEATURES \
 	GEN(9), \
 	.is_lp = 1, \
@@ -753,6 +757,10 @@ static const struct intel_device_info glk_info = {
 	GEN9_FEATURES, \
 	PLATFORM(INTEL_KABYLAKE)
 
+#define KBL_DMCLESS_PLATFORM \
+	GEN9_DMCLESS_FEATURES, \
+	PLATFORM(INTEL_KABYLAKE)
+
 static const struct intel_device_info kbl_gt1_info = {
 	KBL_PLATFORM,
 	.gt = 1,
@@ -763,6 +771,11 @@ static const struct intel_device_info kbl_gt2_info = {
 	.gt = 2,
 };
 
+static const struct intel_device_info dmcless_kbl_gt2_info = {
+	KBL_DMCLESS_PLATFORM,
+	.gt = 2,
+};
+
 static const struct intel_device_info kbl_gt3_info = {
 	KBL_PLATFORM,
 	.gt = 3,
@@ -1202,6 +1215,7 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_GLK_IDS(&glk_info),
 	INTEL_KBL_GT1_IDS(&kbl_gt1_info),
 	INTEL_KBL_GT2_IDS(&kbl_gt2_info),
+	DMCLESS_INTEL_KBL_GT2_IDS(&dmcless_kbl_gt2_info),
 	INTEL_KBL_GT3_IDS(&kbl_gt3_info),
 	INTEL_KBL_GT4_IDS(&kbl_gt3_info),
 	INTEL_AML_KBL_GT2_IDS(&kbl_gt2_info),
include/drm/i915_pciids.h +5 -1
index 4a4c190f7698..93bea60772ff 100644
@@ -420,11 +420,15 @@
 	INTEL_KBL_ULT_GT2_IDS(info), \
 	INTEL_KBL_ULX_GT2_IDS(info), \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
-	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
 	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
 	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
 	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
 
+#define DMCLESS_INTEL_KBL_GT2_IDS(info) \
+	INTEL_KBL_ULT_GT2_IDS(info), \
+	INTEL_KBL_ULX_GT2_IDS(info), \
+	INTEL_VGA_DEVICE(0x5917, info) /* Mobile GT2 */
+
 #define INTEL_KBL_ULT_GT3_IDS(info) \
 	INTEL_VGA_DEVICE(0x5926, info) /* ULT GT3 */
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
maintainer
#3 lore raw
Quoted 9 lines · Jani Nikula
Quoted 3 lines · Steven 'Steve' Kendall

Some machines with Intel UHD Graphics 620 (8086:5917) such as Dell Latitude 7490 are unable to wake from sleep. Disable DMC for Intel UHD Graphics 620.

Cc some more folks

The patch at hand seems like too heavy a hammer. But this needs attention.

yeap, it probably deserver a traditional quirk, including vendor ir, instead of this change in the platform list.

Quoted 83 lines

BR,
Jani.

Quoted 74 lines
---
 drivers/gpu/drm/i915/i915_pci.c | 14 ++++++++++++++
 include/drm/i915_pciids.h       |  6 +++++-
 2 files changed, 19 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +14 -0
index cd4487a1d3be..ea148be46b14 100644
@@ -697,6 +697,10 @@ static const struct intel_device_info skl_gt4_info = {
 	.gt = 4,
 };
 
+#define GEN9_DMCLESS_FEATURES \
+	GEN9_FEATURES, \
+	.__runtime.has_dmc = 0
+
 #define GEN9_LP_FEATURES \
 	GEN(9), \
 	.is_lp = 1, \
@@ -753,6 +757,10 @@ static const struct intel_device_info glk_info = {
 	GEN9_FEATURES, \
 	PLATFORM(INTEL_KABYLAKE)
 
+#define KBL_DMCLESS_PLATFORM \
+	GEN9_DMCLESS_FEATURES, \
+	PLATFORM(INTEL_KABYLAKE)
+
 static const struct intel_device_info kbl_gt1_info = {
 	KBL_PLATFORM,
 	.gt = 1,
@@ -763,6 +771,11 @@ static const struct intel_device_info kbl_gt2_info = {
 	.gt = 2,
 };
 
+static const struct intel_device_info dmcless_kbl_gt2_info = {
+	KBL_DMCLESS_PLATFORM,
+	.gt = 2,
+};
+
 static const struct intel_device_info kbl_gt3_info = {
 	KBL_PLATFORM,
 	.gt = 3,
@@ -1202,6 +1215,7 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_GLK_IDS(&glk_info),
 	INTEL_KBL_GT1_IDS(&kbl_gt1_info),
 	INTEL_KBL_GT2_IDS(&kbl_gt2_info),
+	DMCLESS_INTEL_KBL_GT2_IDS(&dmcless_kbl_gt2_info),
 	INTEL_KBL_GT3_IDS(&kbl_gt3_info),
 	INTEL_KBL_GT4_IDS(&kbl_gt3_info),
 	INTEL_AML_KBL_GT2_IDS(&kbl_gt2_info),
include/drm/i915_pciids.h +5 -1
index 4a4c190f7698..93bea60772ff 100644
@@ -420,11 +420,15 @@
 	INTEL_KBL_ULT_GT2_IDS(info), \
 	INTEL_KBL_ULX_GT2_IDS(info), \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
-	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
 	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
 	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
 	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
 
+#define DMCLESS_INTEL_KBL_GT2_IDS(info) \
+	INTEL_KBL_ULT_GT2_IDS(info), \
+	INTEL_KBL_ULX_GT2_IDS(info), \
+	INTEL_VGA_DEVICE(0x5917, info) /* Mobile GT2 */
+
 #define INTEL_KBL_ULT_GT3_IDS(info) \
 	INTEL_VGA_DEVICE(0x5926, info) /* ULT GT3 */
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center