Skip to contentSkip to conversation

package/gesftpserver: Fix per-package build without Python

PATCH New Andreas Naumann 4 participants 4 messages Jun 24, 2021 – Jul 11, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/gesftpserver: Fix per-package build without Python

When building per-package in an environment without Python, the gesftpserver configure script dies when looking for Python support.
The configure script is happy (doesnt check and wont error out) when being told that Python is not available, so we hack around this by setting the appropriate env variable.

---
 package/gesftpserver/gesftpserver.mk | 2 ++
 1 file changed, 2 insertions(+)
package/gesftpserver/gesftpserver.mk +2 -0
index 85511a3c97..a261719610 100644
@@ -23,6 +23,8 @@ GESFTPSERVER_DEPENDENCIES += \
 	$(if $(BR2_ENABLE_LOCALE),,libiconv) \
 	$(if $(BR2_PACKAGE_OPENSSH),openssh)
 
+GESFTPSERVER_CONF_ENV += rjk_cv_python24=false
+
 # openssh/dropbear looks here
 define GESFTPSERVER_ADD_SYMLINK
 	ln -sf gesftpserver $(TARGET_DIR)/usr/libexec/sftp-server
Signature · 1 line
2.32.0
#1 lore raw

PATCH v2 1/1 package/gesftpserver: Fix per-package build without Python

Quoted 7 lines · On Thu, 24 Jun 2021 14:32:37 +0200 Andreas Naumann <[email protected]>…

When building per-package in an environment without Python, the gesftpserver configure script dies when looking for Python support.
The configure script is happy (doesnt check and wont error out) when being told that Python is not available, so we hack around this by setting the appropriate env variable.

Thanks, but the issue is not at all related to per-package. In an environment without Python, gesftpserver fails to build, even with BR2_PER_PACKAGE_DIRECTORIES disabled.

So I've applied after rewriting the commit log, and adding a comment inside the .mk file.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/gesftpserver: Fix per-package build without Python

Hi Thomas,

Quoted 9 lines · Thomas Petazzoni
Quoted 6 lines · On Thu, 24 Jun 2021 14:32:37 +0200 Andreas Naumann <[email protected]>…

When building per-package in an environment without Python, the gesftpserver configure script dies when looking for Python support.
The configure script is happy (doesnt check and wont error out) when being told that Python is not available, so we hack around this by setting the appropriate env variable.

Quoted 5 lines
Quoted 1 line

Thanks, but the issue is not at all related to per-package. In an environment without Python, gesftpserver fails to build, even with BR2_PER_PACKAGE_DIRECTORIES disabled.

ahm true. It was just in my defconfig that another package reproducably built host-python before gesftpserver. When switching to per-package that was no longer the case.

Quoted 3 lines

So I've applied after rewriting the commit log, and adding a comment inside the .mk file.

Thanks!
Andreas

Quoted 5 lines

Thanks!

Thomas

#3 lore raw

PATCH v2 1/1 package/gesftpserver: Fix per-package build without Python

In reply to Thomas Petazzoni
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Quoted 6 lines · On Thu, 24 Jun 2021 14:32:37 +0200 Andreas Naumann <[email protected]>…

When building per-package in an environment without Python, the gesftpserver configure script dies when looking for Python support.
The configure script is happy (doesnt check and wont error out) when being told that Python is not available, so we hack around this by setting the appropriate env variable.

Quoted 8 lines
Quoted 1 line

Thanks, but the issue is not at all related to per-package. In an environment without Python, gesftpserver fails to build, even with BR2_PER_PACKAGE_DIRECTORIES disabled.

So I've applied after rewriting the commit log, and adding a comment inside the .mk file.

Committed to 2021.02.x and 2021.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard