package/go: fix a typo in CC and CXX env values
PATCH 1/1 package/go: fix a typo in CC and CXX env values
This commit fixes a typo in variable names that caused CC and CXX environment variables to be empty.
--- package/go/go.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
go/go.mk +2 -2
@@ -99,8 +99,8 @@ HOST_GO_HOST_ENV = \ $(HOST_GO_COMMON_ENV) \ GOARCH="" \ GOCACHE="$(HOST_GO_HOST_CACHE)" \ - CC="$(HOST_CCNOCCACHE)" \ - CXX="$(HOST_CXXNOCCACHE)" \ + CC="$(HOSTCC_NOCCACHE)" \ + CXX="$(HOSTCXX_NOCCACHE)" \ CGO_CFLAGS="$(HOST_CFLAGS)" \ CGO_CXXFLAGS="$(HOST_CXXFLAGS)" \ CGO_LDFLAGS="$(HOST_LDFLAGS)"
--
2.7.4
Yann E. MORIN
AppliedPATCH 1/1 package/go: fix a typo in CC and CXX env values
Michael, All,
On 2020-12-18 09:57 +0000, Michael Baudino spake thusly:
Quoted 4 lines
This commit fixes a typo in variable names that caused CC and CXX environment variables to be empty.
Signed-off-by Michael Baudino <[email protected]>
Applied to master, thanks.
However, see a little comment, below...
go/go.mk
Quoted 8 lines
--- package/go/go.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)go/go.mk +0
-0
I'm not sure how you generated your patch, but this does not apply as-is because it is not the expected depth, so git-am chokes on it.
Next time, please use 'git send-email' to send your patches, as it ensures that patches are properly formatted.
I fixed it locally (and will do so on your next patch too), so no need to resend those two.
Regards,
Yann E. MORIN.
Quoted 17 lines
go/go.mk +2
-3@@ -99,8 +99,8 @@ HOST_GO_HOST_ENV = \ $(HOST_GO_COMMON_ENV) \ GOARCH="" \ GOCACHE="$(HOST_GO_HOST_CACHE)" \ - CC="$(HOST_CCNOCCACHE)" \ - CXX="$(HOST_CXXNOCCACHE)" \ + CC="$(HOSTCC_NOCCACHE)" \ + CXX="$(HOSTCXX_NOCCACHE)" \ CGO_CFLAGS="$(HOST_CFLAGS)" \ CGO_CXXFLAGS="$(HOST_CXXFLAGS)" \ CGO_LDFLAGS="$(HOST_LDFLAGS)" --2.7.4
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/go: fix a typo in CC and CXX env values
Hi Yann,
Thanks for taking the manual extra steps ? (on both patches!)
I created the patch with git format-patch but I have diff.noprefix in my global git config, may this have caused the depth issue?
Anyway, thanks for accepting the patch and for all the work done on Buildroot ??
-------- Original Message --------
Quoted 53 lines · Yann E. MORIN
Michael, All,
On 2020-12-18 09:57 +0000, Michael Baudino spake thusly:
Quoted 4 lines
This commit fixes a typo in variable names that caused CC and CXX environment variables to be empty.
Signed-off-by Michael Baudino <[email protected]>Applied to master, thanks.
However, see a little comment, below...
go/go.mk
Quoted 8 lines
---
package/go/go.mk| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)go/go.mk +0
-0I'm not sure how you generated your patch, but this does not apply as-is because it is not the expected depth, so git-am chokes on it.
Next time, please use 'git send-email' to send your patches, as it ensures that patches are properly formatted.
I fixed it locally (and will do so on your next patch too), so no need to resend those two.
Regards,
Yann E. MORIN.Quoted 10 lines
go/go.mk +2
-2@@ -99,8 +99,8 @@ HOST_GO_HOST_ENV = \ $(HOST_GO_COMMON_ENV) \ GOARCH="" \ GOCACHE="$(HOST_GO_HOST_CACHE)" \ - CC="$(HOST_CCNOCCACHE)" \ - CXX="$(HOST_CXXNOCCACHE)" \ + CC="$(HOSTCC_NOCCACHE)" \ + CXX="$(HOSTCXX_NOCCACHE)" \ CGO_CFLAGS="$(HOST_CFLAGS)" \ CGO_CXXFLAGS="$(HOST_CXXFLAGS)" \Quoted 7 lines
CGO_LDFLAGS="$(HOST_LDFLAGS)"
--
2.7.4
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot--
.-----------------.--------------------.------------------.--------------------.
Quoted 5 lines
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20201219/a3297b6e/attachment.html>
PATCH 1/1 package/go: fix a typo in CC and CXX env values
In reply to Michael BaudinoQuoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Michael" == Michael Baudino <[email protected]> writes:
This commit fixes a typo in variable names that caused CC and CXX environment variables to be empty.
Signed-off-by Michael Baudino <[email protected]>
Committed to 2020.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard