Skip to contentSkip to conversation

package/mbpfan: new package

PATCH New Christian Stewart 2 participants 2 messages May 18, 2020 – Jul 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mbpfan: new package

Adding mbpfan, a fan control daemon for MacBook laptops.

---
 package/Config.in        |  1 +
 package/mbpfan/Config.in |  9 +++++++++
 package/mbpfan/mbpfan.mk | 38 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 48 insertions(+)
 create mode 100644 package/mbpfan/Config.in
 create mode 100644 package/mbpfan/mbpfan.mk
package/Config.in +1 -0
index c245abbc42..dd5951228b 100644
@@ -488,6 +488,7 @@ endmenu
 	source "package/luksmeta/Config.in"
 	source "package/lvm2/Config.in"
 	source "package/mali-t76x/Config.in"
+	source "package/mbpfan/Config.in"
 	source "package/mdadm/Config.in"
 	source "package/mdevd/Config.in"
 	source "package/memtest86/Config.in"
package/mbpfan/Config.in new file +9 -0
new file mode 100644
index 0000000000..231faa2b15
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_MBPFAN
+	bool "mbpfan"
+	depends on BR2_USE_MMU
+	help
+	  Mbpfan is a daemon for MacBook laptops which monitors the
+	  CPU temperature with the coretemp module, and sets the fan
+	  speeds with the applesmc module.
+
+	  https://github.com/linux-on-mac/mbpfan
package/mbpfan/mbpfan.mk new file +38 -0
new file mode 100644
index 0000000000..e3f3a23377
@@ -0,0 +1,38 @@
+################################################################################
+#
+# mbpfan
+#
+################################################################################
+
+MBPFAN_VERSION = 2.2.1
+MBPFAN_SITE = $(call github,linux-on-mac,mbpfan,v$(MBPFAN_VERSION))
+MBPFAN_LICENSE = GPL-3.0+
+MBPFAN_LICENSE_FILES = COPYING
+
+define MBPFAN_BUILD_CMDS
+	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		$(MAKE) CC="$(TARGET_CC)" -C $(@D)
+endef
+
+define MBPFAN_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0644 $(@D)/mbpfan.conf \
+		$(TARGET_DIR)/etc/mbpfan.conf
+	$(INSTALL) -m 0755 $(@D)/bin/mbpfan $(TARGET_DIR)/usr/sbin/mbpfan
+endef
+
+define MOTION_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 $(@D)/mbpfan.init.debian \
+		$(TARGET_DIR)/etc/init.d/S99mbpfan
+endef
+
+define MBPFAN_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 644 $(@D)/mbpfan.service \
+		$(TARGET_DIR)/usr/lib/systemd/system/mbpfan.service
+
+	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+	ln -fs ../../../../usr/lib/systemd/system/mbpfan.service \
+		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/mbpfan.service
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 package/mbpfan: new package

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christian" == Christian Stewart <[email protected]> writes:

Adding mbpfan, a fan control daemon for MacBook laptops.

---
 package/Config.in        |  1 +
 package/mbpfan/Config.in |  9 +++++++++
 package/mbpfan/mbpfan.mk | 38 ++++++++++++++++++++++++++++++++++++++

You forgot to add a .hash file and an entry in DEVELOPERS.

Quoted 53 lines
 3 files changed, 48 insertions(+)
 create mode 100644 package/mbpfan/Config.in
 create mode 100644 package/mbpfan/mbpfan.mk
package/Config.in +1 -0
index c245abbc42..dd5951228b 100644
@@ -488,6 +488,7 @@ endmenu
 	source "package/luksmeta/Config.in"
 	source "package/lvm2/Config.in"
 	source "package/mali-t76x/Config.in"
+	source "package/mbpfan/Config.in"
 	source "package/mdadm/Config.in"
 	source "package/mdevd/Config.in"
 	source "package/memtest86/Config.in"
package/mbpfan/Config.in new file +9 -0
new file mode 100644
index 0000000000..231faa2b15
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_MBPFAN
+	bool "mbpfan"
+	depends on BR2_USE_MMU
+	help
+	  Mbpfan is a daemon for MacBook laptops which monitors the
+	  CPU temperature with the coretemp module, and sets the fan
+	  speeds with the applesmc module.
+
+	  https://github.com/linux-on-mac/mbpfan
package/mbpfan/mbpfan.mk new file +16 -0
new file mode 100644
index 0000000000..e3f3a23377
@@ -0,0 +1,38 @@
+################################################################################
+#
+# mbpfan
+#
+################################################################################
+
+MBPFAN_VERSION = 2.2.1
+MBPFAN_SITE = $(call github,linux-on-mac,mbpfan,v$(MBPFAN_VERSION))
+MBPFAN_LICENSE = GPL-3.0+
+MBPFAN_LICENSE_FILES = COPYING
+
+define MBPFAN_BUILD_CMDS
+	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		$(MAKE) CC="$(TARGET_CC)" -C $(@D)
+endef

package/mbpfan/mbpfan.mk line 26

Quoted 10 lines
package/mbpfan/mbpfan.mk new file +10 -0
+
+define MBPFAN_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0644 $(@D)/mbpfan.conf \
+		$(TARGET_DIR)/etc/mbpfan.conf
+	$(INSTALL) -m 0755 $(@D)/bin/mbpfan $(TARGET_DIR)/usr/sbin/mbpfan
+endef
+
+define MOTION_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 $(@D)/mbpfan.init.debian \
+		$(TARGET_DIR)/etc/init.d/S99mbpfan

mbpfan.init.debian uses a bunch of Debian specific scripts, so that is no good.

package/mbpfan/mbpfan.mk line 35

Quoted 9 lines
package/mbpfan/mbpfan.mk new file +9 -0
+endef
+
+define MBPFAN_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 644 $(@D)/mbpfan.service \
+		$(TARGET_DIR)/usr/lib/systemd/system/mbpfan.service
+
+	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+	ln -fs ../../../../usr/lib/systemd/system/mbpfan.service \
+		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/mbpfan.service

This is no longer needed, as they are created at image creation time (under sysinit.target as that it what the service file states).

Committed with these fixes, thanks.

Signature · 1 line
Bye, Peter Korsgaard