scripts/bpf: Emit an #error directive known types list needs updating
Subsystems (3)
PATCH 1/1 scripts/bpf: Emit an #error directive known types list needs updating
Make the compiler report a clear error when bpf_helpers_doc.py needs updating rather than rely on the fact that Clang fails to compile English:
../../../lib/bpf/bpf_helper_defs.h:2707:1: error: unknown type name 'Unrecognized' Unrecognized type 'struct bpf_inet_lookup', please add it to known types!
--- scripts/bpf_helpers_doc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/bpf_helpers_doc.py +1 -1
@@ -489,7 +489,7 @@ class PrinterHelpers(Printer): if t in self.mapped_types: return self.mapped_types[t] print("") - print("Unrecognized type '%s', please add it to known types!" % t) + print("#error \"Unrecognized type '%s', please add it to known types!\"" % t) sys.exit(1) seen_helpers = set()
Signature · 1 line
2.20.1
Quoted 8 lines · Jakub Sitnicki
Make the compiler report a clear error when
bpf_helpers_doc.pyneeds updating rather than rely on the fact that Clang fails to compile English:
../../../lib/bpf/bpf_helper_defs.h:2707:1: error: unknown type name 'Unrecognized' Unrecognized type 'structbpf_inet_lookup', please add it to known types!Signed-off-by Jakub Sitnicki <[email protected]>
Applied, thanks!
Quoted 18 lines · Jakub Sitnicki
Make the compiler report a clear error when
bpf_helpers_doc.pyneeds updating rather than rely on the fact that Clang fails to compile English:
../../../lib/bpf/bpf_helper_defs.h:2707:1: error: unknown type name 'Unrecognized' Unrecognized type 'structbpf_inet_lookup', please add it to known types!Signed-off-by Jakub Sitnicki <[email protected]>--- scripts/bpf_helpers_doc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/bpf_helpers_doc.py +0
-0
scripts/bpf_helpers_doc.py class PrinterHelpers(Printer): · line 492
Quoted 5 lines
scripts/bpf_helpers_doc.py +1
-1@@ -489,7 +489,7 @@ class PrinterHelpers(Printer): if t in self.mapped_types: return self.mapped_types[t] print("") - print("Unrecognized type '%s', please add it to known types!" % t) + print("#error \"Unrecognized type '%s', please add it to known types!\"" % t)
My bad, this was intended to be printed to stderr, not to stdout output. Can you please do a follow up patch turning this into eprint instead?
This shouldn't be reported by Clang, rather by tool. And we should ensure in libbpf's Makefile that bpf_helper_defs.h is deleted on error. I'll do it a bit later, unless you'll beat me to it.
Quoted 6 lines
scripts/bpf_helpers_doc.py +0
-1sys.exit(1) seen_helpers = set() --2.20.1
Quoted 29 lines · Andrii Nakryiko
Quoted 18 lines · Jakub Sitnicki
Make the compiler report a clear error when
bpf_helpers_doc.pyneeds updating rather than rely on the fact that Clang fails to compile English:
../../../lib/bpf/bpf_helper_defs.h:2707:1: error: unknown type name 'Unrecognized' Unrecognized type 'structbpf_inet_lookup', please add it to known types!Signed-off-by Jakub Sitnicki <[email protected]>--- scripts/bpf_helpers_doc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/bpf_helpers_doc.py +0
-0scripts/bpf_helpers_doc.py class PrinterHelpers(Printer): · line 492
Quoted 5 lines
scripts/bpf_helpers_doc.py +1
-1@@ -489,7 +489,7 @@ class PrinterHelpers(Printer): if t in self.mapped_types: return self.mapped_types[t] print("") - print("Unrecognized type '%s', please add it to known types!" % t) + print("#error \"Unrecognized type '%s', please add it to known types!\"" % t)My bad, this was intended to be printed to stderr, not to stdout output. Can you please do a follow up patch turning this into eprint instead?
Quoted 3 lines
This shouldn't be reported by Clang, rather by tool. And we should ensure in libbpf's
Makefilethatbpf_helper_defs.his deleted on error. I'll do it a bit later, unless you'll beat me to it.
This sounds sensible. I could have guessed it. Here's the fix:
https://lore.kernel.org/bpf/[email protected]/T/#u
-Jakub