Skip to contentSkip to conversation

package/openjdk: set PATH before calling make

PATCH New Fabrice Fontaine 3 participants 3 messages Jun 10, 2019 – Jun 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/openjdk: set PATH before calling make

PATH must be set to $(BR_PATH) thanks to $(TARGET_MAKE_ENV) before calling make otherwise build fails on:
/bin/bash: gawk: command not found

When build fails, config.log contains the following line:

configure:13709: checking for gawk
configure:13725: found /home/buildroot/autobuild/run/instance-3/output/host/bin/gawk configure:13736: result: gawk
[...]
ac_cv_prog_AWK=gawk

Fixes:
- http://autobuild.buildroot.org/results/43c5d08f599e8f44b59a576d243ae1c7b27de7a3

---
Changes v1 -> v2 (after review of Arnout Vandecappelle):
- Set PATH thanks to $(TARGET_MAKE_ENV) instead of setting AWK

 package/openjdk/openjdk.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/openjdk/openjdk.mk +1 -1
index 318e4bade3..91a00870c5 100644
@@ -109,7 +109,7 @@ endef
 # Make -jn is unsupported. Instead, set the "--with-jobs=" configure option,
 # and use $(MAKE1).
 define OPENJDK_BUILD_CMDS
-	$(MAKE1) -C $(@D) legacy-jre-image
+	$(TARGET_MAKE_ENV) $(MAKE1) -C $(@D) legacy-jre-image
 endef
 
 # Calling make install always builds and installs the JDK instead of the JRE,
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 package/openjdk: set PATH before calling make

Quoted 12 lines · Fabrice Fontaine

PATH must be set to $(BR_PATH) thanks to $(TARGET_MAKE_ENV) before calling make otherwise build fails on:
/bin/bash: gawk: command not found

When build fails, config.log contains the following line:

configure:13709: checking for gawk
configure:13725: found /home/buildroot/autobuild/run/instance-3/output/host/bin/gawk configure:13736: result: gawk
[...]
ac_cv_prog_AWK=gawk

Quoted 4 lines

Fixes:
- http://autobuild.buildroot.org/results/43c5d08f599e8f44b59a576d243ae1c7b27de7a3

Applied to master, thanks.

Regards,
Arnout

Quoted 21 lines

---
Changes v1 -> v2 (after review of Arnout Vandecappelle):
- Set PATH thanks to $(TARGET_MAKE_ENV) instead of setting AWK

 package/openjdk/openjdk.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/openjdk/openjdk.mk +1 -1
index 318e4bade3..91a00870c5 100644
@@ -109,7 +109,7 @@ endef
 # Make -jn is unsupported. Instead, set the "--with-jobs=" configure option,
 # and use $(MAKE1).
 define OPENJDK_BUILD_CMDS
-	$(MAKE1) -C $(@D) legacy-jre-image
+	$(TARGET_MAKE_ENV) $(MAKE1) -C $(@D) legacy-jre-image
 endef
 
 # Calling make install always builds and installs the JDK instead of the JRE,
#2 lore raw

PATCH v2 1/1 package/openjdk: set PATH before calling make

In reply to Fabrice Fontaine
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

PATH must be set to $(BR_PATH) thanks to $(TARGET_MAKE_ENV) before calling make otherwise build fails on:
/bin/bash: gawk: command not found

When build fails, config.log contains the following line:

configure:13709: checking for gawk
configure:13725: found /home/buildroot/autobuild/run/instance-3/output/host/bin/gawk configure:13736: result: gawk
[...]
ac_cv_prog_AWK=gawk

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/43c5d08f599e8f44b59a576d243ae1c7b27de7a3

---
Changes v1 -> v2 (after review of Arnout Vandecappelle):
- Set PATH thanks to $(TARGET_MAKE_ENV) instead of setting AWK

Committed to 2019.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard