Skip to contentSkip to conversation

usb: gadget: uvc: configfs: Add bFrameIndex attributes

PATCH New Felipe Balbi 1 participant 1 message Jul 31, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH v7 1/1 usb: gadget: uvc: configfs: Add bFrameIndex attributes

Hi,

Quoted 25 lines · Laurent Pinchart

Hi Felipe,

Quoted 22 lines · On Thursday, 26 July 2018 13:49:07 EEST Felipe Balbi wrote:
Quoted 20 lines · Laurent Pinchart

From: Joel Pepper <[email protected]>

- Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size.
- Automatically assign ascending bFrameIndex to each frame in a format.

Before all "bFrameindex" attributes were set to "1" with no way to configure the gadget otherwise. This resulted in the host always negotiating for bFrameIndex 1 (i.e. the first framesize of the gadget). After the negotiation the host driver will set the user or application selected framesize, while the gadget is actually set to the first framesize.

Now, when the containing format is linked into the streaming header, iterate over all child frame descriptors and assign ascending indices. The automatically assigned indices can be read from the new read only bFrameIndex configsfs attribute in each frame descriptor item.

[Simplified documentation, renamed function, blank space update]
Quoted 5 lines
Quoted 2 lines

please rebase on testing/next, but give me a couple hours to go through the rest of my inbox first ;)

I will. Have you had time to go through the rest of your inbox now ? It's been a few hours already I suppose :-)

well, pull request was already pushed to Greg. We're already in -rc7, too late for this merge window.