arm64: Set -fno-PIC along with -mcmodel=large

PATCH Applied David Michael 3 participants 6 messages Jan 7, 2018 – Apr 19, 2018

Subsystems (2)

Live update kexec handover (KHO)

lore

Share & tools

lore

David Michael

author

2018-01-07 16:27 UTC #0 lore raw

PATCH 1/1 arm64: Set -fno-PIC along with -mcmodel=large

As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large code model is unsupported. This fixes the "sorry, unimplemented" errors when building with compilers defaulting to -fPIC.
---

Hi,

I'm hitting this error with 2.0.16 on Gentoo:

purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC

This change fixes it. Can something like this be applied?

Thanks.

David

 purgatory/arch/arm64/Makefile | 1 +
 1 file changed, 1 insertion(+)

purgatory/arch/arm64/Makefile +1 -0

index 636abea..80068ca 100644
@@ -1,6 +1,7 @@
 
 arm64_PURGATORY_EXTRA_CFLAGS = \
 	-mcmodel=large \
+	-fno-PIC \
 	-fno-stack-protector \
 	-fno-asynchronous-unwind-tables \
 	-Wundef \

Signature · 7 lines

2.14.3


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Geoff Levand

2018-02-02 23:48 UTC #1 lore raw

Hi,

Quoted 8 lines · David Michael

As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large code model is unsupported. This fixes the "sorry, unimplemented" errors when building with compilers defaulting to -fPIC.
---
purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
This change fixes it. Can something like this be applied?

This change seems reasonable considering large model + PIC is unsupported.

Reviewed by: Geoff Levand <[email protected]>

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Geoff Levand

2018-04-12 23:37 UTC #2 lore raw

Hi Simon,

Quoted 8 lines · Geoff Levand

Hi,
Quoted 5 lines · David Michael
As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large code model is unsupported. This fixes the "sorry, unimplemented" errors when building with compilers defaulting to -fPIC.
---

Quoted 7 lines

Quoted 3 lines
purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
This change fixes it. Can something like this be applied?
This change seems reasonable considering large model + PIC is unsupported.
Reviewed by: Geoff Levand <[email protected]>

Could you please merged this fix so arm64 builds work OK on Gentoo and Gentoo derivatives.

Thanks.

-Geoff

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Simon Horman

2018-04-18 12:54 UTC #3 lore raw

Quoted 13 lines · Geoff Levand

Hi Simon,
Quoted 10 lines · Geoff Levand
Hi,
Quoted 7 lines · David Michael
As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large code model is unsupported. This fixes the "sorry, unimplemented" errors when building with compilers defaulting to -fPIC.
---
purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC

Quoted 8 lines

Quoted 5 lines
Quoted 1 line
This change fixes it. Can something like this be applied?
This change seems reasonable considering large model + PIC is unsupported.
Reviewed by: Geoff Levand <[email protected]>
Could you please merged this fix so arm64 builds work OK on Gentoo and Gentoo derivatives.

Sure, but it really ought to have a Signed-off-by line from David.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

David Michael

author

2018-04-18 16:46 UTC #4 lore raw

Quoted 16 lines · Simon Horman

Quoted 15 lines · Geoff Levand
Hi Simon,
Quoted 12 lines · Geoff Levand
Hi,
Quoted 8 lines · David Michael
As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large code model is unsupported. This fixes the "sorry, unimplemented" errors when building with compilers defaulting to -fPIC.
---
purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
This change fixes it. Can something like this be applied?

Quoted 8 lines

Quoted 6 lines
Quoted 3 lines
This change seems reasonable considering large model + PIC is unsupported.
Reviewed by: Geoff Levand <[email protected]>
Could you please merged this fix so arm64 builds work OK on Gentoo and Gentoo derivatives.
Sure, but it really ought to have a Signed-off-by line from David.

Sorry about that. Should I resend the patch, or can you amend it with this line?

Signed-off-by David Michael <[email protected]>

Thanks.

David

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Simon Horman

Applied

2018-04-19 08:21 UTC #5 lore raw

Quoted 24 lines · David Michael

Quoted 23 lines · Simon Horman
Quoted 21 lines · Geoff Levand
Hi Simon,
Quoted 8 lines · Geoff Levand
Hi,
Quoted 5 lines · David Michael
As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large code model is unsupported. This fixes the "sorry, unimplemented" errors when building with compilers defaulting to -fPIC.
---
Quoted 7 lines
Quoted 3 lines
purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
This change fixes it. Can something like this be applied?
This change seems reasonable considering large model + PIC is unsupported.
Reviewed by: Geoff Levand <[email protected]>
Could you please merged this fix so arm64 builds work OK on Gentoo and Gentoo derivatives.

Quoted 6 lines

Quoted 1 line
Sure, but it really ought to have a Signed-off-by line from David.
Sorry about that. Should I resend the patch, or can you amend it with this line?
Signed-off-by David Michael <[email protected]>

Thanks, applied.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec