Skip to contentSkip to conversation

package/glibc: switch to downloading a tarball

PATCH New Yann E. MORIN 2 participants 2 messages Nov 13, 2017 – Nov 14, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/glibc: switch to downloading a tarball

Currently, we do a full git clone of the repository, which takes quite some time, especially on slow networks.

This was done like that because the initial patch was using the official repository as the source of the download, and that repository did not offer remotely-generated tarballs.

But now we've switched to using a mirror on github, which does provide such a tarball, which provides faster downloads.

Use that.

However, the tarball from github differs from the one we were generating locally, because the paths inside are different. WE used to create a archive with paths starting with glibc-glibc-2.26-73-g4b692dfb95[...], while github does away with the git-describe prefix, and generates paths that start with just glibc-4b692dffb95[...]. The content are exactly identicall (checked with a diff), though.

Update the hash accordingly.

Cc Waldemar Brodkorb <[email protected]>
Cc Romain Naour <[email protected]>
Cc Arnout Vandecappelle <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/glibc/glibc.hash | 2 +-
 package/glibc/glibc.mk   | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
package/glibc/glibc.hash +1 -1
index 5910dda72d..4e5bc7f7bc 100644
@@ -1,4 +1,4 @@
 # Locally calculated (fetched from Github)
-sha256  f1f2566fea1518dd7244d322882242bbd654eb215fba51a7ab001b8fd2c9bcbe     glibc-glibc-2.26-73-g4b692dffb95ac4812b161eb6a16113d7e824982e.tar.gz
+sha256  d66b3702961c846ead2bacf17a9b5239cc1e8a43ca6e322f3637e99f276efec1     glibc-glibc-2.26-73-g4b692dffb95ac4812b161eb6a16113d7e824982e.tar.gz
 # Locally calculated (fetched from Github)
 sha256  5aa9adeac09727db0b8a52794186563771e74d70410e9fd86431e339953fd4bb     glibc-arc-2017.09-release.tar.gz
package/glibc/glibc.mk +1 -2
index 5911dfec5f..d99b524ef9 100644
@@ -18,8 +18,7 @@ GLIBC_VERSION = glibc-2.26-73-g4b692dffb95ac4812b161eb6a16113d7e824982e
 # When updating the version, check it on the official repository;
 # *NEVER* decide on a version string by looking at the mirror.
 # Then check that the mirror has been synced already (happens once a day.)
-GLIBC_SITE = https://github.com/bminor/glibc.git
-GLIBC_SITE_METHOD = git
+GLIBC_SITE = $(call github,bminor,glibc,$(GLIBC_VERSION))
 endif
 
 GLIBC_SRC_SUBDIR = .
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/glibc: switch to downloading a tarball

Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Currently, we do a full git clone of the repository, which takes quite some time, especially on slow networks.

This was done like that because the initial patch was using the official repository as the source of the download, and that repository did not offer remotely-generated tarballs.

But now we've switched to using a mirror on github, which does provide such a tarball, which provides faster downloads.

Use that.

However, the tarball from github differs from the one we were generating locally, because the paths inside are different. WE used to create a archive with paths starting with glibc-glibc-2.26-73-g4b692dfb95[...], while github does away with the git-describe prefix, and generates paths that start with just glibc-4b692dffb95[...]. The content are exactly identicall (checked with a diff), though.

Quoted 8 lines

Update the hash accordingly.

Cc Waldemar Brodkorb <[email protected]>
Cc Romain Naour <[email protected]>
Cc Arnout Vandecappelle <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard