uvcvideo: Add bayer 16-bit format patterns

PATCH In review Edgar Thier 3 participants 14 messages Nov 14, 2016 – Nov 17, 2016

Subsystems (3)

Documentation Media (V4L/DVB) USB video class

lore

Share & tools

lore

Edgar Thier

author

2016-11-14 13:26 UTC #0 lore raw

PATCH 1/1 uvcvideo: Add bayer 16-bit format patterns

Quoted 1 line

From aec97c931cb4b91f91dd0ed38f74d866d4f13347 Mon Sep 17 00:00:00 2001

From: Edgar Thier <[email protected]>
Date: Mon, 14 Nov 2016 14:17:57 +0100
Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns

Add bayer 16-bit GUIDs to uvcvideo and associated them with the corresponding V4L2 pixel formats.

Signed-off-by Edgar Thier <[email protected]>

---

drivers/media/usb/uvc/uvc_driver.c   | 20 ++++++++++++++++++++
drivers/media/usb/uvc/uvcvideo.h     | 12 ++++++++++++
drivers/media/v4l2-core/v4l2-ioctl.c |  4 ++++
include/uapi/linux/videodev2.h       |  3 +++
4 files changed, 39 insertions(+)

drivers/media/usb/uvc/uvc_driver.c +0 -0

index 87b2fc3b..9d1fc33 100644
@@ -168,6 +168,26 @@ static struct uvc_format_desc uvc_fmts[] = {

.guid = UVC_GUID_FORMAT_RW10,
.fcc = V4L2_PIX_FMT_SRGGB10P,
},
+ {
+ .name = "Bayer 16-bit (SBGGR16)",
+ .guid = UVC_GUID_FORMAT_BG16,
+ .fcc = V4L2_PIX_FMT_SBGGR16,
+ },
+ {
+ .name = "Bayer 16-bit (SGBRG16)",
+ .guid = UVC_GUID_FORMAT_GB16,
+ .fcc = V4L2_PIX_FMT_SGBRG16,
+ },
+ {
+ .name = "Bayer 16-bit (SRGGB16)",
+ .guid = UVC_GUID_FORMAT_RG16,
+ .fcc = V4L2_PIX_FMT_SRGGB16,
+ },
+ {
+ .name = "Bayer 16-bit (SGRBG16)",
+ .guid = UVC_GUID_FORMAT_GR16,
+ .fcc = V4L2_PIX_FMT_SGRBG16,
+ },
};

/* ------------------------------------------------------------------------

drivers/media/usb/uvc/uvcvideo.h +0 -0

index 7e4d3ee..3d6cc62 100644
@@ -106,6 +106,18 @@

#define UVC_GUID_FORMAT_RGGB \
{ 'R', 'G', 'G', 'B', 0x00, 0x00, 0x10, 0x00, \
0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} +#define UVC_GUID_FORMAT_BG16 \
+ { 'B', 'G', '1', '6', 0x00, 0x00, 0x10, 0x00, \
+ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_GB16 \
+ { 'G', 'B', '1', '6', 0x00, 0x00, 0x10, 0x00, \
+ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_RG16 \
+ { 'R', 'G', '1', '6', 0x00, 0x00, 0x10, 0x00, \
+ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_GR16 \
+ { 'G', 'R', '1', '6', 0x00, 0x00, 0x10, 0x00, \
+ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
#define UVC_GUID_FORMAT_RGBP \
{ 'R', 'G', 'B', 'P', 0x00, 0x00, 0x10, 0x00, \
0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}

drivers/media/v4l2-core/v4l2-ioctl.c +0 -0

index 181381d..abbb6d5 100644
@@ -1179,6 +1179,10 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)

case V4L2_PIX_FMT_SGBRG12: descr = "12-bit Bayer GBGB/RGRG"; break;
case V4L2_PIX_FMT_SGRBG12: descr = "12-bit Bayer GRGR/BGBG"; break;
case V4L2_PIX_FMT_SRGGB12: descr = "12-bit Bayer RGRG/GBGB"; break;
+ case V4L2_PIX_FMT_SGBRG16: descr = "16-bit Bayer GBGB/RGRG"; break;
+ case V4L2_PIX_FMT_SGRBG16: descr = "16-bit Bayer GRGR/BGBG"; break;
+ case V4L2_PIX_FMT_SRGGB16: descr = "16-bit Bayer RGRG/GBGB"; break;
+ case V4L2_PIX_FMT_SBGGR16: descr = "16-bit Bayer BGBG/GRGR"; break;
case V4L2_PIX_FMT_SBGGR10P: descr = "10-bit Bayer BGBG/GRGR Packed"; break;
case V4L2_PIX_FMT_SGBRG10P: descr = "10-bit Bayer GBGB/RGRG Packed"; break;
case V4L2_PIX_FMT_SGRBG10P: descr = "10-bit Bayer GRGR/BGBG Packed"; break;

include/uapi/linux/videodev2.h +0 -0

index 4364ce6..6bdf592 100644
@@ -605,6 +605,9 @@ struct v4l2_pix_format {

#define V4L2_PIX_FMT_SGRBG12 v4l2_fourcc('B', 'A', '1', '2') /* 12  GRGR.. BGBG.. */
#define V4L2_PIX_FMT_SRGGB12 v4l2_fourcc('R', 'G', '1', '2') /* 12  RGRG.. GBGB.. */
#define V4L2_PIX_FMT_SBGGR16 v4l2_fourcc('B', 'Y', 'R', '2') /* 16  BGBG.. GRGR.. */
+#define V4L2_PIX_FMT_SGBRG16 v4l2_fourcc('G', 'B', '1', '6') /* 16  GBGB.. RGRG.. */
+#define V4L2_PIX_FMT_SRGGB16 v4l2_fourcc('R', 'G', '1', '6') /* 16  RGRG.. GBGB.. */
+#define V4L2_PIX_FMT_SGRBG16 v4l2_fourcc('G', 'R', '1', '6') /* 16  GRGR.. BGBG.. */

/* HSV formats */
#define V4L2_PIX_FMT_HSV24 v4l2_fourcc('H', 'S', 'V', '3') --
2.10.2

Sakari Ailus

Acked-by Lad, Prabhakar on v1 1/1

2016-11-14 14:14 UTC #1 lore raw

Hi Edgar,

Quoted 10 lines · Edgar Thier

From aec97c931cb4b91f91dd0ed38f74d866d4f13347 Mon Sep 17 00:00:00 2001
From: Edgar Thier <[email protected]>
Date: Mon, 14 Nov 2016 14:17:57 +0100
Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns
Add bayer 16-bit GUIDs to uvcvideo and associated them with the corresponding V4L2 pixel formats.
Signed-off-by Edgar Thier <[email protected]>
---

...

include/uapi/linux/videodev2.h struct v4l2_pix_format { · line 610

Quoted 11 lines

include/uapi/linux/videodev2.h +3 -0

index 4364ce6..6bdf592 100644
@@ -605,6 +605,9 @@ struct v4l2_pix_format {
 #define V4L2_PIX_FMT_SGRBG12 v4l2_fourcc('B', 'A', '1', '2') /* 12  GRGR.. BGBG.. */
 #define V4L2_PIX_FMT_SRGGB12 v4l2_fourcc('R', 'G', '1', '2') /* 12  RGRG.. GBGB.. */
 #define V4L2_PIX_FMT_SBGGR16 v4l2_fourcc('B', 'Y', 'R', '2') /* 16  BGBG.. GRGR.. */
+#define V4L2_PIX_FMT_SGBRG16 v4l2_fourcc('G', 'B', '1', '6') /* 16  GBGB.. RGRG.. */
+#define V4L2_PIX_FMT_SRGGB16 v4l2_fourcc('R', 'G', '1', '6') /* 16  RGRG.. GBGB.. */
+#define V4L2_PIX_FMT_SGRBG16 v4l2_fourcc('G', 'R', '1', '6') /* 16  GRGR.. BGBG.. */

Thanks for the patch!

Could you rebase your uvcvideo changes on this patch, dropping the framework changes from yours?

Cc Laurent. Laurent, could you take both of the patches to your tree after the rebase?

The patch is also available here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=packed12-postponed2&id=c5b60538b33f993109248a642c8e9b74f7d1abd1>

Quoted 1 line

From c5b60538b33f993109248a642c8e9b74f7d1abd1 Mon Sep 17 00:00:00 2001

From: Sakari Ailus <[email protected]>
Date: Mon, 27 Jun 2016 16:46:16 +0300
Subject: [PATCH 1/1] v4l: Add 16-bit raw bayer pixel formats

The formats added by this patch are:

	V4L2_PIX_FMT_SBGGR16
	V4L2_PIX_FMT_SGBRG16
	V4L2_PIX_FMT_SGRBG16

V4L2_PIX_FMT_SRGGB16 already existed before the patch. Rework the documentation to match that of the other sample depths.

Also align the description of V4L2_PIX_FMT_SRGGB16 to match with other similar formats.

Signed-off-by Sakari Ailus <[email protected]>

Acked-by Lad, Prabhakar <[email protected]>

---
 Documentation/media/uapi/v4l/pixfmt-rgb.rst     |  2 +-
 Documentation/media/uapi/v4l/pixfmt-sbggr16.rst | 62 ----------------------
 Documentation/media/uapi/v4l/pixfmt-srggb16.rst | 69 +++++++++++++++++++++++++
 drivers/media/v4l2-core/v4l2-ioctl.c            |  5 +-
 include/uapi/linux/videodev2.h                  |  3 ++
 5 files changed, 77 insertions(+), 64 deletions(-)
 delete mode 100644 Documentation/media/uapi/v4l/pixfmt-sbggr16.rst
 create mode 100644 Documentation/media/uapi/v4l/pixfmt-srggb16.rst

Documentation/media/uapi/v4l/pixfmt-rgb.rst +1 -1

index 9cc9808..b0f3513 100644
@@ -12,9 +12,9 @@ RGB Formats
 
     pixfmt-packed-rgb
     pixfmt-srggb8
-    pixfmt-sbggr16
     pixfmt-srggb10
     pixfmt-srggb10p
     pixfmt-srggb10alaw8
     pixfmt-srggb10dpcm8
     pixfmt-srggb12
+    pixfmt-srggb16

Documentation/media/uapi/v4l/pixfmt-sbggr16.rst deleted +0 ~~-62~~

62 lines not on this page · raw message

Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file +69 -0

69 lines not on this page · raw message

drivers/media/v4l2-core/v4l2-ioctl.c +4 -1

index 181381d..61d2d65 100644
@@ -1191,7 +1191,10 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
 	case V4L2_PIX_FMT_SGBRG10DPCM8:	descr = "8-bit Bayer GBGB/RGRG (DPCM)"; break;
 	case V4L2_PIX_FMT_SGRBG10DPCM8:	descr = "8-bit Bayer GRGR/BGBG (DPCM)"; break;
 	case V4L2_PIX_FMT_SRGGB10DPCM8:	descr = "8-bit Bayer RGRG/GBGB (DPCM)"; break;
-	case V4L2_PIX_FMT_SBGGR16:	descr = "16-bit Bayer BGBG/GRGR (Exp.)"; break;
+	case V4L2_PIX_FMT_SBGGR16:	descr = "16-bit Bayer BGBG/GRGR"; break;
+	case V4L2_PIX_FMT_SGBRG16:	descr = "16-bit Bayer GBGB/RGRG"; break;
+	case V4L2_PIX_FMT_SGRBG16:	descr = "16-bit Bayer GRGR/BGBG"; break;
+	case V4L2_PIX_FMT_SRGGB16:	descr = "16-bit Bayer RGRG/GBGB"; break;
 	case V4L2_PIX_FMT_SN9C20X_I420:	descr = "GSPCA SN9C20X I420"; break;
 	case V4L2_PIX_FMT_SPCA501:	descr = "GSPCA SPCA501"; break;
 	case V4L2_PIX_FMT_SPCA505:	descr = "GSPCA SPCA505"; break;

include/uapi/linux/videodev2.h +3 -0

index 4364ce6..ba352b6 100644
@@ -605,6 +605,9 @@ struct v4l2_pix_format {
 #define V4L2_PIX_FMT_SGRBG12 v4l2_fourcc('B', 'A', '1', '2') /* 12  GRGR.. BGBG.. */
 #define V4L2_PIX_FMT_SRGGB12 v4l2_fourcc('R', 'G', '1', '2') /* 12  RGRG.. GBGB.. */
 #define V4L2_PIX_FMT_SBGGR16 v4l2_fourcc('B', 'Y', 'R', '2') /* 16  BGBG.. GRGR.. */
+#define V4L2_PIX_FMT_SGBRG16 v4l2_fourcc('G', 'B', '1', '6') /* 16  GBGB.. RGRG.. */
+#define V4L2_PIX_FMT_SGRBG16 v4l2_fourcc('G', 'R', '1', '6') /* 16  GRGR.. BGBG.. */
+#define V4L2_PIX_FMT_SRGGB16 v4l2_fourcc('R', 'G', '1', '6') /* 16  RGRG.. GBGB.. */
 
 /* HSV formats */
 #define V4L2_PIX_FMT_HSV24 v4l2_fourcc('H', 'S', 'V', '3')

Signature · 7 lines

2.1.4

-- 
Kind regards,

Sakari Ailus
e-mail: [email protected]	XMPP: [email protected]

Edgar Thier

author

2016-11-15 05:39 UTC #2 lore raw

PATCH 1/1 uvcvideo: Add bayer 16-bit format patterns

Quoted 2 lines

From 10ce06db4ab3c037758b3cb5264007f59801f1a1 Mon Sep 17 00:00:00 2001

From: Edgar Thier <[email protected]>
Date: Tue, 15 Nov 2016 06:33:10 +0100
Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns

Signed-off-by Edgar Thier <[email protected]>

---
drivers/media/usb/uvc/uvc_driver.c | 20 ++++++++++++++++++++
drivers/media/usb/uvc/uvcvideo.h | 12 ++++++++++++

2 files changed, 32 insertions(+)

drivers/media/usb/uvc/uvc_driver.c +0 -0

index 87b2fc3b..9d1fc33 100644
@@ -168,6 +168,26 @@ static struct uvc_format_desc uvc_fmts[] = {

/* ------------------------------------------------------------------------

drivers/media/usb/uvc/uvcvideo.h +0 -0

index 7e4d3ee..3d6cc62 100644
@@ -106,6 +106,18 @@

Sakari Ailus

Acked-by on v1 1/1

2016-11-15 13:45 UTC #3 lore raw

Hi Edgar,

Quoted 7 lines · Edgar Thier

From 10ce06db4ab3c037758b3cb5264007f59801f1a1 Mon Sep 17 00:00:00 2001
From: Edgar Thier <[email protected]>
Date: Tue, 15 Nov 2016 06:33:10 +0100
Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns
Signed-off-by Edgar Thier <[email protected]>

Acked-by Sakari Ailus <[email protected]>

Quoted 10 lines

---
drivers/media/usb/uvc/uvc_driver.c | 20 ++++++++++++++++++++
drivers/media/usb/uvc/uvcvideo.h | 12 ++++++++++++
2 files changed, 32 insertions(+)
drivers/media/usb/uvc/uvc_driver.c +0 -0
index 87b2fc3b..9d1fc33 100644

drivers/media/usb/uvc/uvc_driver.c static struct uvc_format_desc uvc_fmts[] = { · line 172

Quoted 5 lines

drivers/media/usb/uvc/uvc_driver.c +2 -0

@@ -168,6 +168,26 @@ static struct uvc_format_desc uvc_fmts[] = {
 .guid		= UVC_GUID_FORMAT_RW10,
 .fcc		= V4L2_PIX_FMT_SRGGB10P,
 },
+	{
+			.name		= "Bayer 16-bit (SBGGR16)",

Laurent, are these still needed? The V4L2 framework fills in the format name... certainly out of scope for this patch though.

Quoted 20 lines

drivers/media/usb/uvc/uvc_driver.c +18 -0

+			.guid		= UVC_GUID_FORMAT_BG16,
+			.fcc		= V4L2_PIX_FMT_SBGGR16,
+	},
+	{
+			.name		= "Bayer 16-bit (SGBRG16)",
+			.guid		= UVC_GUID_FORMAT_GB16,
+			.fcc		= V4L2_PIX_FMT_SGBRG16,
+	},
+	{
+			.name		= "Bayer 16-bit (SRGGB16)",
+			.guid		= UVC_GUID_FORMAT_RG16,
+			.fcc		= V4L2_PIX_FMT_SRGGB16,
+	},
+	{
+			.name		= "Bayer 16-bit (SGRBG16)",
+			.guid		= UVC_GUID_FORMAT_GR16,
+			.fcc		= V4L2_PIX_FMT_SGRBG16,
+	},
 };

Signature · 4 lines

Kind regards,

Sakari Ailus
e-mail: [email protected]	XMPP: [email protected]

Laurent Pinchart

maintainer

2016-11-15 14:45 UTC #4 lore raw

Hi Sakari,

Quoted 15 lines · On Tuesday 15 Nov 2016 15:45:32 Sakari Ailus wrote:

Quoted 6 lines · Edgar Thier
From 10ce06db4ab3c037758b3cb5264007f59801f1a1 Mon Sep 17 00:00:00 2001
From: Edgar Thier <[email protected]>
Date: Tue, 15 Nov 2016 06:33:10 +0100
Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns
Signed-off-by Edgar Thier <[email protected]>
Acked-by Sakari Ailus <[email protected]>
Quoted 5 lines
---
drivers/media/usb/uvc/uvc_driver.c | 20 ++++++++++++++++++++
drivers/media/usb/uvc/uvcvideo.h | 12 ++++++++++++
2 files changed, 32 insertions(+)

Quoted 13 lines

drivers/media/usb/uvc/uvc_driver.c static struct uvc_format_desc uvc_fmts[] = { · line 172
Quoted 10 lines
(quoted diff) +0 -0
b/drivers/media/usb/uvc/uvc_driver.c index 87b2fc3b..9d1fc33 100644
drivers/media/usb/uvc/uvc_driver.c +2 -0
@@ -168,6 +168,26 @@ static struct uvc_format_desc uvc_fmts[] = {
 .guid		= UVC_GUID_FORMAT_RW10,
 .fcc		= V4L2_PIX_FMT_SRGGB10P,
 },
+	{
+			.name		= "Bayer 16-bit (SBGGR16)",
Laurent, are these still needed? The V4L2 framework fills in the format name... certainly out of scope for this patch though.

I'll fix that.

Quoted 19 lines

drivers/media/usb/uvc/uvc_driver.c +18 -0

+			.guid		= UVC_GUID_FORMAT_BG16,
+			.fcc		= V4L2_PIX_FMT_SBGGR16,
+	},
+	{
+			.name		= "Bayer 16-bit (SGBRG16)",
+			.guid		= UVC_GUID_FORMAT_GB16,
+			.fcc		= V4L2_PIX_FMT_SGBRG16,
+	},
+	{
+			.name		= "Bayer 16-bit (SRGGB16)",
+			.guid		= UVC_GUID_FORMAT_RG16,
+			.fcc		= V4L2_PIX_FMT_SRGGB16,
+	},
+	{
+			.name		= "Bayer 16-bit (SGRBG16)",
+			.guid		= UVC_GUID_FORMAT_GR16,
+			.fcc		= V4L2_PIX_FMT_SGRBG16,
+	},
 };

Signature · 3 lines

Regards,

Laurent Pinchart

Laurent Pinchart

maintainer

2016-11-15 14:44 UTC #5 lore raw

In reply to Edgar Thier

Hi Edgar,

Thank you for the patch.

Quoted 4 lines · On Tuesday 15 Nov 2016 06:39:41 Edgar Thier wrote:

From 10ce06db4ab3c037758b3cb5264007f59801f1a1 Mon Sep 17 00:00:00 2001
From: Edgar Thier <[email protected]>
Date: Tue, 15 Nov 2016 06:33:10 +0100
Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns

Which device(s) support these formats ?

Quoted 60 lines

Signed-off-by Edgar Thier <[email protected]>

---
drivers/media/usb/uvc/uvc_driver.c | 20 ++++++++++++++++++++
drivers/media/usb/uvc/uvcvideo.h | 12 ++++++++++++

2 files changed, 32 insertions(+)

(quoted diff) +0 -0

b/drivers/media/usb/uvc/uvc_driver.c index 87b2fc3b..9d1fc33 100644

drivers/media/usb/uvc/uvc_driver.c +20 -0

@@ -168,6 +168,26 @@ static struct uvc_format_desc uvc_fmts[] = {
 .guid		= UVC_GUID_FORMAT_RW10,
 .fcc		= V4L2_PIX_FMT_SRGGB10P,
 },
+	{
+			.name		= "Bayer 16-bit (SBGGR16)",
+			.guid		= UVC_GUID_FORMAT_BG16,
+			.fcc		= V4L2_PIX_FMT_SBGGR16,
+	},
+	{
+			.name		= "Bayer 16-bit (SGBRG16)",
+			.guid		= UVC_GUID_FORMAT_GB16,
+			.fcc		= V4L2_PIX_FMT_SGBRG16,
+	},
+	{
+			.name		= "Bayer 16-bit (SRGGB16)",
+			.guid		= UVC_GUID_FORMAT_RG16,
+			.fcc		= V4L2_PIX_FMT_SRGGB16,
+	},
+	{
+			.name		= "Bayer 16-bit (SGRBG16)",
+			.guid		= UVC_GUID_FORMAT_GR16,
+			.fcc		= V4L2_PIX_FMT_SGRBG16,
+	},
 };
 
 /* ------------------------------------------------------------------------

(quoted diff) +0 -0

b/drivers/media/usb/uvc/uvcvideo.h index 7e4d3ee..3d6cc62 100644

drivers/media/usb/uvc/uvcvideo.h +12 -0

@@ -106,6 +106,18 @@
 #define UVC_GUID_FORMAT_RGGB \
 { 'R',  'G',  'G',  'B', 0x00, 0x00, 0x10, 0x00, \
 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_BG16 \
+	{ 'B',  'G',  '1',  '6', 0x00, 0x00, 0x10, 0x00, \
+	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_GB16 \
+	{ 'G',  'B',  '1',  '6', 0x00, 0x00, 0x10, 0x00, \
+	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_RG16 \
+	{ 'R',  'G',  '1',  '6', 0x00, 0x00, 0x10, 0x00, \
+	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_GR16 \
+	{ 'G',  'R',  '1',  '6', 0x00, 0x00, 0x10, 0x00, \
+	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
 #define UVC_GUID_FORMAT_RGBP \
 { 'R',  'G',  'B',  'P', 0x00, 0x00, 0x10, 0x00, \
 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}

Signature · 3 lines

Regards,

Laurent Pinchart

Laurent Pinchart

maintainer

2016-11-15 14:50 UTC #6 lore raw

Hi Edgar,

Quoted 7 lines · On Tuesday 15 Nov 2016 16:44:55 Laurent Pinchart wrote:

Quoted 4 lines · On Tuesday 15 Nov 2016 06:39:41 Edgar Thier wrote:
From 10ce06db4ab3c037758b3cb5264007f59801f1a1 Mon Sep 17 00:00:00 2001
From: Edgar Thier <[email protected]>
Date: Tue, 15 Nov 2016 06:33:10 +0100
Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns
Which device(s) support these formats ?

And could you please try to fix your e-mail client and/or server to avoid corrupting patches ?

Quoted 61 lines

Signed-off-by Edgar Thier <[email protected]>

---
drivers/media/usb/uvc/uvc_driver.c | 20 ++++++++++++++++++++
drivers/media/usb/uvc/uvcvideo.h | 12 ++++++++++++

2 files changed, 32 insertions(+)

(quoted diff) +0 -0

b/drivers/media/usb/uvc/uvc_driver.c index 87b2fc3b..9d1fc33 100644

drivers/media/usb/uvc/uvc_driver.c +20 -1

@@ -168,6 +168,26 @@ static struct uvc_format_desc uvc_fmts[] = {
 .guid		= UVC_GUID_FORMAT_RW10,
 .fcc		= V4L2_PIX_FMT_SRGGB10P,
 },
+	{
+			.name		= "Bayer 16-bit (SBGGR16)",
+			.guid		= UVC_GUID_FORMAT_BG16,
+			.fcc		= V4L2_PIX_FMT_SBGGR16,
+	},
+	{
+			.name		= "Bayer 16-bit (SGBRG16)",
+			.guid		= UVC_GUID_FORMAT_GB16,
+			.fcc		= V4L2_PIX_FMT_SGBRG16,
+	},
+	{
+			.name		= "Bayer 16-bit (SRGGB16)",
+			.guid		= UVC_GUID_FORMAT_RG16,
+			.fcc		= V4L2_PIX_FMT_SRGGB16,
+	},
+	{
+			.name		= "Bayer 16-bit (SGRBG16)",
+			.guid		= UVC_GUID_FORMAT_GR16,
+			.fcc		= V4L2_PIX_FMT_SGRBG16,
+	},
 };
 
 /*
------------------------------------------------------------------------

(quoted diff) +0 -0

b/drivers/media/usb/uvc/uvcvideo.h index 7e4d3ee..3d6cc62 100644

drivers/media/usb/uvc/uvcvideo.h +12 -0

@@ -106,6 +106,18 @@
 #define UVC_GUID_FORMAT_RGGB \
 { 'R',  'G',  'G',  'B', 0x00, 0x00, 0x10, 0x00, \
 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_BG16 \
+	{ 'B',  'G',  '1',  '6', 0x00, 0x00, 0x10, 0x00, \
+	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_GB16 \
+	{ 'G',  'B',  '1',  '6', 0x00, 0x00, 0x10, 0x00, \
+	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_RG16 \
+	{ 'R',  'G',  '1',  '6', 0x00, 0x00, 0x10, 0x00, \
+	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
+#define UVC_GUID_FORMAT_GR16 \
+	{ 'G',  'R',  '1',  '6', 0x00, 0x00, 0x10, 0x00, \
+	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
 #define UVC_GUID_FORMAT_RGBP \
 { 'R',  'G',  'B',  'P', 0x00, 0x00, 0x10, 0x00, \
 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}

Signature · 3 lines

Regards,

Laurent Pinchart

Edgar Thier

author

2016-11-15 05:48 UTC #7 lore raw

In reply to Sakari Ailus

Hi Sakari,

Sorry for the waiting. I hope the patch I just submitted is alright.

I took the freedom and uploaded the lsusb -v output for 3 cameras with bayer 16-bit patterns. You can find them here:

dfk23up1300_16bitbayer_RG.lsusb: http://pastebin.com/PDdY7rs0
dfk23ux249_16bitbayer_GB.lsusb: http://pastebin.com/gtjF3Q2k
dfk33ux250_16bitbayer_GR.lsusb: http://pastebin.com/Errz5UMr

Cheers,

Edgar

Quoted 266 lines

Hi Edgar,

Quoted 10 lines · Edgar Thier

From aec97c931cb4b91f91dd0ed38f74d866d4f13347 Mon Sep 17 00:00:00 2001
From: Edgar Thier <[email protected]>
Date: Mon, 14 Nov 2016 14:17:57 +0100
Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns
Add bayer 16-bit GUIDs to uvcvideo and associated them with the corresponding V4L2 pixel formats.
Signed-off-by Edgar Thier <[email protected]>
---

...

include/uapi/linux/videodev2.h struct v4l2_pix_format { · line 610

Quoted 11 lines

include/uapi/linux/videodev2.h +3 -0

index 4364ce6..6bdf592 100644
@@ -605,6 +605,9 @@ struct v4l2_pix_format {
 #define V4L2_PIX_FMT_SGRBG12 v4l2_fourcc('B', 'A', '1', '2') /* 12  GRGR.. BGBG.. */
 #define V4L2_PIX_FMT_SRGGB12 v4l2_fourcc('R', 'G', '1', '2') /* 12  RGRG.. GBGB.. */
 #define V4L2_PIX_FMT_SBGGR16 v4l2_fourcc('B', 'Y', 'R', '2') /* 16  BGBG.. GRGR.. */
+#define V4L2_PIX_FMT_SGBRG16 v4l2_fourcc('G', 'B', '1', '6') /* 16  GBGB.. RGRG.. */
+#define V4L2_PIX_FMT_SRGGB16 v4l2_fourcc('R', 'G', '1', '6') /* 16  RGRG.. GBGB.. */
+#define V4L2_PIX_FMT_SGRBG16 v4l2_fourcc('G', 'R', '1', '6') /* 16  GRGR.. BGBG.. */

Thanks for the patch!

Could you rebase your uvcvideo changes on this patch, dropping the framework changes from yours?

Cc Laurent. Laurent, could you take both of the patches to your tree after the rebase?

The patch is also available here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=packed12-postponed2&id=c5b60538b33f993109248a642c8e9b74f7d1abd1>

From c5b60538b33f993109248a642c8e9b74f7d1abd1 Mon Sep 17 00:00:00 2001
From: Sakari Ailus <[email protected]>
Date: Mon, 27 Jun 2016 16:46:16 +0300
Subject: [PATCH 1/1] v4l: Add 16-bit raw bayer pixel formats

The formats added by this patch are:

	V4L2_PIX_FMT_SBGGR16
	V4L2_PIX_FMT_SGBRG16
	V4L2_PIX_FMT_SGRBG16

V4L2_PIX_FMT_SRGGB16 already existed before the patch. Rework the documentation to match that of the other sample depths.

Also align the description of V4L2_PIX_FMT_SRGGB16 to match with other similar formats.

Signed-off-by Sakari Ailus <[email protected]>

Acked-by Lad, Prabhakar <[email protected]>

---
 Documentation/media/uapi/v4l/pixfmt-rgb.rst     |  2 +-
 Documentation/media/uapi/v4l/pixfmt-sbggr16.rst | 62 ----------------------
 Documentation/media/uapi/v4l/pixfmt-srggb16.rst | 69 +++++++++++++++++++++++++
 drivers/media/v4l2-core/v4l2-ioctl.c            |  5 +-
 include/uapi/linux/videodev2.h                  |  3 ++
 5 files changed, 77 insertions(+), 64 deletions(-)
 delete mode 100644 Documentation/media/uapi/v4l/pixfmt-sbggr16.rst
 create mode 100644 Documentation/media/uapi/v4l/pixfmt-srggb16.rst

Documentation/media/uapi/v4l/pixfmt-rgb.rst +1 -1

index 9cc9808..b0f3513 100644
@@ -12,9 +12,9 @@ RGB Formats
 
     pixfmt-packed-rgb
     pixfmt-srggb8
-    pixfmt-sbggr16
     pixfmt-srggb10
     pixfmt-srggb10p
     pixfmt-srggb10alaw8
     pixfmt-srggb10dpcm8
     pixfmt-srggb12
+    pixfmt-srggb16

Documentation/media/uapi/v4l/pixfmt-sbggr16.rst deleted +0 ~~-62~~

deleted file mode 100644
index 6f7f327..0000000
@@ -1,62 +0,0 @@
-.. -*- coding: utf-8; mode: rst -*-
-
-.. _V4L2-PIX-FMT-SBGGR16:
-
-*****************************
-V4L2_PIX_FMT_SBGGR16 ('BYR2')
-*****************************
-
-Bayer RGB format
-
-
-Description
-===========
-
-This format is similar to
-:ref:`V4L2_PIX_FMT_SBGGR8 <V4L2-PIX-FMT-SBGGR8>`, except each pixel
-has a depth of 16 bits. The least significant byte is stored at lower
-memory addresses (little-endian).
-
-**Byte Order.**
-Each cell is one byte.
-
-.. flat-table::
-    :header-rows:  0
-    :stub-columns: 0
-
-    * - start + 0:
-      - B\ :sub:`00low`
-      - B\ :sub:`00high`
-      - G\ :sub:`01low`
-      - G\ :sub:`01high`
-      - B\ :sub:`02low`
-      - B\ :sub:`02high`
-      - G\ :sub:`03low`
-      - G\ :sub:`03high`
-    * - start + 8:
-      - G\ :sub:`10low`
-      - G\ :sub:`10high`
-      - R\ :sub:`11low`
-      - R\ :sub:`11high`
-      - G\ :sub:`12low`
-      - G\ :sub:`12high`
-      - R\ :sub:`13low`
-      - R\ :sub:`13high`
-    * - start + 16:
-      - B\ :sub:`20low`
-      - B\ :sub:`20high`
-      - G\ :sub:`21low`
-      - G\ :sub:`21high`
-      - B\ :sub:`22low`
-      - B\ :sub:`22high`
-      - G\ :sub:`23low`
-      - G\ :sub:`23high`
-    * - start + 24:
-      - G\ :sub:`30low`
-      - G\ :sub:`30high`
-      - R\ :sub:`31low`
-      - R\ :sub:`31high`
-      - G\ :sub:`32low`
-      - G\ :sub:`32high`
-      - R\ :sub:`33low`
-      - R\ :sub:`33high`

Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file +69 -0

new file mode 100644
index 0000000..06facc9
@@ -0,0 +1,69 @@
+.. -*- coding: utf-8; mode: rst -*-
+
+.. _V4L2-PIX-FMT-SRGGB16:
+.. _v4l2-pix-fmt-sbggr16:
+.. _v4l2-pix-fmt-sgbrg16:
+.. _v4l2-pix-fmt-sgrbg16:
+
+
+***************************************************************************************************************************
+V4L2_PIX_FMT_SRGGB16 ('RG16'), V4L2_PIX_FMT_SGRBG16 ('GR16'), V4L2_PIX_FMT_SGBRG16 ('GB16'), V4L2_PIX_FMT_SBGGR16 ('BYR2'),
+***************************************************************************************************************************
+
+
+16-bit Bayer formats
+
+
+Description
+===========
+
+These four pixel formats are raw sRGB / Bayer formats with 16 bits per
+sample. Each sample is stored in a 16-bit word. Each n-pixel row contains
+n/2 green samples and n/2 blue or red samples, with alternating red and blue
+rows. Bytes are stored in memory in little endian order. They are
+conventionally described as GRGR... BGBG..., RGRG... GBGB..., etc. Below is
+an example of one of these formats:
+
+**Byte Order.**
+Each cell is one byte.
+
+.. flat-table::
+    :header-rows:  0
+    :stub-columns: 0
+
+    * - start + 0:
+      - B\ :sub:`00low`
+      - B\ :sub:`00high`
+      - G\ :sub:`01low`
+      - G\ :sub:`01high`
+      - B\ :sub:`02low`
+      - B\ :sub:`02high`
+      - G\ :sub:`03low`
+      - G\ :sub:`03high`
+    * - start + 8:
+      - G\ :sub:`10low`
+      - G\ :sub:`10high`
+      - R\ :sub:`11low`
+      - R\ :sub:`11high`
+      - G\ :sub:`12low`
+      - G\ :sub:`12high`
+      - R\ :sub:`13low`
+      - R\ :sub:`13high`
+    * - start + 16:
+      - B\ :sub:`20low`
+      - B\ :sub:`20high`
+      - G\ :sub:`21low`
+      - G\ :sub:`21high`
+      - B\ :sub:`22low`
+      - B\ :sub:`22high`
+      - G\ :sub:`23low`
+      - G\ :sub:`23high`
+    * - start + 24:
+      - G\ :sub:`30low`
+      - G\ :sub:`30high`
+      - R\ :sub:`31low`
+      - R\ :sub:`31high`
+      - G\ :sub:`32low`
+      - G\ :sub:`32high`
+      - R\ :sub:`33low`
+      - R\ :sub:`33high`

drivers/media/v4l2-core/v4l2-ioctl.c +4 -1

index 181381d..61d2d65 100644
@@ -1191,7 +1191,10 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
 	case V4L2_PIX_FMT_SGBRG10DPCM8:	descr = "8-bit Bayer GBGB/RGRG (DPCM)"; break;
 	case V4L2_PIX_FMT_SGRBG10DPCM8:	descr = "8-bit Bayer GRGR/BGBG (DPCM)"; break;
 	case V4L2_PIX_FMT_SRGGB10DPCM8:	descr = "8-bit Bayer RGRG/GBGB (DPCM)"; break;
-	case V4L2_PIX_FMT_SBGGR16:	descr = "16-bit Bayer BGBG/GRGR (Exp.)"; break;
+	case V4L2_PIX_FMT_SBGGR16:	descr = "16-bit Bayer BGBG/GRGR"; break;
+	case V4L2_PIX_FMT_SGBRG16:	descr = "16-bit Bayer GBGB/RGRG"; break;
+	case V4L2_PIX_FMT_SGRBG16:	descr = "16-bit Bayer GRGR/BGBG"; break;
+	case V4L2_PIX_FMT_SRGGB16:	descr = "16-bit Bayer RGRG/GBGB"; break;
 	case V4L2_PIX_FMT_SN9C20X_I420:	descr = "GSPCA SN9C20X I420"; break;
 	case V4L2_PIX_FMT_SPCA501:	descr = "GSPCA SPCA501"; break;
 	case V4L2_PIX_FMT_SPCA505:	descr = "GSPCA SPCA505"; break;

include/uapi/linux/videodev2.h +3 -1

index 4364ce6..ba352b6 100644
@@ -605,6 +605,9 @@ struct v4l2_pix_format {
 #define V4L2_PIX_FMT_SGRBG12 v4l2_fourcc('B', 'A', '1', '2') /* 12  GRGR.. BGBG.. */
 #define V4L2_PIX_FMT_SRGGB12 v4l2_fourcc('R', 'G', '1', '2') /* 12  RGRG.. GBGB.. */
 #define V4L2_PIX_FMT_SBGGR16 v4l2_fourcc('B', 'Y', 'R', '2') /* 16  BGBG.. GRGR.. */
+#define V4L2_PIX_FMT_SGBRG16 v4l2_fourcc('G', 'B', '1', '6') /* 16  GBGB.. RGRG.. */
+#define V4L2_PIX_FMT_SGRBG16 v4l2_fourcc('G', 'R', '1', '6') /* 16  GRGR.. BGBG.. */
+#define V4L2_PIX_FMT_SRGGB16 v4l2_fourcc('R', 'G', '1', '6') /* 16  RGRG.. GBGB.. */
 
 /* HSV formats */
 #define V4L2_PIX_FMT_HSV24 v4l2_fourcc('H', 'S', 'V', '3')
--

2.1.4

--
Kind regards,

Sakari Ailus
e-mail: [email protected] XMPP: [email protected]

Laurent Pinchart

maintainer Reviewed-by

2016-11-15 14:43 UTC #8 lore raw

In reply to Sakari Ailus

Hi Sakari,

Quoted 57 lines · On Monday 14 Nov 2016 16:14:25 Sakari Ailus wrote:

Quoted 10 lines · Edgar Thier
From aec97c931cb4b91f91dd0ed38f74d866d4f13347 Mon Sep 17 00:00:00 2001
From: Edgar Thier <[email protected]>
Date: Mon, 14 Nov 2016 14:17:57 +0100
Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns
Add bayer 16-bit GUIDs to uvcvideo and associated them with the corresponding V4L2 pixel formats.
Signed-off-by Edgar Thier <[email protected]>
---
...
Quoted 12 lines
(quoted diff) +0 -0
b/include/uapi/linux/videodev2.h index 4364ce6..6bdf592 100644
include/uapi/linux/videodev2.h +1 -0
@@ -605,6 +605,9 @@ struct v4l2_pix_format {
 #define V4L2_PIX_FMT_SGRBG12 v4l2_fourcc('B', 'A', '1', '2') /* 12 
 GRGR.. BGBG.. */
 #define V4L2_PIX_FMT_SRGGB12 v4l2_fourcc('R', 'G', '1', '2') /* 12 
 RGRG.. GBGB.. */
 #define V4L2_PIX_FMT_SBGGR16 v4l2_fourcc('B', 'Y', 'R', '2') /* 16 
 BGBG.. GRGR.. */
+#define V4L2_PIX_FMT_SGBRG16 v4l2_fourcc('G', 'B', '1', '6') /* 16 
Quoted 5 lines
GBGB.. RGRG.. */
+#define V4L2_PIX_FMT_SRGGB16 v4l2_fourcc('R', 'G', '1', '6') /* 16 RGRG.. GBGB.. */
+#define V4L2_PIX_FMT_SGRBG16 v4l2_fourcc('G', 'R', '1', '6') /* 16 GRGR.. BGBG.. */
Thanks for the patch!
Could you rebase your uvcvideo changes on this patch, dropping the framework changes from yours?
Cc Laurent. Laurent, could you take both of the patches to your tree after the rebase?
The patch is also available here:
<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=packed12-postpo ned2&id=c5b60538b33f993109248a642c8e9b74f7d1abd1>
From c5b60538b33f993109248a642c8e9b74f7d1abd1 Mon Sep 17 00:00:00 2001
From: Sakari Ailus <[email protected]>
Date: Mon, 27 Jun 2016 16:46:16 +0300
Subject: [PATCH 1/1] v4l: Add 16-bit raw bayer pixel formats
The formats added by this patch are:
	V4L2_PIX_FMT_SBGGR16
	V4L2_PIX_FMT_SGBRG16
	V4L2_PIX_FMT_SGRBG16

Quoted 8 lines

V4L2_PIX_FMT_SRGGB16 already existed before the patch. Rework the documentation to match that of the other sample depths.
Also align the description of V4L2_PIX_FMT_SRGGB16 to match with other similar formats.
Signed-off-by Sakari Ailus <[email protected]>
Acked-by Lad, Prabhakar <[email protected]>

Thank you for the patch.

Quoted 9 lines

---

Documentation/media/uapi/v4l/pixfmt-rgb.rst     |  2 +-
Documentation/media/uapi/v4l/pixfmt-sbggr16.rst | 62 ----------------------
Documentation/media/uapi/v4l/pixfmt-srggb16.rst | 69 ++++++++++++++++++++++
drivers/media/v4l2-core/v4l2-ioctl.c            |  5 +-
include/uapi/linux/videodev2.h                  |  3 ++
 5 files changed, 77 insertions(+), 64 deletions(-)
 delete mode 100644 Documentation/media/uapi/v4l/pixfmt-sbggr16.rst
 create mode 100644 Documentation/media/uapi/v4l/pixfmt-srggb16.rst

[snip]

Quoted 33 lines

(quoted diff) +0 -0
b/Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file mode 100644 index 0000000..06facc9
Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file +9 -0
@@ -0,0 +1,69 @@
+.. -*- coding: utf-8; mode: rst -*-
+
+.. _V4L2-PIX-FMT-SRGGB16:
+.. _v4l2-pix-fmt-sbggr16:
+.. _v4l2-pix-fmt-sgbrg16:
+.. _v4l2-pix-fmt-sgrbg16:
+
+
+***************************************************************************
************************************************ +V4L2_PIX_FMT_SRGGB16 ('RG16'), V4L2_PIX_FMT_SGRBG16 ('GR16'), V4L2_PIX_FMT_SGBRG16 ('GB16'), V4L2_PIX_FMT_SBGGR16 ('BYR2'),
+**************************************************************************
************************************************* +
Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file +10 -0
+
+16-bit Bayer formats
+
+
+Description
+===========
+
+These four pixel formats are raw sRGB / Bayer formats with 16 bits per
+sample. Each sample is stored in a 16-bit word. Each n-pixel row contains
+n/2 green samples and n/2 blue or red samples, with alternating red and
blue
Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file +2 -0
+rows. Bytes are stored in memory in little endian order. They are
+conventionally described as GRGR... BGBG..., RGRG... GBGB..., etc. Below

Quoted 2 lines

is
+an example of one of these formats:

To make it clearer, how about telling which format that is ?

Apart from that,

Reviewed-by Laurent Pinchart <[email protected]>

Quoted 44 lines

Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file +44 -0

+
+**Byte Order.**
+Each cell is one byte.
+
+.. flat-table::
+    :header-rows:  0
+    :stub-columns: 0
+
+    * - start + 0:
+      - B\ :sub:`00low`
+      - B\ :sub:`00high`
+      - G\ :sub:`01low`
+      - G\ :sub:`01high`
+      - B\ :sub:`02low`
+      - B\ :sub:`02high`
+      - G\ :sub:`03low`
+      - G\ :sub:`03high`
+    * - start + 8:
+      - G\ :sub:`10low`
+      - G\ :sub:`10high`
+      - R\ :sub:`11low`
+      - R\ :sub:`11high`
+      - G\ :sub:`12low`
+      - G\ :sub:`12high`
+      - R\ :sub:`13low`
+      - R\ :sub:`13high`
+    * - start + 16:
+      - B\ :sub:`20low`
+      - B\ :sub:`20high`
+      - G\ :sub:`21low`
+      - G\ :sub:`21high`
+      - B\ :sub:`22low`
+      - B\ :sub:`22high`
+      - G\ :sub:`23low`
+      - G\ :sub:`23high`
+    * - start + 24:
+      - G\ :sub:`30low`
+      - G\ :sub:`30high`
+      - R\ :sub:`31low`
+      - R\ :sub:`31high`
+      - G\ :sub:`32low`
+      - G\ :sub:`32high`
+      - R\ :sub:`33low`
+      - R\ :sub:`33high`

Signature · 3 lines

Regards,

Laurent Pinchart

Sakari Ailus

2016-11-15 17:04 UTC #9 lore raw

Hi Laurent,

Quoted 2 lines · Laurent Pinchart

Hi Sakari,

...

Quoted 5 lines

Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file +5 -0

+Description
+===========
+
+These four pixel formats are raw sRGB / Bayer formats with 16 bits per
+sample. Each sample is stored in a 16-bit word. Each n-pixel row contains

Quoted 8 lines

Quoted 6 lines
+n/2 green samples and n/2 blue or red samples, with alternating red and blue
(quoted diff) +2 -0
+rows. Bytes are stored in memory in little endian order. They are
+conventionally described as GRGR... BGBG..., RGRG... GBGB..., etc. Below
is
+an example of one of these formats:
To make it clearer, how about telling which format that is ?

I don't object the change as such, but the text is the same than on other bayer formats as well. The fix should not be done on this one only.

I propose to handle that separately if that's ok for you.

Signature · 4 lines

Regards,

Sakari Ailus
e-mail: [email protected]	XMPP: [email protected]

Laurent Pinchart

maintainer

2016-11-15 19:07 UTC #10 lore raw

Hi Sakari,

Quoted 20 lines · On Tuesday 15 Nov 2016 19:04:02 Sakari Ailus wrote:

Quoted 1 line · Laurent Pinchart
Hi Sakari,
...
Quoted 6 lines
Quoted 6 lines
Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file +5 -0
+Description
+===========
+
+These four pixel formats are raw sRGB / Bayer formats with 16 bits per
+sample. Each sample is stored in a 16-bit word. Each n-pixel row
contains
Quoted 8 lines
Quoted 6 lines
+n/2 green samples and n/2 blue or red samples, with alternating red and blue
(quoted diff) +2 -0
+rows. Bytes are stored in memory in little endian order. They are
+conventionally described as GRGR... BGBG..., RGRG... GBGB..., etc.
Below is
+an example of one of these formats:
To make it clearer, how about telling which format that is ?

Quoted 4 lines

I don't object the change as such, but the text is the same than on other bayer formats as well. The fix should not be done on this one only.
I propose to handle that separately if that's ok for you.

I'm fine with that, can you submit a patch ? :-)

Signature · 3 lines

Regards,

Laurent Pinchart

Edgar Thier

author

2016-11-15 19:18 UTC #11 lore raw

Hi Laurent,

Quoted 1 line

Which device(s) support these formats ?

As mentioned in my last mail, I took the freedom and uploaded the lsusb -v output for 3 cameras with
bayer 16-bit patterns. You can find them here:

dfk23up1300_16bitbayer_RG.lsusb: http://pastebin.com/PDdY7rs0
dfk23ux249_16bitbayer_GB.lsusb: http://pastebin.com/gtjF3Q2k
dfk33ux250_16bitbayer_GR.lsusb: http://pastebin.com/Errz5UMr

All 3 are USB 3.0 industrial cameras by 'The Imaging Source'.

Quoted 1 line

And could you please try to fix your e-mail client and/or server to avoid corrupting patches ?

I am not sure what is wrong but I will look into it.

Cheers,

Edgar

Laurent Pinchart

maintainer

2016-11-17 11:57 UTC #12 lore raw

Hi Edgar,

Quoted 8 lines · On Tuesday 15 Nov 2016 20:18:56 Edgar Thier wrote:

Hi Laurent,
Quoted 1 line
Which device(s) support these formats ?
As mentioned in my last mail, I took the freedom and uploaded the lsusb -v output for 3 cameras with
bayer 16-bit patterns. You can find them here:

Quoted 5 lines

dfk23up1300_16bitbayer_RG.lsusb: http://pastebin.com/PDdY7rs0
dfk23ux249_16bitbayer_GB.lsusb: http://pastebin.com/gtjF3Q2k
dfk33ux250_16bitbayer_GR.lsusb: http://pastebin.com/Errz5UMr
All 3 are USB 3.0 industrial cameras by 'The Imaging Source'.

Thank you. I've added the cameras names to the commit message.

Quoted 4 lines

Quoted 2 lines
And could you please try to fix your e-mail client and/or server to avoid corrupting patches ?
I am not sure what is wrong but I will look into it.

Thanks. If it's on the server side there might not be much you'll be able to do, but it's always worth a shot.

Signature · 3 lines

Regards,

Laurent Pinchart

Sakari Ailus

2016-11-15 20:53 UTC #13 lore raw

In reply to Laurent Pinchart

Quoted 23 lines · Laurent Pinchart

Hi Sakari,
Quoted 20 lines · On Tuesday 15 Nov 2016 19:04:02 Sakari Ailus wrote:
Quoted 1 line · Laurent Pinchart
Hi Sakari,
...
Quoted 14 lines
Quoted 10 lines
Documentation/media/uapi/v4l/pixfmt-srggb16.rst new file +5 -0
+Description
+===========
+
+These four pixel formats are raw sRGB / Bayer formats with 16 bits per
+sample. Each sample is stored in a 16-bit word. Each n-pixel row
contains
+n/2 green samples and n/2 blue or red samples, with alternating red and blue
(quoted diff) +2 -0
+rows. Bytes are stored in memory in little endian order. They are
+conventionally described as GRGR... BGBG..., RGRG... GBGB..., etc.
Quoted 2 lines
Below is
+an example of one of these formats:
To make it clearer, how about telling which format that is ?

Quoted 6 lines

Quoted 4 lines
I don't object the change as such, but the text is the same than on other bayer formats as well. The fix should not be done on this one only.
I propose to handle that separately if that's ok for you.
I'm fine with that, can you submit a patch ? :-)

Sure, likely tomorrow.

Signature · 2 lines

Sakari Ailus
e-mail: [email protected]	XMPP: [email protected]