Skip to contentSkip to conversation

botan: pass --prefix=/usr to fix .pc file

PATCH New Thomas Petazzoni 2 participants 2 messages Apr 10, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 botan: pass --prefix=/usr to fix .pc file

botan uses a non-autotools build system. We currently don't pass any --prefix=/usr, and by default the prefix is set to /usr/local. This doesn't cause a lot of visible issues because at install time, we pass DESTDIR=$(TARGET_DIR)/usr (the build system doesn't make the difference between DESTDIR and prefix).

However, the generated pkg-config .pc file is wrong, as it contains prefix=/usr/local instead of prefix=/usr, which doesn't match where the botan library and headers are installed. By passing --prefix=/usr, we make sure that the .pc file is in line with where botan is installed.

Fixes bug #7760

---
 package/botan/botan.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/botan/botan.mk +2 -1
index 70a0946..6ac3ce7 100644
@@ -16,7 +16,8 @@ BOTAN_CONF_OPTS = \
 	--cpu=$(BR2_ARCH) \
 	--os=linux \
 	--cc=gcc \
-	--cc-bin="$(TARGET_CXX)"
+	--cc-bin="$(TARGET_CXX)" \
+	--prefix=/usr
 
 ifeq ($(BR2_STATIC_LIBS),y)
 BOTAN_CONF_OPTS += --disable-shared --no-autoload
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 botan: pass --prefix=/usr to fix .pc file

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

botan uses a non-autotools build system. We currently don't pass any --prefix=/usr, and by default the prefix is set to /usr/local. This doesn't cause a lot of visible issues because at install time, we pass DESTDIR=$(TARGET_DIR)/usr (the build system doesn't make the difference between DESTDIR and prefix).

However, the generated pkg-config .pc file is wrong, as it contains prefix=/usr/local instead of prefix=/usr, which doesn't match where the botan library and headers are installed. By passing --prefix=/usr, we make sure that the .pc file is in line with where botan is installed.

Quoted 3 lines

Fixes bug #7760

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard