Skip to contentSkip to conversation

alsa-lib: Disable mixer in alsa-lib when BR2_PREFER_STATIC_LIB is selected.

PATCH New sonic.adi at gmail.com 2 participants 2 messages Nov 18, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 alsa-lib: Disable mixer in alsa-lib when BR2_PREFER_STATIC_LIB is selected.

From: Sonic Zhang <[email protected]>

The mixer in ALSA library depends on runtime library loader which doesn't available if building for static library.

---
 package/alsa-lib/alsa-lib.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/alsa-lib/alsa-lib.mk +1 -1
index a7ffd77..145bcf8 100644
@@ -19,7 +19,7 @@ ALSA_LIB_CONF_OPT = --with-alsa-devdir=$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_DEVD
 
 # Can't build with static & shared at the same time (1.0.25+)
 ifeq ($(BR2_PREFER_STATIC_LIB),y)
-ALSA_LIB_CONF_OPT += --enable-shared=no
+ALSA_LIB_CONF_OPT += --enable-shared=no --disable-mixer
 else
 ALSA_LIB_CONF_OPT += --enable-static=no
 endif
Signature · 1 line
1.8.2.3
#1 lore raw

PATCH 1/1 alsa-lib: Disable mixer in alsa-lib when BR2_PREFER_STATIC_LIB is selected.

Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"sonic" == sonic adi <[email protected]> writes:

From: Sonic Zhang <[email protected]>
The mixer in ALSA library depends on runtime library loader which doesn't available if building for static library.

---
 package/alsa-lib/alsa-lib.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/alsa-lib/alsa-lib.mk +0 -0
index a7ffd77..145bcf8 100644

package/alsa-lib/alsa-lib.mk ALSA_LIB_CONF_OPT = --with-alsa-devdir=$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_DEVD · line 22

Quoted 5 lines
package/alsa-lib/alsa-lib.mk +1 -1
@@ -19,7 +19,7 @@ ALSA_LIB_CONF_OPT = --with-alsa-devdir=$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_DEVD
 
 # Can't build with static & shared at the same time (1.0.25+)
 ifeq ($(BR2_PREFER_STATIC_LIB),y)
-ALSA_LIB_CONF_OPT += --enable-shared=no
+ALSA_LIB_CONF_OPT += --enable-shared=no --disable-mixer

We already have BR2_PACkAGE_ALSA_LIB_MIXER to control if the mixer support should be enabled or not, so you should instead make that option depend on !BR2_PREFER_STATIC_LIB.

You also need to propagate this dependency to the reverse deps of the option:

git grep -l 'select BR2_PACKAGE_ALSA_LIB_MIXER'
package/alsa-utils/Config.in
package/alsamixergui/Config.in
package/gstreamer/gst-plugins-base/Config.in
package/gstreamer1/gst1-plugins-base/Config.in
package/mpd/Config.in

Care to fix this and resend? Thanks.

Signature · 1 line
Bye, Peter Korsgaard