Skip to contentSkip to conversation

Add support for SD/MMC on SOCFPGA

PATCH Superseded [email protected] 6 participants 12 messages Sep 9, 2013 – Sep 26, 2013

Subsystems (6)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Add support for SD/MMC on SOCFPGA

From: Dinh Nguyen <[email protected]>

Hi,

Here is a patch series that enables SD/MMC support for the SOCFPGA platform. This is the 6th revision of the series. This series is intended for v3.13.

v6:
- Reuse "samsung,dw-mshc-sdr-timing" binding
- Clean up dw_mmc-socfpga.c to have only the necessary functions
- Remove dw_mci_socfpga_parse_dt(), as we'll let the platform function:
socfpga_sysmgr_set_dwmmc_drvsel_smpsel() do that work
- Always use SDMMC_CMD_USE_HOLD_REG
- Add mach-socfpga/system_mgr.c, which contains function that will set the SD/MMC SDR values in the System Manager.
- Expose an API function in the mach-socfpga platform code so that the SD/MMC driver can use to set the SDR values.

I know that there's a general rule not to have drivers access specific function(s) in platform code, but for this case I am really unsure of what would be the best solution. The system manager IP block itself does not warrant a driver, so a "syscon" driver should suffice. However, there are specific register offsets that are needed, these can be defined in either in the SD/MMC or DTS entry. But in order for the DTS entries to be correct, it would need register offset information as well. And I was informed that register offsets were frowned upon in the past.

So for this go-around, I am exposing an API from the mach-socfpga platform code that will only be used by a platform-specific implementation of the SD/MMC driver.

v5:
- Add "altr,ciu-clk-offset" that represents the necessary offset and shift values in the sysmgr phandle. This is used to set the correct CIU clock values.

v4:
- Add a complete binding example in documentations
- Add a phandle entry for "altr,sysmgr" which links the system manager to the SD/MMC IP block that controls the SDR timings.
- Split up patches
1/3 - Add syscon binding to sys-mgr node
2/3 - DTS bindings and documentation for SD/MMC on SOCFPGA 3/3 - Driver changes to use the bindings

v3:
- Explicitly reference synopsis-dw-mshc.txt for base bindings
- Remove "dw-mshc-ciu-div" as driver can get clock information dts "ciu" entry
- Fixed indentation issue

v2:
- Remove bus-width and extra line in documentation
- Merge bindings example into a single node in documentation

Dinh Nguyen (3):
arm: socfpga: Set the SDMMC clock phase in system manager
mmc: dw_mmc-socfpga: Clean up SOCFPGA platform specific functionality
arm: dts: socfpga: Add support for SD/MMC

 .../devicetree/bindings/mmc/socfpga-dw-mshc.txt    |   38 ++++++++++++
 arch/arm/boot/dts/socfpga.dtsi                     |   11 ++++
 arch/arm/boot/dts/socfpga_cyclone5.dts             |   12 ++++
 arch/arm/boot/dts/socfpga_vt.dts                   |   12 ++++
 arch/arm/mach-socfpga/Makefile                     |    2 +-
 arch/arm/mach-socfpga/core.h                       |    6 ++
 arch/arm/mach-socfpga/system_mgr.c                 |   32 ++++++++++
 drivers/mmc/host/dw_mmc-pltfm.h                    |    2 +-
 drivers/mmc/host/dw_mmc-socfpga.c                  |   63 +-------------------
 9 files changed, 115 insertions(+), 63 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt
 create mode 100644 arch/arm/mach-socfpga/system_mgr.c
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/3 arm: socfpga: Set the SDMMC clock phase in system manager

From: Dinh Nguyen <[email protected]>

Add functionality in the System Manager to set the SDR settings for the SD/MMC IP.

Cc Pavel Machek <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc Chris Ball <[email protected]>
Cc Jaehoon Chung <[email protected]>
Cc Seungwon Jeon <[email protected]>
Cc devicetree at vger.kernel.org
Cc linux-mmc at vger.kernel.org
CC linux-arm-kernel at lists.infradead.org
---
 arch/arm/mach-socfpga/Makefile     |    2 +-
 arch/arm/mach-socfpga/core.h       |    6 ++++++
 arch/arm/mach-socfpga/system_mgr.c |   32 ++++++++++++++++++++++++++++++++
 3 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/mach-socfpga/system_mgr.c
arch/arm/mach-socfpga/Makefile +1 -1
index 6dd7a93..e4ff8b9 100644
@@ -2,5 +2,5 @@
 # Makefile for the linux kernel.
 #
 
-obj-y					:= socfpga.o
+obj-y					:= socfpga.o system_mgr.o
 obj-$(CONFIG_SMP)	+= headsmp.o platsmp.o
arch/arm/mach-socfpga/core.h +6 -0
index 572b8f7..b05fa6a 100644
@@ -44,4 +44,10 @@ extern unsigned long cpu1start_addr;
 
 #define SOCFPGA_SCU_VIRT_BASE   0xfffec000
 
+/* SDMMC Group for System Manager defines */
+#define SYSMGR_SDMMCGRP_CTRL_OFFSET             0x108
+#define DRV_CLK_PHASE_SHIFT_SEL_MASK    0x7
+#define SYSMGR_SDMMC_CTRL_SET(smplsel, drvsel)          \
+	((((smplsel) & 0x7) << 3) | (((drvsel) & 0x7) << 0))
+
 #endif
arch/arm/mach-socfpga/system_mgr.c new file +32 -0
new file mode 100644
index 0000000..c69a854
@@ -0,0 +1,32 @@
+/*
+ * Copyright Altera Corporation (C) 2013. All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+#include <linux/of_platform.h>
+#include <asm/mach/map.h>
+
+#include "core.h"
+
+void socfpga_sysmgr_set_dwmmc_drvsel_smpsel(void)
+{
+	struct device_node *np;
+	u32 timing[2];
+	u32 hs_timing;
+
+	np = of_find_compatible_node(NULL, NULL, "altr,socfpga-dw-mshc");
+	of_property_read_u32_array(np, "samsung,dw-mshc-sdr-timing", timing, 2);
+	hs_timing = SYSMGR_SDMMC_CTRL_SET(timing[0], timing[1]);
+	writel(hs_timing, sys_manager_base_addr + SYSMGR_SDMMCGRP_CTRL_OFFSET);
+}
+EXPORT_SYMBOL(socfpga_sysmgr_set_dwmmc_drvsel_smpsel);
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 1/3 arm: socfpga: Set the SDMMC clock phase in system manager

Hi!

Quoted 10 lines

From: Dinh Nguyen <[email protected]>

Add functionality in the System Manager to set the SDR settings for the SD/MMC IP.

arch/arm/mach-socfpga/system_mgr.c new file +2 -0
+void socfpga_sysmgr_set_dwmmc_drvsel_smpsel(void)
+{

arch/arm/mach-socfpga/system_mgr.c line 32

Quoted 10 lines
arch/arm/mach-socfpga/system_mgr.c new file +10 -0
+	struct device_node *np;
+	u32 timing[2];
+	u32 hs_timing;
+
+	np = of_find_compatible_node(NULL, NULL, "altr,socfpga-dw-mshc");
+	of_property_read_u32_array(np, "samsung,dw-mshc-sdr-timing", timing, 2);
+	hs_timing = SYSMGR_SDMMC_CTRL_SET(timing[0], timing[1]);
+	writel(hs_timing, sys_manager_base_addr + SYSMGR_SDMMCGRP_CTRL_OFFSET);
+}
+EXPORT_SYMBOL(socfpga_sysmgr_set_dwmmc_drvsel_smpsel);

To get the abstraction right, would it make sense to have timing parameters as arguments to socfpga_sysmgr_set_dwmmc_drvsel_smpsel(), so that sysmgr code is not walking MMC's device tree directly?

Thanks,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw

PATCH 1/3 arm: socfpga: Set the SDMMC clock phase in system manager

Hi Dinh,

Quoted 8 lines · Pavel Machek
Quoted 7 lines

From: Dinh Nguyen <[email protected]>

Add functionality in the System Manager to set the SDR settings for the SD/MMC IP.

Quoted 16 lines

arch/arm/mach-socfpga/system_mgr.c line 32

Quoted 12 lines
arch/arm/mach-socfpga/system_mgr.c new file +12 -0
+void socfpga_sysmgr_set_dwmmc_drvsel_smpsel(void)
+{
+	struct device_node *np;
+	u32 timing[2];
+	u32 hs_timing;
+
+	np = of_find_compatible_node(NULL, NULL, "altr,socfpga-dw-mshc");
+	of_property_read_u32_array(np, "samsung,dw-mshc-sdr-timing", timing, 2);
+	hs_timing = SYSMGR_SDMMC_CTRL_SET(timing[0], timing[1]);
+	writel(hs_timing, sys_manager_base_addr + SYSMGR_SDMMCGRP_CTRL_OFFSET);
+}
+EXPORT_SYMBOL(socfpga_sysmgr_set_dwmmc_drvsel_smpsel);

To get the abstraction right, would it make sense to have timing parameters as arguments to socfpga_sysmgr_set_dwmmc_drvsel_smpsel(), so that sysmgr code is not walking MMC's device tree directly?

I think this review comment from Pavel is still open, please reply. Thanks,

- Chris.

Signature · 1 line
Chris Ball   <[email protected]>   <http://printf.net/>
#4 lore raw

PATCH 1/3 arm: socfpga: Set the SDMMC clock phase in system manager

Hi Chris,

Quoted 28 lines · Chris Ball

Hi Dinh,

Quoted 8 lines · Pavel Machek
Quoted 7 lines

From: Dinh Nguyen <[email protected]>

Add functionality in the System Manager to set the SDR settings for the SD/MMC IP.

Quoted 16 lines

arch/arm/mach-socfpga/system_mgr.c line 32

Quoted 12 lines
arch/arm/mach-socfpga/system_mgr.c new file +12 -0
+void socfpga_sysmgr_set_dwmmc_drvsel_smpsel(void)
+{
+	struct device_node *np;
+	u32 timing[2];
+	u32 hs_timing;
+
+	np = of_find_compatible_node(NULL, NULL, "altr,socfpga-dw-mshc");
+	of_property_read_u32_array(np, "samsung,dw-mshc-sdr-timing", timing, 2);
+	hs_timing = SYSMGR_SDMMC_CTRL_SET(timing[0], timing[1]);
+	writel(hs_timing, sys_manager_base_addr + SYSMGR_SDMMCGRP_CTRL_OFFSET);
+}
+EXPORT_SYMBOL(socfpga_sysmgr_set_dwmmc_drvsel_smpsel);

To get the abstraction right, would it make sense to have timing parameters as arguments to socfpga_sysmgr_set_dwmmc_drvsel_smpsel(), so that sysmgr code is not walking MMC's device tree directly?

Quoted 1 line

I think this review comment from Pavel is still open, please reply.

I sent a Rev 2 that addresses this comment on 9/23. Let me know if I need to resend it in case you missed it.

Thanks,
Dinh

Quoted 5 lines

Thanks,

- Chris.

Signature · 1 line
Chris Ball   <[email protected]>   <http://printf.net/>
#5 lore raw

PATCH 2/3 mmc: dw_mmc-socfpga: Clean up SOCFPGA platform specific functionality

In reply to [email protected]

From: Dinh Nguyen <[email protected]>

The SDR timing registers for the SD/MMC IP block for SOCFPGA is located in the system manager. This system manager IP block is located outside of the SD IP block itself. Therefore, the function to set the SDR timing register should be in the platform specific code so that the SD driver can be autonomous of any future System Manager changes.

Also, there is no need for "altr,dw-mshc-ciu-div" as the driver can get the value of the CIU clock from the common clock API.

Cc Pavel Machek <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc Chris Ball <[email protected]>
Cc Jaehoon Chung <[email protected]>
Cc Seungwon Jeon <[email protected]>
Cc devicetree at vger.kernel.org
Cc linux-mmc at vger.kernel.org
CC linux-arm-kernel at lists.infradead.org
---
 drivers/mmc/host/dw_mmc-pltfm.h   |    2 +-
 drivers/mmc/host/dw_mmc-socfpga.c |   63 ++-----------------------------------
 2 files changed, 3 insertions(+), 62 deletions(-)
drivers/mmc/host/dw_mmc-pltfm.h +1 -1
index 68e7fd2..682400f 100644
@@ -16,5 +16,5 @@ extern int dw_mci_pltfm_register(struct platform_device *pdev,
 				const struct dw_mci_drv_data *drv_data);
 extern int dw_mci_pltfm_remove(struct platform_device *pdev);
 extern const struct dev_pm_ops dw_mci_pltfm_pmops;
-
+extern void socfpga_sysmgr_set_dwmmc_drvsel_smpsel(void);
 #endif /* _DW_MMC_PLTFM_H_ */
drivers/mmc/host/dw_mmc-socfpga.c +2 -61

87 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#6 lore raw

PATCH 3/3 arm: dts: socfpga: Add support for SD/MMC

In reply to [email protected]

From: Dinh Nguyen <[email protected]>

Add bindings for SD/MMC for SOCFPGA.

Cc Pavel Machek <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc Chris Ball <[email protected]>
Cc Jaehoon Chung <[email protected]>
Cc Seungwon Jeon <[email protected]>
Cc devicetree at vger.kernel.org
Cc linux-mmc at vger.kernel.org
CC linux-arm-kernel at lists.infradead.org
---
 .../devicetree/bindings/mmc/socfpga-dw-mshc.txt    |   38 ++++++++++++++++++++
 arch/arm/boot/dts/socfpga.dtsi                     |   11 ++++++
 arch/arm/boot/dts/socfpga_cyclone5.dts             |   12 +++++++
 arch/arm/boot/dts/socfpga_vt.dts                   |   12 +++++++
 4 files changed, 73 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt
Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt new file +38 -0
new file mode 100644
index 0000000..f565835
@@ -0,0 +1,38 @@
+* Altera SOCFPGA specific extensions to the Synopsis Designware Mobile
+  Storage Host Controller
+
+The Synopsis designware mobile storage host controller is used to interface
+a SoC with storage medium such as eMMC or SD/MMC cards. This file documents
+differences between the core Synopsis dw mshc controller properties described
+by synopsis-dw-mshc.txt and the properties used by the SOCFPGA specific
+extensions to the Synopsis Designware Mobile Storage Host Controller.
+
+Required Properties:
+
+* compatible: should be
+        - "altr,socfpga-dw-mshc": for controllers with Altera SOCFPGA
+          specific extensions.
+
+* samsung,dw-mshc-sdr-timing: See exynos-dw-mshc.txt for more information about
+	this binding.
+
+Example:
+        dwmmc0 at ff704000 {
+                compatible = "altr,socfpga-dw-mshc", "snps,dw-mshc";
+                reg = <0xff704000 0x1000>;
+                interrupts = <0 139 4>;
+                fifo-depth = <0x400>;
+                #address-cells = <1>;
+                #size-cells = <0>;
+                clocks = <&l4_mp_clk>, <&sdmmc_clk>;
+                clock-names = "biu", "ciu";
+                num-slots = <1>;
+                supports-highspeed;
+                broken-cd;
+                samsung,dw-mshc-sdr-timing = <0 3>;
+
+                slot at 0 {
+                        reg = <0>;
+                        bus-width = <4>;
+                };
+        };
arch/arm/boot/dts/socfpga.dtsi +11 -0
index bee62a2..25ad850 100644
@@ -468,6 +468,17 @@
 			cache-level = <2>;
 		};
 
+		mmc: dwmmc0 at ff704000 {
+			compatible = "altr,socfpga-dw-mshc";
+			reg = <0xff704000 0x1000>;
+			interrupts = <0 139 4>;
+			fifo-depth = <0x400>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			clocks = <&l4_mp_clk>, <&sdmmc_clk>;
+			clock-names = "biu", "ciu";
+		};
+
 		/* Local timer */
 		timer at fffec600 {
 			compatible = "arm,cortex-a9-twd-timer";
arch/arm/boot/dts/socfpga_cyclone5.dts +12 -0
index 973999d..b4b68ad 100644
@@ -48,6 +48,18 @@
 			};
 		};
 
+		dwmmc0 at ff704000 {
+			num-slots = <1>;
+			supports-highspeed;
+			broken-cd;
+			samsung,dw-mshc-sdr-timing = <0 3>;
+
+			slot at 0 {
+				reg = <0>;
+				bus-width = <4>;
+			};
+		};
+
 		ethernet at ff702000 {
 			phy-mode = "rgmii";
 			phy-addr = <0xffffffff>; /* probe for phy addr */
arch/arm/boot/dts/socfpga_vt.dts +12 -0
index d1ec0ca..7dc709b 100644
@@ -41,6 +41,18 @@
 			};
 		};
 
+		dwmmc0 at ff704000 {
+			num-slots = <1>;
+			supports-highspeed;
+			broken-cd;
+			samsung,dw-mshc-sdr-timing = <0 3>;
+
+			slot at 0 {
+				reg = <0>;
+				bus-width = <4>;
+			};
+		};
+
 		ethernet at ff700000 {
 			phy-mode = "gmii";
 			status = "okay";
Signature · 1 line
1.7.9.5
#7 lore raw

PATCH 3/3 arm: dts: socfpga: Add support for SD/MMC

Quoted 13 lines · dinguyen at altera.com

From: Dinh Nguyen <[email protected]>

Add bindings for SD/MMC for SOCFPGA.

Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt +7 -0
 
+* Altera SOCFPGA specific extensions to the Synopsis Designware Mobile
+  Storage Host Controller
+
+The Synopsis designware mobile storage host controller is used to interface
+a SoC with storage medium such as eMMC or SD/MMC cards. This file documents
+differences between the core Synopsis dw mshc controller properties described
+by synopsis-dw-mshc.txt and the properties used by the SOCFPGA specific

Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt line 17

Quoted 10 lines
Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt +10 -0
+extensions to the Synopsis Designware Mobile Storage Host Controller.
+
+Required Properties:
+
+* compatible: should be
+        - "altr,socfpga-dw-mshc": for controllers with Altera SOCFPGA
+          specific extensions.
+
+* samsung,dw-mshc-sdr-timing: See exynos-dw-mshc.txt for more information about
+	this binding.

s/binding/property/

It's odd that this isn't "synopsis," rather than "samsung," if the property is generic across all/some uses of the Synopsis core. But, I guess this is fine.

#8 lore raw

PATCH 3/3 arm: dts: socfpga: Add support for SD/MMC

Quoted 29 lines · On Monday 09 of September 2013 15:11:43 Stephen Warren wrote:
Quoted 24 lines · dinguyen at altera.com

From: Dinh Nguyen <[email protected]>

Add bindings for SD/MMC for SOCFPGA.

Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt +1 -0
 
+* Altera SOCFPGA specific extensions to the Synopsis Designware

Mobile

Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt +3 -0
+  Storage Host Controller
+
+The Synopsis designware mobile storage host controller is used to

interface +a SoC with storage medium such as eMMC or SD/MMC cards. This file documents +differences between the core Synopsis dw mshc controller properties described +by synopsis-dw-mshc.txt and the properties used by the SOCFPGA specific +extensions to the Synopsis Designware Mobile Storage Host Controller. +

Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt +7 -0
+Required Properties:
+
+* compatible: should be
+        - "altr,socfpga-dw-mshc": for controllers with Altera SOCFPGA
+          specific extensions.
+
+* samsung,dw-mshc-sdr-timing: See exynos-dw-mshc.txt for more
Quoted 1 line

information about + this binding.

s/binding/property/

Quoted 3 lines

It's odd that this isn't "synopsis," rather than "samsung," if the property is generic across all/some uses of the Synopsis core. But, I guess this is fine.

Just as a side note, correct name is Synopsys, not Synopsis. There are multiple places around Documentation/devicetree where this typo is present[1]. Should we consider correcting this or the typo will have to stay?

[1] git grep -i synopsis Documentation/devicetree/
Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:* Samsung Exynos specific extensions to the Synopsis Designware Mobile Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:The Synopsis designware mobile storage host controller is used to interface Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:differences between the core Synopsis dw mshc controller properties described Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:by synopsis-dw-mshc.txt and the properties used by the Samsung Exynos specific Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:extensions to the Synopsis Designware Mobile Storage Host Controller. Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:* Rockchip specific extensions to the Synopsis Designware Mobile Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:The Synopsis designware mobile storage host controller is used to interface Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:differences between the core Synopsis dw mshc controller properties described Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:by synopsis-dw-mshc.txt and the properties used by the Rockchip specific Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:extensions to the Synopsis Designware Mobile Storage Host Controller. Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt:* Synopsis Designware Mobile Storage Host Controller Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt:The Synopsis designware mobile storage host controller is used to interface Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt:properties used by the Synopsis Designware Mobile Storage Host Controller.
Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt: - snps,dw-mshc: for controllers compliant with synopsis dw-mshc.
Documentation/devicetree/bindings/pci/designware-pcie.txt:* Synopsis Designware PCIe interface

Best regards,
Tomasz

#9 lore raw

PATCH 3/3 arm: dts: socfpga: Add support for SD/MMC

On 09/14/2013 06:30 AM, Tomasz Figa wrote:
...

Quoted 5 lines

Just as a side note, correct name is Synopsys, not Synopsis. There are multiple places around Documentation/devicetree where this typo is present[1]. Should we consider correcting this or the typo will have to stay?

Quoted 16 lines

[1] git grep -i synopsis Documentation/devicetree/
Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:* Samsung Exynos specific extensions to the Synopsis Designware Mobile Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:The Synopsis designware mobile storage host controller is used to interface Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:differences between the core Synopsis dw mshc controller properties described Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:by synopsis-dw-mshc.txt and the properties used by the Samsung Exynos specific Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:extensions to the Synopsis Designware Mobile Storage Host Controller. Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:* Rockchip specific extensions to the Synopsis Designware Mobile Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:The Synopsis designware mobile storage host controller is used to interface Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:differences between the core Synopsis dw mshc controller properties described Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:by synopsis-dw-mshc.txt and the properties used by the Rockchip specific Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:extensions to the Synopsis Designware Mobile Storage Host Controller. Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt:* Synopsis Designware Mobile Storage Host Controller Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt:The Synopsis designware mobile storage host controller is used to interface Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt:properties used by the Synopsis Designware Mobile Storage Host Controller.
Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt: - snps,dw-mshc: for controllers compliant with synopsis dw-mshc.
Documentation/devicetree/bindings/pci/designware-pcie.txt:* Synopsis Designware PCIe interface

Those typos only appear to exist in free-form text and not in any property names/values. As such, they can all easily be fixed without impacting any DT content or ABI.

#10 lore raw

PATCH 3/3 arm: dts: socfpga: Add support for SD/MMC

Quoted 6 lines · Stephen Warren

On 09/14/2013 06:30 AM, Tomasz Figa wrote:
...

Quoted 4 lines

Just as a side note, correct name is Synopsys, not Synopsis. There are multiple places around Documentation/devicetree where this typo is present[1]. Should we consider correcting this or the typo will have to stay?

I can send a patch to fix the typos.

Dinh

Quoted 22 lines
Quoted 17 lines

[1] git grep -i synopsis Documentation/devicetree/
Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:* Samsung Exynos specific extensions to the Synopsis Designware Mobile Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:The Synopsis designware mobile storage host controller is used to interface Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:differences between the core Synopsis dw mshc controller properties described Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:by synopsis-dw-mshc.txt and the properties used by the Samsung Exynos specific Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt:extensions to the Synopsis Designware Mobile Storage Host Controller. Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:* Rockchip specific extensions to the Synopsis Designware Mobile Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:The Synopsis designware mobile storage host controller is used to interface Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:differences between the core Synopsis dw mshc controller properties described Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:by synopsis-dw-mshc.txt and the properties used by the Rockchip specific Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt:extensions to the Synopsis Designware Mobile Storage Host Controller. Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt:* Synopsis Designware Mobile Storage Host Controller Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt:The Synopsis designware mobile storage host controller is used to interface Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt:properties used by the Synopsis Designware Mobile Storage Host Controller.
Documentation/devicetree/bindings/mmc/synopsis-dw-mshc.txt: - snps,dw-mshc: for controllers compliant with synopsis dw-mshc.
Documentation/devicetree/bindings/pci/designware-pcie.txt:* Synopsis Designware PCIe interface

Those typos only appear to exist in free-form text and not in any property names/values. As such, they can all easily be fixed without impacting any DT content or ABI.

#11 lore raw

PATCH 3/3 arm: dts: socfpga: Add support for SD/MMC

In reply to dinguyen at altera.com
Quoted 6 lines · dinguyen at altera.com

From: Dinh Nguyen <[email protected]>

Add bindings for SD/MMC for SOCFPGA.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html