Skip to contentSkip to conversation

system/device-table: do not set /home/default stgid

PATCH New Yann E. MORIN 3 participants 4 messages May 25, 2013 – May 30, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 system/device-table: do not set /home/default stgid

From: "Yann E. MORIN" <[email protected]>

Currently, /home/default is mode 2755 which means it is setgid. Since /home/default is not group-writable, it is useless.

---
AFAICS, there is no reason that /home/default be setgid. However, I have not audited all packages to check whether one would require that.

---
 system/device_table.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
system/device_table.txt +1 -1
index 421728b..43c0cfa 100644
@@ -9,7 +9,7 @@
 /dev					d	755	0	0	-	-	-	-	-
 /tmp					d	1777	0	0	-	-	-	-	-
 /etc					d	755	0	0	-	-	-	-	-
-/home/default				d	2755	1000	1000	-	-	-	-	-
+/home/default				d	755	1000	1000	-	-	-	-	-
 /var/www				d	755	33	33	-	-	-	-	-
 /etc/shadow				f	600	0	0	-	-	-	-	-
 /etc/passwd				f	644	0	0	-	-	-	-	-
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 system/device-table: do not set /home/default stgid

All,

On 2013-05-25 22:33 +0200, Yann E. MORIN spake thusly:

Quoted 20 lines

From: "Yann E. MORIN" <[email protected]>

Currently, /home/default is mode 2755 which means it is setgid. Since /home/default is not group-writable, it is useless.

---
AFAICS, there is no reason that /home/default be setgid. However, I have not audited all packages to check whether one would require that.

---
 system/device_table.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
system/device_table.txt +0 -0
index 421728b..43c0cfa 100644

system/device_table.txt line 15

Quoted 8 lines
system/device_table.txt +1 -1
@@ -9,7 +9,7 @@
 /dev					d	755	0	0	-	-	-	-	-
 /tmp					d	1777	0	0	-	-	-	-	-
 /etc					d	755	0	0	-	-	-	-	-
-/home/default				d	2755	1000	1000	-	-	-	-	-
+/home/default				d	755	1000	1000	-	-	-	-	-
 /var/www				d	755	33	33	-	-	-	-	-
 /etc/shadow				f	600	0	0	-	-	-	-	-
 /etc/passwd				f	644	0	0	-	-	-	-	-

I think this should got in -next, not master. If it should go at all.

Any reason for this setgid bit on a group-unwritable directory in the first place?

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 system/device-table: do not set /home/default stgid

Hi Yann,

2013/5/25 Yann E. MORIN <[email protected]>:

Quoted 18 lines

All,

On 2013-05-25 22:33 +0200, Yann E. MORIN spake thusly:

Quoted 15 lines

From: "Yann E. MORIN" <[email protected]>

Currently, /home/default is mode 2755 which means it is setgid. Since /home/default is not group-writable, it is useless.

---
AFAICS, there is no reason that /home/default be setgid. However, I have not audited all packages to check whether one would require that.

---
 system/device_table.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

system/device_table.txt line 15

Quoted 13 lines
system/device_table.txt +1 -1
index 421728b..43c0cfa 100644
@@ -9,7 +9,7 @@
 /dev                                 d       755     0       0       -       -       -       -       -
 /tmp                                 d       1777    0       0       -       -       -       -       -
 /etc                                 d       755     0       0       -       -       -       -       -
-/home/default                                d       2755    1000    1000    -       -       -       -       -
+/home/default                                d       755     1000    1000    -       -       -       -       -
 /var/www                             d       755     33      33      -       -       -       -       -
 /etc/shadow                          f       600     0       0       -       -       -       -       -
 /etc/passwd                          f       644     0       0       -       -       -       -       -

I think this should got in -next, not master. If it should go at all.

(for the patch itself and its application on next).

Quoted 3 lines

Any reason for this setgid bit on a group-unwritable directory in the first place?

It has been there for ages (from the beginning), though i don't see any obvious reasons to set this setgid bit on the home directory.

Regards,

Signature · 1 line
Samuel
#3 lore raw

PATCH 1/1 system/device-table: do not set /home/default stgid

In reply to Yann E. MORIN
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Yann> From: "Yann E. MORIN" <[email protected]> Yann> Currently, /home/default is mode 2755 which means it is setgid. Yann> Since /home/default is not group-writable, it is useless.

Committed to next, thanks.

Signature · 1 line
Bye, Peter Korsgaard