Skip to contentSkip to conversation

iftop: new package

PATCH New Bogdan Radulescu 3 participants 9 messages Jan 16, 2013 – Jan 21, 2013

lore
Share & tools
lore

Bogdan Radulescu

author
#0 lore raw

PATCH 1/1 iftop: new package

Added the iftop package which is really nice to easily see what uses the bandwidth on your machine.

Bogdan Radulescu (1):
iftop: new package

 package/Config.in       |  1 +
 package/iftop/Config.in | 12 ++++++++++++
 package/iftop/iftop.mk  | 14 ++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/iftop/Config.in
 create mode 100644 package/iftop/iftop.mk
Signature · 1 line
1.7.12.1
author
#1 lore raw

PATCH 1/1 iftop: new package

Added the iftop package which is really usefull to see quickly what uses the bandwidth on your machine.

---
 package/Config.in       |  1 +
 package/iftop/Config.in | 12 ++++++++++++
 package/iftop/iftop.mk  | 14 ++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/iftop/Config.in
 create mode 100644 package/iftop/iftop.mk
package/Config.in +1 -0
index ba03b3c..9e2dd8b 100644
@@ -772,6 +772,7 @@ endif
 source "package/bwm-ng/Config.in"
 source "package/cpuload/Config.in"
 source "package/htop/Config.in"
+source "package/iftop/Config.in"
 source "package/keyutils/Config.in"
 source "package/kmod/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
package/iftop/Config.in new file +12 -0
new file mode 100644
index 0000000..ddcc4c9
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_IFTOP
+	bool "iftop"
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_LIBPCAP
+	select BR2_TOOLCHAIN_BUILDROOT_INET_IPV6
+	help
+	  iftop does for network usage what top(1) does for CPU usage.
+	  It listens to network traffic on a named interface and displays
+	  a table of current bandwidth usage by pairs of hosts. Handy for
+	  answering the question "why is our ADSL link so slow?".
+
+	  http://www.ex-parrot.com/pdw/iftop/
package/iftop/iftop.mk new file +14 -0
new file mode 100644
index 0000000..3c8df9d
@@ -0,0 +1,14 @@
+#############################################################
+#
+# iftop
+#
+#############################################################
+IFTOP_VERSION = 1.0pre2
+IFTOP_SITE = http://www.ex-parrot.com/pdw/iftop/download/
+
+IFTOP_DEPENDENCIES = ncurses libpcap
+
+IFTOP_LICENSE = GPL
+IFTOP_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.12.1
#2 lore raw

PATCH 1/1 iftop: new package

Dear Bogdan Radulescu,

package/iftop/Config.in line 5

Quoted 1 line · Bogdan Radulescu
package/iftop/Config.in new file +1 -0
+	select BR2_TOOLCHAIN_BUILDROOT_INET_IPV6

No, selecting toolchain options is not correct, and in this particular case, it would only work for the internal toolchain backend (breaking the external backend and Crosstool-NG backend).

See package/squid/Config.in for an example.

Basically, you must do something like:

config BR2_PACKAGE_FOO
depends on BR2_INET_IPV6

comment "foo requires IPv6 support in toolchain"
depends on !BR2_INET_IPV6

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 iftop: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Dear Bogdan Radulescu,

Quoted 1 line · Bogdan Radulescu

package/iftop/Config.in line 5

Quoted 1 line
package/iftop/Config.in new file +1 -0
+	select BR2_TOOLCHAIN_BUILDROOT_INET_IPV6

Thomas> No, selecting toolchain options is not correct, and in this particular Thomas> case, it would only work for the internal toolchain backend (breaking Thomas> the external backend and Crosstool-NG backend).

Thomas> See package/squid/Config.in for an example.

Thomas> Basically, you must do something like:

Thomas> config BR2_PACKAGE_FOO
Thomas> depends on BR2_INET_IPV6

Thomas> comment "foo requires IPv6 support in toolchain"
Thomas> depends on !BR2_INET_IPV6

Indeed. Also don't forget to sign off on your patch (git commit -s).

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 iftop: new package

In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Thomas> No, selecting toolchain options is not correct, and in this particular Thomas> case, it would only work for the internal toolchain backend (breaking Thomas> the external backend and Crosstool-NG backend).

Thomas> See package/squid/Config.in for an example.

Thomas> Basically, you must do something like:

Thomas> config BR2_PACKAGE_FOO
Thomas> depends on BR2_INET_IPV6

Thomas> comment "foo requires IPv6 support in toolchain"
Thomas> depends on !BR2_INET_IPV6

Bogdan, care to resend with the issues pointed out by me and Thomas fixed?

Signature · 1 line
Bye, Peter Korsgaard
author
#5 lore raw

PATCH 1/1 iftop: new package

I adjusted my patch and yes, the correct way is very nice :)
I was at the mountains and I didn't have my computer to send the adjustment earlier. Thanks for you advice!

Signed-off-by Bogdan Radulescu <[email protected]>
---
 package/Config.in       |  1 +
 package/iftop/Config.in | 16 ++++++++++++++++
 package/iftop/iftop.mk  | 15 +++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/iftop/Config.in
 create mode 100644 package/iftop/iftop.mk
package/Config.in +1 -0
index ba03b3c..9e2dd8b 100644
@@ -772,6 +772,7 @@ endif
 source "package/bwm-ng/Config.in"
 source "package/cpuload/Config.in"
 source "package/htop/Config.in"
+source "package/iftop/Config.in"
 source "package/keyutils/Config.in"
 source "package/kmod/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
package/iftop/Config.in new file +16 -0
new file mode 100644
index 0000000..90e36b8
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_IFTOP
+	bool "iftop"
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_LIBPCAP
+	select BR2_INET_IPV6
+
+	help
+	  iftop does for network usage what top(1) does for CPU usage.
+	  It listens to network traffic on a named interface and displays
+	  a table of current bandwidth usage by pairs of hosts. Handy for
+	  answering the question "why is our ADSL link so slow?".
+
+	  http://www.ex-parrot.com/pdw/iftop/
+
+comment "iftop requires IPv6 support in toolchain"
+	depends on !BR2_INET_IPV6
package/iftop/iftop.mk new file +15 -0
new file mode 100644
index 0000000..48c9480
@@ -0,0 +1,15 @@
+#############################################################
+#
+# iftop
+#
+#############################################################
+
+IFTOP_VERSION = 1.0pre2
+IFTOP_SITE = http://www.ex-parrot.com/pdw/iftop/download/
+
+IFTOP_DEPENDENCIES = ncurses libpcap
+
+IFTOP_LICENSE = GPL
+IFTOP_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.12.1
#6 lore raw

PATCH 1/1 iftop: new package

Dear Bogdan Radulescu,

Quoted 3 lines · Bogdan Radulescu

I adjusted my patch and yes, the correct way is very nice :) I was at the mountains and I didn't have my computer to send the adjustment earlier. Thanks for you advice!

You shouldn't put such a message here in the commit log: it will be preserved forever in the Git history. If you want to send such informations, either use an introduction e-mail (separate from the e-mail carrying the patch itself), or for a single patch, put your "personal" comments...

Quoted 4 lines
Signed-off-by Bogdan Radulescu <[email protected]>

---

... here. I.e, after the --- line.

package/iftop/Config.in line 5

Quoted 5 lines
package/iftop/Config.in new file +5 -0
+config BR2_PACKAGE_IFTOP
+	bool "iftop"
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_LIBPCAP
+	select BR2_INET_IPV6

No. Please look at how other packages do it for BR2_INET_IPV6. You're not allowed to select it. You should depend on it, and show a comment when BR2_INET_IPV6 is not available.

package/iftop/Config.in line 7

Quoted 2 lines
package/iftop/Config.in new file +2 -0
+
+	help

No empty line between the bool/select/depends on line and the help line.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#7 lore raw

PATCH 1/1 iftop: new package

Added the iftop package which is really usefull to see quickly what uses the bandwidth on your machine.

Signed-off-by Bogdan Radulescu <[email protected]>
---
 package/Config.in       |  1 +
 package/iftop/Config.in | 15 +++++++++++++++
 package/iftop/iftop.mk  | 15 +++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/iftop/Config.in
 create mode 100644 package/iftop/iftop.mk
package/Config.in +1 -0
index ba03b3c..9e2dd8b 100644
@@ -772,6 +772,7 @@ endif
 source "package/bwm-ng/Config.in"
 source "package/cpuload/Config.in"
 source "package/htop/Config.in"
+source "package/iftop/Config.in"
 source "package/keyutils/Config.in"
 source "package/kmod/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
package/iftop/Config.in new file +15 -0
new file mode 100644
index 0000000..99ea973
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_IFTOP
+	bool "iftop"
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_LIBPCAP
+	depends on BR2_INET_IPV6
+	help
+	  iftop does for network usage what top(1) does for CPU usage.
+	  It listens to network traffic on a named interface and displays
+	  a table of current bandwidth usage by pairs of hosts. Handy for
+	  answering the question "why is our ADSL link so slow?".
+
+	  http://www.ex-parrot.com/pdw/iftop/
+
+comment "iftop requires IPv6 support in toolchain"
+	depends on !BR2_INET_IPV6
package/iftop/iftop.mk new file +15 -0
new file mode 100644
index 0000000..48c9480
@@ -0,0 +1,15 @@
+#############################################################
+#
+# iftop
+#
+#############################################################
+
+IFTOP_VERSION = 1.0pre2
+IFTOP_SITE = http://www.ex-parrot.com/pdw/iftop/download/
+
+IFTOP_DEPENDENCIES = ncurses libpcap
+
+IFTOP_LICENSE = GPL
+IFTOP_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.12.1
#8 lore raw

PATCH 1/1 iftop: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bogdan" == Bogdan Radulescu <[email protected]> writes:

Bogdan> Added the iftop package which is really usefull to see quickly Bogdan> what uses the bandwidth on your machine.

Bogdan> Signed-off-by: Bogdan Radulescu <[email protected]> Bogdan> ---

 Bogdan>  package/Config.in       |  1 +
 Bogdan>  package/iftop/Config.in | 15 +++++++++++++++
 Bogdan>  package/iftop/iftop.mk  | 15 +++++++++++++++
 Bogdan>  3 files changed, 31 insertions(+)
 Bogdan>  create mode 100644 package/iftop/Config.in
 Bogdan>  create mode 100644 package/iftop/iftop.mk

Bogdan> diff --git a/package/Config.in b/package/Config.in Bogdan> index ba03b3c..9e2dd8b 100644
Bogdan> --- a/package/Config.in
Bogdan> +++ b/package/Config.in
Bogdan> @@ -772,6 +772,7 @@ endif

 Bogdan>  source "package/bwm-ng/Config.in"
 Bogdan>  source "package/cpuload/Config.in"
 Bogdan>  source "package/htop/Config.in"

Bogdan> +source "package/iftop/Config.in"

I find it more sensible to have it under Networking applications together with E.G. iperf, so I've moved it.

Bogdan> +++ b/package/iftop/iftop.mk
Bogdan> @@ -0,0 +1,15 @@
Bogdan> +############################################################# Bogdan> +#
Bogdan> +# iftop
Bogdan> +#
Bogdan> +############################################################# Bogdan> +
Bogdan> +IFTOP_VERSION = 1.0pre2
Bogdan> +IFTOP_SITE = http://www.ex-parrot.com/pdw/iftop/download/
Bogdan> +
Bogdan> +IFTOP_DEPENDENCIES = ncurses libpcap
Bogdan> +
Bogdan> +IFTOP_LICENSE = GPL
Bogdan> +IFTOP_LICENSE_FILES = COPYING

License is GPLv2+

Committed with these changes, thanks.

Signature · 1 line
Bye, Peter Korsgaard