Skip to contentSkip to conversation

Don't show error if Acer WMI is not found

PATCH In review William Douglas 2 participants 2 messages Nov 28, 2011 – Nov 29, 2011

Subsystems (2)
x86 platform drivers Acer WMI laptop extras
lore
Share & tools
lore

William Douglas

author
#0 lore raw

PATCH 1/1 Don't show error if Acer WMI is not found

Quoted 2 lines

From 486df5137ae34a4057d604e2b645d7b3848a562f Mon Sep 17 00:00:00 2001

From: William Douglas <[email protected]>
Date: Mon, 28 Nov 2011 11:30:26 -0800
Subject: [PATCH] Don't show error if Acer WMI is not found.

This patch initiated by Pascal seemed to get left out when switching to pr_<level>. I've updated the patch and am resubmitting it as it reduces unnecessary boot noise.

Signed-off-by William Douglas <[email protected]>
---
 drivers/platform/x86/acer-wmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/platform/x86/acer-wmi.c +1 -1
index b848277..607af16 100644
@@ -1946,7 +1946,7 @@ static int __init acer_wmi_init(void)
 		AMW0_find_mailled();
 
 	if (!interface) {
-		pr_err("No or unsupported WMI interface, unable to load\n");
+		pr_info("No or unsupported WMI interface, unable to load\n");
 		return -ENODEV;
 	}
Signature · 4 lines
1.7.7.4

--
William Douglas, Intel Open Source Technology Center
maintainer
#1 lore raw

於 一，2011-11-28 於 12:00 -0800，William Douglas 提到：

Quoted 19 lines
Quoted 1 line

From 486df5137ae34a4057d604e2b645d7b3848a562f Mon Sep 17 00:00:00 2001

From: William Douglas <[email protected]>
Date: Mon, 28 Nov 2011 11:30:26 -0800
Subject: [PATCH] Don't show error if Acer WMI is not found.

This patch initiated by Pascal seemed to get left out when switching to pr_<level>. I've updated the patch and am resubmitting it as it reduces unnecessary boot noise.

Signed-off-by William Douglas <[email protected]>
---
 drivers/platform/x86/acer-wmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/platform/x86/acer-wmi.c +0 -0
index b848277..607af16 100644

drivers/platform/x86/acer-wmi.c static int __init acer_wmi_init(void) · line 1952

Quoted 8 lines
drivers/platform/x86/acer-wmi.c +1 -1
@@ -1946,7 +1946,7 @@ static int __init acer_wmi_init(void)
 		AMW0_find_mailled();
 
 	if (!interface) {
-		pr_err("No or unsupported WMI interface, unable to load\n");
+		pr_info("No or unsupported WMI interface, unable to load\n");
 		return -ENODEV;
 	}
Signed-off-by Lee, Chun-Yi <[email protected]>

It looks good to me!

Thanks for your patch
Joey Lee