trivial build fix: link fsadm against liblvm.a

PATCH New Nix 2 participants 2 messages Sep 12, 2007 – Oct 3, 2007

lore

Share & tools

lore

Nix

author

2007-09-12 12:39 UTC #0 lore raw

PATCH 1/1 trivial build fix: link fsadm against liblvm.a

Currently it's not, which means that since the introduction of last_path_component(), it hasn't built.

Fix is trivial:

Index: lvm/tools/fsadm/Makefile.in
===================================================================
RCS file: /cvs/lvm2/LVM2/tools/fsadm/Makefile.in,v retrieving revision 1.2

tools/fsadm/Makefile.in +3 -1

diff -u -r1.2 Makefile.in
@@ -20,10 +20,12 @@
 
 TARGETS = fsadm
 
+LVMLIBS = -llvm
+
 include $(top_srcdir)/make.tmpl
 
 fsadm: $(OBJECTS)
-	$(CC) -o $@ $(CFLAGS) $(OBJECTS) -rdynamic
+	$(CC) -o $@ $(CFLAGS) $(OBJECTS) $(LDFLAGS) $(LVMLIBS) -rdynamic
 
 install: fsadm
 	$(INSTALL) -D $(OWNER) $(GROUP) -m 555 $(STRIP) fsadm \

Signature · 2 lines

`Some people don't think performance issues are "real bugs", and I think 
such people shouldn't be allowed to program.' --- Linus Torvalds

Jim Meyering

2007-10-03 09:51 UTC #1 lore raw

PATCH 1/1 trivial build fix: link fsadm against liblvm.a

Quoted 8 lines · Nix

Currently it's not, which means that since the introduction of last_path_component(), it hasn't built.
Fix is trivial:
Index: lvm/tools/fsadm/Makefile.in
===================================================================
RCS file: /cvs/lvm2/LVM2/tools/fsadm/Makefile.in,v

Thanks. Applied.