Do not require console control protocol.

PATCH In review Johan Rydberg 2 participants 4 messages Jul 27, 2006 – Jul 29, 2006

lore

Share & tools

lore

Johan Rydberg

author

2006-07-27 22:03 UTC #0 lore raw

PATCH 1/1 Do not require console control protocol.

Hi,

I would like to have the following patch committed. Some EFI implementations do not provide a console control protocol instance, and it is covered by neither EFI or UEFI specifications.

2006-07-28 Johan Rydberg <[email protected]>

* kern/efi/efi.c (grub_efi_set_text_mode): Assume console already is in text mode if there is no console control protocol instance available.

Index: kern/efi/efi.c
===================================================================
RCS file: /sources/grub/grub2/kern/efi/efi.c,v
retrieving revision 1.7

efi/efi.c +3 -1

diff -u -r1.7 efi.c
@@ -125,7 +125,9 @@
 
   c = grub_efi_locate_protocol (&console_control_guid, 0);
   if (! c)
-    return 0;
+    /* No console control protocol instance available, assume it is
+       already in text mode. */
+    return 1;
   
   if (c->get_mode (c, &mode, 0, 0) != GRUB_EFI_SUCCESS)
     return 0;

Yoshinori K. Okuji

2006-07-27 22:22 UTC #1 lore raw

Quoted 3 lines · Johan Rydberg

I would like to have the following patch committed. Some EFI implementations do not provide a console control protocol instance, and it is covered by neither EFI or UEFI specifications.

Right, right. My code was only for testing, so it was not good, generally speaking. BTW, can I add you into the project members of GRUB so that you can commit patches yourself?

Thanks,
Okuji

Johan Rydberg

author

2006-07-28 10:08 UTC #2 lore raw

Quoted 7 lines · Yoshinori K. Okuji

Quoted 3 lines
I would like to have the following patch committed. Some EFI implementations do not provide a console control protocol instance, and it is covered by neither EFI or UEFI specifications.
Right, right. My code was only for testing, so it was not good, generally speaking. BTW, can I add you into the project members of GRUB so that you can commit patches yourself?

Yes, please do.

Yoshinori K. Okuji

2006-07-29 11:22 UTC #3 lore raw

Quoted 10 lines · Johan Rydberg

Quoted 7 lines · Yoshinori K. Okuji
Quoted 3 lines
I would like to have the following patch committed. Some EFI implementations do not provide a console control protocol instance, and it is covered by neither EFI or UEFI specifications.
Right, right. My code was only for testing, so it was not good, generally speaking. BTW, can I add you into the project members of GRUB so that you can commit patches yourself?
Yes, please do.

Done. Can you check in your patch, please?

Okuji