Skip to contentSkip to conversation

drm: dp: fix a possible memory leak in fetch_monitor_name()

PATCH In review Hangyu Hua 2 participants 2 messages May 16, 2022 – May 17, 2022

Subsystems (2)
lore
Share & tools
lore

Hangyu Hua

author
#0 lore raw

PATCH 1/1 drm: dp: fix a possible memory leak in fetch_monitor_name()

drm_dp_mst_get_edid call kmemdup to create mst_edid. So mst_edid need to be freed after use.

---
 drivers/gpu/drm/dp/drm_dp_mst_topology.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/dp/drm_dp_mst_topology.c +1 -0
index 11300b53d24f..7a7cc44686f9 100644
@@ -4852,6 +4852,7 @@ static void fetch_monitor_name(struct drm_dp_mst_topology_mgr *mgr,
 
 	mst_edid = drm_dp_mst_get_edid(port->connector, mgr, port);
 	drm_edid_get_monitor_name(mst_edid, name, namelen);
+	kfree(mst_edid);
 }
 
 /**
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw

Will push to the appropriate branch in a bit

Quoted 22 lines · Hangyu Hua

drm_dp_mst_get_edid call kmemdup to create mst_edid. So mst_edid need to be freed after use.

---
 drivers/gpu/drm/dp/drm_dp_mst_topology.c | 1 +

 1 file changed, 1 insertion(+)
drivers/gpu/drm/dp/drm_dp_mst_topology.c +0 -0
index 11300b53d24f..7a7cc44686f9 100644
@@ -4852,6 +4852,7 @@ static void fetch_monitor_name(struct
 drm_dp_mst_topology_mgr *mgr,


        mst_edid = drm_dp_mst_get_edid(port->connector, mgr, port); drm_edid_get_monitor_name(mst_edid, name, namelen); +       kfree(mst_edid);
 }

 /**

Signature · 3 lines
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat