Skip to contentSkip to conversation

package/pipewire: fix webrtc-audio-processing condition

PATCH In review Thomas Petazzoni via buildroot 2 participants 3 messages Jan 10, 2024 – Jan 14, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/pipewire: fix webrtc-audio-processing condition

The condition checking whether the webrtc-audio-processing package is enabled, added in commit 3ccd3b4c384e98703841b12f7309362957f8f17d ("package/pipewire: bump to version 0.3.32") is obviously incorrect, and can never be true.

Fix the condition to use the correct variable instead.

---
 package/pipewire/pipewire.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pipewire/pipewire.mk +1 -1
index 628c69ff8a..f0f3cd847c 100644
@@ -225,7 +225,7 @@ else
 PIPEWIRE_CONF_OPTS += -Dcompress-offload=disabled
 endif
 
-ifeq ($(WEBRTC_AUDIO_PROCESSING),y)
+ifeq ($(BR2_PACKAGE_WEBRTC_AUDIO_PROCESSING),y)
 PIPEWIRE_CONF_OPTS += -Decho-cancel-webrtc=enabled
 PIPEWIRE_DEPENDENCIES += webrtc-audio-processing
 else
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni via buildroot <[email protected]> writes:

The condition checking whether the webrtc-audio-processing package is enabled, added in commit 3ccd3b4c384e98703841b12f7309362957f8f17d ("package/pipewire: bump to version 0.3.32") is obviously incorrect, and can never be true.

Fix the condition to use the correct variable instead.

Committed, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Thomas Petazzoni via buildroot
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni via buildroot <[email protected]> writes:

The condition checking whether the webrtc-audio-processing package is enabled, added in commit 3ccd3b4c384e98703841b12f7309362957f8f17d ("package/pipewire: bump to version 0.3.32") is obviously incorrect, and can never be true.

Fix the condition to use the correct variable instead.

Committed to 2023.02.x and 2023.11.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot