gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen
PATCH 1/1 gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen
Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the build for aarch64 target.
Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html
--- .gitlab-ci.d/crossbuilds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
.gitlab-ci.d/crossbuilds.yml +2 -2
@@ -186,7 +186,7 @@ cross-amd64-xen-only: variables: IMAGE: debian-amd64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm cross-arm64-xen-only: extends: .cross_accel_build_job
@@ -195,4 +195,4 @@ cross-arm64-xen-only: variables: IMAGE: debian-arm64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm
Signature · 1 line
2.17.0
Quoted 24 lines · Vikram Garhwal
Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the build for aarch64 target.
Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html
Signed-off-by Vikram Garhwal <[email protected]>--- .gitlab-ci.d/crossbuilds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-).gitlab-ci.d/crossbuilds.yml +1
-1@@ -186,7 +186,7 @@ cross-amd64-xen-only: variables: IMAGE: debian-amd64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm cross-arm64-xen-only: extends: .cross_accel_build_job
.gitlab-ci.d/crossbuilds.yml cross-arm64-xen-only: · line 198
Quoted 5 lines
.gitlab-ci.d/crossbuilds.yml +1
-1@@ -195,4 +195,4 @@ cross-arm64-xen-only: variables: IMAGE: debian-arm64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm
This patch looks wrong. I'm pretty sure we wanted to test the build without TCG here. Building with TCG enabled is already done in other jobs. So instead of removing "--disable-tcg" here the question is rather: Why does it not build with this flag anymore? Can those problems be fixed instead?
Thomas
Quoted 23 lines · Thomas Huth
Quoted 22 lines · Vikram Garhwal
Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the build for aarch64 target.
Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html
Signed-off-by Vikram Garhwal <[email protected]>---
.gitlab-ci.d/crossbuilds.yml| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-).gitlab-ci.d/crossbuilds.yml +0
-0@@ -186,7 +186,7 @@ cross-amd64-xen-only:variables:
IMAGE: debian-amd64-cross
ACCEL: xen
-EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm +EXTRA_CONFIGURE_OPTS: --disable-kvm cross-arm64-xen-only:
extends: .cross_accel_build_job
Quoted 8 lines
Quoted 6 lines
.gitlab-ci.d/crossbuilds.yml +0
-0@@ -195,4 +195,4 @@ cross-arm64-xen-only:variables:
IMAGE: debian-arm64-cross
ACCEL: xen
-EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm +EXTRA_CONFIGURE_OPTS: --disable-kvmThis patch looks wrong. I'm pretty sure we wanted to test the build without TCG here. Building with TCG enabled is already done in other jobs. So instead of removing "--disable-tcg" here the question is rather: Why does it not build with this flag anymore? Can those problems be fixed instead?
I concur, this used to work. Did this config bit-rotted? The latest /master job succeeded:
https://gitlab.com/qemu-project/qemu/-/jobs/4094506462
Quoted 15 lines · Vikram Garhwal
Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the build for aarch64 target.
Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html
Signed-off-by Vikram Garhwal <[email protected]>--- .gitlab-ci.d/crossbuilds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-).gitlab-ci.d/crossbuilds.yml +0
-0
.gitlab-ci.d/crossbuilds.yml cross-amd64-xen-only: · line 189
Quoted 5 lines
.gitlab-ci.d/crossbuilds.yml +1
-1@@ -186,7 +186,7 @@ cross-amd64-xen-only: variables: IMAGE: debian-amd64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm
x86 should handle --disable-tcg fine.
.gitlab-ci.d/crossbuilds.yml cross-arm64-xen-only: · line 198
Quoted 9 lines
.gitlab-ci.d/crossbuilds.yml +1
-1cross-arm64-xen-only: extends: .cross_accel_build_job@@ -195,4 +195,4 @@ cross-arm64-xen-only: variables: IMAGE: debian-arm64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm
Currently this builds qemu-system-i386, but with your changes and the work Fabiano is doing:
Message-Id: <[email protected]>
Date: Mon, 13 Mar 2023 12:10:48 -0300
Subject: [PATCH v9 00/10] target/arm: Allow CONFIG_TCG=n builds
From: Fabiano Rosas <[email protected]>
We should be able to have a qemu-system-aarch64 supporting Xen without TCG
Signature · 2 lines
Alex Bennée Virtualisation Tech Lead @ Linaro
Quoted 38 lines · Alex Bennée
Quoted 15 lines · Vikram Garhwal
Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the build for aarch64 target.
Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html
Signed-off-by Vikram Garhwal <[email protected]>--- .gitlab-ci.d/crossbuilds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-).gitlab-ci.d/crossbuilds.yml +0
-0.gitlab-ci.d/crossbuilds.yml cross-amd64-xen-only: · line 189
Quoted 5 lines
.gitlab-ci.d/crossbuilds.yml +1
-1@@ -186,7 +186,7 @@ cross-amd64-xen-only: variables: IMAGE: debian-amd64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvmx86 should handle --disable-tcg fine.
.gitlab-ci.d/crossbuilds.yml cross-arm64-xen-only: · line 198
Quoted 9 lines
.gitlab-ci.d/crossbuilds.yml +1
-1cross-arm64-xen-only: extends: .cross_accel_build_job@@ -195,4 +195,4 @@ cross-arm64-xen-only: variables: IMAGE: debian-arm64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvmCurrently this builds qemu-system-i386, but with your changes and the work Fabiano is doing:
Quoted 6 lines
Message-Id: <[email protected]>
Date: Mon, 13 Mar 2023 12:10:48 -0300
Subject: [PATCH v9 00/10] target/arm: AllowCONFIG_TCG=nbuilds
From: Fabiano Rosas <[email protected]>We should be able to have a qemu-system-aarch64 supporting Xen without TCG
The build should already be working on current master after Philippe fixed the gdbstub issues. My remaining patches fix tests and general runtime issues. I just sent v10 to the list.
Hi all,
Yes, gdbstub build issue is only for for aarch64-softmmu target and that was the reason for this patch. x86 targets build fine with ''disable-tcg" option.
Thanks Fabiano & Philippe for sharing the existing patch series for this.
Regards,
Vikram
Quoted 47 lines · Fabiano Rosas
Quoted 36 lines · Alex Bennée
Quoted 15 lines · Vikram Garhwal
Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the build for aarch64 target.
Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html
Signed-off-by Vikram Garhwal <[email protected]>--- .gitlab-ci.d/crossbuilds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-).gitlab-ci.d/crossbuilds.yml +0
-0.gitlab-ci.d/crossbuilds.yml cross-amd64-xen-only: · line 189
Quoted 5 lines
.gitlab-ci.d/crossbuilds.yml +1
-1@@ -186,7 +186,7 @@ cross-amd64-xen-only: variables: IMAGE: debian-amd64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvmx86 should handle --disable-tcg fine.
.gitlab-ci.d/crossbuilds.yml cross-arm64-xen-only: · line 198
Quoted 9 lines
.gitlab-ci.d/crossbuilds.yml +1
-1cross-arm64-xen-only: extends: .cross_accel_build_job@@ -195,4 +195,4 @@ cross-arm64-xen-only: variables: IMAGE: debian-arm64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvmCurrently this builds qemu-system-i386, but with your changes and the work Fabiano is doing:
Quoted 6 lines
Message-Id: <[email protected]>
Date: Mon, 13 Mar 2023 12:10:48 -0300
Subject: [PATCH v9 00/10] target/arm: AllowCONFIG_TCG=nbuilds
From: Fabiano Rosas <[email protected]>We should be able to have a qemu-system-aarch64 supporting Xen without TCG
The build should already be working on current master after Philippe fixed the gdbstub issues. My remaining patches fix tests and general runtime issues. I just sent v10 to the list.