Skip to contentSkip to conversation

usb: dwc3: core: Add shutdown callback for dwc3

PATCH Applied Sandeep Maheswaram 4 participants 4 messages Apr 14, 2021 – May 26, 2021

Subsystems (3)
USB Arm Qualcomm mailing list DesignWare USB3 DRD IP driver
lore
Share & tools
lore

Sandeep Maheswaram

author
#0 lore raw

PATCH v2 1/1 usb: dwc3: core: Add shutdown callback for dwc3

This patch adds a shutdown callback to USB DWC core driver to ensure that it is properly shutdown in reboot/shutdown path. This is required where SMMU address translation is enabled like on SC7180
SoC and few others. If the hardware is still accessing memory after SMMU translation is disabled as part of SMMU shutdown callback in system reboot or shutdown path, then IOVAs(I/O virtual address) which it was using will go on the bus as the physical addresses which might result in unknown crashes (NoC/interconnect errors).

Signed-off-by Sandeep Maheswaram <[email protected]>

---
Changes in v2:
- As per Stephen's comment, calling dwc3_remove in dwc3_shutdown.

 drivers/usb/dwc3/core.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/usb/dwc3/core.c +6 -0
index 05e2e54c..2022d90 100644
@@ -1658,6 +1658,11 @@ static int dwc3_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static void dwc3_shutdown(struct platform_device *pdev)
+{
+	dwc3_remove(pdev);
+}
+
 #ifdef CONFIG_PM
 static int dwc3_core_init_for_resume(struct dwc3 *dwc)
 {

@@ -1975,6 +1980,7 @@ MODULE_DEVICE_TABLE(acpi, dwc3_acpi_match);
 static struct platform_driver dwc3_driver = {
 	.probe		= dwc3_probe,
 	.remove		= dwc3_remove,
+	.shutdown   = dwc3_shutdown,
 	.driver		= {
 		.name	= "dwc3",
 		.of_match_table	= of_match_ptr(of_dwc3_match),
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Acked-by on v2 1/1
#1 lore raw
Quoted 10 lines · Sandeep Maheswaram

This patch adds a shutdown callback to USB DWC core driver to ensure that it is properly shutdown in reboot/shutdown path. This is required where SMMU address translation is enabled like on SC7180
SoC and few others. If the hardware is still accessing memory after SMMU translation is disabled as part of SMMU shutdown callback in system reboot or shutdown path, then IOVAs(I/O virtual address) which it was using will go on the bus as the physical addresses which might result in unknown crashes (NoC/interconnect errors).

Signed-off-by Sandeep Maheswaram <[email protected]>
Acked-by Felipe Balbi <[email protected]>
Signature · 1 line
balbi
Reviewed-by on v2 1/1
#2 lore raw
In reply to Sandeep Maheswaram

Quoting Sandeep Maheswaram (2021-04-13 23:03:29)

Quoted 11 lines

This patch adds a shutdown callback to USB DWC core driver to ensure that it is properly shutdown in reboot/shutdown path. This is required where SMMU address translation is enabled like on SC7180
SoC and few others. If the hardware is still accessing memory after SMMU translation is disabled as part of SMMU shutdown callback in system reboot or shutdown path, then IOVAs(I/O virtual address) which it was using will go on the bus as the physical addresses which might result in unknown crashes (NoC/interconnect errors).

Signed-off-by Sandeep Maheswaram <[email protected]>

---

Reviewed-by Stephen Boyd <[email protected]>
CI Applied
#3 lore raw
In reply to Sandeep Maheswaram
This patch was applied to qcom/linux.git (refs/heads/for-next):

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

Quoted 10 lines · On Wed, 14 Apr 2021 11:33:29 +0530 you wrote:

This patch adds a shutdown callback to USB DWC core driver to ensure that it is properly shutdown in reboot/shutdown path. This is required where SMMU address translation is enabled like on SC7180
SoC and few others. If the hardware is still accessing memory after SMMU translation is disabled as part of SMMU shutdown callback in system reboot or shutdown path, then IOVAs(I/O virtual address) which it was using will go on the bus as the physical addresses which might result in unknown crashes (NoC/interconnect errors).

[...]

Here is the summary with links:
- [v2] usb: dwc3: core: Add shutdown callback for dwc3

    https://git.kernel.org/qcom/c/568262bf5492

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html