package/gqview: fix build with gcc 10
PATCH 1/1 package/gqview: fix build with gcc 10
Fixes:
- http://autobuild.buildroot.org/results/ab19e23cae603b2aa6e696e4937d106883e78b76
--- .../gqview/0002-fix-build-with-gcc-10.patch | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 package/gqview/0002-fix-build-with-gcc-10.patch
package/gqview/0002-fix-build-with-gcc-10.patch new file +27 -0
@@ -0,0 +1,27 @@ +fix build with gcc 10 + +Define bar_exif_key_count and bar_exif_key_list as extern to avoid the +following build failure with gcc 10 (which defaults to -fno-common): + +/home/buildroot/autobuild/instance-2/output-1/host/lib/gcc/arm-buildroot-linux-gnueabihf/10.2.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: info.o:(.rodata+0x0): multiple definition of `bar_exif_key_count'; bar_exif.o:(.rodata+0x0): first defined here +/home/buildroot/autobuild/instance-2/output-1/host/lib/gcc/arm-buildroot-linux-gnueabihf/10.2.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: info.o:(.bss+0x0): multiple definition of `bar_exif_key_list'; bar_exif.o:(.data+0x0): first defined here + +Fixes: + - http://autobuild.buildroot.org/results/ab19e23cae603b2aa6e696e4937d106883e78b76 + +Signed-off-by: Fabrice Fontaine <[email protected]> + +diff -Naur gqview-2.1.5.orig/src/bar_exif.h gqview-2.1.5/src/bar_exif.h +--- gqview-2.1.5.orig/src/bar_exif.h 2020-09-09 20:32:50.506755031 +0200 ++++ gqview-2.1.5/src/bar_exif.h 2020-09-09 20:33:30.370755818 +0200 +@@ -24,8 +24,8 @@ + + /* these are exposed for when duplication of the exif bar's text is needed */ + +-const gchar **bar_exif_key_list; +-const gint bar_exif_key_count; ++extern const gchar **bar_exif_key_list; ++extern const gint bar_exif_key_count; + + gchar *bar_exif_validate_text(gchar *text); +
Signature · 1 line
2.28.0
PATCH 1/1 package/gqview: fix build with gcc 10
Quoted 8 lines · On Wed, 9 Sep 2020 21:32:52 +0200 Fabrice Fontaine…
Fixes:
- http://autobuild.buildroot.org/results/ab19e23cae603b2aa6e696e4937d106883e78b76Signed-off-by Fabrice Fontaine <[email protected]>--- .../gqview/0002-fix-build-with-gcc-10.patch | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 package/gqview/0002-fix-build-with-gcc-10.patch
Applied to master, thanks. I have applied, but to be honest, I believe we should drop gqview. It has been unmaintained since 2006. There is a fork called geeqie. Perhaps it makes sense to package it... or not. I'm not sure this kind of desktop-level applications are really that useful in the context of Buildroot.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/gqview: fix build with gcc 10
In reply to Fabrice FontaineQuoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
Fixes:
- http://autobuild.buildroot.org/results/ab19e23cae603b2aa6e696e4937d106883e78b76Signed-off-by Fabrice Fontaine <[email protected]>
Committed to 2020.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard