Skip to contentSkip to conversation

package/mraa: fix architecture

PATCH New Fabrice Fontaine 2 participants 2 messages Jul 24, 2020 – Jul 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mraa: fix architecture

mraa supports aarch64 since version 0.9.0 and
https://github.com/eclipse/mraa/commit/47ec54c3330de176ed0b8e3254e81d9451fb866a

mips is supported since version 1.9.0 and
https://github.com/eclipse/mraa/commit/6770be911ba18b25ff284eeac80390e4111f602f

Moreover, BUILD_ARCH must be passed otherwise build will fail on i686 and arm

Fixes:
- http://autobuild.buildroot.org/results/8e99eb282668f6f83f43c5be45112d82936e3408
- http://autobuild.buildroot.org/results/75ba0840da6eb4907847ef05adeec2df109c9937

---
 package/mraa/Config.in | 10 +++++++++-
 package/mraa/mraa.mk   | 13 +++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)
package/mraa/Config.in +9 -1
index 1181965b86..745b235cb3 100644
@@ -1,9 +1,16 @@
+config BR2_PACKAGE_MRAA_ARCH_SUPPORTS
+	bool
+	default y if BR2_aarch64 || BR2_aarch64_be
+	default y if BR2_arm || BR2_armeb
+	default y if BR2_i386 || BR2_x86_64
+	default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
+
 config BR2_PACKAGE_MRAA
 	bool "mraa"
+	depends on BR2_PACKAGE_MRAA_ARCH_SUPPORTS
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on BR2_arm || BR2_i386 || BR2_x86_64
 	help
 	  mraa is a C/C++ library with bindings to javascript & python
 	  to interface with the IO on Galileo, Edison & other
@@ -13,5 +20,6 @@ config BR2_PACKAGE_MRAA
 	  http://iotdk.intel.com/docs/master/mraa
 
 comment "mraa needs a toolchain w/ C++, threads, dynamic library"
+	depends on BR2_PACKAGE_MRAA_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \
 		|| BR2_STATIC_LIBS
package/mraa/mraa.mk +13 -0
index 23413de08e..9397f12cfd 100644
@@ -10,10 +10,23 @@ MRAA_LICENSE = MIT
 MRAA_LICENSE_FILES = COPYING
 MRAA_INSTALL_STAGING = YES
 
+ifeq ($(BR2_i386),y)
+MRAA_ARCH = i386
+else ifeq ($(BR2_x86_64),y)
+MRAA_ARCH = x86_64
+else ifeq ($(BR2_arm)$(BR2_armeb),y)
+MRAA_ARCH = arm
+else ifeq ($(BR2_aarch64)$(BR2_aarch64_be),y)
+MRAA_ARCH = aarch64
+else ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y)
+MRAA_ARCH = mips
+endif
+
 # USBPLAT only makes sense with FTDI4222, which requires the ftd2xx library,
 # which doesn't exist in buildroot
 
 MRAA_CONF_OPTS += \
+	-DBUILDARCH=$(MRAA_ARCH) \
 	-DBUILDSWIG=OFF \
 	-DUSBPLAT=OFF \
 	-DFTDI4222=OFF \
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 package/mraa: fix architecture

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

mraa supports aarch64 since version 0.9.0 and
https://github.com/eclipse/mraa/commit/47ec54c3330de176ed0b8e3254e81d9451fb866a

mips is supported since version 1.9.0 and
https://github.com/eclipse/mraa/commit/6770be911ba18b25ff284eeac80390e4111f602f

Quoted 8 lines

Moreover, BUILD_ARCH must be passed otherwise build will fail on i686 and arm

Fixes:
- http://autobuild.buildroot.org/results/8e99eb282668f6f83f43c5be45112d82936e3408
- http://autobuild.buildroot.org/results/75ba0840da6eb4907847ef05adeec2df109c9937

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard