video, drm, etc: constify fbops in struct fb_info
Subsystems (56)
v2 cover video, drm, etc: constify fbops in struct fb_info
This is v2 of https://patchwork.freedesktop.org/series/70119/
I wanted to make our struct fb_ops const because we don't modify it... and this is what I ended up with to fix it and a bunch of others.
I would appreciate acks to merge all this via the drm-misc tree. This is especially important for patches 1-8 to reasonably get the job done. Patches 9-14 are somewhat easier to merge at leisure afterwards, but there really isn't much conflict potential IMO.
Daniel, please double-check me adding your Reviewed-by on the later patches wasn't overzealous.
BR,
Jani.
Jani Nikula (14):
video: fb_defio: preserve user fb_ops
drm/fb-helper: don't preserve fb_ops across deferred IO use
video: smscufx: don't restore fb_mmap after deferred IO cleanup
video: udlfb: don't restore fb_mmap after deferred IO cleanup
video: fbdev: vesafb: modify the static fb_ops directly
video: fbmem: use const pointer for fb_ops
video: omapfb: use const pointer for fb_ops
video: fbdev: make fbops member of struct fb_info a const pointer
drm: constify fb ops across all drivers
video: constify fb ops across all drivers
HID: picoLCD: constify fb ops
media: constify fb ops across all drivers
samples: vfio-mdev: constify fb ops
auxdisplay: constify fb ops
drivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 27 +++---------------- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +-- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- drivers/gpu/drm/radeon/radeon_fb.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +- drivers/gpu/drm/tegra/fb.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +- drivers/hid/hid-picolcd_fb.c | 3 +-- drivers/media/pci/ivtv/ivtvfb.c | 3 +-- drivers/media/platform/vivid/vivid-osd.c | 3 +-- drivers/video/fbdev/68328fb.c | 2 +- drivers/video/fbdev/acornfb.c | 2 +- drivers/video/fbdev/amba-clcd.c | 2 +- drivers/video/fbdev/amifb.c | 2 +- drivers/video/fbdev/arcfb.c | 2 +- drivers/video/fbdev/arkfb.c | 2 +- drivers/video/fbdev/asiliantfb.c | 2 +- drivers/video/fbdev/atmel_lcdfb.c | 2 +- drivers/video/fbdev/aty/aty128fb.c | 2 +- drivers/video/fbdev/aty/atyfb_base.c | 2 +- drivers/video/fbdev/aty/radeon_base.c | 2 +- drivers/video/fbdev/au1100fb.c | 2 +- drivers/video/fbdev/au1200fb.c | 2 +- drivers/video/fbdev/broadsheetfb.c | 2 +- drivers/video/fbdev/bw2.c | 2 +- drivers/video/fbdev/carminefb.c | 2 +- drivers/video/fbdev/cg14.c | 2 +- drivers/video/fbdev/cg3.c | 2 +- drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/chipsfb.c | 2 +- drivers/video/fbdev/cirrusfb.c | 2 +- drivers/video/fbdev/clps711x-fb.c | 2 +- drivers/video/fbdev/cobalt_lcdfb.c | 2 +- drivers/video/fbdev/controlfb.c | 2 +- drivers/video/fbdev/core/fb_defio.c | 3 --- drivers/video/fbdev/core/fbmem.c | 19 ++++++++----- drivers/video/fbdev/cyber2000fb.c | 2 +- drivers/video/fbdev/da8xx-fb.c | 2 +- drivers/video/fbdev/dnfb.c | 2 +- drivers/video/fbdev/efifb.c | 2 +- drivers/video/fbdev/ep93xx-fb.c | 2 +- drivers/video/fbdev/fb-puv3.c | 2 +- drivers/video/fbdev/ffb.c | 2 +- drivers/video/fbdev/fm2fb.c | 2 +- drivers/video/fbdev/fsl-diu-fb.c | 2 +- drivers/video/fbdev/g364fb.c | 2 +- drivers/video/fbdev/gbefb.c | 2 +- drivers/video/fbdev/geode/gx1fb_core.c | 2 +- drivers/video/fbdev/geode/gxfb_core.c | 2 +- drivers/video/fbdev/geode/lxfb_core.c | 2 +- drivers/video/fbdev/goldfishfb.c | 2 +- drivers/video/fbdev/grvga.c | 2 +- drivers/video/fbdev/gxt4500.c | 2 +- drivers/video/fbdev/hecubafb.c | 2 +- drivers/video/fbdev/hgafb.c | 2 +- drivers/video/fbdev/hitfb.c | 2 +- drivers/video/fbdev/hpfb.c | 2 +- drivers/video/fbdev/hyperv_fb.c | 2 +- drivers/video/fbdev/i740fb.c | 2 +- drivers/video/fbdev/imsttfb.c | 2 +- drivers/video/fbdev/imxfb.c | 2 +- drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +- drivers/video/fbdev/kyro/fbdev.c | 2 +- drivers/video/fbdev/leo.c | 2 +- drivers/video/fbdev/macfb.c | 2 +- drivers/video/fbdev/matrox/matroxfb_crtc2.c | 2 +- drivers/video/fbdev/maxinefb.c | 2 +- drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +- drivers/video/fbdev/mbx/mbxfb.c | 2 +- drivers/video/fbdev/metronomefb.c | 2 +- drivers/video/fbdev/mmp/fb/mmpfb.c | 2 +- drivers/video/fbdev/mx3fb.c | 5 ++-- drivers/video/fbdev/neofb.c | 2 +- drivers/video/fbdev/nvidia/nvidia.c | 2 +- drivers/video/fbdev/ocfb.c | 2 +- drivers/video/fbdev/offb.c | 2 +- drivers/video/fbdev/omap/omapfb_main.c | 2 +- .../video/fbdev/omap2/omapfb/omapfb-main.c | 2 +- drivers/video/fbdev/p9100.c | 2 +- drivers/video/fbdev/platinumfb.c | 2 +- drivers/video/fbdev/pm2fb.c | 2 +- drivers/video/fbdev/pm3fb.c | 2 +- drivers/video/fbdev/pmag-aa-fb.c | 2 +- drivers/video/fbdev/pmag-ba-fb.c | 2 +- drivers/video/fbdev/pmagb-b-fb.c | 2 +- drivers/video/fbdev/ps3fb.c | 2 +- drivers/video/fbdev/pvr2fb.c | 2 +- drivers/video/fbdev/pxa168fb.c | 2 +- drivers/video/fbdev/pxafb.c | 4 +-- drivers/video/fbdev/q40fb.c | 2 +- drivers/video/fbdev/riva/fbdev.c | 2 +- drivers/video/fbdev/s3c-fb.c | 2 +- drivers/video/fbdev/s3c2410fb.c | 2 +- drivers/video/fbdev/s3fb.c | 2 +- drivers/video/fbdev/sa1100fb.c | 2 +- drivers/video/fbdev/savage/savagefb_driver.c | 2 +- drivers/video/fbdev/sh7760fb.c | 2 +- drivers/video/fbdev/sh_mobile_lcdcfb.c | 4 +-- drivers/video/fbdev/simplefb.c | 2 +- drivers/video/fbdev/sis/sis_main.c | 2 +- drivers/video/fbdev/skeletonfb.c | 2 +- drivers/video/fbdev/sm712fb.c | 2 +- drivers/video/fbdev/smscufx.c | 3 +-- drivers/video/fbdev/ssd1307fb.c | 2 +- drivers/video/fbdev/sstfb.c | 2 +- drivers/video/fbdev/stifb.c | 2 +- drivers/video/fbdev/sunxvr1000.c | 2 +- drivers/video/fbdev/sunxvr2500.c | 2 +- drivers/video/fbdev/sunxvr500.c | 2 +- drivers/video/fbdev/tcx.c | 2 +- drivers/video/fbdev/tdfxfb.c | 2 +- drivers/video/fbdev/tgafb.c | 2 +- drivers/video/fbdev/tmiofb.c | 2 +- drivers/video/fbdev/tridentfb.c | 2 +- drivers/video/fbdev/udlfb.c | 1 - drivers/video/fbdev/uvesafb.c | 2 +- drivers/video/fbdev/valkyriefb.c | 2 +- drivers/video/fbdev/vesafb.c | 6 ++--- drivers/video/fbdev/vfb.c | 2 +- drivers/video/fbdev/vga16fb.c | 2 +- drivers/video/fbdev/vt8500lcdfb.c | 2 +- drivers/video/fbdev/vt8623fb.c | 2 +- drivers/video/fbdev/w100fb.c | 2 +- drivers/video/fbdev/wm8505fb.c | 2 +- drivers/video/fbdev/xen-fbfront.c | 2 +- drivers/video/fbdev/xilinxfb.c | 2 +- include/linux/fb.h | 2 +- samples/vfio-mdev/mdpy-fb.c | 2 +- 136 files changed, 156 insertions(+), 175 deletions(-)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/14 video: fb_defio: preserve user fb_ops
Modifying fb_ops directly to override fb_mmap with fb_deferred_io_mmap and then resetting it to NULL afterwards causes problems all over the place. First, it prevents making the fbops member of struct fb_info a const pointer, which means we can't make struct fb_ops const anywhere. Second, a few places have to go out of their way to restore the original fb_mmap pointer that gets reset to NULL.
Since the only user of the fbops->fb_mmap hook is fb_mmap() in fbmem.c, call fb_deferred_io_mmap() directly when deferred IO is enabled, and avoid modifying fb_ops altogether.
Simply use info->fbdefio to determine whether deferred IO should be used or not. This should be accurate enough for all use cases, although perhaps not pedantically correct.
v2: Simplify considerably by calling fb_deferred_io_mmap() directly
(Daniel, Ville)
--- drivers/video/fbdev/core/fb_defio.c | 3 --- drivers/video/fbdev/core/fbmem.c | 15 +++++++++++---- 2 files changed, 11 insertions(+), 7 deletions(-)
drivers/video/fbdev/core/fb_defio.c +0 -3
@@ -171,7 +171,6 @@ int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) vma->vm_private_data = info;return 0 ; } -EXPORT_SYMBOL (fb_deferred_io_mmap);/* workqueue callback */ static void fb_deferred_io_work (struct work_struct *work)
@@ -206,7 +205,6 @@ void fb_deferred_io_init(struct fb_info *info)BUG_ON (!fbdefio);mutex_init (&fbdefio->lock); - info->fbops->fb_mmap = fb_deferred_io_mmap;INIT_DELAYED_WORK (&info->deferred_work, fb_deferred_io_work);INIT_LIST_HEAD (&fbdefio->pagelist);if (fbdefio->delay ==0 )/* set a default of 1 s */
@@ -237,7 +235,6 @@ void fb_deferred_io_cleanup(struct fb_info *info) page->mapping =NULL ; } - info->fbops->fb_mmap =NULL ;mutex_destroy (&fbdefio->lock); }EXPORT_SYMBOL_GPL (fb_deferred_io_cleanup);
drivers/video/fbdev/core/fbmem.c +11 -4
@@ -1332,16 +1332,23 @@ static int fb_mmap(struct file *file, struct vm_area_struct * vma) { struct fb_info *info = file_fb_info(file); -struct fb_ops *fb; +int (*fb_mmap_fn)(struct fb_info *info,struct vm_area_struct *vma);unsigned long mmio_pgoff;unsigned long start;u32 len;if (!info)return -ENODEV ; - fb = info->fbops;mutex_lock (&info->mm_lock); -if (fb->fb_mmap) { + + fb_mmap_fn = info->fbops->fb_mmap; + +#if IS_ENABLED (CONFIG_FB_DEFERRED_IO ) +if (info->fbdefio) + fb_mmap_fn = fb_deferred_io_mmap; +#endif + +if (fb_mmap_fn) {int res;/*
@@ -1349,7 +1356,7 @@ fb_mmap(struct file *file, struct vm_area_struct * vma)* SME protection is removed ahead of the call */ vma->vm_page_prot =pgprot_decrypted (vma->vm_page_prot); - res = fb->fb_mmap (info, vma); + res =fb_mmap_fn (info, vma);mutex_unlock (&info->mm_lock);return res; }
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 01/14] video: fb_defio: preserve user fb_ops
Den 29.11.2019 11.29, skrev Jani Nikula:
Quoted 18 lines
Modifying
fb_opsdirectly to overridefb_mmapwithfb_deferred_io_mmapand then resetting it to NULL afterwards causes problems all over the place. First, it prevents making the fbops member of structfb_infoa const pointer, which means we can't make structfb_opsconst anywhere. Second, a few places have to go out of their way to restore the originalfb_mmappointer that gets reset to NULL.Since the only user of the
fbops->fb_mmaphook isfb_mmap()infbmem.c, callfb_deferred_io_mmap()directly when deferred IO is enabled, and avoid modifyingfb_opsaltogether.Simply use
info->fbdefioto determine whether deferred IO should be used or not. This should be accurate enough for all use cases, although perhaps not pedantically correct.v2: Simplify considerably by calling
fb_deferred_io_mmap()directly
(Daniel, Ville)
Quoted 6 lines
Cc Jaya Kumar <[email protected]>Cc Daniel Vetter <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Jani Nikula <[email protected]>---
Nice simple solution:
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 01/14] video: fb_defio: preserve user fb_ops
In reply to Jani NikulaQuoted 61 lines · Jani Nikula
Modifying
fb_opsdirectly to overridefb_mmapwithfb_deferred_io_mmapand then resetting it to NULL afterwards causes problems all over the place. First, it prevents making the fbops member of structfb_infoa const pointer, which means we can't make structfb_opsconst anywhere. Second, a few places have to go out of their way to restore the originalfb_mmappointer that gets reset to NULL.Since the only user of the
fbops->fb_mmaphook isfb_mmap()infbmem.c, callfb_deferred_io_mmap()directly when deferred IO is enabled, and avoid modifyingfb_opsaltogether.Simply use
info->fbdefioto determine whether deferred IO should be used or not. This should be accurate enough for all use cases, although perhaps not pedantically correct.v2: Simplify considerably by calling
fb_deferred_io_mmap()directly
(Daniel, Ville)Cc Jaya Kumar <[email protected]>Cc Daniel Vetter <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/video/fbdev/core/fb_defio.c | 3 --- drivers/video/fbdev/core/fbmem.c | 15 +++++++++++---- 2 files changed, 11 insertions(+), 7 deletions(-)drivers/video/fbdev/core/fb_defio.c +0
-3@@ -171,7 +171,6 @@ int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) vma->vm_private_data = info;return 0 ; } -EXPORT_SYMBOL (fb_deferred_io_mmap);/* workqueue callback */ static void fb_deferred_io_work (struct work_struct *work)@@ -206,7 +205,6 @@ void fb_deferred_io_init(struct fb_info *info)BUG_ON (!fbdefio);mutex_init (&fbdefio->lock); - info->fbops->fb_mmap = fb_deferred_io_mmap;INIT_DELAYED_WORK (&info->deferred_work, fb_deferred_io_work);INIT_LIST_HEAD (&fbdefio->pagelist);if (fbdefio->delay ==0 )/* set a default of 1 s */ @@ -237,7 +235,6 @@ void fb_deferred_io_cleanup(struct fb_info *info) page->mapping =NULL ; } - info->fbops->fb_mmap =NULL ;mutex_destroy (&fbdefio->lock); }EXPORT_SYMBOL_GPL (fb_deferred_io_cleanup);drivers/video/fbdev/core/fbmem.c +0
-0
drivers/video/fbdev/core/fbmem.c static int · line 1335
Quoted 5 lines
drivers/video/fbdev/core/fbmem.c +1
-1@@ -1332,16 +1332,23 @@ static int fb_mmap(struct file *file, struct vm_area_struct * vma) { struct fb_info *info = file_fb_info(file); -struct fb_ops *fb; +int (*fb_mmap_fn)(struct fb_info *info,struct vm_area_struct *vma);
Oh I function pointer for tidier control flow, neato.
Quoted 33 lines
drivers/video/fbdev/core/fbmem.c +10
-3unsigned long mmio_pgoff;unsigned long start;u32 len;if (!info)return -ENODEV ; - fb = info->fbops;mutex_lock (&info->mm_lock); -if (fb->fb_mmap) { + + fb_mmap_fn = info->fbops->fb_mmap; + +#if IS_ENABLED (CONFIG_FB_DEFERRED_IO ) +if (info->fbdefio) + fb_mmap_fn = fb_deferred_io_mmap; +#endif + +if (fb_mmap_fn) {int res;/* @@ -1349,7 +1356,7 @@ fb_mmap(struct file *file, struct vm_area_struct * vma)* SME protection is removed ahead of the call */ vma->vm_page_prot =pgprot_decrypted (vma->vm_page_prot); - res = fb->fb_mmap (info, vma); + res =fb_mmap_fn (info, vma);mutex_unlock (&info->mm_lock);return res; }Signature · 1 line
2.20.1
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 2/14 drm/fb-helper: don't preserve fb_ops across deferred IO use
In reply to Jani NikulaDeferred IO now preserves the fb_ops.
v2: Remove the no-op vfree, drop a local var (Noralf)
--- drivers/gpu/drm/drm_fb_helper.c | 25 +++---------------------- 1 file changed, 3 insertions(+), 22 deletions(-)
drivers/gpu/drm/drm_fb_helper.c +3 -22
@@ -1954,7 +1954,6 @@ static int drm_fbdev_fb_release(struct fb_info *info, int user)static void drm_fbdev_cleanup (struct drm_fb_helper *fb_helper) {struct fb_info *fbi = fb_helper->fbdev; -struct fb_ops *fbops =NULL ;void *shadow =NULL ;if (!fb_helper->dev)
@@ -1963,15 +1962,11 @@ static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper)if (fbi && fbi->fbdefio) {fb_deferred_io_cleanup (fbi); shadow = fbi->screen_buffer; - fbops = fbi->fbops; }drm_fb_helper_fini (fb_helper); -if (shadow) { -vfree (shadow); -kfree (fbops); - } +vfree (shadow);drm_client_framebuffer_delete (fb_helper->buffer); }
@@ -2062,24 +2057,10 @@ static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper,drm_fb_helper_fill_info (fbi, fb_helper, sizes);if (drm_fbdev_use_shadow_fb (fb_helper)) { -struct fb_ops *fbops; -void *shadow; - -/* -* fb_deferred_io_cleanup() clears &fbops->fb_mmap so a per -* instance version is necessary. -*/ - fbops =kzalloc (sizeof (*fbops),GFP_KERNEL ); - shadow =vzalloc (fbi->screen_size); -if (!fbops || !shadow) { -kfree (fbops); -vfree (shadow); + fbi->screen_buffer =vzalloc (fbi->screen_size); +if (!fbi->screen_buffer)return -ENOMEM ; - } - *fbops = *fbi->fbops; - fbi->fbops = fbops; - fbi->screen_buffer = shadow; fbi->fbdefio = &drm_fbdev_defio;fb_deferred_io_init (fbi);
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 02/14] drm/fb-helper: don't preserve fb_ops across deferred IO use
Den 29.11.2019 11.29, skrev Jani Nikula:
Quoted 9 lines
Deferred IO now preserves the
fb_ops.v2: Remove the no-op vfree, drop a local var (Noralf)
Cc Noralf Trønnes <[email protected]>Reviewed-by Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>---
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 3/14 video: smscufx: don't restore fb_mmap after deferred IO cleanup
In reply to Jani NikulaDeferred IO now preserves the fb_ops.
--- drivers/video/fbdev/smscufx.c | 1 - 1 file changed, 1 deletion(-)
drivers/video/fbdev/smscufx.c +0 -1
@@ -1170,7 +1170,6 @@ static int ufx_ops_release(struct fb_info *info, int user)fb_deferred_io_cleanup (info);kfree (info->fbdefio); info->fbdefio =NULL ; - info->fbops->fb_mmap = ufx_ops_mmap; } pr_debug("released /dev/fb%d user=%d count=%d",
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 4/14 video: udlfb: don't restore fb_mmap after deferred IO cleanup
In reply to Jani NikulaDeferred IO now preserves the fb_ops.
--- drivers/video/fbdev/udlfb.c | 1 - 1 file changed, 1 deletion(-)
drivers/video/fbdev/udlfb.c +0 -1
@@ -1037,7 +1037,6 @@ static int dlfb_ops_release(struct fb_info *info, int user)fb_deferred_io_cleanup (info);kfree (info->fbdefio); info->fbdefio =NULL ; - info->fbops->fb_mmap = dlfb_ops_mmap; }dev_dbg (info->dev,"release, user=%d count=%d\n" , user, dlfb->fb_count);
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 5/14 video: fbdev: vesafb: modify the static fb_ops directly
In reply to Jani NikulaAvoid modifying the fb_ops via info->fbops to let us make the pointer const in the future.
--- drivers/video/fbdev/vesafb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/video/fbdev/vesafb.c +3 -3
@@ -447,15 +447,15 @@ static int vesafb_probe(struct platform_device *dev) vesafb_fix.smem_start, info->screen_base, size_remap/1024, size_total/1024); +if (!ypan) + vesafb_ops.fb_pan_display =NULL ; + info->fbops = &vesafb_ops; info->var = vesafb_defined; info->fix = vesafb_fix; info->flags =FBINFO_FLAG_DEFAULT |FBINFO_MISC_FIRMWARE | (ypan ?FBINFO_HWACCEL_YPAN :0 ); -if (!ypan) - info->fbops->fb_pan_display =NULL ; -if (fb_alloc_cmap (&info->cmap,256 ,0 ) <0 ) { err = -ENOMEM ; goto err;
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 6/14 video: fbmem: use const pointer for fb_ops
In reply to Jani NikulaUse const for fb_ops to let us make the info->fbops pointer const in the future.
v2: rebase
--- drivers/video/fbdev/core/fbmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/core/fbmem.c +2 -2
@@ -1079,7 +1079,7 @@ EXPORT_SYMBOL(fb_blank);static long do_fb_ioctl (struct fb_info *info,unsigned int cmd,unsigned long arg) { -struct fb_ops *fb; +const struct fb_ops *fb;struct fb_var_screeninfo var;struct fb_fix_screeninfo fix;struct fb_cmap cmap_from;
@@ -1292,7 +1292,7 @@ static long fb_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) {struct fb_info *info =file_fb_info (file); -struct fb_ops *fb; +const struct fb_ops *fb;long ret = -ENOIOCTLCMD ;if (!info)
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Intel-gfx] [PATCH v2 06/14] video: fbmem: use const pointer for fb_ops
Quoted 7 lines · Jani Nikula
Use const for
fb_opsto let us make theinfo->fbopspointer const in the future.v2: rebase
Signed-off-by Jani Nikula <[email protected]>
I guess my r-b got lost on this, not sure, anyway.
Quoted 33 lines
--- drivers/video/fbdev/core/fbmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/video/fbdev/core/fbmem.c +2
-2@@ -1079,7 +1079,7 @@ EXPORT_SYMBOL(fb_blank);static long do_fb_ioctl (struct fb_info *info,unsigned int cmd,unsigned long arg) { -struct fb_ops *fb; +const struct fb_ops *fb;struct fb_var_screeninfo var;struct fb_fix_screeninfo fix;struct fb_cmap cmap_from;@@ -1292,7 +1292,7 @@ static long fb_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) {struct fb_info *info =file_fb_info (file); -struct fb_ops *fb; +const struct fb_ops *fb;long ret = -ENOIOCTLCMD ;if (!info)Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 7/14 video: omapfb: use const pointer for fb_ops
In reply to Jani NikulaUse const for fb_ops to let us make the info->fbops pointer const in the future.
--- drivers/video/fbdev/omap/omapfb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/omap/omapfb_main.c +1 -1
@@ -1052,7 +1052,7 @@ static int omapfb_ioctl(struct fb_info *fbi, unsigned int cmd, {struct omapfb_plane_struct *plane = fbi->par;struct omapfb_device *fbdev = plane->fbdev; -struct fb_ops *ops = fbi->fbops; +const struct fb_ops *ops = fbi->fbops;union {struct omapfb_update_window update_window;struct omapfb_plane_info plane_info;
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 07/14] video: omapfb: use const pointer for fb_ops
Quoted 7 lines · Jani Nikula
Use const for
fb_opsto let us make theinfo->fbopspointer const in the future.Reviewed-by Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Pushed up to and including this patch to drm-misc-next, thanks for the reviews and acks.
I may have missed some pointer chasing uses of info->fbops, reported by 0day. I'll need to double check those before proceeding with the next patch.
BR,
Jani.
Quoted 17 lines
--- drivers/video/fbdev/omap/omapfb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/video/fbdev/omap/omapfb_main.c +1
-1@@ -1052,7 +1052,7 @@ static int omapfb_ioctl(struct fb_info *fbi, unsigned int cmd, {struct omapfb_plane_struct *plane = fbi->par;struct omapfb_device *fbdev = plane->fbdev; -struct fb_ops *ops = fbi->fbops; +const struct fb_ops *ops = fbi->fbops;union {struct omapfb_update_window update_window;struct omapfb_plane_info plane_info;
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
PATCH v2 8/14 video: fbdev: make fbops member of struct fb_info a const pointer
In reply to Jani NikulaNow that we no longer modify the fbops, or hold non-const pointers to it, we can make it const. After this, we can start making the fbops const all over the place.
--- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/fb.h +1 -1
@@ -472,7 +472,7 @@ struct fb_info {struct fb_deferred_io *fbdefio;#endif -struct fb_ops *fbops; +const struct fb_ops *fbops;struct device *device;/* This is the parent */ struct device *dev;/* This is this fb device */ int class_flag;/* private sysfs flags */
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botRe: [PATCH v2 08/14] video: fbdev: make fbops member of struct fb_info a const pointer
I love your patch! Yet something to improve:
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.4 next-20191129]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Jani-Nikula/video-drm-etc-constify-fbops-in-struct-fb_info/20191129-193852 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
All errors (new ones prefixed by >>):
drivers/video/fbdev/uvesafb.c: In function 'uvesafb_init_info':
>> drivers/video/fbdev/uvesafb.c:1443:25: error: assignment of member 'fb_blank' in read-only object
info->fbops->fb_blank = NULL;
^
drivers/video/fbdev/uvesafb.c:1513:31: error: assignment of member 'fb_pan_display' in read-only object
info->fbops->fb_pan_display = NULL;
^
--
drivers/video/fbdev/aty/atyfb_base.c: In function 'atyfb_set_par':
>> drivers/video/fbdev/aty/atyfb_base.c:1319:24: error: assignment of member 'fb_sync' in read-only object
info->fbops->fb_sync = atyfb_sync;
^
drivers/video/fbdev/aty/atyfb_base.c:1322:24: error: assignment of member 'fb_sync' in read-only object
info->fbops->fb_sync = NULL;
^
--
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c: In function 'mb862xxfb_init_accel':
>> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:311:28: error: assignment of member 'fb_fillrect' in read-only object
info->fbops->fb_fillrect = cfb_fillrect;
^
>> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:312:28: error: assignment of member 'fb_copyarea' in read-only object
info->fbops->fb_copyarea = cfb_copyarea;
^
>> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:313:29: error: assignment of member 'fb_imageblit' in read-only object
info->fbops->fb_imageblit = cfb_imageblit;
^
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:316:28: error: assignment of member 'fb_fillrect' in read-only object
info->fbops->fb_fillrect = mb86290fb_fillrect;
^
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:317:28: error: assignment of member 'fb_copyarea' in read-only object
info->fbops->fb_copyarea = mb86290fb_copyarea;
^
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:318:29: error: assignment of member 'fb_imageblit' in read-only object
info->fbops->fb_imageblit = mb86290fb_imageblit;
^
--
drivers/video/fbdev/nvidia/nvidia.c: In function 'nvidiafb_set_par':
>> drivers/video/fbdev/nvidia/nvidia.c:663:29: error: assignment of member 'fb_imageblit' in read-only object
info->fbops->fb_imageblit = nvidiafb_imageblit;
^
>> drivers/video/fbdev/nvidia/nvidia.c:664:28: error: assignment of member 'fb_fillrect' in read-only object
info->fbops->fb_fillrect = nvidiafb_fillrect;
^
drivers/video/fbdev/nvidia/nvidia.c:665:28: error: assignment of member 'fb_copyarea' in read-only object
info->fbops->fb_copyarea = nvidiafb_copyarea;
^
drivers/video/fbdev/nvidia/nvidia.c:666:24: error: assignment of member 'fb_sync' in read-only object
info->fbops->fb_sync = nvidiafb_sync;
^
drivers/video/fbdev/nvidia/nvidia.c:672:29: error: assignment of member 'fb_imageblit' in read-only object
info->fbops->fb_imageblit = cfb_imageblit;
^
drivers/video/fbdev/nvidia/nvidia.c:673:28: error: assignment of member 'fb_fillrect' in read-only object
info->fbops->fb_fillrect = cfb_fillrect;
^
drivers/video/fbdev/nvidia/nvidia.c:674:28: error: assignment of member 'fb_copyarea' in read-only object
info->fbops->fb_copyarea = cfb_copyarea;
^
drivers/video/fbdev/nvidia/nvidia.c:675:24: error: assignment of member 'fb_sync' in read-only object
info->fbops->fb_sync = NULL;
^
drivers/video/fbdev/nvidia/nvidia.c: In function 'nvidia_set_fbinfo':
drivers/video/fbdev/nvidia/nvidia.c:1168:29: error: assignment of member 'fb_cursor' in read-only object
info->fbops->fb_cursor = NULL;
^vim +/fb_blank +1443 drivers/video/fbdev/uvesafb.c
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1427
48c68c4f1b5424 drivers/video/uvesafb.c Greg Kroah-Hartman 2012-12-21 1428 static void uvesafb_init_info(struct fb_info *info, struct vbe_mode_ib *mode)
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1429 {
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1430 unsigned int size_vmode;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1431 unsigned int size_remap;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1432 unsigned int size_total;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1433 struct uvesafb_par *par = info->par;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1434 int i, h;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1435
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1436 info->pseudo_palette = ((u8 *)info->par + sizeof(struct uvesafb_par));
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1437 info->fix = uvesafb_fix;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1438 info->fix.ypanstep = par->ypan ? 1 : 0;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1439 info->fix.ywrapstep = (par->ypan > 1) ? 1 : 0;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1440
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1441 /* Disable blanking if the user requested so. */
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1442 if (!blank)
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 @1443 info->fbops->fb_blank = NULL;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1444
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1445 /*
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1446 * Find out how much IO memory is required for the mode with
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1447 * the highest resolution.
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1448 */
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1449 size_remap = 0;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1450 for (i = 0; i < par->vbe_modes_cnt; i++) {
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1451 h = par->vbe_modes[i].bytes_per_scan_line *
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1452 par->vbe_modes[i].y_res;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1453 if (h > size_remap)
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1454 size_remap = h;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1455 }
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1456 size_remap *= 2;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1457
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1458 /*
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1459 * size_vmode -- that is the amount of memory needed for the
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1460 * used video mode, i.e. the minimum amount of
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1461 * memory we need.
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1462 */
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1463 size_vmode = info->var.yres * mode->bytes_per_scan_line;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1464
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1465 /*
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1466 * size_total -- all video memory we have. Used for mtrr
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1467 * entries, resource allocation and bounds
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1468 * checking.
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1469 */
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1470 size_total = par->vbe_ib.total_memory * 65536;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1471 if (vram_total)
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1472 size_total = vram_total * 1024 * 1024;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1473 if (size_total < size_vmode)
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1474 size_total = size_vmode;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1475
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1476 /*
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1477 * size_remap -- the amount of video memory we are going to
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1478 * use for vesafb. With modern cards it is no
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1479 * option to simply use size_total as th
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1480 * wastes plenty of kernel address space.
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1481 */
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1482 if (vram_remap)
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1483 size_remap = vram_remap * 1024 * 1024;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1484 if (size_remap < size_vmode)
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1485 size_remap = size_vmode;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1486 if (size_remap > size_total)
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1487 size_remap = size_total;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1488
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1489 info->fix.smem_len = size_remap;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1490 info->fix.smem_start = mode->phys_base_ptr;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1491
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1492 /*
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1493 * We have to set yres_virtual here because when setup_var() was
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1494 * called, smem_len wasn't defined yet.
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1495 */
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1496 info->var.yres_virtual = info->fix.smem_len /
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1497 mode->bytes_per_scan_line;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1498
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1499 if (par->ypan && info->var.yres_virtual > info->var.yres) {
a8feae09110675 drivers/video/fbdev/uvesafb.c Joe Perches 2017-06-14 1500 pr_info("scrolling: %s using protected mode interface, yres_virtual=%d\n",
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1501 (par->ypan > 1) ? "ywrap" : "ypan",
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1502 info->var.yres_virtual);
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1503 } else {
a8feae09110675 drivers/video/fbdev/uvesafb.c Joe Perches 2017-06-14 1504 pr_info("scrolling: redraw\n");
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1505 info->var.yres_virtual = info->var.yres;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1506 par->ypan = 0;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1507 }
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1508
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1509 info->flags = FBINFO_FLAG_DEFAULT |
1cc9fb6dbf915e drivers/video/uvesafb.c Roel Kluin 2009-03-31 1510 (par->ypan ? FBINFO_HWACCEL_YPAN : 0);
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1511
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1512 if (!par->ypan)
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1513 info->fbops->fb_pan_display = NULL;
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1514 }
8bdb3a2d7df48b drivers/video/uvesafb.c Michal Januszewski 2007-10-16 1515 :::::: The code at line 1443 was first introduced by commit :::::: 8bdb3a2d7df48b861972c4bfb58490853a228f51 uvesafb: the driver core
:::::: TO: Michal Januszewski <[email protected]> :::::: CC: Linus Torvalds <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/[email protected] Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 9/14 drm: constify fb ops across all drivers
In reply to Jani NikulaNow that the fbops member of struct fb_info is const, we can start making the ops const as well.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 ++-- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- drivers/gpu/drm/radeon/radeon_fb.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +- drivers/gpu/drm/tegra/fb.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +- 13 files changed, 14 insertions(+), 14 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c +1 -1
@@ -69,7 +69,7 @@ amdgpufb_release(struct fb_info *info, int user)return 0 ; } -static struct fb_ops amdgpufb_ops = { +static const struct fb_ops amdgpufb_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_open = amdgpufb_open,
drivers/gpu/drm/armada/armada_fbdev.c +1 -1
@@ -16,7 +16,7 @@#include "armada_fb.h" #include "armada_gem.h" -static /*const*/ struct fb_ops armada_fb_ops = { +static const struct fb_ops armada_fb_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_fillrect = drm_fb_helper_cfb_fillrect,
drivers/gpu/drm/drm_fb_helper.c +1 -1
@@ -1997,7 +1997,7 @@ static int drm_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)return -ENODEV ; } -static struct fb_ops drm_fbdev_fb_ops = { +static const struct fb_ops drm_fbdev_fb_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_open = drm_fbdev_fb_open,
drivers/gpu/drm/exynos/exynos_drm_fbdev.c +1 -1
@@ -60,7 +60,7 @@ static int exynos_drm_fb_mmap(struct fb_info *info,return 0 ; } -static struct fb_ops exynos_drm_fb_ops = { +static const struct fb_ops exynos_drm_fb_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_mmap = exynos_drm_fb_mmap,
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c +1 -1
@@ -38,7 +38,7 @@ static int hibmcfb_create_object(return ret; } -static struct fb_ops hibmc_drm_fb_ops = { +static const struct fb_ops hibmc_drm_fb_ops = { .owner =THIS_MODULE , .fb_check_var = drm_fb_helper_check_var, .fb_set_par = drm_fb_helper_set_par,
drivers/gpu/drm/i915/display/intel_fbdev.c +1 -1
@@ -100,7 +100,7 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var,return ret; } -static struct fb_ops intelfb_ops = { +static const struct fb_ops intelfb_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_set_par = intel_fbdev_set_par,
drivers/gpu/drm/msm/msm_fbdev.c +1 -1
@@ -26,7 +26,7 @@ struct msm_fbdev {struct drm_framebuffer *fb; }; -static struct fb_ops msm_fb_ops = { +static const struct fb_ops msm_fb_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS ,
drivers/gpu/drm/nouveau/nouveau_fbcon.c +2 -2
@@ -203,7 +203,7 @@ nouveau_fbcon_release(struct fb_info *info, int user)return 0 ; } -static struct fb_ops nouveau_fbcon_ops = { +static const struct fb_ops nouveau_fbcon_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_open = nouveau_fbcon_open,
@@ -214,7 +214,7 @@ static struct fb_ops nouveau_fbcon_ops = { .fb_sync = nouveau_fbcon_sync, }; -static struct fb_ops nouveau_fbcon_sw_ops = { +static const struct fb_ops nouveau_fbcon_sw_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_open = nouveau_fbcon_open,
drivers/gpu/drm/omapdrm/omap_fbdev.c +1 -1
@@ -70,7 +70,7 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var,return drm_fb_helper_pan_display (var, fbi); } -static struct fb_ops omap_fb_ops = { +static const struct fb_ops omap_fb_ops = { .owner =THIS_MODULE , .fb_check_var = drm_fb_helper_check_var,
drivers/gpu/drm/radeon/radeon_fb.c +1 -1
@@ -73,7 +73,7 @@ radeonfb_release(struct fb_info *info, int user)return 0 ; } -static struct fb_ops radeonfb_ops = { +static const struct fb_ops radeonfb_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_open = radeonfb_open,
drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c +1 -1
@@ -27,7 +27,7 @@ static int rockchip_fbdev_mmap(struct fb_info *info,return rockchip_gem_mmap_buf (private->fbdev_bo, vma); } -static struct fb_ops rockchip_drm_fbdev_ops = { +static const struct fb_ops rockchip_drm_fbdev_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_mmap = rockchip_fbdev_mmap,
drivers/gpu/drm/tegra/fb.c +1 -1
@@ -192,7 +192,7 @@ static int tegra_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)return __tegra_gem_mmap (&bo->gem, vma); } -static struct fb_ops tegra_fb_ops = { +static const struct fb_ops tegra_fb_ops = { .owner =THIS_MODULE ,DRM_FB_HELPER_DEFAULT_OPS , .fb_fillrect = drm_fb_helper_sys_fillrect,
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c +1 -1
@@ -624,7 +624,7 @@ static int vmw_fb_set_par(struct fb_info *info) } -static struct fb_ops vmw_fb_ops = { +static const struct fb_ops vmw_fb_ops = { .owner =THIS_MODULE , .fb_check_var = vmw_fb_check_var, .fb_set_par = vmw_fb_set_par,
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 10/14 video: constify fb ops across all drivers
In reply to Jani NikulaNow that the fbops member of struct fb_info is const, we can start making the ops const as well.
This does not cover all drivers; some actually modify the fbops struct, for example to adjust for different configurations, and others do more involved things that I'd rather not touch in practically obsolete drivers. Mostly this is the low hanging fruit where we can add "const" and be done with it.
v2:
- fix typo (Christophe de Dinechin)
- use "static const" instead of "const static" in mx3fb.c
- also constify smscufx.c
fixup to video drivers
--- drivers/video/fbdev/68328fb.c | 2 +- drivers/video/fbdev/acornfb.c | 2 +- drivers/video/fbdev/amba-clcd.c | 2 +- drivers/video/fbdev/amifb.c | 2 +- drivers/video/fbdev/arcfb.c | 2 +- drivers/video/fbdev/arkfb.c | 2 +- drivers/video/fbdev/asiliantfb.c | 2 +- drivers/video/fbdev/atmel_lcdfb.c | 2 +- drivers/video/fbdev/aty/aty128fb.c | 2 +- drivers/video/fbdev/aty/atyfb_base.c | 2 +- drivers/video/fbdev/aty/radeon_base.c | 2 +- drivers/video/fbdev/au1100fb.c | 2 +- drivers/video/fbdev/au1200fb.c | 2 +- drivers/video/fbdev/broadsheetfb.c | 2 +- drivers/video/fbdev/bw2.c | 2 +- drivers/video/fbdev/carminefb.c | 2 +- drivers/video/fbdev/cg14.c | 2 +- drivers/video/fbdev/cg3.c | 2 +- drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/chipsfb.c | 2 +- drivers/video/fbdev/cirrusfb.c | 2 +- drivers/video/fbdev/clps711x-fb.c | 2 +- drivers/video/fbdev/cobalt_lcdfb.c | 2 +- drivers/video/fbdev/controlfb.c | 2 +- drivers/video/fbdev/cyber2000fb.c | 2 +- drivers/video/fbdev/da8xx-fb.c | 2 +- drivers/video/fbdev/dnfb.c | 2 +- drivers/video/fbdev/efifb.c | 2 +- drivers/video/fbdev/ep93xx-fb.c | 2 +- drivers/video/fbdev/fb-puv3.c | 2 +- drivers/video/fbdev/ffb.c | 2 +- drivers/video/fbdev/fm2fb.c | 2 +- drivers/video/fbdev/fsl-diu-fb.c | 2 +- drivers/video/fbdev/g364fb.c | 2 +- drivers/video/fbdev/gbefb.c | 2 +- drivers/video/fbdev/geode/gx1fb_core.c | 2 +- drivers/video/fbdev/geode/gxfb_core.c | 2 +- drivers/video/fbdev/geode/lxfb_core.c | 2 +- drivers/video/fbdev/goldfishfb.c | 2 +- drivers/video/fbdev/grvga.c | 2 +- drivers/video/fbdev/gxt4500.c | 2 +- drivers/video/fbdev/hecubafb.c | 2 +- drivers/video/fbdev/hgafb.c | 2 +- drivers/video/fbdev/hitfb.c | 2 +- drivers/video/fbdev/hpfb.c | 2 +- drivers/video/fbdev/hyperv_fb.c | 2 +- drivers/video/fbdev/i740fb.c | 2 +- drivers/video/fbdev/imsttfb.c | 2 +- drivers/video/fbdev/imxfb.c | 2 +- drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +- drivers/video/fbdev/kyro/fbdev.c | 2 +- drivers/video/fbdev/leo.c | 2 +- drivers/video/fbdev/macfb.c | 2 +- drivers/video/fbdev/matrox/matroxfb_crtc2.c | 2 +- drivers/video/fbdev/maxinefb.c | 2 +- drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +- drivers/video/fbdev/mbx/mbxfb.c | 2 +- drivers/video/fbdev/metronomefb.c | 2 +- drivers/video/fbdev/mmp/fb/mmpfb.c | 2 +- drivers/video/fbdev/mx3fb.c | 5 +++-- drivers/video/fbdev/neofb.c | 2 +- drivers/video/fbdev/nvidia/nvidia.c | 2 +- drivers/video/fbdev/ocfb.c | 2 +- drivers/video/fbdev/offb.c | 2 +- drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 2 +- drivers/video/fbdev/p9100.c | 2 +- drivers/video/fbdev/platinumfb.c | 2 +- drivers/video/fbdev/pm2fb.c | 2 +- drivers/video/fbdev/pm3fb.c | 2 +- drivers/video/fbdev/pmag-aa-fb.c | 2 +- drivers/video/fbdev/pmag-ba-fb.c | 2 +- drivers/video/fbdev/pmagb-b-fb.c | 2 +- drivers/video/fbdev/ps3fb.c | 2 +- drivers/video/fbdev/pvr2fb.c | 2 +- drivers/video/fbdev/pxa168fb.c | 2 +- drivers/video/fbdev/pxafb.c | 4 ++-- drivers/video/fbdev/q40fb.c | 2 +- drivers/video/fbdev/riva/fbdev.c | 2 +- drivers/video/fbdev/s3c-fb.c | 2 +- drivers/video/fbdev/s3c2410fb.c | 2 +- drivers/video/fbdev/s3fb.c | 2 +- drivers/video/fbdev/sa1100fb.c | 2 +- drivers/video/fbdev/savage/savagefb_driver.c | 2 +- drivers/video/fbdev/sh7760fb.c | 2 +- drivers/video/fbdev/sh_mobile_lcdcfb.c | 4 ++-- drivers/video/fbdev/simplefb.c | 2 +- drivers/video/fbdev/sis/sis_main.c | 2 +- drivers/video/fbdev/skeletonfb.c | 2 +- drivers/video/fbdev/sm712fb.c | 2 +- drivers/video/fbdev/smscufx.c | 2 +- drivers/video/fbdev/ssd1307fb.c | 2 +- drivers/video/fbdev/sstfb.c | 2 +- drivers/video/fbdev/stifb.c | 2 +- drivers/video/fbdev/sunxvr1000.c | 2 +- drivers/video/fbdev/sunxvr2500.c | 2 +- drivers/video/fbdev/sunxvr500.c | 2 +- drivers/video/fbdev/tcx.c | 2 +- drivers/video/fbdev/tdfxfb.c | 2 +- drivers/video/fbdev/tgafb.c | 2 +- drivers/video/fbdev/tmiofb.c | 2 +- drivers/video/fbdev/tridentfb.c | 2 +- drivers/video/fbdev/uvesafb.c | 2 +- drivers/video/fbdev/valkyriefb.c | 2 +- drivers/video/fbdev/vfb.c | 2 +- drivers/video/fbdev/vga16fb.c | 2 +- drivers/video/fbdev/vt8500lcdfb.c | 2 +- drivers/video/fbdev/vt8623fb.c | 2 +- drivers/video/fbdev/w100fb.c | 2 +- drivers/video/fbdev/wm8505fb.c | 2 +- drivers/video/fbdev/xen-fbfront.c | 2 +- drivers/video/fbdev/xilinxfb.c | 2 +- 111 files changed, 115 insertions(+), 114 deletions(-)
drivers/video/fbdev/68328fb.c +1 -1
@@ -96,7 +96,7 @@ static int mc68x328fb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info);static int mc68x328fb_mmap (struct fb_info *info,struct vm_area_struct *vma); -static struct fb_ops mc68x328fb_ops = { +static const struct fb_ops mc68x328fb_ops = { .fb_check_var = mc68x328fb_check_var, .fb_set_par = mc68x328fb_set_par, .fb_setcolreg = mc68x328fb_setcolreg,
drivers/video/fbdev/acornfb.c +1 -1
@@ -604,7 +604,7 @@ acornfb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info)return 0 ; } -static struct fb_ops acornfb_ops = { +static const struct fb_ops acornfb_ops = { .owner =THIS_MODULE , .fb_check_var = acornfb_check_var, .fb_set_par = acornfb_set_par,
drivers/video/fbdev/amba-clcd.c +1 -1
@@ -423,7 +423,7 @@ static int clcdfb_mmap(struct fb_info *info,return ret; } -static struct fb_ops clcdfb_ops = { +static const struct fb_ops clcdfb_ops = { .owner =THIS_MODULE , .fb_check_var = clcdfb_check_var, .fb_set_par = clcdfb_set_par,
drivers/video/fbdev/amifb.c +1 -1
@@ -3493,7 +3493,7 @@ static irqreturn_t amifb_interrupt(int irq, void *dev_id) } -static struct fb_ops amifb_ops = { +static const struct fb_ops amifb_ops = { .owner =THIS_MODULE , .fb_check_var = amifb_check_var, .fb_set_par = amifb_set_par,
drivers/video/fbdev/arcfb.c +1 -1
@@ -491,7 +491,7 @@ static ssize_t arcfb_write(struct fb_info *info, const char __user *buf,return err; } -static struct fb_ops arcfb_ops = { +static const struct fb_ops arcfb_ops = { .owner =THIS_MODULE , .fb_open = arcfb_open, .fb_read = fb_sys_read,
drivers/video/fbdev/arkfb.c +1 -1
@@ -917,7 +917,7 @@ static int arkfb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info/* Frame buffer operations */ -static struct fb_ops arkfb_ops = { +static const struct fb_ops arkfb_ops = { .owner =THIS_MODULE , .fb_open = arkfb_open, .fb_release = arkfb_release,
drivers/video/fbdev/asiliantfb.c +1 -1
@@ -95,7 +95,7 @@ static int asiliantfb_set_par(struct fb_info *info);static int asiliantfb_setcolreg (u_int regno,u_int red,u_int green,u_int blue,u_int transp,struct fb_info *info); -static struct fb_ops asiliantfb_ops = { +static const struct fb_ops asiliantfb_ops = { .owner =THIS_MODULE , .fb_check_var = asiliantfb_check_var, .fb_set_par = asiliantfb_set_par,
drivers/video/fbdev/atmel_lcdfb.c +1 -1
@@ -824,7 +824,7 @@ static int atmel_lcdfb_blank(int blank_mode, struct fb_info *info)return ((blank_mode ==FB_BLANK_NORMAL ) ?1 :0 ); } -static struct fb_ops atmel_lcdfb_ops = { +static const struct fb_ops atmel_lcdfb_ops = { .owner =THIS_MODULE , .fb_check_var = atmel_lcdfb_check_var, .fb_set_par = atmel_lcdfb_set_par,
drivers/video/fbdev/aty/aty128fb.c +1 -1
@@ -509,7 +509,7 @@ static void aty128_bl_set_power(struct fb_info *info, int power); (readb(bios + (v) + 3) << 24)) -static struct fb_ops aty128fb_ops = { +static const struct fb_ops aty128fb_ops = { .owner =THIS_MODULE , .fb_check_var = aty128fb_check_var, .fb_set_par = aty128fb_set_par,
drivers/video/fbdev/aty/atyfb_base.c +1 -1
@@ -280,7 +280,7 @@ static const struct fb_videomode defmode = {0 ,FB_VMODE_NONINTERLACED }; -static struct fb_ops atyfb_ops = { +static const struct fb_ops atyfb_ops = { .owner =THIS_MODULE , .fb_open = atyfb_open, .fb_release = atyfb_release,
drivers/video/fbdev/aty/radeon_base.c +1 -1
@@ -1965,7 +1965,7 @@ static int radeonfb_set_par(struct fb_info *info) } -static struct fb_ops radeonfb_ops = { +static const struct fb_ops radeonfb_ops = { .owner =THIS_MODULE , .fb_check_var = radeonfb_check_var, .fb_set_par = radeonfb_set_par,
drivers/video/fbdev/au1100fb.c +1 -1
@@ -348,7 +348,7 @@ int au1100fb_fb_mmap(struct fb_info *fbi, struct vm_area_struct *vma) fbdev->fb_len); } -static struct fb_ops au1100fb_ops = +static const struct fb_ops au1100fb_ops = { .owner =THIS_MODULE , .fb_setcolreg = au1100fb_fb_setcolreg,
drivers/video/fbdev/au1200fb.c +1 -1
@@ -1483,7 +1483,7 @@ static int au1200fb_ioctl(struct fb_info *info, unsigned int cmd, } -static struct fb_ops au1200fb_fb_ops = { +static const struct fb_ops au1200fb_fb_ops = { .owner =THIS_MODULE , .fb_check_var = au1200fb_fb_check_var, .fb_set_par = au1200fb_fb_set_par,
drivers/video/fbdev/broadsheetfb.c +1 -1
@@ -1048,7 +1048,7 @@ static ssize_t broadsheetfb_write(struct fb_info *info, const char __user *buf,return (err) ? err : count; } -static struct fb_ops broadsheetfb_ops = { +static const struct fb_ops broadsheetfb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = broadsheetfb_write,
drivers/video/fbdev/bw2.c +1 -1
@@ -37,7 +37,7 @@ static int bw2_ioctl(struct fb_info *, unsigned int, unsigned long);* Frame buffer operations */ -static struct fb_ops bw2_ops = { +static const struct fb_ops bw2_ops = { .owner =THIS_MODULE , .fb_blank = bw2_blank, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/carminefb.c +1 -1
@@ -527,7 +527,7 @@ static int init_hardware(struct carmine_hw *hw)return 0 ; } -static struct fb_ops carminefb_ops = { +static const struct fb_ops carminefb_ops = { .owner =THIS_MODULE , .fb_fillrect = cfb_fillrect, .fb_copyarea = cfb_copyarea,
drivers/video/fbdev/cg14.c +1 -1
@@ -39,7 +39,7 @@ static int cg14_pan_display(struct fb_var_screeninfo *, struct fb_info *);* Frame buffer operations */ -static struct fb_ops cg14_ops = { +static const struct fb_ops cg14_ops = { .owner =THIS_MODULE , .fb_setcolreg = cg14_setcolreg, .fb_pan_display = cg14_pan_display,
drivers/video/fbdev/cg3.c +1 -1
@@ -39,7 +39,7 @@ static int cg3_ioctl(struct fb_info *, unsigned int, unsigned long);* Frame buffer operations */ -static struct fb_ops cg3_ops = { +static const struct fb_ops cg3_ops = { .owner =THIS_MODULE , .fb_setcolreg = cg3_setcolreg, .fb_blank = cg3_blank,
drivers/video/fbdev/cg6.c +1 -1
@@ -44,7 +44,7 @@ static int cg6_pan_display(struct fb_var_screeninfo *, struct fb_info *);* Frame buffer operations */ -static struct fb_ops cg6_ops = { +static const struct fb_ops cg6_ops = { .owner =THIS_MODULE , .fb_setcolreg = cg6_setcolreg, .fb_blank = cg6_blank,
drivers/video/fbdev/chipsfb.c +1 -1
@@ -79,7 +79,7 @@ static int chipsfb_setcolreg(u_int regno, u_int red, u_int green, u_int blue, u_int transp, struct fb_info *info);static int chipsfb_blank (int blank,struct fb_info *info); -static struct fb_ops chipsfb_ops = { +static const struct fb_ops chipsfb_ops = { .owner =THIS_MODULE , .fb_check_var = chipsfb_check_var, .fb_set_par = chipsfb_set_par,
drivers/video/fbdev/cirrusfb.c +1 -1
@@ -1956,7 +1956,7 @@ static void cirrusfb_zorro_unmap(struct fb_info *info)#endif /* CONFIG_ZORRO */ /* function table of the above functions */ -static struct fb_ops cirrusfb_ops = { +static const struct fb_ops cirrusfb_ops = { .owner =THIS_MODULE , .fb_open = cirrusfb_open, .fb_release = cirrusfb_release,
drivers/video/fbdev/clps711x-fb.c +1 -1
@@ -153,7 +153,7 @@ static int clps711x_fb_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops clps711x_fb_ops = { +static const struct fb_ops clps711x_fb_ops = { .owner =THIS_MODULE , .fb_setcolreg = clps711x_fb_setcolreg, .fb_check_var = clps711x_fb_check_var,
drivers/video/fbdev/cobalt_lcdfb.c +1 -1
@@ -269,7 +269,7 @@ static int cobalt_lcdfb_cursor(struct fb_info *info, struct fb_cursor *cursor)return 0 ; } -static struct fb_ops cobalt_lcd_fbops = { +static const struct fb_ops cobalt_lcd_fbops = { .owner =THIS_MODULE , .fb_read = cobalt_lcdfb_read, .fb_write = cobalt_lcdfb_write,
drivers/video/fbdev/controlfb.c +1 -1
@@ -157,7 +157,7 @@ static int default_vmode __initdata = VMODE_NVRAM;static int default_cmode__initdata =CMODE_NVRAM ; -static struct fb_ops controlfb_ops = { +static const struct fb_ops controlfb_ops = { .owner =THIS_MODULE , .fb_check_var = controlfb_check_var, .fb_set_par = controlfb_set_par,
drivers/video/fbdev/cyber2000fb.c +1 -1
@@ -1060,7 +1060,7 @@ static int cyber2000fb_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops cyber2000fb_ops = { +static const struct fb_ops cyber2000fb_ops = { .owner =THIS_MODULE , .fb_check_var = cyber2000fb_check_var, .fb_set_par = cyber2000fb_set_par,
drivers/video/fbdev/da8xx-fb.c +1 -1
@@ -1294,7 +1294,7 @@ static int da8xxfb_set_par(struct fb_info *info)return 0 ; } -static struct fb_ops da8xx_fb_ops = { +static const struct fb_ops da8xx_fb_ops = { .owner =THIS_MODULE , .fb_check_var = fb_check_var, .fb_set_par = da8xxfb_set_par,
drivers/video/fbdev/dnfb.c +1 -1
@@ -108,7 +108,7 @@static int dnfb_blank (int blank,struct fb_info *info);static void dnfb_copyarea (struct fb_info *info,const struct fb_copyarea *area); -static struct fb_ops dn_fb_ops = { +static const struct fb_ops dn_fb_ops = { .owner =THIS_MODULE , .fb_blank = dnfb_blank, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/efifb.c +1 -1
@@ -255,7 +255,7 @@ static void efifb_destroy(struct fb_info *info)fb_dealloc_cmap (&info->cmap); } -static struct fb_ops efifb_ops = { +static const struct fb_ops efifb_ops = { .owner =THIS_MODULE , .fb_destroy = efifb_destroy, .fb_setcolreg = efifb_setcolreg,
drivers/video/fbdev/ep93xx-fb.c +1 -1
@@ -402,7 +402,7 @@ static int ep93xxfb_setcolreg(unsigned int regno, unsigned int red,return 0 ; } -static struct fb_ops ep93xxfb_ops = { +static const struct fb_ops ep93xxfb_ops = { .owner =THIS_MODULE , .fb_check_var = ep93xxfb_check_var, .fb_set_par = ep93xxfb_set_par,
drivers/video/fbdev/fb-puv3.c +1 -1
@@ -644,7 +644,7 @@ int unifb_mmap(struct fb_info *info,return vm_iomap_memory (vma, info->fix.smem_start, info->fix.smem_len); } -static struct fb_ops unifb_ops = { +static const struct fb_ops unifb_ops = { .fb_read = fb_sys_read, .fb_write = fb_sys_write, .fb_check_var = unifb_check_var,
drivers/video/fbdev/ffb.c +1 -1
@@ -44,7 +44,7 @@ static int ffb_pan_display(struct fb_var_screeninfo *, struct fb_info *);* Frame buffer operations */ -static struct fb_ops ffb_ops = { +static const struct fb_ops ffb_ops = { .owner =THIS_MODULE , .fb_setcolreg = ffb_setcolreg, .fb_blank = ffb_blank,
drivers/video/fbdev/fm2fb.c +1 -1
@@ -165,7 +165,7 @@ static int fm2fb_setcolreg(u_int regno, u_int red, u_int green, u_int blue, u_int transp, struct fb_info *info);static int fm2fb_blank (int blank,struct fb_info *info); -static struct fb_ops fm2fb_ops = { +static const struct fb_ops fm2fb_ops = { .owner =THIS_MODULE , .fb_setcolreg = fm2fb_setcolreg, .fb_blank = fm2fb_blank,
drivers/video/fbdev/fsl-diu-fb.c +1 -1
@@ -1448,7 +1448,7 @@ static int fsl_diu_release(struct fb_info *info, int user)return res; } -static struct fb_ops fsl_diu_ops = { +static const struct fb_ops fsl_diu_ops = { .owner =THIS_MODULE , .fb_check_var = fsl_diu_check_var, .fb_set_par = fsl_diu_set_par,
drivers/video/fbdev/g364fb.c +1 -1
@@ -111,7 +111,7 @@ static int g364fb_setcolreg(u_int regno, u_int red, u_int green,static int g364fb_cursor (struct fb_info *info,struct fb_cursor *cursor);static int g364fb_blank (int blank,struct fb_info *info); -static struct fb_ops g364fb_ops = { +static const struct fb_ops g364fb_ops = { .owner =THIS_MODULE , .fb_setcolreg = g364fb_setcolreg, .fb_pan_display = g364fb_pan_display,
drivers/video/fbdev/gbefb.c +1 -1
@@ -1044,7 +1044,7 @@ static int gbefb_mmap(struct fb_info *info,return 0 ; } -static struct fb_ops gbefb_ops = { +static const struct fb_ops gbefb_ops = { .owner =THIS_MODULE , .fb_check_var = gbefb_check_var, .fb_set_par = gbefb_set_par,
drivers/video/fbdev/geode/gx1fb_core.c +1 -1
@@ -252,7 +252,7 @@ static int parse_panel_option(struct fb_info *info)return 0 ; } -static struct fb_ops gx1fb_ops = { +static const struct fb_ops gx1fb_ops = { .owner =THIS_MODULE , .fb_check_var = gx1fb_check_var, .fb_set_par = gx1fb_set_par,
drivers/video/fbdev/geode/gxfb_core.c +1 -1
@@ -265,7 +265,7 @@ static int gxfb_map_video_memory(struct fb_info *info, struct pci_dev *dev)return 0 ; } -static struct fb_ops gxfb_ops = { +static const struct fb_ops gxfb_ops = { .owner =THIS_MODULE , .fb_check_var = gxfb_check_var, .fb_set_par = gxfb_set_par,
drivers/video/fbdev/geode/lxfb_core.c +1 -1
@@ -386,7 +386,7 @@ static int lxfb_map_video_memory(struct fb_info *info, struct pci_dev *dev)return 0 ; } -static struct fb_ops lxfb_ops = { +static const struct fb_ops lxfb_ops = { .owner =THIS_MODULE , .fb_check_var = lxfb_check_var, .fb_set_par = lxfb_set_par,
drivers/video/fbdev/goldfishfb.c +1 -1
@@ -160,7 +160,7 @@ static int goldfish_fb_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops goldfish_fb_ops = { +static const struct fb_ops goldfish_fb_ops = { .owner =THIS_MODULE , .fb_check_var = goldfish_fb_check_var, .fb_set_par = goldfish_fb_set_par,
drivers/video/fbdev/grvga.c +1 -1
@@ -251,7 +251,7 @@ static int grvga_pan_display(struct fb_var_screeninfo *var,return 0 ; } -static struct fb_ops grvga_ops = { +static const struct fb_ops grvga_ops = { .owner =THIS_MODULE , .fb_check_var = grvga_check_var, .fb_set_par = grvga_set_par,
drivers/video/fbdev/gxt4500.c +1 -1
@@ -599,7 +599,7 @@ static const struct fb_fix_screeninfo gxt4500_fix = { .mmio_len = 0x20000, }; -static struct fb_ops gxt4500_ops = { +static const struct fb_ops gxt4500_ops = { .owner =THIS_MODULE , .fb_check_var = gxt4500_check_var, .fb_set_par = gxt4500_set_par,
drivers/video/fbdev/hecubafb.c +1 -1
@@ -197,7 +197,7 @@ static ssize_t hecubafb_write(struct fb_info *info, const char __user *buf,return (err) ? err : count; } -static struct fb_ops hecubafb_ops = { +static const struct fb_ops hecubafb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = hecubafb_write,
drivers/video/fbdev/hgafb.c +1 -1
@@ -523,7 +523,7 @@ static void hgafb_imageblit(struct fb_info *info, const struct fb_image *image) } } -static struct fb_ops hgafb_ops = { +static const struct fb_ops hgafb_ops = { .owner =THIS_MODULE , .fb_open = hgafb_open, .fb_release = hgafb_release,
drivers/video/fbdev/hitfb.c +1 -1
@@ -311,7 +311,7 @@ static int hitfb_set_par(struct fb_info *info)return 0 ; } -static struct fb_ops hitfb_ops = { +static const struct fb_ops hitfb_ops = { .owner =THIS_MODULE , .fb_check_var = hitfb_check_var, .fb_set_par = hitfb_set_par,
drivers/video/fbdev/hpfb.c +1 -1
@@ -184,7 +184,7 @@ static int hpfb_sync(struct fb_info *info)return 0 ; } -static struct fb_ops hpfb_ops = { +static const struct fb_ops hpfb_ops = { .owner =THIS_MODULE , .fb_setcolreg = hpfb_setcolreg, .fb_blank = hpfb_blank,
drivers/video/fbdev/hyperv_fb.c +1 -1
@@ -623,7 +623,7 @@ static void hvfb_cfb_imageblit(struct fb_info *p,synthvid_update (p); } -static struct fb_ops hvfb_ops = { +static const struct fb_ops hvfb_ops = { .owner =THIS_MODULE , .fb_check_var = hvfb_check_var, .fb_set_par = hvfb_set_par,
drivers/video/fbdev/i740fb.c +1 -1
@@ -981,7 +981,7 @@ static int i740fb_blank(int blank_mode, struct fb_info *info)return (blank_mode ==FB_BLANK_NORMAL ) ?1 :0 ; } -static struct fb_ops i740fb_ops = { +static const struct fb_ops i740fb_ops = { .owner =THIS_MODULE , .fb_open = i740fb_open, .fb_release = i740fb_release,
drivers/video/fbdev/imsttfb.c +1 -1
@@ -1333,7 +1333,7 @@ static struct pci_driver imsttfb_pci_driver = { .remove = imsttfb_remove, }; -static struct fb_ops imsttfb_ops = { +static const struct fb_ops imsttfb_ops = { .owner =THIS_MODULE , .fb_check_var = imsttfb_check_var, .fb_set_par = imsttfb_set_par,
drivers/video/fbdev/imxfb.c +1 -1
@@ -566,7 +566,7 @@ static int imxfb_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops imxfb_ops = { +static const struct fb_ops imxfb_ops = { .owner =THIS_MODULE , .fb_check_var = imxfb_check_var, .fb_set_par = imxfb_set_par,
drivers/video/fbdev/intelfb/intelfbdrv.c +1 -1
@@ -193,7 +193,7 @@ static const struct pci_device_id intelfb_pci_table[] = {static int num_registered =0 ;/* fb ops */ -static struct fb_ops intel_fb_ops = { +static const struct fb_ops intel_fb_ops = { .owner =THIS_MODULE , .fb_open = intelfb_open, .fb_release = intelfb_release,
drivers/video/fbdev/kyro/fbdev.c +1 -1
@@ -648,7 +648,7 @@ static struct pci_driver kyrofb_pci_driver = { .remove = kyrofb_remove, }; -static struct fb_ops kyrofb_ops = { +static const struct fb_ops kyrofb_ops = { .owner =THIS_MODULE , .fb_check_var = kyrofb_check_var, .fb_set_par = kyrofb_set_par,
drivers/video/fbdev/leo.c +1 -1
@@ -39,7 +39,7 @@ static int leo_pan_display(struct fb_var_screeninfo *, struct fb_info *);* Frame buffer operations */ -static struct fb_ops leo_ops = { +static const struct fb_ops leo_ops = { .owner =THIS_MODULE , .fb_setcolreg = leo_setcolreg, .fb_blank = leo_blank,
drivers/video/fbdev/macfb.c +1 -1
@@ -496,7 +496,7 @@ static int macfb_setcolreg(unsigned regno, unsigned red, unsigned green,return 0 ; } -static struct fb_ops macfb_ops = { +static const struct fb_ops macfb_ops = { .owner =THIS_MODULE , .fb_setcolreg = macfb_setcolreg, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/matrox/matroxfb_crtc2.c +1 -1
@@ -563,7 +563,7 @@ static int matroxfb_dh_blank(int blank, struct fb_info* info) {#undef m2info } -static struct fb_ops matroxfb_dh_ops = { +static const struct fb_ops matroxfb_dh_ops = { .owner =THIS_MODULE , .fb_open = matroxfb_dh_open, .fb_release = matroxfb_dh_release,
drivers/video/fbdev/maxinefb.c +1 -1
@@ -105,7 +105,7 @@ static int maxinefb_setcolreg(unsigned regno, unsigned red, unsigned green,return 0 ; } -static struct fb_ops maxinefb_ops = { +static const struct fb_ops maxinefb_ops = { .owner =THIS_MODULE , .fb_setcolreg = maxinefb_setcolreg, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c +1 -1
@@ -401,7 +401,7 @@ static int mb862xxfb_ioctl(struct fb_info *fbi, unsigned int cmd, }/* framebuffer ops */ -static struct fb_ops mb862xxfb_ops = { +static const struct fb_ops mb862xxfb_ops = { .owner =THIS_MODULE , .fb_check_var = mb862xxfb_check_var, .fb_set_par = mb862xxfb_set_par,
drivers/video/fbdev/mbx/mbxfb.c +1 -1
@@ -671,7 +671,7 @@ static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,return -EINVAL ; } -static struct fb_ops mbxfb_ops = { +static const struct fb_ops mbxfb_ops = { .owner =THIS_MODULE , .fb_check_var = mbxfb_check_var, .fb_set_par = mbxfb_set_par,
drivers/video/fbdev/metronomefb.c +1 -1
@@ -558,7 +558,7 @@ static ssize_t metronomefb_write(struct fb_info *info, const char __user *buf,return (err) ? err : count; } -static struct fb_ops metronomefb_ops = { +static const struct fb_ops metronomefb_ops = { .owner =THIS_MODULE , .fb_write = metronomefb_write, .fb_fillrect = metronomefb_fillrect,
drivers/video/fbdev/mmp/fb/mmpfb.c +1 -1
@@ -454,7 +454,7 @@ static int mmpfb_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops mmpfb_ops = { +static const struct fb_ops mmpfb_ops = { .owner =THIS_MODULE , .fb_blank = mmpfb_blank, .fb_check_var = mmpfb_check_var,
drivers/video/fbdev/mx3fb.c +3 -2
@@ -1249,7 +1249,7 @@ static int mx3fb_pan_display(struct fb_var_screeninfo *var,* invoked by the core framebuffer driver to perform operations like * blitting, rectangle filling, copy regions and cursor definition. */ -static struct fb_ops mx3fb_ops = { +static const struct fb_ops mx3fb_ops = { .owner =THIS_MODULE , .fb_set_par = mx3fb_set_par, .fb_check_var = mx3fb_check_var,
@@ -1389,7 +1389,8 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi)* mx3fb_init_fbinfo() - initialize framebuffer information object. * @return: initialized framebuffer structure. */ -static struct fb_info *mx3fb_init_fbinfo (struct device *dev,struct fb_ops *ops) +static struct fb_info *mx3fb_init_fbinfo (struct device *dev, +const struct fb_ops *ops) {struct fb_info *fbi;struct mx3fb_info *mx3fbi;
drivers/video/fbdev/neofb.c +1 -1
@@ -1610,7 +1610,7 @@ neofb_cursor(struct fb_info *info, struct fb_cursor *cursor)} */ -static struct fb_ops neofb_ops = { +static const struct fb_ops neofb_ops = { .owner =THIS_MODULE , .fb_open = neofb_open, .fb_release = neofb_release,
drivers/video/fbdev/nvidia/nvidia.c +1 -1
@@ -1024,7 +1024,7 @@ static int nvidiafb_release(struct fb_info *info, int user)return err; } -static struct fb_ops nvidia_fb_ops = { +static const struct fb_ops nvidia_fb_ops = { .owner =THIS_MODULE , .fb_open = nvidiafb_open, .fb_release = nvidiafb_release,
drivers/video/fbdev/ocfb.c +1 -1
@@ -285,7 +285,7 @@ static int ocfb_init_var(struct ocfb_dev *fbdev)return 0 ; } -static struct fb_ops ocfb_ops = { +static const struct fb_ops ocfb_ops = { .owner =THIS_MODULE , .fb_setcolreg = ocfb_setcolreg, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/offb.c +1 -1
@@ -286,7 +286,7 @@ static void offb_destroy(struct fb_info *info)framebuffer_release (info); } -static struct fb_ops offb_ops = { +static const struct fb_ops offb_ops = { .owner =THIS_MODULE , .fb_destroy = offb_destroy, .fb_setcolreg = offb_setcolreg,
drivers/video/fbdev/omap2/omapfb/omapfb-main.c +1 -1
@@ -1280,7 +1280,7 @@ ssize_t omapfb_write(struct fb_info *info, const char __user *buf, }#endif -static struct fb_ops omapfb_ops = { +static const struct fb_ops omapfb_ops = { .owner =THIS_MODULE , .fb_open = omapfb_open, .fb_release = omapfb_release,
drivers/video/fbdev/p9100.c +1 -1
@@ -37,7 +37,7 @@ static int p9100_ioctl(struct fb_info *, unsigned int, unsigned long);* Frame buffer operations */ -static struct fb_ops p9100_ops = { +static const struct fb_ops p9100_ops = { .owner =THIS_MODULE , .fb_setcolreg = p9100_setcolreg, .fb_blank = p9100_blank,
drivers/video/fbdev/platinumfb.c +1 -1
@@ -96,7 +96,7 @@ static int platinum_var_to_par(struct fb_var_screeninfo *var,* Interface used by the world */ -static struct fb_ops platinumfb_ops = { +static const struct fb_ops platinumfb_ops = { .owner =THIS_MODULE , .fb_check_var = platinumfb_check_var, .fb_set_par = platinumfb_set_par,
drivers/video/fbdev/pm2fb.c +1 -1
@@ -1483,7 +1483,7 @@ static int pm2fb_cursor(struct fb_info *info, struct fb_cursor *cursor)* Frame buffer operations */ -static struct fb_ops pm2fb_ops = { +static const struct fb_ops pm2fb_ops = { .owner =THIS_MODULE , .fb_check_var = pm2fb_check_var, .fb_set_par = pm2fb_set_par,
drivers/video/fbdev/pm3fb.c +1 -1
@@ -1200,7 +1200,7 @@ static int pm3fb_blank(int blank_mode, struct fb_info *info)* Frame buffer operations */ -static struct fb_ops pm3fb_ops = { +static const struct fb_ops pm3fb_ops = { .owner =THIS_MODULE , .fb_check_var = pm3fb_check_var, .fb_set_par = pm3fb_set_par,
drivers/video/fbdev/pmag-aa-fb.c +1 -1
@@ -147,7 +147,7 @@ static int aafb_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops aafb_ops = { +static const struct fb_ops aafb_ops = { .owner =THIS_MODULE , .fb_blank = aafb_blank, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/pmag-ba-fb.c +1 -1
@@ -117,7 +117,7 @@ static int pmagbafb_setcolreg(unsigned int regno, unsigned int red,return 0 ; } -static struct fb_ops pmagbafb_ops = { +static const struct fb_ops pmagbafb_ops = { .owner =THIS_MODULE , .fb_setcolreg = pmagbafb_setcolreg, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/pmagb-b-fb.c +1 -1
@@ -121,7 +121,7 @@ static int pmagbbfb_setcolreg(unsigned int regno, unsigned int red,return 0 ; } -static struct fb_ops pmagbbfb_ops = { +static const struct fb_ops pmagbbfb_ops = { .owner =THIS_MODULE , .fb_setcolreg = pmagbbfb_setcolreg, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/ps3fb.c +1 -1
@@ -934,7 +934,7 @@ static irqreturn_t ps3fb_vsync_interrupt(int irq, void *ptr) } -static struct fb_ops ps3fb_ops = { +static const struct fb_ops ps3fb_ops = { .fb_open = ps3fb_open, .fb_release = ps3fb_release, .fb_read = fb_sys_read,
drivers/video/fbdev/pvr2fb.c +1 -1
@@ -707,7 +707,7 @@ static ssize_t pvr2fb_write(struct fb_info *info, const char *buf, }#endif /* CONFIG_PVR2_DMA */ -static struct fb_ops pvr2fb_ops = { +static const struct fb_ops pvr2fb_ops = { .owner =THIS_MODULE , .fb_setcolreg = pvr2fb_setcolreg, .fb_blank = pvr2fb_blank,
drivers/video/fbdev/pxa168fb.c +1 -1
@@ -545,7 +545,7 @@ static irqreturn_t pxa168fb_handle_irq(int irq, void *dev_id)return IRQ_NONE ; } -static struct fb_ops pxa168fb_ops = { +static const struct fb_ops pxa168fb_ops = { .owner =THIS_MODULE , .fb_check_var = pxa168fb_check_var, .fb_set_par = pxa168fb_set_par,
drivers/video/fbdev/pxafb.c +2 -2
@@ -597,7 +597,7 @@ static int pxafb_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops pxafb_ops = { +static const struct fb_ops pxafb_ops = { .owner =THIS_MODULE , .fb_check_var = pxafb_check_var, .fb_set_par = pxafb_set_par,
@@ -865,7 +865,7 @@ static int overlayfb_set_par(struct fb_info *info)return 0 ; } -static struct fb_ops overlay_fb_ops = { +static const struct fb_ops overlay_fb_ops = { .owner =THIS_MODULE , .fb_open = overlayfb_open, .fb_release = overlayfb_release,
drivers/video/fbdev/q40fb.c +1 -1
@@ -75,7 +75,7 @@ static int q40fb_setcolreg(unsigned regno, unsigned red, unsigned green,return 0 ; } -static struct fb_ops q40fb_ops = { +static const struct fb_ops q40fb_ops = { .owner =THIS_MODULE , .fb_setcolreg = q40fb_setcolreg, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/riva/fbdev.c +1 -1
@@ -1673,7 +1673,7 @@ static int rivafb_sync(struct fb_info *info)* ------------------------------------------------------------------------- */ /* kernel interface */ -static struct fb_ops riva_fb_ops = { +static const struct fb_ops riva_fb_ops = { .owner =THIS_MODULE , .fb_open = rivafb_open, .fb_release = rivafb_release,
drivers/video/fbdev/s3c-fb.c +1 -1
@@ -1035,7 +1035,7 @@ static int s3c_fb_ioctl(struct fb_info *info, unsigned int cmd,return ret; } -static struct fb_ops s3c_fb_ops = { +static const struct fb_ops s3c_fb_ops = { .owner =THIS_MODULE , .fb_check_var = s3c_fb_check_var, .fb_set_par = s3c_fb_set_par,
drivers/video/fbdev/s3c2410fb.c +1 -1
@@ -618,7 +618,7 @@ static int s3c2410fb_debug_store(struct device *dev, static DEVICE_ATTR(debug, 0664, s3c2410fb_debug_show, s3c2410fb_debug_store); -static struct fb_ops s3c2410fb_ops = { +static const struct fb_ops s3c2410fb_ops = { .owner =THIS_MODULE , .fb_check_var = s3c2410fb_check_var, .fb_set_par = s3c2410fb_set_par,
drivers/video/fbdev/s3fb.c +1 -1
@@ -1037,7 +1037,7 @@ static int s3fb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info)/* Frame buffer operations */ -static struct fb_ops s3fb_ops = { +static const struct fb_ops s3fb_ops = { .owner =THIS_MODULE , .fb_open = s3fb_open, .fb_release = s3fb_release,
drivers/video/fbdev/sa1100fb.c +1 -1
@@ -574,7 +574,7 @@ static int sa1100fb_mmap(struct fb_info *info,return vm_iomap_memory (vma, info->fix.mmio_start, info->fix.mmio_len); } -static struct fb_ops sa1100fb_ops = { +static const struct fb_ops sa1100fb_ops = { .owner =THIS_MODULE , .fb_check_var = sa1100fb_check_var, .fb_set_par = sa1100fb_set_par,
drivers/video/fbdev/savage/savagefb_driver.c +1 -1
@@ -1637,7 +1637,7 @@ static int savagefb_release(struct fb_info *info, int user)return 0 ; } -static struct fb_ops savagefb_ops = { +static const struct fb_ops savagefb_ops = { .owner =THIS_MODULE , .fb_open = savagefb_open, .fb_release = savagefb_release,
drivers/video/fbdev/sh7760fb.c +1 -1
@@ -341,7 +341,7 @@ static int sh7760fb_set_par(struct fb_info *info)return 0 ; } -static struct fb_ops sh7760fb_ops = { +static const struct fb_ops sh7760fb_ops = { .owner =THIS_MODULE , .fb_blank = sh7760fb_blank, .fb_check_var = sh7760fb_check_var,
drivers/video/fbdev/sh_mobile_lcdcfb.c +2 -2
@@ -1490,7 +1490,7 @@ sh_mobile_lcdc_overlay_mmap(struct fb_info *info, struct vm_area_struct *vma) ovl->dma_handle, ovl->fb_size); } -static struct fb_ops sh_mobile_lcdc_overlay_ops = { +static const struct fb_ops sh_mobile_lcdc_overlay_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = fb_sys_write,
@@ -1964,7 +1964,7 @@ sh_mobile_lcdc_mmap(struct fb_info *info, struct vm_area_struct *vma) ch->dma_handle, ch->fb_size); } -static struct fb_ops sh_mobile_lcdc_ops = { +static const struct fb_ops sh_mobile_lcdc_ops = { .owner =THIS_MODULE , .fb_setcolreg = sh_mobile_lcdc_setcolreg, .fb_read = fb_sys_read,
drivers/video/fbdev/simplefb.c +1 -1
@@ -78,7 +78,7 @@ static void simplefb_destroy(struct fb_info *info)iounmap (info->screen_base); } -static struct fb_ops simplefb_ops = { +static const struct fb_ops simplefb_ops = { .owner =THIS_MODULE , .fb_destroy = simplefb_destroy, .fb_setcolreg = simplefb_setcolreg,
drivers/video/fbdev/sis/sis_main.c +1 -1
@@ -1906,7 +1906,7 @@ sisfb_get_fix(struct fb_fix_screeninfo *fix, int con, struct fb_info *info)/* ---------------- fb_ops structures ----------------- */ -static struct fb_ops sisfb_ops = { +static const struct fb_ops sisfb_ops = { .owner =THIS_MODULE , .fb_open = sisfb_open, .fb_release = sisfb_release,
drivers/video/fbdev/skeletonfb.c +1 -1
@@ -634,7 +634,7 @@ int xxxfb_sync(struct fb_info *info)* Frame buffer operations */ -static struct fb_ops xxxfb_ops = { +static const struct fb_ops xxxfb_ops = { .owner =THIS_MODULE , .fb_open = xxxfb_open, .fb_read = xxxfb_read,
drivers/video/fbdev/sm712fb.c +1 -1
@@ -1369,7 +1369,7 @@ static int smtc_set_par(struct fb_info *info)return 0 ; } -static struct fb_ops smtcfb_ops = { +static const struct fb_ops smtcfb_ops = { .owner =THIS_MODULE , .fb_check_var = smtc_check_var, .fb_set_par = smtc_set_par,
drivers/video/fbdev/smscufx.c +1 -1
@@ -1268,7 +1268,7 @@ static int ufx_ops_blank(int blank_mode, struct fb_info *info)return 0 ; } -static struct fb_ops ufx_ops = { +static const struct fb_ops ufx_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = ufx_ops_write,
drivers/video/fbdev/ssd1307fb.c +1 -1
@@ -280,7 +280,7 @@ static void ssd1307fb_imageblit(struct fb_info *info, const struct fb_image *imassd1307fb_update_display (par); } -static struct fb_ops ssd1307fb_ops = { +static const struct fb_ops ssd1307fb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = ssd1307fb_write,
drivers/video/fbdev/sstfb.c +1 -1
@@ -1307,7 +1307,7 @@ static int sstfb_setup(char *options) } -static struct fb_ops sstfb_ops = { +static const struct fb_ops sstfb_ops = { .owner =THIS_MODULE , .fb_check_var = sstfb_check_var, .fb_set_par = sstfb_set_par,
drivers/video/fbdev/stifb.c +1 -1
@@ -1101,7 +1101,7 @@ stifb_init_display(struct stifb_info *fb)/* ------------ Interfaces to hardware functions ------------ */ -static struct fb_ops stifb_ops = { +static const struct fb_ops stifb_ops = { .owner =THIS_MODULE , .fb_setcolreg = stifb_setcolreg, .fb_blank = stifb_blank,
drivers/video/fbdev/sunxvr1000.c +1 -1
@@ -59,7 +59,7 @@ static int gfb_setcolreg(unsigned regno,return 0 ; } -static struct fb_ops gfb_ops = { +static const struct fb_ops gfb_ops = { .owner =THIS_MODULE , .fb_setcolreg = gfb_setcolreg, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/sunxvr2500.c +1 -1
@@ -63,7 +63,7 @@ static int s3d_setcolreg(unsigned regno,return 0 ; } -static struct fb_ops s3d_ops = { +static const struct fb_ops s3d_ops = { .owner =THIS_MODULE , .fb_setcolreg = s3d_setcolreg, .fb_fillrect = cfb_fillrect,
drivers/video/fbdev/sunxvr500.c +1 -1
@@ -186,7 +186,7 @@ static void e3d_copyarea(struct fb_info *info, const struct fb_copyarea *area)spin_unlock_irqrestore (&ep->lock, flags); } -static struct fb_ops e3d_ops = { +static const struct fb_ops e3d_ops = { .owner =THIS_MODULE , .fb_setcolreg = e3d_setcolreg, .fb_fillrect = e3d_fillrect,
drivers/video/fbdev/tcx.c +1 -1
@@ -40,7 +40,7 @@ static int tcx_pan_display(struct fb_var_screeninfo *, struct fb_info *);* Frame buffer operations */ -static struct fb_ops tcx_ops = { +static const struct fb_ops tcx_ops = { .owner =THIS_MODULE , .fb_setcolreg = tcx_setcolreg, .fb_blank = tcx_blank,
drivers/video/fbdev/tdfxfb.c +1 -1
@@ -1141,7 +1141,7 @@ static int tdfxfb_cursor(struct fb_info *info, struct fb_cursor *cursor)return 0 ; } -static struct fb_ops tdfxfb_ops = { +static const struct fb_ops tdfxfb_ops = { .owner =THIS_MODULE , .fb_check_var = tdfxfb_check_var, .fb_set_par = tdfxfb_set_par,
drivers/video/fbdev/tgafb.c +1 -1
@@ -70,7 +70,7 @@ static struct tc_driver tgafb_tc_driver;* Frame buffer operations */ -static struct fb_ops tgafb_ops = { +static const struct fb_ops tgafb_ops = { .owner =THIS_MODULE , .fb_check_var = tgafb_check_var, .fb_set_par = tgafb_set_par,
drivers/video/fbdev/tmiofb.c +1 -1
@@ -646,7 +646,7 @@ static int tmiofb_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops tmiofb_ops = { +static const struct fb_ops tmiofb_ops = { .owner =THIS_MODULE , .fb_ioctl = tmiofb_ioctl,
drivers/video/fbdev/tridentfb.c +1 -1
@@ -1443,7 +1443,7 @@ static int tridentfb_blank(int blank_mode, struct fb_info *info)return (blank_mode ==FB_BLANK_NORMAL ) ?1 :0 ; } -static struct fb_ops tridentfb_ops = { +static const struct fb_ops tridentfb_ops = { .owner =THIS_MODULE , .fb_setcolreg = tridentfb_setcolreg, .fb_pan_display = tridentfb_pan_display,
drivers/video/fbdev/uvesafb.c +1 -1
@@ -1410,7 +1410,7 @@ static int uvesafb_check_var(struct fb_var_screeninfo *var,return 0 ; } -static struct fb_ops uvesafb_ops = { +static const struct fb_ops uvesafb_ops = { .owner =THIS_MODULE , .fb_open = uvesafb_open, .fb_release = uvesafb_release,
drivers/video/fbdev/valkyriefb.c +1 -1
@@ -113,7 +113,7 @@ static int valkyrie_init_info(struct fb_info *info, struct fb_info_valkyrie *p);static void valkyrie_par_to_fix (struct fb_par_valkyrie *par,struct fb_fix_screeninfo *fix);static void valkyrie_init_fix (struct fb_fix_screeninfo *fix,struct fb_info_valkyrie *p); -static struct fb_ops valkyriefb_ops = { +static const struct fb_ops valkyriefb_ops = { .owner =THIS_MODULE , .fb_check_var = valkyriefb_check_var, .fb_set_par = valkyriefb_set_par,
drivers/video/fbdev/vfb.c +1 -1
@@ -78,7 +78,7 @@ static int vfb_pan_display(struct fb_var_screeninfo *var,static int vfb_mmap (struct fb_info *info,struct vm_area_struct *vma); -static struct fb_ops vfb_ops = { +static const struct fb_ops vfb_ops = { .fb_read = fb_sys_read, .fb_write = fb_sys_write, .fb_check_var = vfb_check_var,
drivers/video/fbdev/vga16fb.c +1 -1
@@ -1270,7 +1270,7 @@ static void vga16fb_destroy(struct fb_info *info)framebuffer_release (info); } -static struct fb_ops vga16fb_ops = { +static const struct fb_ops vga16fb_ops = { .owner =THIS_MODULE , .fb_open = vga16fb_open, .fb_release = vga16fb_release,
drivers/video/fbdev/vt8500lcdfb.c +1 -1
@@ -238,7 +238,7 @@ static int vt8500lcd_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops vt8500lcd_ops = { +static const struct fb_ops vt8500lcd_ops = { .owner =THIS_MODULE , .fb_set_par = vt8500lcd_set_par, .fb_setcolreg = vt8500lcd_setcolreg,
drivers/video/fbdev/vt8623fb.c +1 -1
@@ -634,7 +634,7 @@ static int vt8623fb_pan_display(struct fb_var_screeninfo *var, struct fb_info *i/* Frame buffer operations */ -static struct fb_ops vt8623fb_ops = { +static const struct fb_ops vt8623fb_ops = { .owner =THIS_MODULE , .fb_open = vt8623fb_open, .fb_release = vt8623fb_release,
drivers/video/fbdev/w100fb.c +1 -1
@@ -549,7 +549,7 @@ static int w100fb_set_par(struct fb_info *info)/* * Frame buffer operations */ -static struct fb_ops w100fb_ops = { +static const struct fb_ops w100fb_ops = { .owner =THIS_MODULE , .fb_check_var = w100fb_check_var, .fb_set_par = w100fb_set_par,
drivers/video/fbdev/wm8505fb.c +1 -1
@@ -246,7 +246,7 @@ static int wm8505fb_blank(int blank, struct fb_info *info)return 0 ; } -static struct fb_ops wm8505fb_ops = { +static const struct fb_ops wm8505fb_ops = { .owner =THIS_MODULE , .fb_set_par = wm8505fb_set_par, .fb_setcolreg = wm8505fb_setcolreg,
drivers/video/fbdev/xen-fbfront.c +1 -1
@@ -328,7 +328,7 @@ static int xenfb_set_par(struct fb_info *info)return 0 ; } -static struct fb_ops xenfb_fb_ops = { +static const struct fb_ops xenfb_fb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = xenfb_write,
drivers/video/fbdev/xilinxfb.c +1 -1
@@ -247,7 +247,7 @@ xilinx_fb_blank(int blank_mode, struct fb_info *fbi)return 0 ;/* success */ } -static struct fb_ops xilinxfb_ops = { +static const struct fb_ops xilinxfb_ops = { .owner =THIS_MODULE , .fb_setcolreg = xilinx_fb_setcolreg, .fb_blank = xilinx_fb_blank,
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 10/14] video: constify fb ops across all drivers
Quoted 14 lines · Jani Nikula
Now that the fbops member of struct
fb_infois const, we can start making the ops const as well.This does not cover all drivers; some actually modify the fbops struct, for example to adjust for different configurations, and others do more involved things that I'd rather not touch in practically obsolete drivers. Mostly this is the low hanging fruit where we can add "const" and be done with it.
v2:
- fix typo (Christophe de Dinechin)
- use "static const" instead of "const static" inmx3fb.c
- also constifysmscufx.c
Quoted 5 lines
Reviewed-by Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>fixup to video drivers
Rebase artefact, to be removed before applying...
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 11/14 HID: picoLCD: constify fb ops
In reply to Jani NikulaNow that the fbops member of struct fb_info is const, we can start making the ops const as well.
v2: fix typo (Christophe de Dinechin)
--- drivers/hid/hid-picolcd_fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/hid/hid-picolcd_fb.c +1 -2
@@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info)return 0 ; } -/* Note this can't be const because of struct fb_info definition */ -static struct fb_ops picolcdfb_ops = { +static const struct fb_ops picolcdfb_ops = { .owner =THIS_MODULE , .fb_destroy = picolcd_fb_destroy, .fb_read = fb_sys_read,
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops
Hi Jani,
Quoted 4 lines · On Fri, 29 Nov 2019 12:29:41 Jani Nikula <[email protected]> wrote:
Now that the fbops member of struct
fb_infois const, we can start making the ops const as well.v2: fix typo (Christophe de Dinechin)
Fine with me.
I don't think going through drm-misc would trigger any conflict, but adding Jiri to CC for the case there was any preference.
Quoted 13 lines
Cc Bruno Prémont <[email protected]>Reviewed-by Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/hid/hid-picolcd_fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/hid/hid-picolcd_fb.c +0
-0
drivers/hid/hid-picolcd_fb.c static int picolcd_set_par(struct fb_info *info) · line 423
Quoted 9 lines
drivers/hid/hid-picolcd_fb.c +1
-2@@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info)return 0 ; } -/* Note this can't be const because of struct fb_info definition */ -static struct fb_ops picolcdfb_ops = { +static const struct fb_ops picolcdfb_ops = { .owner =THIS_MODULE , .fb_destroy = picolcd_fb_destroy, .fb_read = fb_sys_read,
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops
Quoted 6 lines · Bruno Prémont
Hi Jani,
Quoted 3 lines · On Fri, 29 Nov 2019 12:29:41 Jani Nikula <[email protected]> wrote:
Now that the fbops member of struct
fb_infois const, we can start making the ops const as well.
Quoted 7 lines
Quoted 1 line
v2: fix typo (Christophe de Dinechin)
Fine with me.
I don't think going through drm-misc would trigger any conflict, but adding Jiri to CC for the case there was any preference.Acked-by Bruno Prémont <[email protected]>
No response, may I proceed with merging this through drm-misc please?
BR,
Jani.
Quoted 24 lines
Quoted 23 lines
Cc Bruno Prémont <[email protected]>Reviewed-by Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/hid/hid-picolcd_fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/hid/hid-picolcd_fb.c +1
-2@@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info)return 0 ; } -/* Note this can't be const because of struct fb_info definition */ -static struct fb_ops picolcdfb_ops = { +static const struct fb_ops picolcdfb_ops = { .owner =THIS_MODULE , .fb_destroy = picolcd_fb_destroy, .fb_read = fb_sys_read,
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops
Quoted 5 lines · Jani Nikula
Quoted 5 lines
Quoted 4 lines
Now that the fbops member of struct
fb_infois const, we can start making the ops const as well.v2: fix typo (Christophe de Dinechin)
Quoted 7 lines
Quoted 5 lines
Fine with me.
I don't think going through drm-misc would trigger any conflict, but adding Jiri to CC for the case there was any preference.Acked-by Bruno Prémont <[email protected]>No response, may I proceed with merging this through drm-misc please?
I have been off the grid the past week, sorry for belated response. Feel free to add
and take it through your tree.
Signature · 2 lines
Jiri Kosina SUSE Labs
PATCH v2 12/14 media: constify fb ops across all drivers
In reply to Jani NikulaNow that the fbops member of struct fb_info is const, we can start making the ops const as well.
Remove the redundant fbops assignments while at it.
v2:
- actually add const in vivid
- fix typo (Christophe de Dinechin)
fixup-to-media
--- drivers/media/pci/ivtv/ivtvfb.c | 3 +-- drivers/media/platform/vivid/vivid-osd.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/media/pci/ivtv/ivtvfb.c +1 -2
@@ -925,7 +925,7 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info)return 0 ; } -static struct fb_ops ivtvfb_ops = { +static const struct fb_ops ivtvfb_ops = { .owner =THIS_MODULE , .fb_write = ivtvfb_write, .fb_check_var = ivtvfb_check_var,
@@ -1049,7 +1049,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv) oi->ivtvfb_info.node =-1 ; oi->ivtvfb_info.flags =FBINFO_FLAG_DEFAULT ; - oi->ivtvfb_info.fbops = &ivtvfb_ops; oi->ivtvfb_info.par = itv; oi->ivtvfb_info.var = oi->ivtvfb_defined; oi->ivtvfb_info.fix = oi->ivtvfb_fix;
drivers/media/platform/vivid/vivid-osd.c +1 -2
@@ -244,7 +244,7 @@ static int vivid_fb_blank(int blank_mode, struct fb_info *info)return 0 ; } -static struct fb_ops vivid_fb_ops = { +static const struct fb_ops vivid_fb_ops = { .owner =THIS_MODULE , .fb_check_var = vivid_fb_check_var, .fb_set_par = vivid_fb_set_par,
@@ -311,7 +311,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev) dev->fb_info.node =-1 ; dev->fb_info.flags =FBINFO_FLAG_DEFAULT ; - dev->fb_info.fbops = &vivid_fb_ops; dev->fb_info.par = dev; dev->fb_info.var = dev->fb_defined; dev->fb_info.fix = dev->fb_fix;
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v2 12/14] media: constify fb ops across all drivers
Quoted 9 lines · Jani Nikula
Now that the fbops member of struct
fb_infois const, we can start making the ops const as well.Remove the redundant fbops assignments while at it.
v2:
- actually add const in vivid
- fix typo (Christophe de Dinechin)
Quoted 8 lines
Cc Hans Verkuil <[email protected]>Cc Andy Walls <[email protected]>Reviewed-by Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>fixup-to-media
Rebase artefact, to be removed before applying...
BR,
Jani.
Quoted 47 lines
--- drivers/media/pci/ivtv/ivtvfb.c | 3 +-- drivers/media/platform/vivid/vivid-osd.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)drivers/media/pci/ivtv/ivtvfb.c +1
-2@@ -925,7 +925,7 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info)return 0 ; } -static struct fb_ops ivtvfb_ops = { +static const struct fb_ops ivtvfb_ops = { .owner =THIS_MODULE , .fb_write = ivtvfb_write, .fb_check_var = ivtvfb_check_var,@@ -1049,7 +1049,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv) oi->ivtvfb_info.node =-1 ; oi->ivtvfb_info.flags =FBINFO_FLAG_DEFAULT ; - oi->ivtvfb_info.fbops = &ivtvfb_ops; oi->ivtvfb_info.par = itv; oi->ivtvfb_info.var = oi->ivtvfb_defined; oi->ivtvfb_info.fix = oi->ivtvfb_fix;drivers/media/platform/vivid/vivid-osd.c +1
-2@@ -244,7 +244,7 @@ static int vivid_fb_blank(int blank_mode, struct fb_info *info)return 0 ; } -static struct fb_ops vivid_fb_ops = { +static const struct fb_ops vivid_fb_ops = { .owner =THIS_MODULE , .fb_check_var = vivid_fb_check_var, .fb_set_par = vivid_fb_set_par,@@ -311,7 +311,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev) dev->fb_info.node =-1 ; dev->fb_info.flags =FBINFO_FLAG_DEFAULT ; - dev->fb_info.fbops = &vivid_fb_ops; dev->fb_info.par = dev; dev->fb_info.var = dev->fb_defined; dev->fb_info.fix = dev->fb_fix;
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 13/14 samples: vfio-mdev: constify fb ops
In reply to Jani NikulaNow that the fbops member of struct fb_info is const, we can start making the ops const as well.
v2: fix typo (Christophe de Dinechin)
--- samples/vfio-mdev/mdpy-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
samples/vfio-mdev/mdpy-fb.c +1 -1
@@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info)iounmap (info->screen_base); } -static struct fb_ops mdpy_fb_ops = { +static const struct fb_ops mdpy_fb_ops = { .owner =THIS_MODULE , .fb_destroy = mdpy_fb_destroy, .fb_setcolreg = mdpy_fb_setcolreg,
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 14/14 auxdisplay: constify fb ops
In reply to Jani NikulaNow that the fbops member of struct fb_info is const, we can start making the ops const as well.
--- drivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/auxdisplay/cfag12864bfb.c +1 -1
@@ -57,7 +57,7 @@ static int cfag12864bfb_mmap(struct fb_info *info, struct vm_area_struct *vma)return vm_map_pages_zero (vma, &pages,1 ); } -static struct fb_ops cfag12864bfb_ops = { +static const struct fb_ops cfag12864bfb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = fb_sys_write,
drivers/auxdisplay/ht16k33.c +1 -1
@@ -228,7 +228,7 @@ static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma)return vm_map_pages_zero (vma, &pages,1 ); } -static struct fb_ops ht16k33_fb_ops = { +static const struct fb_ops ht16k33_fb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = fb_sys_write,
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 14/14] auxdisplay: constify fb ops
drivers/auxdisplay/cfag12864bfb.c
Quoted 15 lines · Jani Nikula
Now that the fbops member of struct
fb_infois const, we can start making the ops const as well.Cc Miguel Ojeda Sandonis <[email protected]>Cc Robin van der Gracht <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/auxdisplay/cfag12864bfb.c +0
-0
Oh, another display subsystem? Intriguing ...
Quoted 29 lines
drivers/auxdisplay/cfag12864bfb.c +1
-1@@ -57,7 +57,7 @@ static int cfag12864bfb_mmap(struct fb_info *info, struct vm_area_struct *vma)return vm_map_pages_zero (vma, &pages,1 ); } -static struct fb_ops cfag12864bfb_ops = { +static const struct fb_ops cfag12864bfb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = fb_sys_write,drivers/auxdisplay/ht16k33.c +1
-1@@ -228,7 +228,7 @@ static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma)return vm_map_pages_zero (vma, &pages,1 ); } -static struct fb_ops ht16k33_fb_ops = { +static const struct fb_ops ht16k33_fb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = fb_sys_write,Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Miguel Ojeda
Reviewed-byRe: [PATCH v2 14/14] auxdisplay: constify fb ops
Quoted 4 lines · Daniel Vetter
Oh, another display subsystem? Intriguing ...
Reviewed-by Daniel Vetter <[email protected]>
It is intended for displays that are not intended as the usual/main display, e.g. very small LCDs :)
Cheers,
Miguel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 14/14] auxdisplay: constify fb ops
Quoted 8 lines · Miguel Ojeda
Quoted 4 lines · Daniel Vetter
Oh, another display subsystem? Intriguing ...
Reviewed-by Daniel Vetter <[email protected]>It is intended for displays that are not intended as the usual/main display, e.g. very small LCDs :)
Well we do have very small lcd display drivers in drm, and before that in fbdev. And you have a fbdev framebuffer driver in there, which looks a bit misplaced ...
Afaiui you also have some even tinier lcd drivers where you don't address pixels, but just directly upload text, and those obviously don't fit into drm/fbdev world. But anything where you can address pixels very much does. -Daniel
Quoted 5 lines
Reviewed-by Miguel Ojeda <[email protected]>Cheers,
Miguel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 14/14] auxdisplay: constify fb ops
Quoted 9 lines · Daniel Vetter
Well we do have very small lcd display drivers in drm, and before that in fbdev. And you have a fbdev framebuffer driver in there, which looks a bit misplaced ...
Afaiui you also have some even tinier lcd drivers where you don't address pixels, but just directly upload text, and those obviously don't fit into drm/fbdev world. But anything where you can address pixels very much does. -Daniel
The first driver in the category used fb.h. At the time (~13 years ago) it was decided that the drivers should go into a different category/folder instead and then the other were added.
In any case, I am removing the original ones since I cannot test them anymore and there are likely no user. The only other fb user could be relocated if Robin agrees.
Cheers,
Miguel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
robin
maintainerRe: [PATCH v2 14/14] auxdisplay: constify fb ops
Quoted 11 lines · Miguel Ojeda
Quoted 9 lines · Daniel Vetter
Well we do have very small lcd display drivers in drm, and before that in fbdev. And you have a fbdev framebuffer driver in there, which looks a bit misplaced ...
Afaiui you also have some even tinier lcd drivers where you don't address pixels, but just directly upload text, and those obviously don't fit into drm/fbdev world. But anything where you can address pixels very much does. -Daniel
Quoted 7 lines
The first driver in the category used
fb.h. At the time (~13 years ago) it was decided that the drivers should go into a different category/folder instead and then the other were added.In any case, I am removing the original ones since I cannot test them anymore and there are likely no user. The only other fb user could be relocated if Robin agrees.
The ht16k33 driver registers a framebuffer, backlight and input device. Not sure if it's OK to let a driver under fbdev register all of those, but relocating it is fine by me.
Robin
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 14/14] auxdisplay: constify fb ops
In reply to Jani NikulaQuoted 39 lines · Jani Nikula
Now that the fbops member of struct
fb_infois const, we can start making the ops const as well.Cc Miguel Ojeda Sandonis <[email protected]>Cc Robin van der Gracht <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/auxdisplay/cfag12864bfb.c +1
-1@@ -57,7 +57,7 @@ static int cfag12864bfb_mmap(struct fb_info *info, struct vm_area_struct *vma)return vm_map_pages_zero (vma, &pages,1 ); } -static struct fb_ops cfag12864bfb_ops = { +static const struct fb_ops cfag12864bfb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read,drivers/auxdisplay/cfag12864bfb.c +0
-0.fb_write = fb_sys_write,drivers/auxdisplay/ht16k33.c +1
-1@@ -228,7 +228,7 @@ static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma)return vm_map_pages_zero (vma, &pages,1 ); } -static struct fb_ops ht16k33_fb_ops = { +static const struct fb_ops ht16k33_fb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read,
Quoted 1 line
.fb_write =
fb_sys_write,
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Jani Nikula
This is v2 of https://patchwork.freedesktop.org/series/70119/
I wanted to make our struct
fb_opsconst because we don't modify it... and this is what I ended up with to fix it and a bunch of others.I would appreciate acks to merge all this via the drm-misc tree. This is especially important for patches 1-8 to reasonably get the job done. Patches 9-14 are somewhat easier to merge at leisure afterwards, but there really isn't much conflict potential IMO.
Only patches 11-14 need acks, drivers/video is already officially maintained in drm-misc.
Quoted 2 lines
Daniel, please double-check me adding your Reviewed-by on the later patches wasn't overzealous.
Yeah, looks all neat&tidy.
-Daniel
Quoted 183 lines
BR,
Jani.Cc Andy Walls <[email protected]>Cc Bernie Thompson <[email protected]>Cc Bruno Prémont <[email protected]>Cc Daniel Vetter <[email protected]>Cc Hans Verkuil <[email protected]>Cc Jaya Kumar <[email protected]>Cc Kirti Wankhede <[email protected]>Cc Miguel Ojeda Sandonis <[email protected]>Cc Noralf Trønnes <[email protected]>Cc Robin van der Gracht <[email protected]>Cc Steve Glendinning <[email protected]>Cc Ville Syrjälä <[email protected]>Jani Nikula (14):
video:fb_defio: preserve userfb_ops
drm/fb-helper: don't preservefb_opsacross deferred IO use
video: smscufx: don't restorefb_mmapafter deferred IO cleanup
video: udlfb: don't restorefb_mmapafter deferred IO cleanup
video: fbdev: vesafb: modify the staticfb_opsdirectly
video: fbmem: use const pointer forfb_ops
video: omapfb: use const pointer forfb_ops
video: fbdev: make fbops member of structfb_infoa const pointer
drm: constify fb ops across all drivers
video: constify fb ops across all drivers
HID: picoLCD: constify fb ops
media: constify fb ops across all drivers
samples: vfio-mdev: constify fb ops
auxdisplay: constify fb opsdrivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 27 +++---------------- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +-- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- drivers/gpu/drm/radeon/radeon_fb.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +- drivers/gpu/drm/tegra/fb.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +- drivers/hid/hid-picolcd_fb.c | 3 +-- drivers/media/pci/ivtv/ivtvfb.c | 3 +-- drivers/media/platform/vivid/vivid-osd.c | 3 +-- drivers/video/fbdev/68328fb.c | 2 +- drivers/video/fbdev/acornfb.c | 2 +- drivers/video/fbdev/amba-clcd.c | 2 +- drivers/video/fbdev/amifb.c | 2 +- drivers/video/fbdev/arcfb.c | 2 +- drivers/video/fbdev/arkfb.c | 2 +- drivers/video/fbdev/asiliantfb.c | 2 +- drivers/video/fbdev/atmel_lcdfb.c | 2 +- drivers/video/fbdev/aty/aty128fb.c | 2 +- drivers/video/fbdev/aty/atyfb_base.c | 2 +- drivers/video/fbdev/aty/radeon_base.c | 2 +- drivers/video/fbdev/au1100fb.c | 2 +- drivers/video/fbdev/au1200fb.c | 2 +- drivers/video/fbdev/broadsheetfb.c | 2 +- drivers/video/fbdev/bw2.c | 2 +- drivers/video/fbdev/carminefb.c | 2 +- drivers/video/fbdev/cg14.c | 2 +- drivers/video/fbdev/cg3.c | 2 +- drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/chipsfb.c | 2 +- drivers/video/fbdev/cirrusfb.c | 2 +- drivers/video/fbdev/clps711x-fb.c | 2 +- drivers/video/fbdev/cobalt_lcdfb.c | 2 +- drivers/video/fbdev/controlfb.c | 2 +- drivers/video/fbdev/core/fb_defio.c | 3 --- drivers/video/fbdev/core/fbmem.c | 19 ++++++++----- drivers/video/fbdev/cyber2000fb.c | 2 +- drivers/video/fbdev/da8xx-fb.c | 2 +- drivers/video/fbdev/dnfb.c | 2 +- drivers/video/fbdev/efifb.c | 2 +- drivers/video/fbdev/ep93xx-fb.c | 2 +- drivers/video/fbdev/fb-puv3.c | 2 +- drivers/video/fbdev/ffb.c | 2 +- drivers/video/fbdev/fm2fb.c | 2 +- drivers/video/fbdev/fsl-diu-fb.c | 2 +- drivers/video/fbdev/g364fb.c | 2 +- drivers/video/fbdev/gbefb.c | 2 +- drivers/video/fbdev/geode/gx1fb_core.c | 2 +- drivers/video/fbdev/geode/gxfb_core.c | 2 +- drivers/video/fbdev/geode/lxfb_core.c | 2 +- drivers/video/fbdev/goldfishfb.c | 2 +- drivers/video/fbdev/grvga.c | 2 +- drivers/video/fbdev/gxt4500.c | 2 +- drivers/video/fbdev/hecubafb.c | 2 +- drivers/video/fbdev/hgafb.c | 2 +- drivers/video/fbdev/hitfb.c | 2 +- drivers/video/fbdev/hpfb.c | 2 +- drivers/video/fbdev/hyperv_fb.c | 2 +- drivers/video/fbdev/i740fb.c | 2 +- drivers/video/fbdev/imsttfb.c | 2 +- drivers/video/fbdev/imxfb.c | 2 +- drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +- drivers/video/fbdev/kyro/fbdev.c | 2 +- drivers/video/fbdev/leo.c | 2 +- drivers/video/fbdev/macfb.c | 2 +- drivers/video/fbdev/matrox/matroxfb_crtc2.c | 2 +- drivers/video/fbdev/maxinefb.c | 2 +- drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +- drivers/video/fbdev/mbx/mbxfb.c | 2 +- drivers/video/fbdev/metronomefb.c | 2 +- drivers/video/fbdev/mmp/fb/mmpfb.c | 2 +- drivers/video/fbdev/mx3fb.c | 5 ++-- drivers/video/fbdev/neofb.c | 2 +- drivers/video/fbdev/nvidia/nvidia.c | 2 +- drivers/video/fbdev/ocfb.c | 2 +- drivers/video/fbdev/offb.c | 2 +- drivers/video/fbdev/omap/omapfb_main.c | 2 +- .../video/fbdev/omap2/omapfb/omapfb-main.c | 2 +- drivers/video/fbdev/p9100.c | 2 +- drivers/video/fbdev/platinumfb.c | 2 +- drivers/video/fbdev/pm2fb.c | 2 +- drivers/video/fbdev/pm3fb.c | 2 +- drivers/video/fbdev/pmag-aa-fb.c | 2 +- drivers/video/fbdev/pmag-ba-fb.c | 2 +- drivers/video/fbdev/pmagb-b-fb.c | 2 +- drivers/video/fbdev/ps3fb.c | 2 +- drivers/video/fbdev/pvr2fb.c | 2 +- drivers/video/fbdev/pxa168fb.c | 2 +- drivers/video/fbdev/pxafb.c | 4 +-- drivers/video/fbdev/q40fb.c | 2 +- drivers/video/fbdev/riva/fbdev.c | 2 +- drivers/video/fbdev/s3c-fb.c | 2 +- drivers/video/fbdev/s3c2410fb.c | 2 +- drivers/video/fbdev/s3fb.c | 2 +- drivers/video/fbdev/sa1100fb.c | 2 +- drivers/video/fbdev/savage/savagefb_driver.c | 2 +- drivers/video/fbdev/sh7760fb.c | 2 +- drivers/video/fbdev/sh_mobile_lcdcfb.c | 4 +-- drivers/video/fbdev/simplefb.c | 2 +- drivers/video/fbdev/sis/sis_main.c | 2 +- drivers/video/fbdev/skeletonfb.c | 2 +- drivers/video/fbdev/sm712fb.c | 2 +- drivers/video/fbdev/smscufx.c | 3 +-- drivers/video/fbdev/ssd1307fb.c | 2 +- drivers/video/fbdev/sstfb.c | 2 +- drivers/video/fbdev/stifb.c | 2 +- drivers/video/fbdev/sunxvr1000.c | 2 +- drivers/video/fbdev/sunxvr2500.c | 2 +- drivers/video/fbdev/sunxvr500.c | 2 +- drivers/video/fbdev/tcx.c | 2 +- drivers/video/fbdev/tdfxfb.c | 2 +- drivers/video/fbdev/tgafb.c | 2 +- drivers/video/fbdev/tmiofb.c | 2 +- drivers/video/fbdev/tridentfb.c | 2 +- drivers/video/fbdev/udlfb.c | 1 - drivers/video/fbdev/uvesafb.c | 2 +- drivers/video/fbdev/valkyriefb.c | 2 +- drivers/video/fbdev/vesafb.c | 6 ++--- drivers/video/fbdev/vfb.c | 2 +- drivers/video/fbdev/vga16fb.c | 2 +- drivers/video/fbdev/vt8500lcdfb.c | 2 +- drivers/video/fbdev/vt8623fb.c | 2 +- drivers/video/fbdev/w100fb.c | 2 +- drivers/video/fbdev/wm8505fb.c | 2 +- drivers/video/fbdev/xen-fbfront.c | 2 +- drivers/video/fbdev/xilinxfb.c | 2 +- include/linux/fb.h | 2 +- samples/vfio-mdev/mdpy-fb.c | 2 +- 136 files changed, 156 insertions(+), 175 deletions(-)Signature · 1 line
2.20.1
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✓ Fi.CI.BAT: success for video, drm, etc: constify fbops in struct fb_info
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: video, drm, etc: constify fbops in struct fb_info
URL : https://patchwork.freedesktop.org/series/70198/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7444 -> Patchwork_15507
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/index.html
Known issues
------------
Here are the changes found in Patchwork_15507 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][1] ([fdo#112261]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-skl-lmem/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-skl-lmem/igt@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- fi-icl-y: [INCOMPLETE][3] ([fdo#107713]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-icl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-icl-y/igt@[email protected]
- fi-icl-u3: [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-icl-u3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-icl-u3/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][7] ([fdo#108511]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-skl-6770hq/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-skl-6770hq/igt@[email protected]
* igt@i915_selftest@live_hangcheck:
- fi-icl-dsi: [INCOMPLETE][9] ([fdo#107713] / [fdo#108569]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111045] / [fdo#111096]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-kbl-7500u/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [FAIL][13] ([fdo#103167]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-icl-u2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-icl-u2/igt@[email protected]
- fi-tgl-y: [FAIL][15] ([fdo#103167] / [fdo#112163]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-tgl-y/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-tgl-y/igt@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-x1275: [DMESG-WARN][17] ([fdo#103558] / [fdo#105602] / [fdo#105763] / [fdo#107139]) -> [DMESG-WARN][18] ([fdo#103558] / [fdo#105602] / [fdo#107139])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][19] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][20] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-kbl-x1275/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-kbl-x1275/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][21] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][22] ([fdo#103558] / [fdo#105602]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/fi-kbl-x1275/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#112163]: https://bugs.freedesktop.org/show_bug.cgi?id=112163
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
Participating hosts (52 -> 46)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7444 -> Patchwork_15507
CI-20190529: 20190529
CI_DRM_7444: b51db4a957209a27e9c5d0bbd3ce2408ccee6c2c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5318: 26ae6584ac03ad862d82f986302275a68bcccb29 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15507: b099e2f386ecf0be0776cb0c539033f30557c48b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b099e2f386ec auxdisplay: constify fb ops326eb5b2ad54 samples: vfio-mdev: constify fb opsfdb70c7d9e84 media: constify fb ops across all drivers 987933940f3d HID: picoLCD: constify fb ops248f42a2f080 video: constify fb ops across all drivers 020ee7988844 drm: constify fb ops across all drivers7ab815fd6cf7 video: fbdev: make fbops member of struct fb_info a const pointer 8d50bc4dd43a video: omapfb: use const pointer for fb_ops 388ded2e7847 video: fbmem: use const pointer for fb_ops 9c6c8c4c1374 video: fbdev: vesafb: modify the static fb_ops directly 7446468f698e video: udlfb: don't restore fb_mmap after deferred IO cleanup 6c6cef9cfbb5 video: smscufx: don't restore fb_mmap after deferred IO cleanup 77bbf1e6b593 drm/fb-helper: don't preserve fb_ops across deferred IO use 67dcc618122a video: fb_defio: preserve user fb_ops
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for video, drm, etc: constify fbops in struct fb_info
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: video, drm, etc: constify fbops in struct fb_info
URL : https://patchwork.freedesktop.org/series/70198/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7444_full -> Patchwork_15507_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15507_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_15507_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15507_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_psr@sprite_plane_onoff:
- shard-iclb: NOTRUN -> [FAIL][1] +19 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-iclb7/igt@kms_psr@sprite_plane_onoff.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@perf_pmu@frequency-idle}:
- shard-kbl: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-kbl7/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_15507_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-apl7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-apl4/igt@[email protected]
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([i915#456])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-tglb4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-tglb1/igt@[email protected]
* igt@gem_ctx_isolation@vcs1-reset:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276] / [fdo#112080])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-iclb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-iclb5/igt@[email protected]
* igt@gem_exec_reloc@basic-cpu-read-active:
- shard-skl: [PASS][9] -> [DMESG-WARN][10] ([i915#109])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl4/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-bsd2:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-iclb4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-iclb5/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-snb2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-snb6/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([i915#456] / [i915#460]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-tglb5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-tglb4/igt@[email protected]
* igt@i915_suspend@forcewake:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([i915#69])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl2/igt@[email protected]
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#34])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl8/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl6/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][21] -> [INCOMPLETE][22] ([i915#221])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack:
- shard-tglb: [PASS][23] -> [FAIL][24] ([i915#49]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-tglb1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-tglb1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-iclb: [PASS][25] -> [INCOMPLETE][26] ([i915#123] / [i915#140])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move:
- shard-tglb: [PASS][27] -> [INCOMPLETE][28] ([i915#474])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-tglb6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-tglb7/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#49])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-skl: [PASS][31] -> [INCOMPLETE][32] ([fdo#112347])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl10/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][33] -> [FAIL][34] ([fdo#108145])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#108145] / [i915#265])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl8/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl6/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-kbl7/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-kbl3/igt@[email protected]
* igt@kms_vblank@pipe-d-ts-continuation-suspend:
- shard-tglb: [PASS][39] -> [INCOMPLETE][40] ([i915#460])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-tglb6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-tglb1/igt@[email protected]
* igt@perf_pmu@busy-check-all-vcs1:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#112080]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-iclb4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-iclb5/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][43] ([i915#82]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-snb1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-snb5/igt@[email protected]
* igt@gem_exec_balancer@indices:
- shard-skl: [INCOMPLETE][45] -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl8/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl10/igt@[email protected]
* igt@gem_persistent_relocs@forked-thrashing:
- shard-snb: [FAIL][47] ([i915#520]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-snb5/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-snb7/igt@[email protected]
* igt@gem_sync@basic-store-all:
- shard-tglb: [INCOMPLETE][49] ([i915#472]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-tglb6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-tglb2/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-snb5/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-snb1/igt@[email protected]
- shard-hsw: [DMESG-WARN][53] ([fdo#111870]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-hsw5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-hsw4/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +5 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-kbl7/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-kbl1/igt@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-tglb: [INCOMPLETE][57] ([i915#456] / [i915#460]) -> [PASS][58] +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-tglb4/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-tglb8/igt@[email protected]
* igt@kms_color@pipe-a-ctm-0-25:
- shard-skl: [DMESG-WARN][59] ([i915#109]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl9/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: [INCOMPLETE][61] ([i915#140]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-tglb: [INCOMPLETE][63] ([i915#474]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-tglb8/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-tglb1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-kbl: [INCOMPLETE][65] ([fdo#103665] / [i915#634]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-kbl1/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-kbl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][67] ([i915#49]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-iclb8/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-iclb5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-iclb: [INCOMPLETE][69] ([i915#123] / [i915#140]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt:
- shard-skl: [INCOMPLETE][71] ([i915#123]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl9/igt@[email protected]
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-kbl: [INCOMPLETE][73] ([fdo#103665]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-kbl7/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-kbl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][75] ([fdo#108145]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl2/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl5/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][77] ([fdo#108145] / [i915#265]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl6/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl3/igt@[email protected]
#### Warnings ####
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [FAIL][79] ([i915#54]) -> [DMESG-FAIL][80] ([i915#180] / [i915#54])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-apl6/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-apl1/igt@[email protected]
* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-skl: [INCOMPLETE][81] ([fdo#112391]) -> [INCOMPLETE][82] ([fdo#112347])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7444/shard-skl9/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/shard-skl2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347
[fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#634]: https://gitlab.freedesktop.org/drm/intel/issues/634
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7444 -> Patchwork_15507
CI-20190529: 20190529
CI_DRM_7444: b51db4a957209a27e9c5d0bbd3ce2408ccee6c2c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5318: 26ae6584ac03ad862d82f986302275a68bcccb29 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15507: b099e2f386ecf0be0776cb0c539033f30557c48b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15507/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx