Skip to contentSkip to conversation

package/libsigrok: fix libftdi support

PATCH New Fabrice Fontaine 4 participants 5 messages Oct 28, 2019 – Oct 31, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libsigrok: fix libftdi support

libsigrok optionally depends on libftdi1 not libftdi

Fixes:
- http://autobuild.buildroot.net/results/ec1f9f57944139b24738c1be529c4fc4b128a516

---
 package/libsigrok/libsigrok.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libsigrok/libsigrok.mk +2 -2
index c65d63eb2a..aa79191e94 100644
@@ -19,9 +19,9 @@ else
 LIBSIGROK_CONF_OPTS += --without-libserialport
 endif
 
-ifeq ($(BR2_PACKAGE_LIBFTDI),y)
+ifeq ($(BR2_PACKAGE_LIBFTDI1),y)
 LIBSIGROK_CONF_OPTS += --with-libftdi
-LIBSIGROK_DEPENDENCIES += libftdi
+LIBSIGROK_DEPENDENCIES += libftdi1
 else
 LIBSIGROK_CONF_OPTS += --without-libftdi
 endif
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/libsigrok: fix libftdi support

Quoted 1 line · On Mon, 28 Oct 2019 12:24:11 +0100 Fabrice Fontaine…

libsigrok optionally depends on libftdi1 not libftdi

Is this related to a recent change? When there's issue like this, it's good to track down why/when it started occurring rather than just fixing it "blindly", potentially papering over other issues.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/libsigrok: fix libftdi support

Dear Thomas,

Le lun. 28 oct. 2019 ? 14:00, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 9 lines
Quoted 1 line · On Mon, 28 Oct 2019 12:24:11 +0100 Fabrice Fontaine…

libsigrok optionally depends on libftdi1 not libftdi

Is this related to a recent change? When there's issue like this, it's good to track down why/when it started occurring rather than just fixing it "blindly", potentially papering over other issues.

It's related to the commit 01b30e5d69f080853731736336298f6f0fdf24ce which fixes the configure options. Before this commit, this issue was not seen by the autobuilders. From my understanding libsigrok is using libftdi1 since a very long time.

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice

#3 lore raw

PATCH 1/1 package/libsigrok: fix libftdi support

In reply to Fabrice Fontaine
Quoted 6 lines · Fabrice Fontaine

libsigrok optionally depends on libftdi1 not libftdi

Fixes:
- http://autobuild.buildroot.net/results/ec1f9f57944139b24738c1be529c4fc4b128a516

Applied to master, thanks, with an extended commit log based on the explanation
you gave by mail.

Regards,
Arnout

Quoted 21 lines
---
 package/libsigrok/libsigrok.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libsigrok/libsigrok.mk +2 -2
index c65d63eb2a..aa79191e94 100644
@@ -19,9 +19,9 @@ else
 LIBSIGROK_CONF_OPTS += --without-libserialport
 endif
 
-ifeq ($(BR2_PACKAGE_LIBFTDI),y)
+ifeq ($(BR2_PACKAGE_LIBFTDI1),y)
 LIBSIGROK_CONF_OPTS += --with-libftdi
-LIBSIGROK_DEPENDENCIES += libftdi
+LIBSIGROK_DEPENDENCIES += libftdi1
 else
 LIBSIGROK_CONF_OPTS += --without-libftdi
 endif
#4 lore raw

PATCH 1/1 package/libsigrok: fix libftdi support

In reply to Fabrice Fontaine
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

libsigrok optionally depends on libftdi1 not libftdi
Fixes:
- http://autobuild.buildroot.net/results/ec1f9f57944139b24738c1be529c4fc4b128a516

Committed to 2019.02.x and 2019.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard