Skip to contentSkip to conversation

package/openvmtools: source default file

PATCH New Simon Rowe 4 participants 4 messages Sep 17, 2019 – Sep 26, 2019

lore
Share & tools
lore

Simon Rowe

author
#0 lore raw

PATCH 1/1 package/openvmtools: source default file

In the SYSV init script allow /etc/default/vmtoolsd to override $ARGS (if it present)

---
 package/openvmtools/S10vmtoolsd | 2 ++
 1 file changed, 2 insertions(+)
package/openvmtools/S10vmtoolsd +2 -0
index 6afb9ca..5fdb568 100644
@@ -7,6 +7,8 @@ EXEC="/usr/bin/vmtoolsd"
 ARGS="-b"
 PID="/var/run/vmtoolsd.pid"
 
+[ -r /etc/default/vmtoolsd ] && . /etc/default/vmtoolsd
+
 case "$1" in
   start)
     printf "Starting vmtoolsd: "
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 package/openvmtools: source default file

Hello Simon,

Quoted 7 lines · On Tue, 17 Sep 2019 10:31:41 +0100 Simon Rowe <[email protected]> wrote:

In the SYSV init script allow /etc/default/vmtoolsd to override $ARGS (if it present)

---
 package/openvmtools/S10vmtoolsd | 2 ++
 1 file changed, 2 insertions(+)

Applied to master, thanks. However, it would be nice to convert this init script to our new "template", which can be seen in package/busybox/S01syslogd.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/openvmtools: source default file

Quoted 3 lines · Thomas Petazzoni

Applied to master, thanks. However, it would be nice to convert this init script to our new "template", which can be seen in package/busybox/S01syslogd.

Sure, I create a patch for that,

Simon