Skip to contentSkip to conversation

package/hostapd: security bump version to 2.9

PATCH New Bernd Kuhls 3 participants 10 messages Aug 25, 2019 – Aug 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/hostapd: security bump version to 2.9

Fixes https://w1.fi/security/2019-6/

Release notes:
http://lists.infradead.org/pipermail/hostap/2019-April/039979.html
http://lists.infradead.org/pipermail/hostap/2019-August/040373.html

This release includes all patches from https://w1.fi/security/

---
 package/hostapd/hostapd.hash | 20 ++------------------
 package/hostapd/hostapd.mk   | 19 +------------------
 2 files changed, 3 insertions(+), 36 deletions(-)
package/hostapd/hostapd.hash +2 -18
index 8901aa43be..50225cf6d7 100644
@@ -1,20 +1,4 @@
 # Locally calculated
-sha256  21b0dda3cc3abe75849437f6b9746da461f88f0ea49dd621216936f87440a141  hostapd-2.7.tar.gz
-sha256  86979655f1c5a9578acbf83e8acdf69a36dcc0966a8819f3b6918530ad3e0c67  0001-OpenSSL-Use-constant-time-operations-for-private-big.patch
-sha256  5663da175ecc344c90bea8c95ab831ad47a8002ccbb834f6c091705b92e90e71  0002-Add-helper-functions-for-constant-time-operations.patch
-sha256  e5a6bc9f587351d4495740239ceb0a64958a59b3e875722dcaeb4c93fa517f64  0003-OpenSSL-Use-constant-time-selection-for-crypto_bignu.patch
-sha256  aa5b722bebbaf175ff89a3653c3d048afe0d0f866989fca6b4c8e882a864392a  0004-EAP-pwd-Use-constant-time-and-memory-access-for-find.patch
-sha256  bad9eeaeb118f88303a7a718820b3ba03d705e99b6183b3c44556bedf99db423  0005-SAE-Minimize-timing-differences-in-PWE-derivation.patch
-sha256  ae7be450f652f6f77ad868856ab61ba6cb6d7e768585cf5f9f9f674a66e05b40  0006-SAE-Avoid-branches-in-is_quadratic_residue_blind.patch
-sha256  86b731c787ca58ac001d20fb769b136e2ca76bf81a8465a8e72c50573cfc4b09  0007-SAE-Mask-timing-of-MODP-groups-22-23-24.patch
-sha256  ff7305005217a34818dae247886b9fb1b1db781ab31fb5eac9ebdd9cb0d1edfe  0008-SAE-Use-const_time-selection-for-PWE-in-FFC.patch
-sha256  707057cc0e60fe763350f82135dbe407bc289a4958879c8ff1e9413243a1caa4  0009-SAE-Use-constant-time-operations-in-sae_test_pwd_see.patch
-sha256  82d8ae4fabfe3674bcb5412befe3a74e40d6485906589c219be72e4fd1e70baa  0010-SAE-Fix-confirm-message-validation-in-error-cases.patch
-sha256  ff8d6d92ad4b01987be63cdaf67a24d2eba5b3cd654f37664a8a198e501c0e3b  0011-EAP-pwd-server-Verify-received-scalar-and-element.patch
-sha256  d5ebf4e5a810e9a0c035f9268195c542273998ea70fd58697ee25965094062cc  0012-EAP-pwd-server-Detect-reflection-attacks.patch
-sha256  7156656498f03b24a0b69a26a59d17a9fcc8e76761f1dabe6d13b4176ffd2ef8  0013-EAP-pwd-client-Verify-received-scalar-and-element.patch
-sha256  69926854ec2a79dada290f79f04202764c5d6400d232e3a567ebe633a02c1c66  0014-EAP-pwd-Check-element-x-y-coordinates-explicitly.patch
-sha256	cba82a051a39c48872250b2e85ca8ebc628cfe75a9ccec29f3e994abd4156152  0001-EAP-pwd-server-Fix-reassembly-buffer-handling.patch
-sha256	dc0e015463e1fd1f230795e1a49ddd1b9d00e726cd9f38846d0f4892d7978162  0003-EAP-pwd-peer-Fix-reassembly-buffer-handling.patch
+sha256  881d7d6a90b2428479288d64233151448f8990ab4958e0ecaca7eeb3c9db2bd7  hostapd-2.9.tar.gz
 sha256  e204da659d0583c71af23cb9b55536fe99598ee26a44104344f456e4d17350c6  rtlxdrv.patch
-sha256  76eeecd8fc291a71f29189ea20e6a34387b8048a959cbc6a65c41b98194643a2  README
+sha256  9da5dd0776da266b180b915e460ff75c6ff729aca1196ab396529510f24f3761  README
package/hostapd/hostapd.mk +1 -18
index e6542c879c..f55e716a7c 100644
@@ -4,25 +4,8 @@
 #
 ################################################################################
 
-HOSTAPD_VERSION = 2.7
+HOSTAPD_VERSION = 2.9
 HOSTAPD_SITE = http://w1.fi/releases
-HOSTAPD_PATCH = \
-	https://w1.fi/security/2019-1/0001-OpenSSL-Use-constant-time-operations-for-private-big.patch \
-	https://w1.fi/security/2019-1/0002-Add-helper-functions-for-constant-time-operations.patch \
-	https://w1.fi/security/2019-1/0003-OpenSSL-Use-constant-time-selection-for-crypto_bignu.patch \
-	https://w1.fi/security/2019-2/0004-EAP-pwd-Use-constant-time-and-memory-access-for-find.patch \
-	https://w1.fi/security/2019-1/0005-SAE-Minimize-timing-differences-in-PWE-derivation.patch \
-	https://w1.fi/security/2019-1/0006-SAE-Avoid-branches-in-is_quadratic_residue_blind.patch \
-	https://w1.fi/security/2019-1/0007-SAE-Mask-timing-of-MODP-groups-22-23-24.patch \
-	https://w1.fi/security/2019-1/0008-SAE-Use-const_time-selection-for-PWE-in-FFC.patch \
-	https://w1.fi/security/2019-1/0009-SAE-Use-constant-time-operations-in-sae_test_pwd_see.patch \
-	https://w1.fi/security/2019-3/0010-SAE-Fix-confirm-message-validation-in-error-cases.patch \
-	https://w1.fi/security/2019-4/0011-EAP-pwd-server-Verify-received-scalar-and-element.patch \
-	https://w1.fi/security/2019-4/0012-EAP-pwd-server-Detect-reflection-attacks.patch \
-	https://w1.fi/security/2019-4/0013-EAP-pwd-client-Verify-received-scalar-and-element.patch \
-	https://w1.fi/security/2019-4/0014-EAP-pwd-Check-element-x-y-coordinates-explicitly.patch \
-	https://w1.fi/security/2019-5/0001-EAP-pwd-server-Fix-reassembly-buffer-handling.patch \
-	https://w1.fi/security/2019-5/0003-EAP-pwd-peer-Fix-reassembly-buffer-handling.patch
 HOSTAPD_SUBDIR = hostapd
 HOSTAPD_CONFIG = $(HOSTAPD_DIR)/$(HOSTAPD_SUBDIR)/.config
 HOSTAPD_DEPENDENCIES = host-pkgconf
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 package/wpa_supplicant: security bump version to 2.9

Fixes https://w1.fi/security/2019-6/

Removed patch applied upstream:
http://w1.fi/cgit/hostap/commit/?id=f2973fa39d6109f0f34969e91551a98dc340d537

Removed all other upstream patches which are included in this release.

Release notes:
http://lists.infradead.org/pipermail/hostap/2019-April/039979.html
http://lists.infradead.org/pipermail/hostap/2019-August/040373.html

Support for the old dbus interface was removed upstream:
http://w1.fi/cgit/hostap/commit/?id=6a8dee76d4090287c016680c009b1334e01b5fbd

Removed Config.in option, removed _NEW from remaining dbus option, select BR2_PACKAGE_DBUS when needed and added Config.in.legacy options.

---
 Config.in.legacy                              | 13 ++++++
 ...pplicant-2.7-fix-undefined-remove-ie.patch | 43 -------------------
 package/wpa_supplicant/Config.in              | 20 ++++-----
 package/wpa_supplicant/wpa_supplicant.hash    | 20 +--------
 package/wpa_supplicant/wpa_supplicant.mk      | 35 ++-------------
 5 files changed, 27 insertions(+), 104 deletions(-)
 delete mode 100644 package/wpa_supplicant/0001-wpa_supplicant-2.7-fix-undefined-remove-ie.patch
Config.in.legacy +13 -0
index 190b98f5a5..4ad5c0fca9 100644
@@ -146,6 +146,19 @@ endif
 
 comment "Legacy options removed in 2019.08"
 
+config BR2_PACKAGE_WPA_SUPPLICANT_DBUS_NEW
+	bool "new dbus support option in wpa_supplicant was renamed"
+	select BR2_PACKAGE_WPA_SUPPLICANT_DBUS if BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_LEGACY
+	help
+	  The new dbus support option was renamed.
+
+config BR2_PACKAGE_WPA_SUPPLICANT_DBUS_OLD
+	bool "old dbus support in wpa_supplicant was removed"
+	select BR2_LEGACY
+	help
+	  The old dbus support was removed.
+
 config BR2_PACKAGE_LIBAMCODEC
 	bool "liamcodec package was removed"
 	select BR2_LEGACY
package/wpa_supplicant/0001-wpa_supplicant-2.7-fix-undefined-remove-ie.patch deleted +0 -43

43 lines not on this page · raw message

package/wpa_supplicant/Config.in +8 -12
index 58a074fae8..1594b877c6 100644
@@ -100,23 +100,19 @@ config BR2_PACKAGE_WPA_SUPPLICANT_PASSPHRASE
 	help
 	  Install wpa_passphrase command line utility.
 
-config BR2_PACKAGE_WPA_SUPPLICANT_DBUS_OLD
-	bool "Enable support for old DBus control interface"
-	depends on BR2_PACKAGE_DBUS
+config BR2_PACKAGE_WPA_SUPPLICANT_DBUS
+	bool "Enable support for the DBus control interface"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus
+	select BR2_PACKAGE_DBUS
 	help
-	  Enable support for old DBus control interface
-	  (fi.epitest.hostap.WPASupplicant).
+	  Enable support for the DBus control interface.
 
-config BR2_PACKAGE_WPA_SUPPLICANT_DBUS_NEW
-	bool "Enable support for new DBus control interface"
-	depends on BR2_PACKAGE_DBUS
-	help
-	  Enable support for new DBus control interface
-	  (fi.w1.wpa_supplicant1).
+comment "dbus support needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_WPA_SUPPLICANT_DBUS_INTROSPECTION
 	bool "Introspection support"
-	depends on BR2_PACKAGE_WPA_SUPPLICANT_DBUS_NEW
+	depends on BR2_PACKAGE_WPA_SUPPLICANT_DBUS
 	help
 	  Add introspection support for new DBus control interface.
 
package/wpa_supplicant/wpa_supplicant.hash +2 -18
index 2da15f7f5d..ff5a2edb34 100644
@@ -1,19 +1,3 @@
 # Locally calculated
-sha256  76ea6b06b7a2ea8e6d9eb1a9166166f1656e6d48c7508914f592100c95c73074  wpa_supplicant-2.7.tar.gz
-sha256  86979655f1c5a9578acbf83e8acdf69a36dcc0966a8819f3b6918530ad3e0c67  0001-OpenSSL-Use-constant-time-operations-for-private-big.patch
-sha256  5663da175ecc344c90bea8c95ab831ad47a8002ccbb834f6c091705b92e90e71  0002-Add-helper-functions-for-constant-time-operations.patch
-sha256  e5a6bc9f587351d4495740239ceb0a64958a59b3e875722dcaeb4c93fa517f64  0003-OpenSSL-Use-constant-time-selection-for-crypto_bignu.patch
-sha256  aa5b722bebbaf175ff89a3653c3d048afe0d0f866989fca6b4c8e882a864392a  0004-EAP-pwd-Use-constant-time-and-memory-access-for-find.patch
-sha256  bad9eeaeb118f88303a7a718820b3ba03d705e99b6183b3c44556bedf99db423  0005-SAE-Minimize-timing-differences-in-PWE-derivation.patch
-sha256  ae7be450f652f6f77ad868856ab61ba6cb6d7e768585cf5f9f9f674a66e05b40  0006-SAE-Avoid-branches-in-is_quadratic_residue_blind.patch
-sha256  86b731c787ca58ac001d20fb769b136e2ca76bf81a8465a8e72c50573cfc4b09  0007-SAE-Mask-timing-of-MODP-groups-22-23-24.patch
-sha256  ff7305005217a34818dae247886b9fb1b1db781ab31fb5eac9ebdd9cb0d1edfe  0008-SAE-Use-const_time-selection-for-PWE-in-FFC.patch
-sha256  707057cc0e60fe763350f82135dbe407bc289a4958879c8ff1e9413243a1caa4  0009-SAE-Use-constant-time-operations-in-sae_test_pwd_see.patch
-sha256  82d8ae4fabfe3674bcb5412befe3a74e40d6485906589c219be72e4fd1e70baa  0010-SAE-Fix-confirm-message-validation-in-error-cases.patch
-sha256  ff8d6d92ad4b01987be63cdaf67a24d2eba5b3cd654f37664a8a198e501c0e3b  0011-EAP-pwd-server-Verify-received-scalar-and-element.patch
-sha256  d5ebf4e5a810e9a0c035f9268195c542273998ea70fd58697ee25965094062cc  0012-EAP-pwd-server-Detect-reflection-attacks.patch
-sha256  7156656498f03b24a0b69a26a59d17a9fcc8e76761f1dabe6d13b4176ffd2ef8  0013-EAP-pwd-client-Verify-received-scalar-and-element.patch
-sha256  69926854ec2a79dada290f79f04202764c5d6400d232e3a567ebe633a02c1c66  0014-EAP-pwd-Check-element-x-y-coordinates-explicitly.patch
-sha256	cba82a051a39c48872250b2e85ca8ebc628cfe75a9ccec29f3e994abd4156152  0001-EAP-pwd-server-Fix-reassembly-buffer-handling.patch
-sha256	dc0e015463e1fd1f230795e1a49ddd1b9d00e726cd9f38846d0f4892d7978162  0003-EAP-pwd-peer-Fix-reassembly-buffer-handling.patch
-sha256  76eeecd8fc291a71f29189ea20e6a34387b8048a959cbc6a65c41b98194643a2  README
+sha256  fcbdee7b4a64bea8177973299c8c824419c413ec2e3a95db63dd6a5dc3541f17  wpa_supplicant-2.9.tar.gz
+sha256  9da5dd0776da266b180b915e460ff75c6ff729aca1196ab396529510f24f3761  README
package/wpa_supplicant/wpa_supplicant.mk +4 -31
index a518ecc217..0a7a5072dc 100644
@@ -4,25 +4,8 @@
 #
 ################################################################################
 
-WPA_SUPPLICANT_VERSION = 2.7
+WPA_SUPPLICANT_VERSION = 2.9
 WPA_SUPPLICANT_SITE = http://w1.fi/releases
-WPA_SUPPLICANT_PATCH = \
-	https://w1.fi/security/2019-1/0001-OpenSSL-Use-constant-time-operations-for-private-big.patch \
-	https://w1.fi/security/2019-1/0002-Add-helper-functions-for-constant-time-operations.patch \
-	https://w1.fi/security/2019-1/0003-OpenSSL-Use-constant-time-selection-for-crypto_bignu.patch \
-	https://w1.fi/security/2019-2/0004-EAP-pwd-Use-constant-time-and-memory-access-for-find.patch \
-	https://w1.fi/security/2019-1/0005-SAE-Minimize-timing-differences-in-PWE-derivation.patch \
-	https://w1.fi/security/2019-1/0006-SAE-Avoid-branches-in-is_quadratic_residue_blind.patch \
-	https://w1.fi/security/2019-1/0007-SAE-Mask-timing-of-MODP-groups-22-23-24.patch \
-	https://w1.fi/security/2019-1/0008-SAE-Use-const_time-selection-for-PWE-in-FFC.patch \
-	https://w1.fi/security/2019-1/0009-SAE-Use-constant-time-operations-in-sae_test_pwd_see.patch \
-	https://w1.fi/security/2019-3/0010-SAE-Fix-confirm-message-validation-in-error-cases.patch \
-	https://w1.fi/security/2019-4/0011-EAP-pwd-server-Verify-received-scalar-and-element.patch \
-	https://w1.fi/security/2019-4/0012-EAP-pwd-server-Detect-reflection-attacks.patch \
-	https://w1.fi/security/2019-4/0013-EAP-pwd-client-Verify-received-scalar-and-element.patch \
-	https://w1.fi/security/2019-4/0014-EAP-pwd-Check-element-x-y-coordinates-explicitly.patch \
-	https://w1.fi/security/2019-5/0001-EAP-pwd-server-Fix-reassembly-buffer-handling.patch \
-	https://w1.fi/security/2019-5/0003-EAP-pwd-peer-Fix-reassembly-buffer-handling.patch
 WPA_SUPPLICANT_LICENSE = BSD-3-Clause
 WPA_SUPPLICANT_LICENSE_FILES = README
 WPA_SUPPLICANT_CONFIG = $(WPA_SUPPLICANT_DIR)/wpa_supplicant/.config
@@ -115,34 +98,24 @@ WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_EAP_PWD
 WPA_SUPPLICANT_CONFIG_EDITS += 's/\#\(CONFIG_TLS=\).*/\1internal/'
 endif
 
-ifeq ($(BR2_PACKAGE_DBUS),y)
+ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DBUS),y)
 WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf dbus
 WPA_SUPPLICANT_MAKE_ENV = \
 	PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
 	PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig"
-
-ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DBUS_OLD),y)
-WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_CTRL_IFACE_DBUS=
-define WPA_SUPPLICANT_INSTALL_DBUS_OLD
-	$(INSTALL) -m 0644 -D \
-		$(@D)/wpa_supplicant/dbus/$(WPA_SUPPLICANT_DBUS_OLD_SERVICE).service \
-		$(TARGET_DIR)/usr/share/dbus-1/system-services/$(WPA_SUPPLICANT_DBUS_OLD_SERVICE).service
-endef
-endif
-
-ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DBUS_NEW),y)
 WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_CTRL_IFACE_DBUS_NEW
 define WPA_SUPPLICANT_INSTALL_DBUS_NEW
 	$(INSTALL) -m 0644 -D \
 		$(@D)/wpa_supplicant/dbus/$(WPA_SUPPLICANT_DBUS_NEW_SERVICE).service \
 		$(TARGET_DIR)/usr/share/dbus-1/system-services/$(WPA_SUPPLICANT_DBUS_NEW_SERVICE).service
 endef
-endif
 
 ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DBUS_INTROSPECTION),y)
 WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_CTRL_IFACE_DBUS_INTRO
 endif
 
+else
+WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_CTRL_IFACE_DBUS_NEW
 endif
 
 ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DEBUG_SYSLOG),y)
Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/2 package/wpa_supplicant: security bump version to 2.9

Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

Fixes https://w1.fi/security/2019-6/
Removed patch applied upstream:
http://w1.fi/cgit/hostap/commit/?id=f2973fa39d6109f0f34969e91551a98dc340d537

Removed all other upstream patches which are included in this release.

Release notes:
http://lists.infradead.org/pipermail/hostap/2019-April/039979.html
http://lists.infradead.org/pipermail/hostap/2019-August/040373.html

Quoted 7 lines

Support for the old dbus interface was removed upstream:
http://w1.fi/cgit/hostap/commit/?id=6a8dee76d4090287c016680c009b1334e01b5fbd

Removed Config.in option, removed _NEW from remaining dbus option, select BR2_PACKAGE_DBUS when needed and added Config.in.legacy options.

Committed to next, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/2 package/hostapd: security bump version to 2.9

In reply to Bernd Kuhls
Quoted 5 lines · Bernd Kuhls

Fixes https://w1.fi/security/2019-6/

Release notes:
http://lists.infradead.org/pipermail/hostap/2019-April/039979.html
http://lists.infradead.org/pipermail/hostap/2019-August/040373.html

In addition to fixing 2019-6, this release adds a ton of features. And we're
bumping two releases here... So I don't think we can classify it as a 'security bump"...

Normally we should just take the patches from https://w1.fi/security/2019-6/
like we have all those other patches. However, those patches are based on 2.8 while we still have 2.7, so they probably won't apply cleanly...

Peter, what do you think?

Regards,
Arnout

#4 lore raw

PATCH 1/2 package/hostapd: security bump version to 2.9

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 5 lines · Bernd Kuhls

Fixes https://w1.fi/security/2019-6/

Release notes:
http://lists.infradead.org/pipermail/hostap/2019-April/039979.html
http://lists.infradead.org/pipermail/hostap/2019-August/040373.html

Quoted 7 lines

In addition to fixing 2019-6, this release adds a ton of features. And we're
bumping two releases here... So I don't think we can classify it as a 'security bump"...

Normally we should just take the patches from https://w1.fi/security/2019-6/
like we have all those other patches. However, those patches are based on 2.8 while we still have 2.7, so they probably won't apply cleanly...

Indeed, that was what I initially tried when I saw the advisory.

As far as I read the advisory it is about improvements to the fixes addressed in 2019-1 and 2019-2, which only affects hostapd or wpa_supplicant built with CONFIG_SAE=y (which we don't do) or built with CONFIG_EAP_PWD=y (which we do if BR2_PACKAGE_HOSTAPD_EAP / BR2_PACKAGE_WPA_SUPPLICANT_EAP is enabled + openssl) but then ONLY if:

EAP-pwd being enabled in the runtime configuration). Note that EAP-pwd server implementation in hostapd enables only a single group at the time (pwd_group parameter) and by default, group 19 is used. As such, this would be applicable only if the pwd_group parameter is set to use one of the groups 28-30. The EAP-pwd peer implementation wpa_supplicant, follows the group selected by the server and as such, it would be vulnerable for the case where an attacker controls the authentication server (e.g., through a rogue AP) if the crypto library supports groups 28-30.

I am not sure how popular EAP-PWD is (I have personally never used it) or how difficult it is to exploit after the fixes in 2019-1 / 2019-2, but given the risks of bumping to 2.9, my feeling is that the most sensible solution would be to only apply this for next.

Anybody with more wifi knowledge (Arnout?) that disagrees?

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/2 package/hostapd: security bump version to 2.9

Quoted 17 lines · Peter Korsgaard
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 5 lines · Bernd Kuhls

Fixes https://w1.fi/security/2019-6/

Release notes:
http://lists.infradead.org/pipermail/hostap/2019-April/039979.html
http://lists.infradead.org/pipermail/hostap/2019-August/040373.html

Quoted 7 lines

In addition to fixing 2019-6, this release adds a ton of features. And we're
bumping two releases here... So I don't think we can classify it as a 'security bump"...

Normally we should just take the patches from https://w1.fi/security/2019-6/
like we have all those other patches. However, those patches are based on 2.8 while we still have 2.7, so they probably won't apply cleanly...

Quoted 5 lines

Indeed, that was what I initially tried when I saw the advisory.

As far as I read the advisory it is about improvements to the fixes addressed in 2019-1 and 2019-2, which only affects hostapd or wpa_supplicant built with CONFIG_SAE=y (which we don't do) or built with

SAE is part of WPA3, so we really *should* enable it (or offer an option for
it). And I'm pretty sure that there will be people that have out-of-tree patches to enable it.

That said...

Quoted 13 lines

CONFIG_EAP_PWD=y (which we do if BR2_PACKAGE_HOSTAPD_EAP / BR2_PACKAGE_WPA_SUPPLICANT_EAP is enabled + openssl) but then ONLY if:

EAP-pwd being enabled in the runtime configuration). Note that EAP-pwd server implementation in hostapd enables only a single group at the time (pwd_group parameter) and by default, group 19 is used. As such, this would be applicable only if the pwd_group parameter is set to use one of the groups 28-30. The EAP-pwd peer implementation wpa_supplicant, follows the group selected by the server and as such, it would be vulnerable for the case where an attacker controls the authentication server (e.g., through a rogue AP) if the crypto library supports groups 28-30.

Quoted 6 lines

I am not sure how popular EAP-PWD is (I have personally never used it) or how difficult it is to exploit after the fixes in 2019-1 / 2019-2, but given the risks of bumping to 2.9, my feeling is that the most sensible solution would be to only apply this for next.

Anybody with more wifi knowledge (Arnout?) that disagrees?

EAP-PWD is probably not used in wifi, but it might be used in practice in
802.1X setups. But 802.1X is so rare in general that I doubt that any buildroot user is actually using this.

So, I would say the SAE use case is the relevant one. And for SAE, the simple
workaround is not to enable groups 28-30 in the runtime configuration.

And I definitely agree that the 2.9 bump is too big to take in master (and
definitely LTS). So for master and LTS, I would just add a release not entry with the workaround.

Regards,
Arnout

#6 lore raw

PATCH 1/2 package/hostapd: security bump version to 2.9

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 6 lines
Quoted 1 line

Anybody with more wifi knowledge (Arnout?) that disagrees?

EAP-PWD is probably not used in wifi, but it might be used in practice in
802.1X setups. But 802.1X is so rare in general that I doubt that any buildroot user is actually using this.

Quoted 6 lines

So, I would say the SAE use case is the relevant one. And for SAE, the simple
workaround is not to enable groups 28-30 in the runtime configuration.

And I definitely agree that the 2.9 bump is too big to take in master (and
definitely LTS). So for master and LTS, I would just add a release not entry with the workaround.

Ok, so I'll apply the two security bumps to next.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 1/2 package/hostapd: security bump version to 2.9

Quoted 10 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 5 lines
Quoted 1 line

Anybody with more wifi knowledge (Arnout?) that disagrees?

EAP-PWD is probably not used in wifi, but it might be used in practice in
802.1X setups. But 802.1X is so rare in general that I doubt that any buildroot user is actually using this.

Quoted 8 lines
Quoted 6 lines

So, I would say the SAE use case is the relevant one. And for SAE, the simple
workaround is not to enable groups 28-30 in the runtime configuration.

And I definitely agree that the 2.9 bump is too big to take in master (and
definitely LTS). So for master and LTS, I would just add a release not entry with the workaround.

Ok, so I'll apply the two security bumps to next.

But don't call them security bumps :-). They're version bumps that also happen
to have security fixes.

Regards,
Arnout

#8 lore raw

PATCH 1/2 package/hostapd: security bump version to 2.9

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 4 lines
Quoted 1 line

Ok, so I'll apply the two security bumps to next.

But don't call them security bumps :-). They're version bumps that also happen
to have security fixes.

Sorry, too late for that.

Signature · 1 line
Bye, Peter Korsgaard
#9 lore raw

PATCH 1/2 package/hostapd: security bump version to 2.9

In reply to Bernd Kuhls
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

Fixes https://w1.fi/security/2019-6/
Release notes:
http://lists.infradead.org/pipermail/hostap/2019-April/039979.html
http://lists.infradead.org/pipermail/hostap/2019-August/040373.html

This release includes all patches from https://w1.fi/security/

Committed to next, thanks.

Signature · 1 line
Bye, Peter Korsgaard