Skip to contentSkip to conversation

hw/net/e1000: Fix erroneous comment

PATCH Applied Philippe Mathieu-Daudé 4 participants 4 messages Jul 15, 2019 – Aug 21, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/net/e1000: Fix erroneous comment

Missed during the QOM convertion in 9af21dbee14.

---
 hw/net/e1000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/net/e1000.c +1 -1
index 1dc1466332..ec8ded7252 100644
@@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
 
 /*
  * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
- * Note: A valid DevId will be inserted during pci_e1000_init().
+ * Note: A valid DevId will be inserted during pci_e1000_realize().
  */
 static const uint16_t e1000_eeprom_template[64] = {
     0x0000, 0x0000, 0x0000, 0x0000,      0xffff, 0x0000,      0x0000, 0x0000,
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Philippe Mathieu-Daudé

Missed during the QOM convertion in 9af21dbee14.

Ooops.

Quoted 11 lines
---
 hw/net/e1000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/net/e1000.c +0 -0
index 1dc1466332..ec8ded7252 100644

hw/net/e1000.c static const VMStateDescription vmstate_e1000 = { · line 1617

Quoted 8 lines
hw/net/e1000.c +1 -1
@@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
 
 /*
  * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
- * Note: A valid DevId will be inserted during pci_e1000_init().
+ * Note: A valid DevId will be inserted during pci_e1000_realize().
  */
 static const uint16_t e1000_eeprom_template[64] = {
     0x0000, 0x0000, 0x0000, 0x0000,      0xffff, 0x0000,      0x0000, 0x0000,
Reviewed-by on v1 1/1
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 12 lines · Philippe Mathieu-Daudé

Missed during the QOM convertion in 9af21dbee14.

---
 hw/net/e1000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/net/e1000.c +0 -0
index 1dc1466332..ec8ded7252 100644

hw/net/e1000.c static const VMStateDescription vmstate_e1000 = { · line 1617

Quoted 8 lines
hw/net/e1000.c +1 -1
@@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
 
 /*
  * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
- * Note: A valid DevId will be inserted during pci_e1000_init().
+ * Note: A valid DevId will be inserted during pci_e1000_realize().
  */
 static const uint16_t e1000_eeprom_template[64] = {
     0x0000, 0x0000, 0x0000, 0x0000,      0xffff, 0x0000,      0x0000, 0x0000,
#3 lore raw
In reply to Philippe Mathieu-Daudé

Le 15/07/2019 à 12:22, Philippe Mathieu-Daudé a écrit :

Quoted 13 lines

Missed during the QOM convertion in 9af21dbee14.

---
 hw/net/e1000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/net/e1000.c +0 -0
index 1dc1466332..ec8ded7252 100644

hw/net/e1000.c static const VMStateDescription vmstate_e1000 = { · line 1617

Quoted 8 lines
hw/net/e1000.c +1 -1
@@ -1611,7 +1611,7 @@ static const VMStateDescription vmstate_e1000 = {
 
 /*
  * EEPROM contents documented in Tables 5-2 and 5-3, pp. 98-102.
- * Note: A valid DevId will be inserted during pci_e1000_init().
+ * Note: A valid DevId will be inserted during pci_e1000_realize().
  */
 static const uint16_t e1000_eeprom_template[64] = {
     0x0000, 0x0000, 0x0000, 0x0000,      0xffff, 0x0000,      0x0000, 0x0000,

Applied to my trivial-patches branch.

Thanks,
Laurent