package/putty: disable for uClibc
PATCH 1/1 package/putty: disable for uClibc
putty now uses the futimes() BSD extension that uClibc does not implement.
Fixes:
http://autobuild.buildroot.net/results/801/801e2b2909363b5dcd9735362bb921e017569edc/
http://autobuild.buildroot.net/results/398/3984c6cdd3398645c8ad98bbe23af9090cf4bfcf/
http://autobuild.buildroot.net/results/632/632f93046f9cceffd9b604911542426c10967e0f/
--- package/putty/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
package/putty/Config.in +4 -2
@@ -3,6 +3,7 @@ config BR2_PACKAGE_PUTTY depends on BR2_USE_MMU # fork() depends on BR2_USE_WCHAR depends on !BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_USES_UCLIBC # futimes help PuTTY is a free SSH and Telnet client. Without GTK2 activated, only the commandline tools plink, pscp, psftp,
@@ -11,6 +12,7 @@ config BR2_PACKAGE_PUTTY http://www.chiark.greenend.org.uk/~sgtatham/putty/ -comment "putty needs a toolchain w/ wchar, dynamic library" +comment "putty needs a glibc or musl toolchain w/ wchar, dynamic library" depends on BR2_USE_MMU - depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS + depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \ + BR2_TOOLCHAIN_USES_UCLIBC
Signature · 1 line
2.20.1
PATCH 1/1 package/putty: disable for uClibc
Quoted 7 lines · Baruch Siach
putty now uses the
futimes()BSD extension that uClibc does not implement.Fixes:
http://autobuild.buildroot.net/results/801/801e2b2909363b5dcd9735362bb921e017569edc/
http://autobuild.buildroot.net/results/398/3984c6cdd3398645c8ad98bbe23af9090cf4bfcf/
http://autobuild.buildroot.net/results/632/632f93046f9cceffd9b604911542426c10967e0f/
Although it's true that it also eventually fails to link due to futimes(), the
actual errors in the autobuilders are about POLLRDNORM and POLLRDBAND, which require _XOPEN_SOURCE to be set.
This is quite heavy fallout for something marked as "security bump"...
Regards,
Arnout
Quoted 30 lines
Cc Alexander Dahl <[email protected]>Signed-off-by Baruch Siach <[email protected]>--- package/putty/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)package/putty/Config.in +4
-2@@ -3,6 +3,7 @@ config BR2_PACKAGE_PUTTY depends on BR2_USE_MMU # fork() depends on BR2_USE_WCHAR depends on !BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_USES_UCLIBC # futimes help PuTTY is a free SSH and Telnet client. Without GTK2 activated, only the commandline tools plink, pscp, psftp,@@ -11,6 +12,7 @@ config BR2_PACKAGE_PUTTY http://www.chiark.greenend.org.uk/~sgtatham/putty/ -comment "putty needs a toolchain w/ wchar, dynamic library" +comment "putty needs a glibc or musl toolchain w/ wchar, dynamic library" depends on BR2_USE_MMU - depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS + depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \ + BR2_TOOLCHAIN_USES_UCLIBC
PATCH 1/1 package/putty: disable for uClibc
Hi Arnout,
Quoted 9 lines · Arnout Vandecappelle
Quoted 7 lines · Baruch Siach
putty now uses the
futimes()BSD extension that uClibc does not implement.Fixes:
http://autobuild.buildroot.net/results/801/801e2b2909363b5dcd9735362bb921e017569edc/
http://autobuild.buildroot.net/results/398/3984c6cdd3398645c8ad98bbe23af9090cf4bfcf/
http://autobuild.buildroot.net/results/632/632f93046f9cceffd9b604911542426c10967e0f/
Quoted 5 lines
Although it's true that it also eventually fails to link due to
futimes(), the
actual errors in the autobuilders are about POLLRDNORM and POLLRDBAND, which require_XOPEN_SOURCEto be set.This is quite heavy fallout for something marked as "security bump"...
Indeed. Fortunately, upstream has responded promptly to my build failure report. Simon Tatham suggested a patch that fixes this issue, and another uClibc build issue for ARM.
I'll send a followup patch with these fixes.
baruch
Quoted 27 lines
Regards,
ArnoutQuoted 23 lines
Cc Alexander Dahl <[email protected]>Signed-off-by Baruch Siach <[email protected]>--- package/putty/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)package/putty/Config.in +1
-0@@ -3,6 +3,7 @@ config BR2_PACKAGE_PUTTY depends on BR2_USE_MMU # fork() depends on BR2_USE_WCHAR depends on !BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_USES_UCLIBC # futimes help PuTTY is a free SSH and Telnet client. Without GTK2 activated, only the commandline tools plink, pscp, psftp,@@ -11,6 +12,7 @@ config BR2_PACKAGE_PUTTY http://www.chiark.greenend.org.uk/~sgtatham/putty/
Quoted 7 lines
package/putty/Config.in config BR2_PACKAGE_PUTTY · line 18
Quoted 7 lines
package/putty/Config.in +3
-2-comment "putty needs a toolchain w/ wchar, dynamic library" +comment "putty needs a glibc or musl toolchain w/ wchar, dynamic library" depends on BR2_USE_MMU - depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS + depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \ + BR2_TOOLCHAIN_USES_UCLIBC
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -