drm/i915/icl: Add WaEnable32PlaneMode
Subsystems (2)
PATCH v2 1/6 drm/i915/icl: Add WaEnable32PlaneMode
Gen11 Display suports 32 planes in total. Enable the new format in context status to be used and expanded to 32 planes.
V2: Move the WA to display WA's(Chris)
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 ++++ 2 files changed, 5 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -2573,6 +2573,7 @@ enum i915_power_well_id {/* chicken reg for WaConextSwitchWithConcurrentTLBInvalidate */ #define GEN9_CSFE_CHICKEN1_RCS _MMIO(0x20D4)#define GEN9_PREEMPT_GPGPU_SYNC_SWITCH_DISABLE (1 << 2) +#define GEN11_ENABLE_32_PLANE_MODE (1 << 7)/* WaClearTdlStateAckDirtyBits */ #define GEN8_STATE_ACK _MMIO(0x20F0)
drivers/gpu/drm/i915/intel_pm.c +4 -0
@@ -8734,6 +8734,10 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)/* This is not an Wa. Enable to reduce Sampler power */ I915_WRITE (GEN10_DFR_RATIO_EN_AND_CHICKEN ,I915_READ (GEN10_DFR_RATIO_EN_AND_CHICKEN ) & ~DFR_DISABLE ); + +/* WaEnable32PlaneMode:icl */ +I915_WRITE (GEN9_CSFE_CHICKEN1_RCS , +_MASKED_BIT_ENABLE (GEN11_ENABLE_32_PLANE_MODE )); }static void cnp_init_clock_gating (struct drm_i915_private *dev_priv)
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 2/6 drm/i915/icl: Implement Display WA_1405510057
Display WA_1405510057 asks to not enable YUV 420 HDMI 10bpc when horizontal blank size mod 8 reminder is 2.
--- drivers/gpu/drm/i915/intel_hdmi.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_hdmi.c +9 -1
@@ -1592,6 +1592,8 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,struct drm_atomic_state *state = crtc_state->base.state;struct drm_connector_state *connector_state;struct drm_connector *connector; +const struct drm_display_mode *adjusted_mode = + &crtc_state->base.adjusted_mode;int i;if (HAS_GMCH_DISPLAY (dev_priv))
@@ -1640,7 +1642,13 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,/* Display WA #1139: glk */ if (bpc ==12 &&IS_GLK_REVID (dev_priv,0 ,GLK_REVID_A1 ) && - crtc_state->base.adjusted_mode.htotal >5460 ) + adjusted_mode->htotal >5460 ) +return false; + +/* Display Wa_1405510057:icl */ +if (crtc_state->ycbcr420 && bpc ==10 &&IS_ICELAKE (dev_priv) && + (adjusted_mode->crtc_hblank_end - + adjusted_mode->crtc_hblank_start) %8 ==2 )return false;return true;
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 2/6] drm/i915/icl: Implement Display WA_1405510057
Quoted 12 lines
-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Radhakrishna Sripada
Sent: Thursday, October 4, 2018 11:30 AM
To: [email protected]
Cc: Vivi, Rodrigo <[email protected]>; Zanoni, Paulo R <[email protected]>
Subject: [Intel-gfx] [PATCH v2 2/6] drm/i915/icl: Implement DisplayWA_1405510057
Quoted 8 lines
Display
WA_1405510057asks to not enable YUV 420 HDMI 10bpc when horizontal blank size mod 8 reminder is 2.Cc James Ausmus <[email protected]>Cc Paulo Zanoni <[email protected]>Cc Rodrigo Vivi <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>
Quoted 35 lines
---
drivers/gpu/drm/i915/intel_hdmi.c| 10 +++++++++-1 file changed, 9 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/intel_hdmi.c +2
-0@@ -1592,6 +1592,8 @@ static bool hdmi_deep_color_possible(const structintel_crtc_state *crtc_state, struct drm_atomic_state *state = crtc_state->base.state;struct drm_connector_state *connector_state;struct drm_connector *connector; +const struct drm_display_mode *adjusted_mode = + &crtc_state->base.adjusted_mode;int i;if (
HAS_GMCH_DISPLAY(dev_priv))drivers/gpu/drm/i915/intel_hdmi.c +7
-1@@ -1640,7 +1642,13 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,/* Display WA #1139: glk */ if (bpc == 12 && IS_GLK_REVID(dev_priv, 0, GLK_REVID_A1) && - crtc_state->base.adjusted_mode.htotal > 5460) + adjusted_mode->htotal > 5460) +return false; + +/* Display Wa_1405510057:icl */ +if (crtc_state->ycbcr420 && bpc ==10 &&IS_ICELAKE (dev_priv) && + (adjusted_mode->crtc_hblank_end - + adjusted_mode->crtc_hblank_start) %8 ==2 )return false;return true;
Quoted 7 lines
--
2.9.3_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 3/6 drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken7
In reply to Radhakrishna SripadaFrom: Oscar Mateo <[email protected]>
Required to dinamically set 'Trilinear Filter Quality Mode'
--- drivers/gpu/drm/i915/intel_workarounds.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_workarounds.c +2 -0
@@ -1009,6 +1009,8 @@ static void cnl_whitelist_build(struct whitelist *w)static void icl_whitelist_build (struct whitelist *w) { +/* WaAllowUMDToModifyHalfSliceChicken7:icl */ +whitelist_reg (w,GEN9_HALF_SLICE_CHICKEN7 ); } static struct whitelist *whitelist_build(struct intel_engine_cs *engine,
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 3/6] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken7
Quoted 16 lines · Radhakrishna Sripada
From: Oscar Mateo <[email protected]>
Required to dinamically set 'Trilinear Filter Quality Mode'
Cc Mika Kuoppala <[email protected]>Signed-off-by Oscar Mateo <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/intel_workarounds.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_workarounds.c +0
-0
drivers/gpu/drm/i915/intel_workarounds.c static void cnl_whitelist_build(struct whitelist *w) · line 1013
Quoted 5 lines
drivers/gpu/drm/i915/intel_workarounds.c +2
-0@@ -1009,6 +1009,8 @@ static void cnl_whitelist_build(struct whitelist *w)static void icl_whitelist_build (struct whitelist *w) { +/* WaAllowUMDToModifyHalfSliceChicken7:icl */ +whitelist_reg (w,GEN9_HALF_SLICE_CHICKEN7 );
Userspace consumer mesa: https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/intel/vulkan/genX_state.c#L196
Regards,
Radhakrishna(RK) Sripada
Quoted 6 lines
drivers/gpu/drm/i915/intel_workarounds.c +0
-0} static struct whitelist *whitelist_build(struct intel_engine_cs *engine,Signature · 1 line
2.9.3
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 4/6 drm/i915/icl: WaAllowUMDToModifySamplerMode
In reply to Radhakrishna SripadaFrom: Oscar Mateo <[email protected]>
Required for Bindless samplers.
--- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_workarounds.c | 3 +++ 2 files changed, 5 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +2 -0
@@ -8632,6 +8632,8 @@ enum {#define GAMW_ECO_DEV_RW_IA_REG _MMIO(0x4080)#define GAMW_ECO_DEV_CTX_RELOAD_DISABLE (1 << 7) +#define GEN10_SAMPLER_MODE _MMIO(0xE18C) +/* IVYBRIDGE DPF */ #define GEN7_L3CDERRST1 (slice) _MMIO(0xB008 + (slice) * 0x200)/* L3CD Error Status 1 */ #define GEN7_L3CDERRST1_ROW_MASK (0x7ff << 14)
drivers/gpu/drm/i915/intel_workarounds.c +3 -0
@@ -1011,6 +1011,9 @@ static void icl_whitelist_build(struct whitelist *w) {/* WaAllowUMDToModifyHalfSliceChicken7:icl */ whitelist_reg (w,GEN9_HALF_SLICE_CHICKEN7 ); + +/* WaAllowUMDToModifySamplerMode:icl */ +whitelist_reg (w,GEN10_SAMPLER_MODE ); } static struct whitelist *whitelist_build(struct intel_engine_cs *engine,
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 4/6] drm/i915/icl: WaAllowUMDToModifySamplerMode
Quoted 30 lines · Radhakrishna Sripada
From: Oscar Mateo <[email protected]>
Required for Bindless samplers.
Cc Mika Kuoppala <[email protected]>Signed-off-by Oscar Mateo <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_workarounds.c | 3 +++ 2 files changed, 5 insertions(+)drivers/gpu/drm/i915/i915_reg.h +2
-0@@ -8632,6 +8632,8 @@ enum {#define GAMW_ECO_DEV_RW_IA_REG _MMIO(0x4080)#define GAMW_ECO_DEV_CTX_RELOAD_DISABLE (1 << 7) +#define GEN10_SAMPLER_MODE _MMIO(0xE18C) +/* IVYBRIDGE DPF */ #define GEN7_L3CDERRST1 (slice) _MMIO(0xB008 + (slice) * 0x200)/* L3CD Error Status 1 */ #define GEN7_L3CDERRST1_ROW_MASK (0x7ff << 14)drivers/gpu/drm/i915/intel_workarounds.c +0
-0
drivers/gpu/drm/i915/intel_workarounds.c static void icl_whitelist_build(struct whitelist *w) · line 1016
Quoted 6 lines
drivers/gpu/drm/i915/intel_workarounds.c +3
-0@@ -1011,6 +1011,9 @@ static void icl_whitelist_build(struct whitelist *w) {/* WaAllowUMDToModifyHalfSliceChicken7:icl */ whitelist_reg (w,GEN9_HALF_SLICE_CHICKEN7 ); + +/* WaAllowUMDToModifySamplerMode:icl */ +whitelist_reg (w,GEN10_SAMPLER_MODE );
User space consumer mesa: https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/mesa/drivers/dri/i965/brw_state_upload.c#L72
Regards,
Radhakrishna(RK) Sripada
Quoted 6 lines
drivers/gpu/drm/i915/intel_workarounds.c +0
-0} static struct whitelist *whitelist_build(struct intel_engine_cs *engine,Signature · 1 line
2.9.3
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 5/6 drm/i915/icl: Add Wa_1406609255
In reply to Radhakrishna SripadaShader feature to prefetch binding tables does not support 16:6 18:8 BTP formats. Enabling fault handling could result in hangs with faults. Disabling demand prefetch would disable binding table prefetch.
V2: Fix the stepping rivision to B0(Mika)
References: HSDES#1406609255, HSDES#1406573985
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_workarounds.c | 6 ++++++ 2 files changed, 9 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -7413,6 +7413,9 @@ enum {#define GEN9_SLICE_COMMON_ECO_CHICKEN1 _MMIO(0x731c)#define GEN11_STATE_CACHE_REDIRECT_TO_CS (1 << 11) +#define GEN7_SARCHKMD _MMIO(0xB000) +#define GEN7_DISABLE_DEMAND_PREFETCH (1 << 31) +#define GEN7_L3SQCREG1 _MMIO(0xB010)#define VLV_B0_WA_L3SQCREG1_VALUE 0x00D30000
drivers/gpu/drm/i915/intel_workarounds.c +6 -0
@@ -905,6 +905,12 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)I915_WRITE (GAMT_CHKN_BIT_REG ,I915_READ (GAMT_CHKN_BIT_REG ) |GAMT_CHKN_DISABLE_L3_COH_PIPE ); + +/* Wa_1406609255:icl (pre-prod) */ +if (IS_ICL_REVID (dev_priv,ICL_REVID_A0 ,ICL_REVID_B0 )) +I915_WRITE (GEN7_SARCHKMD , +I915_READ (GEN7_SARCHKMD ) | +GEN7_DISABLE_DEMAND_PREFETCH ); }void intel_gt_workarounds_apply (struct drm_i915_private *dev_priv)
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 5/6] drm/i915/icl: Add Wa_1406609255
Quoted 9 lines · Radhakrishna Sripada
Shader feature to prefetch binding tables does not support 16:6 18:8 BTP formats. Enabling fault handling could result in hangs with faults. Disabling demand prefetch would disable binding table prefetch.
V2: Fix the stepping rivision to B0(Mika)
References: HSDES#1406609255, HSDES#1406573985
Cc Mika Kuoppala <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>
Quoted 38 lines
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_workarounds.c | 6 ++++++ 2 files changed, 9 insertions(+)drivers/gpu/drm/i915/i915_reg.h +3
-0@@ -7413,6 +7413,9 @@ enum {#define GEN9_SLICE_COMMON_ECO_CHICKEN1 _MMIO(0x731c)#define GEN11_STATE_CACHE_REDIRECT_TO_CS (1 << 11) +#define GEN7_SARCHKMD _MMIO(0xB000) +#define GEN7_DISABLE_DEMAND_PREFETCH (1 << 31) +#define GEN7_L3SQCREG1 _MMIO(0xB010)#define VLV_B0_WA_L3SQCREG1_VALUE 0x00D30000drivers/gpu/drm/i915/intel_workarounds.c +6
-0@@ -905,6 +905,12 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)I915_WRITE (GAMT_CHKN_BIT_REG ,I915_READ (GAMT_CHKN_BIT_REG ) |GAMT_CHKN_DISABLE_L3_COH_PIPE ); + +/* Wa_1406609255:icl (pre-prod) */ +if (IS_ICL_REVID (dev_priv,ICL_REVID_A0 ,ICL_REVID_B0 )) +I915_WRITE (GEN7_SARCHKMD , +I915_READ (GEN7_SARCHKMD ) | +GEN7_DISABLE_DEMAND_PREFETCH ); }void intel_gt_workarounds_apply (struct drm_i915_private *dev_priv)Signature · 1 line
2.9.3
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 5/6] drm/i915/icl: Add Wa_1406609255
In reply to Radhakrishna SripadaQuoted 9 lines · Radhakrishna Sripada
Shader feature to prefetch binding tables does not support 16:6 18:8 BTP formats. Enabling fault handling could result in hangs with faults. Disabling demand prefetch would disable binding table prefetch.
V2: Fix the stepping rivision to B0(Mika)
References: HSDES#1406609255, HSDES#1406573985
Cc Mika Kuoppala <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>
Pushed, thanks for the patch.
-Mika
Quoted 38 lines
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_workarounds.c | 6 ++++++ 2 files changed, 9 insertions(+)drivers/gpu/drm/i915/i915_reg.h +3
-0@@ -7413,6 +7413,9 @@ enum {#define GEN9_SLICE_COMMON_ECO_CHICKEN1 _MMIO(0x731c)#define GEN11_STATE_CACHE_REDIRECT_TO_CS (1 << 11) +#define GEN7_SARCHKMD _MMIO(0xB000) +#define GEN7_DISABLE_DEMAND_PREFETCH (1 << 31) +#define GEN7_L3SQCREG1 _MMIO(0xB010)#define VLV_B0_WA_L3SQCREG1_VALUE 0x00D30000drivers/gpu/drm/i915/intel_workarounds.c +6
-0@@ -905,6 +905,12 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)I915_WRITE (GAMT_CHKN_BIT_REG ,I915_READ (GAMT_CHKN_BIT_REG ) |GAMT_CHKN_DISABLE_L3_COH_PIPE ); + +/* Wa_1406609255:icl (pre-prod) */ +if (IS_ICL_REVID (dev_priv,ICL_REVID_A0 ,ICL_REVID_B0 )) +I915_WRITE (GEN7_SARCHKMD , +I915_READ (GEN7_SARCHKMD ) | +GEN7_DISABLE_DEMAND_PREFETCH ); }void intel_gt_workarounds_apply (struct drm_i915_private *dev_priv)Signature · 1 line
2.9.3
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 6/6 drm/i915/icl:Add Wa_1606682166
In reply to Radhakrishna SripadaFrom: Anuj Phogat <[email protected]>
Incorrect TDL's SSP address shift in SARB for 16:6 & 18:8 modes. Disable the Sampler state prefetch functionality in the SARB by programming 0xB000[30] to '1'. This is to be done at boot time and the feature must remain disabled permanently.
Fixes flaky tex-mip-level-selection* piglit tests with Mesa i965 driver.
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_workarounds.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -7415,6 +7415,7 @@ enum {#define GEN7_SARCHKMD _MMIO(0xB000)#define GEN7_DISABLE_DEMAND_PREFETCH (1 << 31) +#define GEN7_DISABLE_SAMPLER_PREFETCH (1 << 30)#define GEN7_L3SQCREG1 _MMIO(0xB010)#define VLV_B0_WA_L3SQCREG1_VALUE 0x00D30000
drivers/gpu/drm/i915/intel_workarounds.c +2 -1
@@ -910,7 +910,8 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)if (IS_ICL_REVID (dev_priv,ICL_REVID_A0 ,ICL_REVID_B0 ))I915_WRITE (GEN7_SARCHKMD ,I915_READ (GEN7_SARCHKMD ) | -GEN7_DISABLE_DEMAND_PREFETCH ); +GEN7_DISABLE_DEMAND_PREFETCH | +GEN7_DISABLE_SAMPLER_PREFETCH ); }void intel_gt_workarounds_apply (struct drm_i915_private *dev_priv)
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 6/6] drm/i915/icl:Add Wa_1606682166
Quoted 7 lines · Radhakrishna Sripada
From: Anuj Phogat <[email protected]>
Incorrect TDL's SSP address shift in SARB for 16:6 & 18:8 modes. Disable the Sampler state prefetch functionality in the SARB by programming 0xB000[30] to '1'. This is to be done at boot time and the feature must remain disabled permanently.
Quoted 5 lines
Fixes flaky tex-mip-level-selection* piglit tests with Mesa i965 driver.
Cc Radhakrishna Sripada <[email protected]>Signed-off-by Anuj Phogat <[email protected]>
Quoted 38 lines
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_workarounds.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -7415,6 +7415,7 @@ enum {#define GEN7_SARCHKMD _MMIO(0xB000)#define GEN7_DISABLE_DEMAND_PREFETCH (1 << 31) +#define GEN7_DISABLE_SAMPLER_PREFETCH (1 << 30)#define GEN7_L3SQCREG1 _MMIO(0xB010)#define VLV_B0_WA_L3SQCREG1_VALUE 0x00D30000drivers/gpu/drm/i915/intel_workarounds.c +2
-1@@ -910,7 +910,8 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)if (IS_ICL_REVID (dev_priv,ICL_REVID_A0 ,ICL_REVID_B0 ))I915_WRITE (GEN7_SARCHKMD ,I915_READ (GEN7_SARCHKMD ) | -GEN7_DISABLE_DEMAND_PREFETCH ); +GEN7_DISABLE_DEMAND_PREFETCH | +GEN7_DISABLE_SAMPLER_PREFETCH ); }void intel_gt_workarounds_apply (struct drm_i915_private *dev_priv)Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Mika Kuoppala
AppliedRe: [PATCH v2 6/6] drm/i915/icl:Add Wa_1606682166
In reply to Radhakrishna SripadaQuoted 7 lines · Radhakrishna Sripada
From: Anuj Phogat <[email protected]>
Incorrect TDL's SSP address shift in SARB for 16:6 & 18:8 modes. Disable the Sampler state prefetch functionality in the SARB by programming 0xB000[30] to '1'. This is to be done at boot time and the feature must remain disabled permanently.
Quoted 5 lines
Fixes flaky tex-mip-level-selection* piglit tests with Mesa i965 driver.
Cc Radhakrishna Sripada <[email protected]>Signed-off-by Anuj Phogat <[email protected]>
Pushed to dinq, thanks for the patch.
-Mika
Quoted 38 lines
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_workarounds.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -7415,6 +7415,7 @@ enum {#define GEN7_SARCHKMD _MMIO(0xB000)#define GEN7_DISABLE_DEMAND_PREFETCH (1 << 31) +#define GEN7_DISABLE_SAMPLER_PREFETCH (1 << 30)#define GEN7_L3SQCREG1 _MMIO(0xB010)#define VLV_B0_WA_L3SQCREG1_VALUE 0x00D30000drivers/gpu/drm/i915/intel_workarounds.c +2
-1@@ -910,7 +910,8 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)if (IS_ICL_REVID (dev_priv,ICL_REVID_A0 ,ICL_REVID_B0 ))I915_WRITE (GEN7_SARCHKMD ,I915_READ (GEN7_SARCHKMD ) | -GEN7_DISABLE_DEMAND_PREFETCH ); +GEN7_DISABLE_DEMAND_PREFETCH | +GEN7_DISABLE_SAMPLER_PREFETCH ); }void intel_gt_workarounds_apply (struct drm_i915_private *dev_priv)Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode
URL : https://patchwork.freedesktop.org/series/50569/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10364 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50569/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10364 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_evict:
fi-bsw-kefka: PASS -> DMESG-WARN (fdo#107709)
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167) fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#107709 https://bugs.freedesktop.org/show_bug.cgi?id=107709
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (48 -> 41) ==
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-ctg-p8600 fi-gdg-551
== Build changes ==
* Linux: CI_DRM_4932 -> Patchwork_10364
CI_DRM_4932: 21f90148bf7adb33d82580013a5697a6bbb88248 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4669: 5f40e617cd9c1e089f4a2d79c53a417d891e3e3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10364: 0e5bcb1216ffcd65716a0840a879a269e4866bbb @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
0e5bcb1216ff drm/i915/icl:Add Wa_1606682166 fd1a33cc069b drm/i915/icl: Add Wa_1406609255 a593fe319225 drm/i915/icl: WaAllowUMDToModifySamplerMode bfdffb94fd07 drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken7 914ba5ff7ca8 drm/i915/icl: Implement Display WA_1405510057 2f27b6f17cd5 drm/i915/icl: Add WaEnable32PlaneMode
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10364/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: series starting with [v2,1/6] drm/i915/icl: Add WaEnable32PlaneMode
URL : https://patchwork.freedesktop.org/series/50569/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932_full -> Patchwork_10364_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10364_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_color@pipe-b-degamma:
shard-apl: PASS -> FAIL (fdo#104782)
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-glk: PASS -> FAIL (fdo#103232) +2
shard-apl: PASS -> FAIL (fdo#103191, fdo#103232) +1
igt@kms_cursor_crc@cursor-128x42-random:
shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#103359)
igt@kms_cursor_crc@cursor-256x256-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_legacy@cursor-vs-flip-atomic:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#106538, fdo#105763)
igt@kms_cursor_legacy@flip-vs-cursor-legacy:
shard-skl: PASS -> FAIL (fdo#102670)
igt@kms_fbcon_fbt@psr:
shard-skl: NOTRUN -> FAIL (fdo#107882)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-skl: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
shard-apl: PASS -> FAIL (fdo#103167) +6
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
shard-glk: PASS -> FAIL (fdo#103167) +4
{igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb}:
shard-skl: NOTRUN -> FAIL (fdo#108145) +2
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-glk: PASS -> FAIL (fdo#103166) +1
shard-apl: PASS -> FAIL (fdo#103166) +2
igt@kms_setmode@basic:
shard-hsw: PASS -> FAIL (fdo#99912)
igt@perf@polling:
shard-hsw: PASS -> FAIL (fdo#102252)
==== Possible fixes ====
igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
shard-glk: FAIL (fdo#108145) -> PASS
igt@kms_color@pipe-a-ctm-max:
shard-apl: FAIL (fdo#108147) -> PASS
igt@kms_cursor_crc@cursor-256x256-onscreen:
shard-glk: FAIL (fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-64x21-sliding:
shard-apl: FAIL (fdo#103232) -> PASS +2
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: FAIL (fdo#105454, fdo#106509) -> PASS
igt@kms_draw_crc@draw-method-xrgb8888-render-untiled:
shard-skl: FAIL -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
shard-glk: FAIL (fdo#103167) -> PASS +1
igt@kms_plane@plane-position-covered-pipe-b-planes:
shard-glk: FAIL (fdo#103166) -> PASS
igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
shard-apl: FAIL (fdo#103166) -> PASS
igt@pm_rpm@modeset-lpsp-stress-no-wait:
shard-skl: INCOMPLETE (fdo#107807) -> PASS {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4932 -> Patchwork_10364
CI_DRM_4932: 21f90148bf7adb33d82580013a5697a6bbb88248 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4669: 5f40e617cd9c1e089f4a2d79c53a417d891e3e3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10364: 0e5bcb1216ffcd65716a0840a879a269e4866bbb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10364/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 15 lines
-----Original Message-----
From: Sripada, Radhakrishna
Sent: Thursday, October 4, 2018 11:30 AM
To: [email protected]
Cc: Sripada, Radhakrishna <[email protected]>; Chris Wilson <[email protected]>; Thierry, Michel <[email protected]>; Ausmus, James <[email protected]>; Srivatsa, Anusha <[email protected]>
Subject: [PATCH v2 1/6] drm/i915/icl: Add WaEnable32PlaneModeGen11 Display suports 32 planes in total. Enable the new format in context status to be used and expanded to 32 planes.
Quoted 7 lines
V2: Move the WA to display WA's(Chris)
Cc Chris Wilson <[email protected]>Cc Michel Thierry <[email protected]>Cc James Ausmus <[email protected]>Cc Anusha Srivatsa <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>
Quoted 33 lines
---
drivers/gpu/drm/i915/i915_reg.h| 1 +drivers/gpu/drm/i915/intel_pm.c| 4 ++++2 files changed, 5 insertions(+)drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -2573,6 +2573,7 @@ enum i915_power_well_id {/* chicken reg for WaConextSwitchWithConcurrentTLBInvalidate */ #define GEN9_CSFE_CHICKEN1_RCS _MMIO(0x20D4)#define GEN9_PREEMPT_GPGPU_SYNC_SWITCH_DISABLE (1 << 2) +#define GEN11_ENABLE_32_PLANE_MODE (1 << 7)/* WaClearTdlStateAckDirtyBits */ #define GEN8_STATE_ACK _MMIO(0x20F0)drivers/gpu/drm/i915/intel_pm.c +4
-0@@ -8734,6 +8734,10 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)/* This is not an Wa. Enable to reduce Sampler power */ I915_WRITE (GEN10_DFR_RATIO_EN_AND_CHICKEN , I915_READ(GEN10_DFR_RATIO_EN_AND_CHICKEN) & ~DFR_DISABLE); + +/* WaEnable32PlaneMode:icl */ +I915_WRITE (GEN9_CSFE_CHICKEN1_RCS , +_MASKED_BIT_ENABLE (GEN11_ENABLE_32_PLANE_MODE )); }
Quoted 3 lines
static void
cnp_init_clock_gating(struct drm_i915_private *dev_priv)--
2.9.3
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx