Skip to contentSkip to conversation

skalibs: fix endianness detection on x86

PATCH New Eric Le Bihan 3 participants 3 messages Mar 20, 2017 – Mar 30, 2017

lore
Share & tools
lore

Eric Le Bihan

author
#0 lore raw

PATCH 1/1 skalibs: fix endianness detection on x86

Update the patch for compile time endianness detection so it works on x86 platforms using GCC <= 4.4.

Fixes:

http://autobuild.buildroot.net/results/c2e8e1180571976b412cbba729c45a3698aea0b2
http://autobuild.buildroot.net/results/2ee47107d8a67470f7bc3e10cf763202d5455d17

Signed-off-by Eric Le Bihan <[email protected]>
---
 .../skalibs/0001-No-runtime-tests-for-endianness.patch  | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
package/skalibs/0001-No-runtime-tests-for-endianness.patch +10 -7
index 4390d44..5f763c4 100644
@@ -1,6 +1,6 @@
-From 1e6f0b094c6ce6454be572704b866d2ce0962e59 Mon Sep 17 00:00:00 2001
+From 6754b208e7ec3bd1d4265db18fa4c0e7961a77bf Mon Sep 17 00:00:00 2001
 From: Eric Le Bihan <[email protected]>
-Date: Sun, 4 Dec 2016 19:10:40 +0100
+Date: Mon, 20 Mar 2017 20:05:00 +0100
 Subject: [PATCH] No runtime tests for endianness
 
 Replace build and execution of runtime test programs for determining

@@ -12,8 +12,8 @@ Signed-off-by: Eric Le Bihan <[email protected]>
 ---
  configure                     | 15 +++++++++++----
  src/sysdeps/trybigendian.c    | 16 ++++++++++++++++
- src/sysdeps/trylittleendian.c | 16 ++++++++++++++++
- 3 files changed, 43 insertions(+), 4 deletions(-)
+ src/sysdeps/trylittleendian.c | 19 +++++++++++++++++++
+ 3 files changed, 46 insertions(+), 4 deletions(-)
  create mode 100644 src/sysdeps/trybigendian.c
  create mode 100644 src/sysdeps/trylittleendian.c
 

@@ -70,16 +70,19 @@ index 0000000..d857572
 +}
 diff --git a/src/sysdeps/trylittleendian.c b/src/sysdeps/trylittleendian.c
 new file mode 100644
-index 0000000..eba065a
+index 0000000..68b93c1
 --- /dev/null
 +++ b/src/sysdeps/trylittleendian.c
-@@ -0,0 +1,16 @@
+@@ -0,0 +1,19 @@
 +#if defined(__BYTE_ORDER) && (__BYTE_ORDER == __LITTLE_ENDIAN) ||	\
 +	defined(__BYTE_ORDER__) && (__BYTE_ORDER__  == __ORDER_LITTLE_ENDIAN__) || \
 +	defined(__LITTLE_ENDIAN) ||					\
 +	defined(__ARMEL__) ||						\
 +	defined(__THUMBEL__) ||					\
 +	defined(__AARCH64EL__) ||					\
++	defined(__i386) || defined(__i386__) ||			\
++	defined(__amd64) || defined(__amd64__) ||			\
++	defined(__x86_64) || defined(__x86_64__) ||			\
 +	defined(_MIPSEL) || defined(__MIPSEL) || defined(__MIPSEL__)
 +#define YEAH
 +#else

@@ -91,5 +94,5 @@ index 0000000..eba065a
 +	return 0;
 +}
 -- 
-2.5.5
+2.1.4
Signature · 1 line
2.9.3
Applied
#1 lore raw

PATCH 1/1 skalibs: fix endianness detection on x86

Hello,

Quoted 5 lines · Eric Le Bihan

Update the patch for compile time endianness detection so it works on x86 platforms using GCC <= 4.4.

Fixes:

Quoted 7 lines

http://autobuild.buildroot.net/results/c2e8e1180571976b412cbba729c45a3698aea0b2
http://autobuild.buildroot.net/results/2ee47107d8a67470f7bc3e10cf763202d5455d17

Signed-off-by Eric Le Bihan <[email protected]>
---
 .../skalibs/0001-No-runtime-tests-for-endianness.patch  | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 skalibs: fix endianness detection on x86

In reply to Eric Le Bihan
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Eric" == Eric Le Bihan <[email protected]> writes:

Update the patch for compile time endianness detection so it works on x86 platforms using GCC <= 4.4.

Fixes:

http://autobuild.buildroot.net/results/c2e8e1180571976b412cbba729c45a3698aea0b2
http://autobuild.buildroot.net/results/2ee47107d8a67470f7bc3e10cf763202d5455d17

Signed-off-by Eric Le Bihan <[email protected]>

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard