syslog-ng: Specify location of libesmtp

PATCH New Chris Packham 4 participants 9 messages Oct 20, 2015 – Oct 21, 2015

Share & tools

Chris Packham

author

2015-10-20 08:16 UTC #0 lore raw

PATCH 1/1 syslog-ng: Specify location of libesmtp

If --with-libesmtp is omitted a host tool is invoked to detect the location of the library and headers, which is obviously the wrong thing for a cross-compile environment. Explicitly add --with-libesmtp to resolve this.

Fixes:
http://git.buildroot.net/buildroot/commit/?id=539acb7500588d0a277357cf831c9f25f770578d
http://git.buildroot.net/buildroot/commit/?id=01f41585a78406f6e830d5eaf4413a983812a299

Signed-off-by Chris Packham <[email protected]>

---
 package/syslog-ng/syslog-ng.mk | 1 +
 1 file changed, 1 insertion(+)

package/syslog-ng/syslog-ng.mk +1 -0

index 7371060..2bbace8 100644
@@ -37,6 +37,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBESMTP),y)
 SYSLOG_NG_DEPENDENCIES += libesmtp
 SYSLOG_NG_CONF_OPTS += --enable-smtp
+SYSLOG_NG_CONF_OPTS += --with-libesmtp="$(STAGING_DIR)/usr"
 else
 SYSLOG_NG_CONF_OPTS += --disable-smtp
 endif

Signature · 1 line

2.5.3

Peter Korsgaard

2015-10-20 09:36 UTC #1 lore raw

PATCH 1/1 syslog-ng: Specify location of libesmtp

Quoted 7 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Chris" == Chris Packham <[email protected]> writes:
If --with-libesmtp is omitted a host tool is invoked to detect the location of the library and headers, which is obviously the wrong thing for a cross-compile environment. Explicitly add --with-libesmtp to resolve this.

Quoted 5 lines

Fixes:
http://git.buildroot.net/buildroot/commit/?id=539acb7500588d0a277357cf831c9f25f770578d
http://git.buildroot.net/buildroot/commit/?id=01f41585a78406f6e830d5eaf4413a983812a299
Signed-off-by Chris Packham <[email protected]>

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard

Chris Packham

author

2015-10-20 09:40 UTC #2 lore raw

PATCH 1/1 syslog-ng: Specify location of libesmtp

Hi Peter,

Quoted 10 lines · Peter Korsgaard

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Chris" == Chris Packham <[email protected]> writes:
If --with-libesmtp is omitted a host tool is invoked to detect the location of the library and headers, which is obviously the wrong thing for a cross-compile environment. Explicitly add --with-libesmtp to resolve this.
Fixes:
http://git.buildroot.net/buildroot/commit/?id=539acb7500588d0a277357cf831c9f25f770578d
http://git.buildroot.net/buildroot/commit/?id=01f41585a78406f6e830d5eaf4413a983812a299

Oops this is the url of the HEAD commit not the url of the build result. This should have been

http://autobuild.buildroot.net/results/b82/b8224ea52d962c62ead367343d68bf98a4b9e883/
http://autobuild.buildroot.net/results/445/445270aed4c79cde75d54d49d13ffad9d684c61b/

Probably doesn't matter but If you want you could revert and fix up the commit message to correct the URL.

Peter Korsgaard

2015-10-20 10:03 UTC #3 lore raw

PATCH 1/1 syslog-ng: Specify location of libesmtp

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Chris" == Chris Packham <[email protected]> writes:

Hi,

Quoted 5 lines

Quoted 4 lines
Quoted 4 lines
Fixes:
http://git.buildroot.net/buildroot/commit/?id=539acb7500588d0a277357cf831c9f25f770578d
http://git.buildroot.net/buildroot/commit/?id=01f41585a78406f6e830d5eaf4413a983812a299

Quoted 8 lines

Oops this is the url of the HEAD commit not the url of the build result. This should have been
http://autobuild.buildroot.net/results/b82/b8224ea52d962c62ead367343d68bf98a4b9e883/
http://autobuild.buildroot.net/results/445/445270aed4c79cde75d54d49d13ffad9d684c61b/
Probably doesn't matter but If you want you could revert and fix up the commit message to correct the URL.

Gaah, you're right - I can't believe I didn't notice that :/

I'll leave it as it is.

Signature · 2 lines

Venlig hilsen,
Peter Korsgaard

Peter Seiderer

2015-10-20 18:57 UTC #4 lore raw

PATCH 1/1 syslog-ng: Specify location of libesmtp

In reply to Chris Packham

Hello Chris,

Quoted 19 lines · Chris Packham

If --with-libesmtp is omitted a host tool is invoked to detect the location of the library and headers, which is obviously the wrong thing for a cross-compile environment. Explicitly add --with-libesmtp to resolve this.
Fixes:
http://git.buildroot.net/buildroot/commit/?id=539acb7500588d0a277357cf831c9f25f770578d
http://git.buildroot.net/buildroot/commit/?id=01f41585a78406f6e830d5eaf4413a983812a299
Signed-off-by Chris Packham <[email protected]>
---
 package/syslog-ng/syslog-ng.mk | 1 +
 1 file changed, 1 insertion(+)
package/syslog-ng/syslog-ng.mk +0 -0
index 7371060..2bbace8 100644

package/syslog-ng/syslog-ng.mk endif · line 43

Quoted 7 lines

package/syslog-ng/syslog-ng.mk +1 -0

@@ -37,6 +37,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBESMTP),y)
 SYSLOG_NG_DEPENDENCIES += libesmtp
 SYSLOG_NG_CONF_OPTS += --enable-smtp
+SYSLOG_NG_CONF_OPTS += --with-libesmtp="$(STAGING_DIR)/usr"
 else
 SYSLOG_NG_CONF_OPTS += --disable-smtp
 endif

The buildroot package libestmp provides a libesmtp-config script, but it is installed into

host/usr/arm-buildroot-linux-gnueabi/sysroot/usr/bin/libesmtp-config

where it is not found by the syslog-ng configure script...

Would a more portable solution be to add this search path (or fix the install location of libestmp-config) for the syslog-ng configure call (libesmtp-config --libs gives '-pthread -L[...]/host/usr/arm-buildroot-linux-gnueabi/sysroot/usr/lib -lesmtp -lssl -lcrypto -ldl')?

Regards,
Peter

Peter Korsgaard

2015-10-20 19:32 UTC #5 lore raw

PATCH 1/1 syslog-ng: Specify location of libesmtp

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Seiderer <[email protected]> writes:

Hi,

Quoted 9 lines

Quoted 2 lines
SYSLOG_NG_CONF_OPTS += --disable-smtp
endif
The buildroot package libestmp provides a libesmtp-config script, but it is installed into
host/usr/arm-buildroot-linux-gnueabi/sysroot/usr/bin/libesmtp-config
where it is not found by the syslog-ng configure script...

Yes, $(STAGING_DIR)/usr/bin, similar to the other *-config scripts.

Quoted 4 lines

Would a more portable solution be to add this search path (or fix the install location of libestmp-config) for the syslog-ng configure call (libesmtp-config --libs gives '-pthread -L[...]/host/usr/arm-buildroot-linux-gnueabi/sysroot/usr/lib -lesmtp -lssl -lcrypto -ldl')?

$(STAGING_DIR)/usr/bin contains binaries for the target (and *-config scripts), so it shouldn't be added to the path, but another approach is indeed to fix the configure script to look elsewhere for the script, similar to how a bunch of packages allow the path to sdl-config to be overridden through the SDL_CONFIG environment variable.

Signature · 1 line

Bye, Peter Korsgaard

Chris Packham

author

2015-10-21 07:41 UTC #6 lore raw

PATCH 1/1 syslog-ng: Specify location of libesmtp

Quoted 21 lines · Peter Korsgaard

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Seiderer <[email protected]> writes:
Hi,
Quoted 9 lines
Quoted 2 lines
SYSLOG_NG_CONF_OPTS += --disable-smtp
endif
The buildroot package libestmp provides a libesmtp-config script, but it is installed into
host/usr/arm-buildroot-linux-gnueabi/sysroot/usr/bin/libesmtp-config
where it is not found by the syslog-ng configure script...
Yes, $(STAGING_DIR)/usr/bin, similar to the other *-config scripts.
Quoted 4 lines
Would a more portable solution be to add this search path (or fix the install location of libestmp-config) for the syslog-ng configure call (libesmtp-config --libs gives '-pthread -L[...]/host/usr/arm-buildroot-linux-gnueabi/sysroot/usr/lib -lesmtp -lssl -lcrypto -ldl')?

Quoted 5 lines

$(STAGING_DIR)/usr/bin contains binaries for the target (and *-config scripts), so it shouldn't be added to the path, but another approach is indeed to fix the configure script to look elsewhere for the script, similar to how a bunch of packages allow the path to sdl-config to be overridden through the SDL_CONFIG environment variable.

The way the test is implemented in configure.ac libestmp-config is invoked directly so it would need to be on the path. Or I could look at an upstream patch to change this to something that can be overridden. I'd almost prefer if libesmtp had pkg-config support which integrates better with autotools and buildroot has existing support for.

Thomas Petazzoni

2015-10-21 08:27 UTC #7 lore raw

PATCH 1/1 syslog-ng: Specify location of libesmtp

Dear Chris Packham,

Quoted 6 lines · Chris Packham

The way the test is implemented in configure.ac libestmp-config is invoked directly so it would need to be on the path. Or I could look at an upstream patch to change this to something that can be overridden. I'd almost prefer if libesmtp had pkg-config support which integrates better with autotools and buildroot has existing support for.

As Peter suggested, the way we usually fix that is by replacing the direct invocation of <foo>-config in configure.ac by ${FOO_CONFIG:foo-config}, so that it can be overridden in the environment.

However, the current --with-<foo> solution that you have used is fine for me. We do use this solution for numerous packages, so I'm fine with using it as well for syslog-ng.

Best regards,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Peter Korsgaard

2015-10-21 09:45 UTC #8 lore raw

PATCH 1/1 syslog-ng: Specify location of libesmtp

Quoted 12 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Dear Chris Packham,
Quoted 6 lines · Chris Packham
The way the test is implemented in configure.ac libestmp-config is invoked directly so it would need to be on the path. Or I could look at an upstream patch to change this to something that can be overridden. I'd almost prefer if libesmtp had pkg-config support which integrates better with autotools and buildroot has existing support for.

Quoted 8 lines

As Peter suggested, the way we usually fix that is by replacing the direct invocation of <foo>-config in configure.ac by ${FOO_CONFIG:foo-config}, so that it can be overridden in the environment.
However, the current --with-<foo> solution that you have used is fine for me. We do use this solution for numerous packages, so I'm fine with using it as well for syslog-ng.

Agreed. The only potential issue is for static linking as libestmp-config --libs may return more libraries than the hardcoded -lesmtp, but I guess the autobuilders will tell us if that is the case.

Signature · 2 lines

Venlig hilsen,
Peter Korsgaard