Skip to contentSkip to conversation

b43: fix support for 5 GHz only BCM43228 model

PATCH RESEND Superseded Kalle Valo 2 participants 6 messages Mar 3, 2015 2 messages not in the archive Networking drivers (wireless)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Kalle Valo

author Applied
#2 lore raw

PATCH RESEND 1/1 b43: fix support for 5 GHz only BCM43228 model

Quoted 6 lines · Rafa? Mi?ecki

It was incorrectly detected as 2 GHz device.

Signed-off-by Rafa? Mi?ecki <[email protected]>
Cc stable at vger.kernel.org # 3.17+

---
Kalle: can you take it for 3.20, please?

Thanks, applied to wireless-drivers.git.

Quoted 1 line

RESEND: It seems patchwork didn't catch my patch. Trying again.

Odd, I still don't see it in patchwork. I wonder what caused that?

Signature · 1 line
Kalle Valo
#3 lore raw

PATCH RESEND 1/1 b43: fix support for 5 GHz only BCM43228 model

Quoted 3 lines · Kalle Valo
Quoted 1 line

RESEND: It seems patchwork didn't catch my patch. Trying again.

Odd, I still don't see it in patchwork. I wonder what caused that?

I also see it neither in my b43-dev nor linux-wireless archives, nor does google find it (only your reply).

Jonas

author
#4 lore raw

PATCH RESEND 1/1 b43: fix support for 5 GHz only BCM43228 model

Quoted 7 lines · Jonas Gorski
Quoted 3 lines · Kalle Valo
Quoted 1 line

RESEND: It seems patchwork didn't catch my patch. Trying again.

Odd, I still don't see it in patchwork. I wonder what caused that?

I also see it neither in my b43-dev nor linux-wireless archives, nor does google find it (only your reply).

Ok, that explains why patchwork didn't catch it (it scans patches from the linux-wireless mailing list). I already applied the patch to wireless-drivers.git but I would appreciate if people would still review it:

commit 0ff66cffde47de51c155ebdd2356403276c04cc4

Author: Rafa? Mi?ecki <[email protected]>
Date:   Mon Mar 2 17:18:55 2015 +0100

b43: fix support for 5 GHz only BCM43228 model

It was incorrectly detected as 2 GHz device.

Signed-off-by Rafa? Mi?ecki <[email protected]>
Cc stable at vger.kernel.org # 3.17+
Signed-off-by Kalle Valo <[email protected]>
drivers/net/wireless/b43/main.c +1 -0
index ccbdb05b28cd..75345c1e8c34 100644
@@ -5370,6 +5370,7 @@ static void b43_supported_bands(struct b43_wldev *dev, bool *have_2ghz_phy,
 	case 0x432a: /* BCM4321 */
 	case 0x432d: /* BCM4322 */
 	case 0x4352: /* BCM43222 */
+	case 0x435a: /* BCM43228 */
 	case 0x4333: /* BCM4331 */
 	case 0x43a2: /* BCM4360 */
 	case 0x43b3: /* BCM4352 */
Signature · 1 line
Kalle Valo
#5 lore raw

PATCH RESEND 1/1 b43: fix support for 5 GHz only BCM43228 model

Quoted 32 lines · Kalle Valo
Quoted 7 lines · Jonas Gorski
Quoted 3 lines · Kalle Valo
Quoted 1 line

RESEND: It seems patchwork didn't catch my patch. Trying again.

Odd, I still don't see it in patchwork. I wonder what caused that?

I also see it neither in my b43-dev nor linux-wireless archives, nor does google find it (only your reply).

Ok, that explains why patchwork didn't catch it (it scans patches from the linux-wireless mailing list). I already applied the patch to wireless-drivers.git but I would appreciate if people would still review it:

commit 0ff66cffde47de51c155ebdd2356403276c04cc4

Author: Rafa? Mi?ecki <[email protected]>
Date:   Mon Mar 2 17:18:55 2015 +0100

b43: fix support for 5 GHz only BCM43228 model

It was incorrectly detected as 2 GHz device.

Signed-off-by Rafa? Mi?ecki <[email protected]>
Cc stable at vger.kernel.org # 3.17+
Signed-off-by Kalle Valo <[email protected]>
drivers/net/wireless/b43/main.c +0 -0
index ccbdb05b28cd..75345c1e8c34 100644

drivers/net/wireless/b43/main.c static void b43_supported_bands(struct b43_wldev *dev, bool *have_2ghz_phy, · line 5373

Quoted 4 lines
drivers/net/wireless/b43/main.c +1 -0
@@ -5370,6 +5370,7 @@ static void b43_supported_bands(struct b43_wldev *dev, bool *have_2ghz_phy,
        case 0x432a: /* BCM4321 */
        case 0x432d: /* BCM4322 */
        case 0x4352: /* BCM43222 */
+       case 0x435a: /* BCM43228 */

Broadcom agrees with that (taken from a broadcom sdk for bcm47xx):

#define BCM43228_D11N_ID 0x4359 /* 43228 802.11n
DualBand device */
#define BCM43228_D11N5G_ID 0x435a /* 43228 802.11n 5GHz device */

If that's enough for you, feel free to add a Reviewed-By from me.

Jonas

#6 lore raw

PATCH RESEND 1/1 b43: fix support for 5 GHz only BCM43228 model

Quoted 1 line · Jonas Gorski

If that's enough for you, feel free to add a Reviewed-By from me.

Obviously you can't since you already applied it, so just add it in your head ;-)

Jonas

author
#7 lore raw

PATCH RESEND 1/1 b43: fix support for 5 GHz only BCM43228 model

Quoted 5 lines · Jonas Gorski
Quoted 1 line · Jonas Gorski

If that's enough for you, feel free to add a Reviewed-By from me.

Obviously you can't since you already applied it, so just add it in your head ;-)

Yeah, the train has left the station. But thanks for double checking, I can sleep safer now :)

Signature · 1 line
Kalle Valo