Skip to contentSkip to conversation

package/bdwgc: only enable on supported architectures

PATCH New Yann E. MORIN 3 participants 3 messages Dec 1, 2014 – Dec 2, 2014

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH v2 1/1 package/bdwgc: only enable on supported architectures

bdwgc has support for a sub-set of the architectures we support.

Since there is roughly a 50-50 split of our architectures that have support in bdwgc vs. those that do not, use a positive dependency logic, rather than a negative one.

The list was constructed by visual inspection of the source code of bdwgc, but the header doing the check is, to say it politely, a bit difficult to read...

So, some working archotectures may be missing. Users needing it may investigate if their architectures are indeed supported.

Fixes;
    http://autobuild.buildroot.net/results/529/529b0b6dd47744c13f56e59a4c669a3f5d56530d/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Pedro Aguilar <[email protected]>
Cc Baruch Siach <[email protected]>

---
Changes v1 -> v2:
- fix case for mipsel (Baruch)

---
 package/bdwgc/Config.in | 7 +++++++
 package/bdwgc/bdwgc.mk  | 2 ++
 package/guile/Config.in | 1 +
 3 files changed, 10 insertions(+)
package/bdwgc/Config.in +7 -0
index 9aa7c7d..215c54d 100644
@@ -1,5 +1,12 @@
+config BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
+	default y
+	depends on BR2_arm || BR2_armeb || BR2_avr32 || BR2_i386 \
+		|| BR2_mips || BR2_mipsel || BR2_powerpc || BR2_sh \
+		|| BR2_sparc || BR2_x86_64
+
 config BR2_PACKAGE_BDWGC
 	bool "bdwgc"
+	depends on BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS
 	select BR2_PACKAGE_LIBATOMIC_OPS
 	help
package/bdwgc/bdwgc.mk +2 -0
index 3e6de1a..b408947 100644
@@ -4,6 +4,8 @@
 #
 ################################################################################
 
+# When bumping the version number, check if the list of supported architectures
+# is still valid; see Config.log.
 BDWGC_VERSION = 7.2f
 BDWGC_SOURCE = gc-$(BDWGC_VERSION).tar.gz
 BDWGC_SITE = http://www.hboehm.info/gc/gc_source
package/guile/Config.in +1 -0
index 009dbdf..8f86e9f 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_GUILE
 	bool "guile"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_PACKAGE_BDWGC_ARCH_SUPPORTS # bdwgc
 	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS # bdwgc
 	depends on BR2_USE_WCHAR # libunistring
 	select BR2_PACKAGE_LIBUNISTRING
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 package/bdwgc: only enable on supported architectures

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

bdwgc has support for a sub-set of the architectures we support. Since there is roughly a 50-50 split of our architectures that have support in bdwgc vs. those that do not, use a positive dependency logic, rather than a negative one.

The list was constructed by visual inspection of the source code of bdwgc, but the header doing the check is, to say it politely, a bit difficult to read...

So, some working archotectures may be missing. Users needing it may investigate if their architectures are indeed supported.

Quoted 6 lines
Fixes;
    http://autobuild.buildroot.net/results/529/529b0b6dd47744c13f56e59a4c669a3f5d56530d/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Pedro Aguilar <[email protected]>
Cc Baruch Siach <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v2 1/1 package/bdwgc: only enable on supported architectures

In reply to Yann E. MORIN

Hi Yann,

Thanks for checking this. I had a look at the not-easy-to-read source code and I confirm that the archs you added should be right.

I've tested it successfully under arm.

Regards.

Quoted 72 lines · Yann E. MORIN

bdwgc has support for a sub-set of the architectures we support.

Since there is roughly a 50-50 split of our architectures that have support in bdwgc vs. those that do not, use a positive dependency logic, rather than a negative one.

The list was constructed by visual inspection of the source code of bdwgc, but the header doing the check is, to say it politely, a bit difficult to read...

So, some working archotectures may be missing. Users needing it may investigate if their architectures are indeed supported.

Fixes;
     http://autobuild.buildroot.net/results/529/529b0b6dd47744c13f56e59a4c669a3f5d56530d/
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Pedro Aguilar <[email protected]>
Cc Baruch Siach <[email protected]>

---
Changes v1 -> v2:
- fix case for mipsel (Baruch)

---
  package/bdwgc/Config.in | 7 +++++++
  package/bdwgc/bdwgc.mk  | 2 ++
  package/guile/Config.in | 1 +
  3 files changed, 10 insertions(+)
package/bdwgc/Config.in +7 -0
index 9aa7c7d..215c54d 100644
@@ -1,5 +1,12 @@
+config BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
+	default y
+	depends on BR2_arm || BR2_armeb || BR2_avr32 || BR2_i386 \
+		|| BR2_mips || BR2_mipsel || BR2_powerpc || BR2_sh \
+		|| BR2_sparc || BR2_x86_64
+
  config BR2_PACKAGE_BDWGC
  	bool "bdwgc"
+	depends on BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
  	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS
  	select BR2_PACKAGE_LIBATOMIC_OPS
  	help
package/bdwgc/bdwgc.mk +2 -0
index 3e6de1a..b408947 100644
@@ -4,6 +4,8 @@
  #
  ################################################################################
 
+# When bumping the version number, check if the list of supported architectures
+# is still valid; see Config.log.
  BDWGC_VERSION = 7.2f
  BDWGC_SOURCE = gc-$(BDWGC_VERSION).tar.gz
  BDWGC_SITE = http://www.hboehm.info/gc/gc_source
package/guile/Config.in +1 -0
index 009dbdf..8f86e9f 100644
@@ -1,6 +1,7 @@
  config BR2_PACKAGE_GUILE
  	bool "guile"
  	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_PACKAGE_BDWGC_ARCH_SUPPORTS # bdwgc
  	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS # bdwgc
  	depends on BR2_USE_WCHAR # libunistring
  	select BR2_PACKAGE_LIBUNISTRING
Signature · 2 lines
Pedro Aguilar
http://paguilar.org