Skip to contentSkip to conversation

uclibc: reinstate support for version 0.9.31

PATCH Superseded spdawson at gmail.com 2 participants 3 messages Nov 6, 2013 – Nov 7, 2013

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 uclibc: reinstate support for version 0.9.31

From: Simon Dawson <[email protected]>

This patch reinstates support for uClibc version 0.9.31, which was removed from Buildroot in commit 8abb5b33c1aae035cf48b1c81104b433ff884c64

---
v4: As suggested by Thomas Petazzoni, make 0.9.31 avr32-only, and disable
other uClibc versions for avr32
v3: Rebase on top of current master
v2: Resend original RFC patch, no changes

 package/connman/Config.in                          |    4 +-
 package/libglib2/libglib2.mk                       |    2 +-
 .../uClibc-0001-add-bsd-endian-conversions.patch   |   64 +
 .../0.9.31.1/uClibc-0002-add-inotify-init1.patch   |   64 +
 .../0.9.31.1/uClibc-0003-add-sock-cloexec.patch    |   43 +
 .../0.9.31.1/uClibc-0004-export-strverscmp.patch   |   30 +
 ...bc-0005-fix-daylight-saving-time-handling.patch |   36 +
 .../uClibc-0006-fix-error-locale-utf-8.patch       |   17 +
 ...Clibc-0007-fix-fcntl64-for-64-bit-targets.patch |   34 +
 .../uClibc-0008-linuxthreads-errno-fix.patch       |   98 +
 .../uClibc-0009-more-workarounds-GCC-PR32219.patch |   40 +
 .../0.9.31.1/uClibc-0010-powerpc-ptrace-fix.patch  |   62 +
 .../0.9.31.1/uClibc-0011-quad-routines.patch       | 7393 ++++++++++++++++++++
 .../0.9.31.1/uClibc-0012-sparc-errno-fix.patch     |   11 +
 package/uclibc/0.9.31.1/uClibc-0013-unshare.patch  |   74 +
 .../uClibc-0014-workaround-GCC-PR32219.patch       |   57 +
 .../uClibc-0015-startfiles-Make-targets.patch      |   60 +
 package/uclibc/Config.in                           |   11 +-
 package/uclibc/uClibc-0.9.31.config                |  259 +
 19 files changed, 8354 insertions(+), 5 deletions(-)
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0001-add-bsd-endian-conversions.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0002-add-inotify-init1.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0003-add-sock-cloexec.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0004-export-strverscmp.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0005-fix-daylight-saving-time-handling.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0006-fix-error-locale-utf-8.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0007-fix-fcntl64-for-64-bit-targets.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0008-linuxthreads-errno-fix.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0009-more-workarounds-GCC-PR32219.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0010-powerpc-ptrace-fix.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0011-quad-routines.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0013-unshare.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0014-workaround-GCC-PR32219.patch
 create mode 100644 package/uclibc/0.9.31.1/uClibc-0015-startfiles-Make-targets.patch
 create mode 100644 package/uclibc/uClibc-0.9.31.config
package/connman/Config.in +2 -2
index c74618a..f231689 100644
@@ -4,7 +4,7 @@ config BR2_PACKAGE_CONNMAN
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_IPTABLES
 	select BR2_PACKAGE_GNUTLS
-	depends on !BR2_UCLIBC_VERSION_0_9_32
+	depends on !(BR2_UCLIBC_VERSION_0_9_31 || BR2_UCLIBC_VERSION_0_9_32)
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_INET_IPV6
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
@@ -50,5 +50,5 @@ config BR2_PACKAGE_CONNMAN_CLIENT
 endif # BR2_PACKAGE_CONNMAN
 
 comment "connman needs a toolchain w/ IPv6, wchar, threads, resolver"
-	depends on BR2_UCLIBC_VERSION_0_9_32 || \
+	depends on BR2_UCLIBC_VERSION_0_9_31 || BR2_UCLIBC_VERSION_0_9_32 || \
 		!BR2_USE_WCHAR || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
package/libglib2/libglib2.mk +1 -1
index 51b2fc1..f770d3a 100644
@@ -51,7 +51,7 @@ LIBGLIB2_CONF_ENV = \
 		gt_cv_c_wchar_t=$(if $(BR2_USE_WCHAR),yes,no)
 
 # old uClibc versions don't provide qsort_r
-ifeq ($(BR2_UCLIBC_VERSION_0_9_32)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC)$(BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEEL_V2)$(BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEBE_V2),y)
+ifeq ($(BR2_UCLIBC_VERSION_0_9_31)$(BR2_UCLIBC_VERSION_0_9_32)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC)$(BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEEL_V2)$(BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEBE_V2),y)
 LIBGLIB2_CONF_ENV += glib_cv_have_qsort_r=no
 else
 LIBGLIB2_CONF_ENV += glib_cv_have_qsort_r=yes
package/uclibc/0.9.31.1/uClibc-0001-add-bsd-endian-conversions.patch new file +64 -0

64 lines not on this page · raw message

package/uclibc/0.9.31.1/uClibc-0002-add-inotify-init1.patch new file +64 -0

64 lines not on this page · raw message

package/uclibc/0.9.31.1/uClibc-0003-add-sock-cloexec.patch new file +43 -0

43 lines not on this page · raw message

package/uclibc/0.9.31.1/uClibc-0004-export-strverscmp.patch new file +30 -0
new file mode 100644
index 0000000..19bc021
@@ -0,0 +1,30 @@
+From 139b8f0c673fed465d27f99c98568e5d5e1b9b72 Mon Sep 17 00:00:00 2001
+From: Denys Vlasenko <[email protected]>
+Date: Fri, 4 Jun 2010 13:36:30 +0200
+Subject: [PATCH] strverscmp: I forgot to export it
+
+Result was:
+
+strverscmp.o:
+000000ec T __GI_strverscmp
+
+i.e. no plain "strverscmp"!
+
+Signed-off-by: Denys Vlasenko <[email protected]>
+Signed-off-by: Gustavo Zacarias <[email protected]>
+---
+ libc/string/strverscmp.c |    1 +
+ 1 files changed, 1 insertions(+), 0 deletions(-)
+
+diff --git a/libc/string/strverscmp.c b/libc/string/strverscmp.c
+index 74ae4c6..b19e8f0 100644
+--- a/libc/string/strverscmp.c
++++ b/libc/string/strverscmp.c
+@@ -115,3 +115,4 @@ int strverscmp (const char *s1, const char *s2)
+       return state;
+   }
+ }
++libc_hidden_def(strverscmp)
+-- 
+1.7.3.4
+
package/uclibc/0.9.31.1/uClibc-0005-fix-daylight-saving-time-handling.patch new file +36 -0
new file mode 100644
index 0000000..5a96113
@@ -0,0 +1,36 @@
+From 47f3da1cf49377c25772bb54d07db55225bbb142 Mon Sep 17 00:00:00 2001
+From: Guillaume Bourcier <[email protected]>
+Date: Tue, 11 Oct 2011 13:45:33 +0200
+Subject: [PATCH] libc: fix daylight saving time handling
+
+The algorithm computing daylight saving time incorrectly adds a day for
+each month after January for leap years. The clock shift from/to DST can
+be delayed if the last Sunday of a transition month is exactly seven
+days before the first of the following month.
+
+This change adds a day for the February month only.
+
+Signed-off-by: Guillaume Bourcier <[email protected]>
+Signed-off-by: Richard Braun <[email protected]>
+Signed-off-by: Carmelo Amoroso <[email protected]>
+Signed-off-by: Gustavo Zacarias <[email protected]>
+---
+ libc/misc/time/time.c |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/libc/misc/time/time.c b/libc/misc/time/time.c
+index 19d68e1..8e2ebf1 100644
+--- a/libc/misc/time/time.c
++++ b/libc/misc/time/time.c
+@@ -689,7 +689,7 @@ static int tm_isdst(register const struct tm *__restrict ptm,
+ 					++day;
+ 				}
+ 				monlen = 31 + day_cor[r->month -1] - day_cor[r->month];
+-				if (isleap && (r->month > 1)) {
++				if (isleap && (r->month == 2)) {
+ 					++monlen;
+ 				}
+ 				/* Wweekday (0 is Sunday) of 1st of the month
+-- 
+1.7.3.4
+
package/uclibc/0.9.31.1/uClibc-0006-fix-error-locale-utf-8.patch new file +17 -0
new file mode 100644
index 0000000..1305add
@@ -0,0 +1,17 @@
+---
+ extra/locale/gen_wc8bit.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+Index: uClibc-0.9.31/extra/locale/gen_wc8bit.c
+===================================================================
+--- uClibc-0.9.31.orig/extra/locale/gen_wc8bit.c
++++ uClibc-0.9.31/extra/locale/gen_wc8bit.c
+@@ -120,7 +120,7 @@
+ 		}
+ 
+  locale_failure:
+-		printf("could not find a UTF8 locale ... please enable en_US.UTF-8\n");
++		fprintf(stderr, "could not find a UTF8 locale ... please enable en_US.UTF-8\n");
+ 		return EXIT_FAILURE;
+  locale_success:
+ 		pclose(fp);
package/uclibc/0.9.31.1/uClibc-0007-fix-fcntl64-for-64-bit-targets.patch new file +34 -0
new file mode 100644
index 0000000..763bfd3
@@ -0,0 +1,34 @@
+From 6f1daaaf2d94c1e6184add44eda38b0781b88cf0 Mon Sep 17 00:00:00 2001
+From: Rob Landley <[email protected]>
+Date: Sun, 16 May 2010 21:41:36 +0000
+Subject: Fix fcntl64 for 64 bit targets.
+
+64 bit targets often don't have a separate fcntl64() system call, because they don't need one.
+
+Signed-off-by: Rob Landley <[email protected]>
+Signed-off-by: Austin Foxley <[email protected]>
+---
+diff --git a/include/fcntl.h b/include/fcntl.h
+index e37073f..3cfb25f 100644
+--- a/include/fcntl.h
++++ b/include/fcntl.h
+@@ -73,7 +73,7 @@ __BEGIN_DECLS
+ 
+    This function is a cancellation point and therefore not marked with
+    __THROW.  */
+-#ifndef __USE_FILE_OFFSET64
++#if !defined(__USE_FILE_OFFSET64) || defined(__LP64__)
+ extern int fcntl (int __fd, int __cmd, ...);
+ libc_hidden_proto(fcntl)
+ #else
+@@ -83,7 +83,7 @@ extern int __REDIRECT (fcntl, (int __fd, int __cmd, ...), fcntl64);
+ #  define fcntl fcntl64
+ # endif
+ #endif
+-#ifdef __USE_LARGEFILE64
++#if defined(__USE_LARGEFILE64) && !defined(__LP64__)
+ extern int fcntl64 (int __fd, int __cmd, ...);
+ libc_hidden_proto(fcntl64)
+ #endif
+--
+cgit v0.8.2.1
package/uclibc/0.9.31.1/uClibc-0008-linuxthreads-errno-fix.patch new file +98 -0

98 lines not on this page · raw message

package/uclibc/0.9.31.1/uClibc-0009-more-workarounds-GCC-PR32219.patch new file +40 -0
new file mode 100644
index 0000000..9e69532
@@ -0,0 +1,40 @@
+From aa67771881d65373da448ad5f7a8393f3a1d9469 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Timo=20Ter=C3=A4s?= <[email protected]>
+Date: Wed, 30 Jun 2010 14:46:37 +0300
+Subject: [PATCH] more workarounds for GCC PR32219
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Commit 2e53dd645d5348f207cec7f8595969dc566c5a55 workarounds GCC
+bug when accessing _locale_init and _stdio_init. We need the same
+fix for __errno_location and __h_errno_location otherwise we crash
+calling null with static and non-threaded builds.
+
+Signed-off-by: Timo Ter?s <[email protected]>
+Signed-off-by: Bernhard Reutner-Fischer <[email protected]>
+---
+ libc/misc/internals/__uClibc_main.c |    4 ++--
+ 1 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/libc/misc/internals/__uClibc_main.c b/libc/misc/internals/__uClibc_main.c
+index 3f09ad2..58f6643 100644
+--- a/libc/misc/internals/__uClibc_main.c
++++ b/libc/misc/internals/__uClibc_main.c
+@@ -447,11 +447,11 @@ void __uClibc_main(int (*main)(int, char **, char **), int argc,
+      * have resulted in errno being set nonzero, so set it to 0 before
+      * we call main.
+      */
+-    if (likely(__errno_location!=NULL))
++    if (likely(not_null_ptr(__errno_location)))
+ 	*(__errno_location()) = 0;
+ 
+     /* Set h_errno to 0 as well */
+-    if (likely(__h_errno_location!=NULL))
++    if (likely(not_null_ptr(__h_errno_location)))
+ 	*(__h_errno_location()) = 0;
+ 
+ #if defined HAVE_CLEANUP_JMP_BUF && defined __UCLIBC_HAS_THREADS_NATIVE__
+-- 
+1.7.1
+
package/uclibc/0.9.31.1/uClibc-0010-powerpc-ptrace-fix.patch new file +62 -0

62 lines not on this page · raw message

package/uclibc/0.9.31.1/uClibc-0011-quad-routines.patch new file +7393 -0

2,490 lines not on this page · raw message

package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch new file +11 -0
new file mode 100644
index 0000000..44d06cb

Lines of this file are not shown. View the raw message.

package/uclibc/0.9.31.1/uClibc-0013-unshare.patch new file +74 -0

74 lines not on this page · raw message

package/uclibc/0.9.31.1/uClibc-0014-workaround-GCC-PR32219.patch new file +57 -0

57 lines not on this page · raw message

package/uclibc/0.9.31.1/uClibc-0015-startfiles-Make-targets.patch new file +60 -0

60 lines not on this page · raw message

package/uclibc/Config.in +9 -2
index 0e7ae54..f71e343 100644

Lines of this file are not shown. View the raw message.

package/uclibc/uClibc-0.9.31.config new file +259 -0

259 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.8.3.2

Part of the diff is not shown here. View the raw message.

#1 lore raw

PATCH v4 1/1 uclibc: reinstate support for version 0.9.31

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"spdawson" == spdawson <[email protected]> writes:

From: Simon Dawson <[email protected]>
This patch reinstates support for uClibc version 0.9.31, which was removed from Buildroot in commit 8abb5b33c1aae035cf48b1c81104b433ff884c64

We'll presumably get a bunch of autobuilder failures if we go back to 0.9.31 for avr32. Are you willing to fix (annotate) all those packages?

package/connman/Config.in config BR2_PACKAGE_CONNMAN · line 10

Quoted 13 lines
package/connman/Config.in +1 -1
index c74618a..f231689 100644
@@ -4,7 +4,7 @@ config BR2_PACKAGE_CONNMAN
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_IPTABLES
 	select BR2_PACKAGE_GNUTLS
-	depends on !BR2_UCLIBC_VERSION_0_9_32
+	depends on !(BR2_UCLIBC_VERSION_0_9_31 || BR2_UCLIBC_VERSION_0_9_32)
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_INET_IPV6
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2

I've already applied your patch to make connman unavailable on avr32, so this can be dropped.

package/uclibc/0.9.31.1/uClibc-0002-add-inotify-init1.patch line 7

Quoted 13 lines
package/uclibc/0.9.31.1/uClibc-0002-add-inotify-init1.patch new file +7 -0
new file mode 100644
index 0000000..cbec426
@@ -0,0 +1,64 @@
+From a2e5630af426f85fdd8721b2820786d9bd2aa695 Mon Sep 17 00:00:00 2001
+From: Vladimir Zapolskiy <[email protected]>
+Date: Tue, 1 Jun 2010 20:02:54 +0400
+Subject: [PATCH] inotify: add inotify_init1 system call support
+
+This patch introduces support for inotify_init1 system call, found
+since Linux 2.6.27.

Hmm, are you now adding support for inotify on avr32?

package/uclibc/0.9.31.1/uClibc-0002-add-inotify-init1.patch

Quoted 9 lines
package/uclibc/0.9.31.1/uClibc-0002-add-inotify-init1.patch new file +7 -0
+++ b/package/uclibc/0.9.31.1/uClibc-0007-fix-fcntl64-for-64-bit-targets.patch
@@ -0,0 +1,34 @@
+From 6f1daaaf2d94c1e6184add44eda38b0781b88cf0 Mon Sep 17 00:00:00 2001
+From: Rob Landley <[email protected]>
+Date: Sun, 16 May 2010 21:41:36 +0000
+Subject: Fix fcntl64 for 64 bit targets.
+
+64 bit targets often don't have a separate fcntl64() system call,
 because they don't need one.

That doesn't sound important for avr32?

package/uclibc/0.9.31.1/uClibc-0010-powerpc-ptrace-fix.patch line 5

Quoted 11 lines
package/uclibc/0.9.31.1/uClibc-0010-powerpc-ptrace-fix.patch new file +5 -0
new file mode 100644
index 0000000..a5cceca
@@ -0,0 +1,62 @@
+[PATCH] powerpc: add PTRACE_EVENT_ defines needed by ltrace
+
+Equivalent to the common version and kernel headers.
+
+Signed-off-by: Peter Korsgaard <[email protected]>

Tsk tsk, who is this guy? ;) Anyway, that also doesn't sound like something we need for avr32.

package/uclibc/0.9.31.1/uClibc-0011-quad-routines.patch line 1

Quoted 7 lines
package/uclibc/0.9.31.1/uClibc-0011-quad-routines.patch new file +1 -0
new file mode 100644
index 0000000..de37c30
@@ -0,0 +1,7393 @@
+diff -Naur uClibc-0.9.31.ori/libc/sysdeps/linux/sparc/Makefile.arch uClibc-0.9.31/libc/sysdeps/linux/sparc/Makefile.arch

This looks sparc specific?

package/uclibc/0.9.31.1/uClibc-0011-quad-routines.patch line 60

Quoted 3 lines
package/uclibc/0.9.31.1/uClibc-0011-quad-routines.patch new file +3 -0
++#if _FP_W_TYPE_SIZE < 32
++#error "Here's a nickel kid.  Go buy yourself a real computer."
++#endif

Heh ;)

package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch

Quoted 5 lines
package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch new file +0 -0
new file mode 100644
index 0000000..44d06cb

This one as well.

Quoted 37 lines

+++ b/package/uclibc/Config.in

package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch new file +7 -1
@@ -8,13 +8,17 @@ choice
 	help
 	  Select the version of uClibc you wish to use.
 
+	config BR2_UCLIBC_VERSION_0_9_31
+		bool "uClibc 0.9.31.x"
+		depends on BR2_avr32
+
 	config BR2_UCLIBC_VERSION_0_9_32
 		bool "uClibc 0.9.32.x"
 		depends on !(BR2_arc || BR2_avr32 || BR2_sh || BR2_xtensa)
 
 	config BR2_UCLIBC_VERSION_0_9_33
 		bool "uClibc 0.9.33.x"
-		depends on !(BR2_arc || BR2_xtensa)
+		depends on !(BR2_arc || BR2_avr32 || BR2_xtensa)
 
 	config BR2_UCLIBC_VERSION_0_9_33_ARC
 		bool "uClibc 0.9.33.x-arc"
@@ -34,6 +38,7 @@ config BR2_USE_UCLIBC_SNAPSHOT
 
 config BR2_UCLIBC_VERSION_STRING
 	string
+	default 0.9.31.1	if BR2_UCLIBC_VERSION_0_9_31
 	default 0.9.32.1	if BR2_UCLIBC_VERSION_0_9_32
 	default 0.9.33.2	if BR2_UCLIBC_VERSION_0_9_33
 	default 0.9.33-arc	if BR2_UCLIBC_VERSION_0_9_33_ARC
@@ -41,6 +46,7 @@ config BR2_UCLIBC_VERSION_STRING
 
 config BR2_UCLIBC_CONFIG
 	string "uClibc configuration file to use?"
+	default "package/uclibc/uClibc-0.9.31.config" if BR2_UCLIBC_VERSION_0_9_31
 	default "package/uclibc/uClibc-0.9.32.config" if BR2_UCLIBC_VERSION_0_9_32
 	default "package/uclibc/uClibc-0.9.33.config" if BR2_UCLIBC_VERSION_0_9_33
 	default "package/uclibc/uClibc-snapshot.config" if BR2_UCLIBC_VERSION_0_9_33_ARC

package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch config BR2_TOOLCHAIN_BUILDROOT_LOCALE · line 99

Quoted 5 lines
package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch new file +1 -1
@@ -90,7 +96,7 @@ config BR2_TOOLCHAIN_BUILDROOT_LOCALE
 
 choice
 	prompt "Thread library implementation"
-	default BR2_PTHREADS_NATIVE if !(BR2_avr32 || BR2_xtensa)
+	default BR2_PTHREADS_NATIVE if (!BR2_UCLIBC_VERSION_0_9_31) && !(BR2_avr32 || BR2_xtensa)

It already depends on !BR2_avr32, so you can drop this.

package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch choice · line 126

Quoted 10 lines
package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch new file +1 -0
 	default BR2_PTHREADS_OLD
 	help
 	  Use this option to select the thread library implementation
@@ -115,6 +121,7 @@ choice
 	config BR2_PTHREADS_NATIVE
 		bool "Native POSIX Threading (NPTL)"
 		select BR2_TOOLCHAIN_HAS_THREADS
+		depends on !BR2_UCLIBC_VERSION_0_9_31
 		depends on !BR2_arc
 		depends on !BR2_avr32

And here as well.

Care to resend with those issues fixed? Thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v4 1/1 uclibc: reinstate support for version 0.9.31

Hi Peter. Thanks for the feedback.

Quoted 2 lines · Peter Korsgaard

We'll presumably get a bunch of autobuilder failures if we go back to 0.9.31 for avr32. Are you willing to fix (annotate) all those packages?

Yes, I'm happy to fix any problems that arise. I actually don't anticipate that 0.9.31 will cause significantly more failures than 0.9.32.

Quoted 2 lines

I've already applied your patch to make connman unavailable on avr32, so this can be dropped.

Okay.

Quoted 1 line

Hmm, are you now adding support for inotify on avr32?

The set of patches for 0.9.31 --- including the patch to add inotify support --- is the set that used to be in Buildroot prior to commit 8abb5b33c1aae035cf48b1c81104b433ff884c64. I don't believe I'm adding anything "new" here...

Quoted 4 lines
Quoted 2 lines

+64 bit targets often don't have a separate fcntl64() system call,
because they don't need one.

That doesn't sound important for avr32?

Agreed; I'll remove this.

Quoted 8 lines

package/uclibc/0.9.31.1/uClibc-0010-powerpc-ptrace-fix.patch line 5

Quoted 5 lines

+[PATCH] powerpc: add PTRACE_EVENT_ defines needed by ltrace

package/uclibc/0.9.31.1/uClibc-0010-powerpc-ptrace-fix.patch new file +4 -0
+
+Equivalent to the common version and kernel headers.
+
+Signed-off-by: Peter Korsgaard <[email protected]>

Tsk tsk, who is this guy? ;) Anyway, that also doesn't sound like something we need for avr32.

Right; I'll remove that one too.

Quoted 3 lines
Quoted 1 line

+diff -Naur uClibc-0.9.31.ori/libc/sysdeps/linux/sparc/Makefile.arch uClibc-0.9.31/libc/sysdeps/linux/sparc/Makefile.arch

This looks sparc specific?

Okay.

Quoted 7 lines

package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch

Quoted 5 lines
package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch new file +0 -0
new file mode 100644
index 0000000..44d06cb

This one as well.

Okay.

Quoted 5 lines

package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch

Quoted 3 lines

prompt "Thread library implementation"

package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch new file +1 -1
-    default BR2_PTHREADS_NATIVE if !(BR2_avr32 || BR2_xtensa)
+    default BR2_PTHREADS_NATIVE if (!BR2_UCLIBC_VERSION_0_9_31) && !(BR2_avr32 || BR2_xtensa)

It already depends on !BR2_avr32, so you can drop this.

Okay.

Quoted 9 lines

package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch choice · line 126

Quoted 7 lines
package/uclibc/0.9.31.1/uClibc-0012-sparc-errno-fix.patch new file +1 -0
@@ -115,6 +121,7 @@ choice
     config BR2_PTHREADS_NATIVE
             bool "Native POSIX Threading (NPTL)"
             select BR2_TOOLCHAIN_HAS_THREADS
+            depends on !BR2_UCLIBC_VERSION_0_9_31
             depends on !BR2_arc
             depends on !BR2_avr32

And here as well.

Okay.

Quoted 1 line

Care to resend with those issues fixed? Thanks.

Of course. I'll rework the patch.

Simon.