Skip to contentSkip to conversation

Pull request for branch for-master/lttng

GIT PULL New Samuel Martin 3 participants 8 messages Dec 30, 2012 – Jan 1, 2013

lore
Share & tools
lore
#0 lore raw

Hello,

Here is version bump for Lttng and related packages.

The following changes since commit f1d44593a04ff3be981c8a3b01a502f0b18193ee:

docs/manual: small fixes and enhancements to adding generic packages (2012-12-30 22:39:13 +0100)

are available in the git repository at:

git at github.com:tSed/buildroot.git for-master/lttng

for you to fetch changes up to 192d7031d43a55c00114dbb0bc54b697e4baf02e:

lttng-babeltrace: bump to 1.0.0 (2012-12-30 23:04:51 +0100)

----------------------------------------------------------------
Samuel Martin (4):
lttng-libust: bump to 2.1.0
lttng-modules: bump to 2.1.0
lttng-tools: bump to 2.1.0
lttng-babeltrace: bump to 1.0.0

 package/lttng-babeltrace/lttng-babeltrace.mk       |  2 +-
 ...t-dont-build-cxx-tests-when-not-available.patch | 13 ++--
 .../lttng-libust-uclibc-sched_getcpu.patch         | 32 ---------
 package/lttng-libust/lttng-libust.mk               |  2 +-
 package/lttng-modules/lttng-modules.mk             |  2 +-
 ...ng-tools-Support-new-lttng-ust-error-code.patch | 82 ++++++++++++++++++++++
 .../lttng-tools-no-sync-file-range-in-uclibc.patch | 51 +++++++-------
 package/lttng-tools/lttng-tools.mk                 |  5 +-
 8 files changed, 122 insertions(+), 67 deletions(-)
 delete mode 100644 package/lttng-libust/lttng-libust-uclibc-sched_getcpu.patch
 create mode 100644 package/lttng-tools/lttng-tools-Support-new-lttng-ust-error-code.patch

Yours,

--

Samuel

#1 lore raw

PATCH 1/4 lttng-libust: bump to 2.1.0

Also remove lttng-libust-uclibc-sed_getcpu.patch because it got merged upstream.

---
 ...t-dont-build-cxx-tests-when-not-available.patch | 13 +++++----
 .../lttng-libust-uclibc-sched_getcpu.patch         | 32 ----------------------
 package/lttng-libust/lttng-libust.mk               |  2 +-
 3 files changed, 8 insertions(+), 39 deletions(-)
 delete mode 100644 package/lttng-libust/lttng-libust-uclibc-sched_getcpu.patch
package/lttng-libust/lttng-libust-dont-build-cxx-tests-when-not-available.patch +7 -6
index bcc5636..b7e8a8f 100644
@@ -38,15 +38,16 @@ index 26227cb..56d84db 100644
 +AM_CONDITIONAL([CXX_WORKS], [test "x$rw_cv_prog_cxx_works" = "xyes"])
 +
  ## Checks for libraries.
- AC_CHECK_LIB([dl], [dlopen])
- AC_CHECK_LIB([pthread], [pthread_create])
+ AC_CHECK_LIB([dl], [dlopen],
+ [
 diff --git a/tests/Makefile.am b/tests/Makefile.am
-index e79ab7c..1a8b795 100644
+index 2b12422..7365ce4 100644
 --- a/tests/Makefile.am
 +++ b/tests/Makefile.am
-@@ -1,6 +1,10 @@
--SUBDIRS = . hello hello-static-lib fork ust-basic-tracing ust-multi-test demo hello.cxx
-+SUBDIRS = . hello hello-static-lib fork ust-basic-tracing ust-multi-test demo
+@@ -1,7 +1,11 @@
+ SUBDIRS = . hello hello-static-lib fork ust-basic-tracing ust-multi-test \
+-		demo hello.cxx daemon
++		demo daemon
  #SUBDIRS = . hello2 basic basic_long simple_include snprintf test-nevents test-libustinstr-malloc dlopen same_line_marker trace_event register_test tracepoint libustctl_function_tests exit-fast
  
 +if CXX_WORKS
package/lttng-libust/lttng-libust-uclibc-sched_getcpu.patch deleted +0 -32
deleted file mode 100644
index 6536185..0000000
@@ -1,32 +0,0 @@
-[PATCH] fix build with modern uClibc
-
-uClibc has sched_getcpu since 0.9.33, so the compat workaround should only
-be used for older uClibc versions.
-
-Signed-off-by: Peter Korsgaard <[email protected]>
----
- liblttng-ust/compat.h |    5 +++++
- 1 file changed, 5 insertions(+)
-
-Index: lttng-ust-1.9.2/liblttng-ust/compat.h
-===================================================================
---- lttng-ust-1.9.2.orig/liblttng-ust/compat.h
-+++ lttng-ust-1.9.2/liblttng-ust/compat.h
-@@ -17,6 +17,10 @@
- #include <sys/syscall.h>
- 
- #ifdef __UCLIBC__
-+/* old uClibc versions didn't have sched_getcpu */
-+#if __UCLIBC_MAJOR__ == 0 && \
-+	(__UCLIBC_MINOR__ < 9 || \
-+	 (__UCLIBC_MINOR__ == 9 && __UCLIBC_SUBLEVEL__ <= 32))
- #define __getcpu(cpu, node, cache)	syscall(__NR_getcpu, cpu, node, cache)
- static inline
- int sched_getcpu(void)
-@@ -26,5 +30,6 @@
- 	s = __getcpu(&c, NULL, NULL);
- 	return (s == -1) ? s : c;
- }
-+#endif /* <= 0.9.32 */
- #endif	/* __UCLIBC__ */
- #endif /* _UST_COMPAT_H */
package/lttng-libust/lttng-libust.mk +1 -1
index cd6c65d..e1f51b1 100644
@@ -4,7 +4,7 @@
 #
 #############################################################
 LTTNG_LIBUST_SITE    = http://lttng.org/files/lttng-ust/
-LTTNG_LIBUST_VERSION = 2.0.3
+LTTNG_LIBUST_VERSION = 2.1.0
 LTTNG_LIBUST_SOURCE  = lttng-ust-$(LTTNG_LIBUST_VERSION).tar.bz2
 
 LTTNG_LIBUST_INSTALL_STAGING = YES
Signature · 1 line
1.8.0.3
#2 lore raw

PATCH 2/4 lttng-modules: bump to 2.1.0

In reply to Samuel Martin
---
 package/lttng-modules/lttng-modules.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/lttng-modules/lttng-modules.mk +1 -1
index a245b19..54ae864 100644
@@ -3,7 +3,7 @@
 # LTTng-modules: the kernel modules (requires at least Linux 2.6.38)
 #
 #############################################################
-LTTNG_MODULES_VERSION = 2.0.3
+LTTNG_MODULES_VERSION = 2.1.0
 LTTNG_MODULES_SITE    = http://lttng.org/files/lttng-modules/
 LTTNG_MODULES_SOURCE  = lttng-modules-$(LTTNG_MODULES_VERSION).tar.bz2
 
Signature · 1 line
1.8.0.3
#3 lore raw

PATCH 3/4 lttng-tools: bump to 2.1.0

In reply to Samuel Martin

* add patch adding src/bin/lttng-sessiond/lttng-ust-error.h which is missing in the lttng-tools-2.1.0 release tarball.
* update the sync_file_range patch.

---
 ...ng-tools-Support-new-lttng-ust-error-code.patch | 82 ++++++++++++++++++++++
 .../lttng-tools-no-sync-file-range-in-uclibc.patch | 51 +++++++-------
 package/lttng-tools/lttng-tools.mk                 |  5 +-
 3 files changed, 112 insertions(+), 26 deletions(-)
 create mode 100644 package/lttng-tools/lttng-tools-Support-new-lttng-ust-error-code.patch
package/lttng-tools/lttng-tools-Support-new-lttng-ust-error-code.patch new file +82 -0
new file mode 100644
index 0000000..73d0884
@@ -0,0 +1,82 @@
+From 49c336c1679295a31b92223dca05feccfe3e3464 Mon Sep 17 00:00:00 2001
+From: David Goulet <[email protected]>
+Date: Fri, 9 Nov 2012 13:37:25 -0500
+Subject: [PATCH] Support new lttng-ust error code
+
+Signed-off-by: David Goulet <[email protected]>
+---
+
+Only keep the src/bin/lttng-sessiond/lttng-ust-error.h adding part,
+needed to build lttng-tool without the lttng-libust dependency, i.e.
+with --disable-lttng-ust. (Samuel Martin)
+
+---
+ src/bin/lttng-sessiond/lttng-ust-error.h | 56 ++++++++++++++++++++++++++++++++
+ 6 files changed, 75 insertions(+), 13 deletions(-)
+ create mode 100644 src/bin/lttng-sessiond/lttng-ust-error.h
+
+diff --git a/src/bin/lttng-sessiond/lttng-ust-error.h b/src/bin/lttng-sessiond/lttng-ust-error.h
+new file mode 100644
+index 0000000..d83ecb8
+--- /dev/null
++++ b/src/bin/lttng-sessiond/lttng-ust-error.h
+@@ -0,0 +1,56 @@
++#ifndef _LTTNG_UST_ERROR_H
++#define _LTTNG_UST_ERROR_H
++
++/*
++ * Copyright (C) 2011 - David Goulet <[email protected]>
++ *                      Julien Desfossez <[email protected]>
++ *                      Mathieu Desnoyers <[email protected]>
++ *
++ * This library is free software; you can redistribute it and/or
++ * modify it under the terms of the GNU Lesser General Public
++ * License as published by the Free Software Foundation; only
++ * version 2.1 of the License.
++ *
++ * This library is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
++ * Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public
++ * License along with this library; if not, write to the Free Software
++ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
++ */
++
++/*
++ * This header is meant for liblttng and libust internal use ONLY.
++ * These declarations should NOT be considered stable API.
++ */
++
++#include <limits.h>
++#include <unistd.h>
++
++#include "lttng-ust-abi.h"
++
++/*
++ * ustcomm error code.
++ */
++enum lttng_ust_error_code {
++	LTTNG_UST_OK = 0,			/* Ok */
++	LTTNG_UST_ERR = 1024,			/* Unknown Error */
++	LTTNG_UST_ERR_NOENT = 1025,		/* No entry */
++	LTTNG_UST_ERR_EXIST = 1026,     /* Object exists */
++	LTTNG_UST_ERR_INVAL = 1027,     /* Invalid argument */
++	LTTNG_UST_ERR_PERM  = 1028,     /* Permission denied */
++	LTTNG_UST_ERR_NOSYS = 1029,     /* Not implemented */
++
++	/* MUST be last element */
++	LTTNG_UST_ERR_NR,			/* Last element */
++};
++
++/*
++ * Return a human-readable error message for an lttng-ust error code.
++ * code must be a positive value (or 0).
++ */
++extern const char *lttng_ust_strerror(int code);
++
++#endif	/* _LTTNG_UST_ERROR_H */
+-- 
+1.8.0.3
+
package/lttng-tools/lttng-tools-no-sync-file-range-in-uclibc.patch +26 -25

61 lines not on this page · raw message

package/lttng-tools/lttng-tools.mk +4 -1
index fe48ac6..18477ba 100644
@@ -3,7 +3,7 @@
 # LTTng-Tools: the trace control client
 #
 #############################################################
-LTTNG_TOOLS_VERSION = 2.0.4
+LTTNG_TOOLS_VERSION = 2.1.0
 LTTNG_TOOLS_SITE    = http://lttng.org/files/lttng-tools/
 LTTNG_TOOLS_SOURCE  = lttng-tools-$(LTTNG_TOOLS_VERSION).tar.bz2
 
@@ -11,6 +11,9 @@ LTTNG_TOOLS_SOURCE  = lttng-tools-$(LTTNG_TOOLS_VERSION).tar.bz2
 # dependency. However, having the babeltrace utilities built for the
 # host is very useful, since those tools allow to convert the binary
 # trace format into an human readable format.
+# Since the 2.1.0 release, lttng-tools depends on flex and bison,
+# but they are not added to the dependency list since they are
+# already Buildroot dependencies.
 LTTNG_TOOLS_DEPENDENCIES = liburcu popt host-lttng-babeltrace
 
 LTTNG_AUTORECONF = YES
Signature · 1 line
1.8.0.3
#4 lore raw

PATCH 3/4 lttng-tools: bump to 2.1.0

Dear Samuel Martin,

package/lttng-tools/lttng-tools.mk LTTNG_TOOLS_SOURCE = lttng-tools-$(LTTNG_TOOLS_VERSION).tar.bz2 · line 16

Quoted 3 lines · Samuel Martin
package/lttng-tools/lttng-tools.mk +3 -0
+# Since the 2.1.0 release, lttng-tools depends on flex and bison,
+# but they are not added to the dependency list since they are
+# already Buildroot dependencies.

We are not very clear about this: we have packages for host-flex and host-bison, and they are actually used by some of our packages. But we also require the user to have flex and bison installed in his distribution.

Probably something that should be clarified, in one direction or another.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

PATCH 3/4 lttng-tools: bump to 2.1.0

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Dear Samuel Martin,

Quoted 3 lines · Samuel Martin

package/lttng-tools/lttng-tools.mk LTTNG_TOOLS_SOURCE = lttng-tools-$(LTTNG_TOOLS_VERSION).tar.bz2 · line 16

Quoted 3 lines
package/lttng-tools/lttng-tools.mk +3 -0
+# Since the 2.1.0 release, lttng-tools depends on flex and bison,
+# but they are not added to the dependency list since they are
+# already Buildroot dependencies.

Thomas> We are not very clear about this: we have packages for host-flex and Thomas> host-bison, and they are actually used by some of our packages. But we Thomas> also require the user to have flex and bison installed in his Thomas> distribution.

Thomas> Probably something that should be clarified, in one direction or Thomas> another.

Yes, it would be good to get rid of the flex/bison deps, and use our own everywhere if possible.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 4/4 lttng-babeltrace: bump to 1.0.0

In reply to Samuel Martin
---
 package/lttng-babeltrace/lttng-babeltrace.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/lttng-babeltrace/lttng-babeltrace.mk +1 -1
index dd701df..60b8a93 100644
@@ -1,5 +1,5 @@
 LTTNG_BABELTRACE_SITE    = http://lttng.org/files/babeltrace/
-LTTNG_BABELTRACE_VERSION = 1.0.0-rc6
+LTTNG_BABELTRACE_VERSION = 1.0.0
 LTTNG_BABELTRACE_SOURCE  = babeltrace-$(LTTNG_BABELTRACE_VERSION).tar.bz2
 
 LTTNG_BABELTRACE_DEPENDENCIES = popt util-linux libglib2
Signature · 1 line
1.8.0.3
#7 lore raw
In reply to Samuel Martin
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Samuel" == Samuel Martin <[email protected]> writes:

Samuel> Hello,
Samuel> Here is version bump for Lttng and related packages.

Samuel> The following changes since commit f1d44593a04ff3be981c8a3b01a502f0b18193ee:

Samuel> docs/manual: small fixes and enhancements to adding generic packages (2012-12-30 22:39:13 +0100)

Samuel> are available in the git repository at:

Samuel> git at github.com:tSed/buildroot.git for-master/lttng

Samuel> for you to fetch changes up to 192d7031d43a55c00114dbb0bc54b697e4baf02e:

Samuel> lttng-babeltrace: bump to 1.0.0 (2012-12-30 23:04:51 +0100)

Samuel> ---------------------------------------------------------------- Samuel> Samuel Martin (4):

 Samuel>       lttng-libust: bump to 2.1.0
 Samuel>       lttng-modules: bump to 2.1.0
 Samuel>       lttng-tools: bump to 2.1.0
 Samuel>       lttng-babeltrace: bump to 1.0.0

Committed all 4, thanks.

Signature · 1 line
Bye, Peter Korsgaard