Skip to contentSkip to conversation

ARM: OMAP: omap_device: Include linux/export.h

PATCH RESEND In review Axel Lin 4 participants 5 messages Nov 3, 2011 – Nov 7, 2011

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH RESEND 1/1 ARM: OMAP: omap_device: Include linux/export.h

Include linux/export.h to fix below build warning:

CC arch/arm/plat-omap/omap_device.o
arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration

Signed-off-by Axel Lin <[email protected]>

---
This resend also CC linux-omap at vger.kernel.org and linux-arm-kernel at lists.infradead.org. This patch is against linux-next 20111103.

 arch/arm/plat-omap/omap_device.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/plat-omap/omap_device.c +1 -0
index cd90bed..f839f94 100644
@@ -78,6 +78,7 @@
 #undef DEBUG
 
 #include <linux/kernel.h>
+#include <linux/export.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/err.h>
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 8 lines · Axel Lin

Include linux/export.h to fix below build warning:

CC arch/arm/plat-omap/omap_device.o
arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration

Signed-off-by Axel Lin <[email protected]>

Thanks, will queue as a fix for v3.2-rc

Kevin

#2 lore raw
Quoted 4 lines · Kevin Hilman
Quoted 2 lines · Axel Lin

Include linux/export.h to fix below build warning:

Quoted 8 lines
Quoted 6 lines

CC arch/arm/plat-omap/omap_device.o
arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration

Signed-off-by Axel Lin <[email protected]>

Thanks, will queue as a fix for v3.2-rc

It is probably better if I track this, since export.h won't exist until Linus pulls the module.h-split tree, and I'm guessing that will be closer to the end of the merge window.

Thanks,
Paul.

Quoted 2 lines

Kevin

Acked-by
#3 lore raw
Quoted 10 lines · Paul Gortmaker
Quoted 9 lines · Kevin Hilman
Quoted 7 lines · Axel Lin

Include linux/export.h to fix below build warning:

CC arch/arm/plat-omap/omap_device.o
arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration

Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Axel Lin <[email protected]>

Thanks, will queue as a fix for v3.2-rc

It is probably better if I track this, since export.h won't exist until Linus pulls the module.h-split tree, and I'm guessing that will be closer to the end of the merge window.

OK, sounds good. Feel free to add:

Acked-by Kevin Hilman <[email protected]>

Thanks,

Kevin

#4 lore raw
In reply to Axel Lin
Quoted 6 lines · Axel Lin

Include linux/export.h to fix below build warning:

CC arch/arm/plat-omap/omap_device.o
arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration

Applying into fixes thanks.

Tony