Skip to contentSkip to conversation

Fix generic irq chip

PATCH New Russell King - ARM Linux 5 participants 7 messages May 20, 2011 – May 23, 2011

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Russell King - ARM Linux

author
#0 lore raw

PATCH 1/1 Fix generic irq chip

As a result of c42321c (genirq: Make generic irq chip depend on CONFIG_GENERIC_IRQ_CHIP), we now need those platforms using this in my tree to select this symbol.

Signed-off-by Russell King <[email protected]>

--
Please send acks ASAP. Thanks to Mark for pointing this out with a patch for Samsung.

 arch/arm/Kconfig           |    2 ++
 arch/arm/plat-omap/Kconfig |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/Kconfig +2 -0
index 44c16f0..9b63bab 100644
@@ -854,6 +854,7 @@ config ARCH_DAVINCI
 	select HAVE_IDE
 	select CLKDEV_LOOKUP
 	select GENERIC_ALLOCATOR
+	select GENERIC_IRQ_CHIP
 	select ARCH_HAS_HOLES_MEMORYMODEL
 	help
 	  Support for TI's DaVinci platform.

@@ -1033,6 +1034,7 @@ config PLAT_IOP
 
 config PLAT_ORION
 	bool
+	select GENERIC_IRQ_CHIP
 	select HAVE_SCHED_CLOCK
 
 config PLAT_PXA
arch/arm/plat-omap/Kconfig +1 -0
index cd5f993..29b4c35 100644
@@ -18,6 +18,7 @@ config ARCH_OMAP1
 config ARCH_OMAP2PLUS
 	bool "TI OMAP2/3/4"
 	select CLKDEV_LOOKUP
+	select GENERIC_IRQ_CHIP
 	select OMAP_DM_TIMER
 	help
 	  "Systems based on OMAP2, OMAP3 or OMAP4"
#1 lore raw

PATCH 1/1 Fix generic irq chip

Quoted 8 lines · Russell King - ARM Linux

As a result of c42321c (genirq: Make generic irq chip depend on CONFIG_GENERIC_IRQ_CHIP), we now need those platforms using this in my tree to select this symbol.

Signed-off-by Russell King <[email protected]>

--
Please send acks ASAP. Thanks to Mark for pointing this out with a patch for Samsung.

Acked-by Thomas Gleixner <[email protected]>

Sorry for the confusion, that patch should have hit the arm kernel list two weeks ago, but for whatever reason it did not.

Thanks,

tglx

#2 lore raw

PATCH 1/1 Fix generic irq chip

In reply to Russell King - ARM Linux
Quoted 8 lines · Russell King - ARM Linux

As a result of c42321c (genirq: Make generic irq chip depend on CONFIG_GENERIC_IRQ_CHIP), we now need those platforms using this in my tree to select this symbol.

Signed-off-by Russell King <[email protected]>

--
Please send acks ASAP. Thanks to Mark for pointing this out with a patch for Samsung.

Acked-by Nicolas Pitre <[email protected]>
Quoted 38 lines
 arch/arm/Kconfig           |    2 ++
 arch/arm/plat-omap/Kconfig |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/Kconfig +2 -0
index 44c16f0..9b63bab 100644
@@ -854,6 +854,7 @@ config ARCH_DAVINCI
 	select HAVE_IDE
 	select CLKDEV_LOOKUP
 	select GENERIC_ALLOCATOR
+	select GENERIC_IRQ_CHIP
 	select ARCH_HAS_HOLES_MEMORYMODEL
 	help
 	  Support for TI's DaVinci platform.

@@ -1033,6 +1034,7 @@ config PLAT_IOP
 
 config PLAT_ORION
 	bool
+	select GENERIC_IRQ_CHIP
 	select HAVE_SCHED_CLOCK
 
 config PLAT_PXA
arch/arm/plat-omap/Kconfig +1 -0
index cd5f993..29b4c35 100644
@@ -18,6 +18,7 @@ config ARCH_OMAP1
 config ARCH_OMAP2PLUS
 	bool "TI OMAP2/3/4"
 	select CLKDEV_LOOKUP
+	select GENERIC_IRQ_CHIP
 	select OMAP_DM_TIMER
 	help
 	  "Systems based on OMAP2, OMAP3 or OMAP4"
#3 lore raw

PATCH 1/1 Fix generic irq chip

In reply to Russell King - ARM Linux
Quoted 8 lines · Russell King - ARM Linux

As a result of c42321c (genirq: Make generic irq chip depend on CONFIG_GENERIC_IRQ_CHIP), we now need those platforms using this in my tree to select this symbol.

Signed-off-by Russell King <[email protected]>

--
Please send acks ASAP. Thanks to Mark for pointing this out with a patch for Samsung.

Acked-by Sekhar Nori <[email protected]>

Thanks,
Sekhar

author
#5 lore raw

PATCH 1/1 Fix generic irq chip

Quoted 6 lines · Kevin Hilman
Quoted 4 lines · Russell King - ARM Linux

As a result of c42321c (genirq: Make generic irq chip depend on CONFIG_GENERIC_IRQ_CHIP), we now need those platforms using this in my tree to select this symbol.

Quoted 6 lines
Quoted 4 lines
Signed-off-by Russell King <[email protected]>

--
Please send acks ASAP. Thanks to Mark for pointing this out with a patch for Samsung.

Acked-by Kevin Hilman <[email protected]>

Thanks, but does that cover Davinci or OMAP?

#6 lore raw

PATCH 1/1 Fix generic irq chip

Quoted 7 lines · Russell King - ARM Linux
Quoted 6 lines · Kevin Hilman
Quoted 4 lines · Russell King - ARM Linux

As a result of c42321c (genirq: Make generic irq chip depend on CONFIG_GENERIC_IRQ_CHIP), we now need those platforms using this in my tree to select this symbol.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Russell King <[email protected]>

--
Please send acks ASAP. Thanks to Mark for pointing this out with a patch for Samsung.

Acked-by Kevin Hilman <[email protected]>

Thanks, but does that cover Davinci or OMAP?

Both, but since Sekhar (DaVinci co-maintainer) ack'd already for davinci, I was mainly adding my ack for OMAP.

Kevin