ffmpeg: allow customization of codecs, (de)muxers and other components
PATCH 3/4 ffmpeg: allow customization of codecs, (de)muxers and other components
Quoted 19 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Luca" == Luca Ceresoli <[email protected]> writes:
Luca> Add the option to customize the list of decoders, encoders, Luca> muxers, demuxers, parsers, protocols, bsfs and filters to be Luca> built into ffmpeg, and to compile or exclude input and output Luca> devices.
Luca> +++
b/package/multimedia/ffmpeg/ffmpeg.mk
Luca> @@ -49,6 +49,58 @@ else
Luca>FFMPEG_CONF_OPT+= --disable-ffserver
Luca> endifLuca> +ifneq ($(BR2_PACKAGE_FFMPEG_ENCODERS),"all") Luca> +FFMPEG_CONF_OPT += --disable-encoders \
Luca> + $(foreach x,$(call qstrip,$(BR2_PACKAGE_FFMPEG_ENCODERS)),--enable-encoder=$(x))
Luca> +endif
Luca> +
Luca> +ifneq ($(BR2_PACKAGE_FFMPEG_DECODERS),"all")
Quoted 2 lines
I would suggest you use qstrip + strip here as well, so it doesn't break if the user accidently added extra spaces or so.
How can foreach break with extra spaces? I've been trying things as:
Quoted 1 line
BR2_PACKAGE_FFMPEG_ENCODERS=" vorbis flac "
and they work ok.
BTW, that was with GNU make. Relevant?
Quoted 4 lines
Signature · 2 lines
-- Bye, Peter Korsgaard
Luca
PATCH 3/4 ffmpeg: allow customization of codecs, (de)muxers and other components
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Luca" == Luca Ceresoli <[email protected]> writes:
Hi,
Luca> +ifneq ($(BR2_PACKAGE_FFMPEG_DECODERS),"all")
Quoted 3 lines
Quoted 3 lines
I would suggest you use qstrip + strip here as well, so it doesn't break if the user accidently added extra spaces or so.
Luca> How can foreach break with extra spaces? I've been trying things as:
Quoted 1 line
Quoted 1 line
BR2_PACKAGE_FFMPEG_ENCODERS=" vorbis flac "
Luca> and they work ok.
Not the foreach, but the ifneq (....,"all") would break if the user ended up setting it to "all " or " all" or similar.
Signature · 1 line
Bye, Peter Korsgaard