timekeeping: Fix bogus clock_was_set() invocation in do_adjtimex()
PATCH 1/1 timekeeping: Fix bogus clock_was_set() invocation in do_adjtimex()
The addition of the bases argument to clock_was_set() fixed up all call sites correctly except for do_adjtimex(). This uses CLOCK_REALTIME instead of CLOCK_SET_WALL as argument. CLOCK_REALTIME is 0.
As a result the effect of that clock_was_set() notification is incomplete and might result in timers expiring late because the hrtimer code does not re-evaluate the affected clock bases.
Use CLOCK_SET_WALL instead of CLOCK_REALTIME to tell the hrtimers code which clock bases need to be re-evaluated.
Fixes 17a1b8826b45 ("hrtimer: Add bases argument to clock_was_set()")
Signed-off-by Thomas Gleixner <[email protected]>
Cc John Stultz <[email protected]>
Cc Stephen Boyd <[email protected]>
--- kernel/time/timekeeping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/timekeeping.c +1 -1
@@ -2606,7 +2606,7 @@ int do_adjtimex(struct __kernel_timex *t clock_set |=timekeeping_advance (TK_ADV_FREQ );if (clock_set) -clock_was_set (CLOCK_REALTIME ); +clock_was_set (CLOCK_SET_WALL );ntp_notify_cmos_timer ();