ALSA: hda: Component should be unbound before deconstruction
cover ALSA: hda: Component should be unbound before deconstruction
Small chain of fixes to correct hda drivers using the hda component infrastructure so that they unregister their component before proceeding to deconstruct the driver.
These three patches been separated from the chain "[PATCH v2 0/7] ALSA:
hda: Improvements to hda_component"
Simon Trimmer (3):
ALSA: hda: cs35l56: Component should be unbound before deconstruction
ALSA: hda: cs35l41: Component should be unbound before deconstruction
ALSA: hda: tas2781: Component should be unbound before deconstruction
sound/pci/hda/cs35l41_hda.c | 4 ++-- sound/pci/hda/cs35l56_hda.c | 4 ++-- sound/pci/hda/tas2781_hda_i2c.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/3 ALSA: hda: cs35l56: Component should be unbound before deconstruction
The interface associated with the hda_component should be deactivated before the driver is deconstructed during removal.
--- sound/pci/hda/cs35l56_hda.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/cs35l56_hda.c +2 -2
@@ -1077,12 +1077,12 @@ void cs35l56_hda_remove(struct device *dev) {struct cs35l56_hda *cs35l56 =dev_get_drvdata (dev); +component_del (cs35l56->base.dev, &cs35l56_hda_comp_ops); +pm_runtime_dont_use_autosuspend (cs35l56->base.dev);pm_runtime_get_sync (cs35l56->base.dev);pm_runtime_disable (cs35l56->base.dev); -component_del (cs35l56->base.dev, &cs35l56_hda_comp_ops); -cs_dsp_remove (&cs35l56->cs_dsp);kfree (cs35l56->system_name);
Signature · 1 line
2.34.1
PATCH 2/3 ALSA: hda: cs35l41: Component should be unbound before deconstruction
In reply to Simon TrimmerThe interface associated with the hda_component should be deactivated before the driver is deconstructed during removal.
--- sound/pci/hda/cs35l41_hda.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/cs35l41_hda.c +2 -2
@@ -2019,6 +2019,8 @@ void cs35l41_hda_remove(struct device *dev) {struct cs35l41_hda *cs35l41 =dev_get_drvdata (dev); +component_del (cs35l41->dev, &cs35l41_hda_comp_ops); +pm_runtime_get_sync (cs35l41->dev);pm_runtime_dont_use_autosuspend (cs35l41->dev);pm_runtime_disable (cs35l41->dev);
@@ -2026,8 +2028,6 @@ void cs35l41_hda_remove(struct device *dev)if (cs35l41->halo_initialized)cs35l41_remove_dsp (cs35l41); -component_del (cs35l41->dev, &cs35l41_hda_comp_ops); -acpi_dev_put (cs35l41->dacpi);pm_runtime_put_noidle (cs35l41->dev);
Signature · 1 line
2.34.1
PATCH 3/3 ALSA: hda: tas2781: Component should be unbound before deconstruction
In reply to Simon TrimmerThe interface associated with the hda_component should be deactivated before the driver is deconstructed during removal.
--- sound/pci/hda/tas2781_hda_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/tas2781_hda_i2c.c +2 -2
@@ -777,11 +777,11 @@ static void tas2781_hda_remove(struct device *dev) {struct tas2781_hda *tas_hda =dev_get_drvdata (dev); +component_del (tas_hda->dev, &tas2781_hda_comp_ops); +pm_runtime_get_sync (tas_hda->dev);pm_runtime_disable (tas_hda->dev); -component_del (tas_hda->dev, &tas2781_hda_comp_ops); -pm_runtime_put_noidle (tas_hda->dev);tasdevice_remove (tas_hda->priv);
Signature · 1 line
2.34.1
Takashi Iwai
AppliedQuoted 5 lines · Simon Trimmer
Small chain of fixes to correct hda drivers using the hda component infrastructure so that they unregister their component before proceeding to deconstruct the driver.
Quoted 7 lines
These three patches been separated from the chain "[PATCH v2 0/7] ALSA:
hda: Improvements tohda_component"Simon Trimmer (3):
ALSA: hda: cs35l56: Component should be unbound before deconstruction
ALSA: hda: cs35l41: Component should be unbound before deconstruction
ALSA: hda: tas2781: Component should be unbound before deconstruction
Applied to for-linus branch now.
thanks,
Takashi