Skip to contentSkip to conversation

rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar"

PATCH In review [email protected] 3 participants 3 messages Jul 19, 2023 – Jul 24, 2023 1 message not in the archive Realtek wireless driver (rtlwifi family)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar"

This patch fixes the checkpatch.pl error:

./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: "foo * bar" should be "foo *bar"

---
 drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c +1 -1
index d18c092..27b029b 100644
@@ -2431,7 +2431,7 @@ static bool _rtl92d_is_legal_5g_channel(struct ieee80211_hw *hw, u8 channel)
 }
 
 static void _rtl92d_phy_calc_curvindex(struct ieee80211_hw *hw,
-                       u32 *targetchnl, u32 * curvecount_val,
+                       u32 *targetchnl, u32 *curvecount_val,
                        bool is5g, u32 *curveindex)
 {
     struct rtl_priv *rtlpriv = rtl_priv(hw);
Reviewed-by on v1 1/1
#2 lore raw
Quoted 23 lines · On 7/19/23 04:54, [email protected] wrote:

This patch fixes the checkpatch.pl error:

./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: "foo * bar" should be "foo *bar"

---
  drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c +1 -1
index d18c092..27b029b 100644
@@ -2431,7 +2431,7 @@ static bool _rtl92d_is_legal_5g_channel(struct 
 ieee80211_hw *hw, u8 channel)
  }
 
  static void _rtl92d_phy_calc_curvindex(struct ieee80211_hw *hw,
-                       u32 *targetchnl, u32 * curvecount_val,
+                       u32 *targetchnl, u32 *curvecount_val,
                         bool is5g, u32 *curveindex)
  {
Quoted 1 line

     struct rtl_priv *rtlpriv = rtl_priv(hw);

The preferred subject would be "wifi: rtlwifi: rtl8192de: ...." That can probably be fixed at merge time. I will let Kalle decide that part.

Thanks,

Larry

#3 lore raw
In reply to [email protected]
Quoted 6 lines · [email protected] writes:

This patch fixes the checkpatch.pl error:

./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR:
"foo * bar" should be "foo *bar"

Please don't submit checkpatch fixes to wireless, they are too much work with very little gain.

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches