Skip to contentSkip to conversation

drm/i915/display/dp: Add fallback on LT failure for DP2.0

PATCH In review Arun R Murthy 4 participants 8 messages Jun 20, 2023 – Jun 26, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/display/dp: Add fallback on LT failure for DP2.0

For DP2.0 as per the Spec on LT failure we need to reduce the lane count if the lane count is not equal to 1. If lane count is 1 then need to retry with reducing the link rate.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +18 -2
index 54ddc953e5bc..2b12ca45596d 100644
@@ -657,8 +657,20 @@ int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 				    "Retrying Link training for eDP with same parameters\n");
 			return 0;
 		}
-		intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
-		intel_dp->max_link_lane_count = lane_count;
+		if (intel_dp->dpcd[DP_MAIN_LINK_CHANNEL_CODING] & DP_CAP_ANSI_128B132B) {
+			if (lane_count > 1) {
+				/* Reduce the lane count */
+				intel_dp->max_link_lane_count = lane_count >> 1;
+				intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index);
+			} else {
+				/* Reduce the link rate */
+				intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
+				intel_dp->max_link_lane_count = intel_dp_max_common_lane_count(intel_dp);
+			}
+		} else {
+			intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
+			intel_dp->max_link_lane_count = lane_count;
+		}
 	} else if (lane_count > 1) {
 		if (intel_dp_is_edp(intel_dp) &&
 		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
@@ -675,6 +687,10 @@ int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 		return -1;
 	}
 
+	drm_dbg_kms(&i915->drm,
+		    "Retrying Link training with link rate %d and lane count %d\n",
+		    intel_dp->max_link_rate, intel_dp->max_link_lane_count);
+
 	return 0;
 }
 
Signature · 1 line
2.25.1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dp: Add fallback on LT failure for DP2.0

== Series Details ==

== Series Details ==

Series: drm/i915/display/dp: Add fallback on LT failure for DP2.0
URL : https://patchwork.freedesktop.org/series/119567/
State : warning

== Summary ==

Error: dim checkpatch failed
ccd7b37665f6 drm/i915/display/dp: Add fallback on LT failure for DP2.0 -:30: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #30: FILE: drivers/gpu/drm/i915/display/intel_dp.c:668:
+ intel_dp->max_link_lane_count = intel_dp_max_common_lane_count(intel_dp);

total: 0 errors, 1 warnings, 0 checks, 32 lines checked

#2 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/dp: Add fallback on LT failure for DP2.0

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: drm/i915/display/dp: Add fallback on LT failure for DP2.0
URL : https://patchwork.freedesktop.org/series/119567/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13290 -> Patchwork_119567v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/index.html

Participating hosts (42 -> 41)
------------------------------

Additional (1): fi-kbl-soraka
Missing (2): bat-mtlp-8 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_119567v1:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-1}:
- bat-dg2-8: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

Known issues
------------

Here are the changes found in Patchwork_119567v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@dmabuf@all-tests@dma_fence:
- bat-dg2-11: [PASS][3] -> [DMESG-FAIL][4] ([i915#8189])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/bat-dg2-11/igt@dmabuf@all-tests@dma_fence.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-dg2-11/igt@dmabuf@all-tests@dma_fence.html

* igt@dmabuf@all-tests@sanitycheck:
- bat-dg2-11: [PASS][5] -> [ABORT][6] ([i915#7699] / [i915#8144])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/bat-dg2-11/igt@dmabuf@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-dg2-11/igt@dmabuf@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/fi-kbl-soraka/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/fi-kbl-soraka/igt@[email protected]

* igt@i915_module_load@reload:
- fi-kbl-soraka: NOTRUN -> [DMESG-WARN][9] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/fi-kbl-soraka/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][10] ([i915#1886] / [i915#7913])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][11] -> [DMESG-WARN][12] ([i915#7699])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/bat-dg2-11/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-dg2-11/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][13] ([i915#6367])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-rpls-2/igt@i915_selftest@[email protected]
- bat-rpls-1: NOTRUN -> [DMESG-WARN][14] ([i915#6367])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][15] ([i915#6687] / [i915#8668])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-rpls-2/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][16] ([i915#6687] / [i915#7978])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-rpls-1/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-kbl-soraka: NOTRUN -> [SKIP][17] ([fdo#109271]) +14 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/fi-kbl-soraka/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4579])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/fi-kbl-soraka/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@migrate:
- bat-atsm-1: [DMESG-FAIL][19] ([i915#7699] / [i915#7913]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/bat-atsm-1/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-atsm-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][21] ([i915#4983] / [i915#7461] / [i915#7981] / [i915#8347] / [i915#8384]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/bat-rpls-1/igt@i915_selftest@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-rpls-1/igt@i915_selftest@[email protected]
- bat-rpls-2: [ABORT][23] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#7981] / [i915#8347]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/bat-rpls-2/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-rpls-2/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@i915_module_load@load:
- bat-adlp-11: [DMESG-WARN][25] ([i915#4423]) -> [ABORT][26] ([i915#4423])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/bat-adlp-11/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/bat-adlp-11/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
[i915#8144]: https://gitlab.freedesktop.org/drm/intel/issues/8144
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668

Build changes
-------------

* Linux: CI_DRM_13290 -> Patchwork_119567v1

CI-20190529: 20190529
CI_DRM_13290: d8109039969700315ed327adfab8732c3c882bd6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7338: 4f2f4b61eafc613ec58fd07bb11be7072b41c6bf @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119567v1: d8109039969700315ed327adfab8732c3c882bd6 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

76f997bfc597 drm/i915/display/dp: Add fallback on LT failure for DP2.0

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/index.html

#3 lore raw
In reply to Arun R Murthy
Quoted 3 lines

For DP2.0 as per the Spec on LT failure we need to reduce the lane count if the lane count is not equal to 1. If lane count is 1 then need to retry with reducing the link rate.

Maybe adding the section where one can refer this in DP 2.0 spec can help.

Quoted 12 lines
---
 drivers/gpu/drm/i915/display/intel_dp.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 54ddc953e5bc..2b12ca45596d 100644

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct · line 664

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -2
@@ -657,8 +657,20 @@ int intel_dp_get_link_train_fallback_values(struct
 intel_dp *intel_dp,
 				    "Retrying Link training for eDP with same
 parameters\n");
 			return 0;
 		}
-		intel_dp->max_link_rate = intel_dp_common_rate(intel_dp,
 index - 1);
-		intel_dp->max_link_lane_count = lane_count;

NIT: Can we add a small comment here on what is being done.

Quoted 18 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
+		if (intel_dp->dpcd[DP_MAIN_LINK_CHANNEL_CODING] &

DP_CAP_ANSI_128B132B) {

drivers/gpu/drm/i915/display/intel_dp.c +3 -0
+			if (lane_count > 1) {
+				/* Reduce the lane count */
+				intel_dp->max_link_lane_count = lane_count
Quoted 1 line
Quoted 1 line

1;

drivers/gpu/drm/i915/display/intel_dp.c +1 -0
+				intel_dp->max_link_rate =

intel_dp_common_rate(intel_dp, index);

drivers/gpu/drm/i915/display/intel_dp.c +3 -0
+			} else {
+				/* Reduce the link rate */
+				intel_dp->max_link_rate =

intel_dp_common_rate(intel_dp, index - 1);

drivers/gpu/drm/i915/display/intel_dp.c +1 -0
+				intel_dp->max_link_lane_count =

intel_dp_max_common_lane_count(intel_dp);

drivers/gpu/drm/i915/display/intel_dp.c +3 -0
+			}
+		} else {
+			intel_dp->max_link_rate =

intel_dp_common_rate(intel_dp, index - 1);

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp, · line 673

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_dp.c +2 -0
+			intel_dp->max_link_lane_count = lane_count;
+		}

Also I see a little issue here so previously what used to happen was we reduced the Link rate first and once we were at the lowest only then proceed to reduce the lane count so has this been reversed in DP2.0 spec.

Regards,
Suraj Kandpal

Quoted 18 lines
drivers/gpu/drm/i915/display/intel_dp.c +4 -0
 	} else if (lane_count > 1) {
 		if (intel_dp_is_edp(intel_dp) &&
 		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
@@ -675,6 +687,10 @@ int intel_dp_get_link_train_fallback_values(struct
 intel_dp *intel_dp,
 		return -1;
 	}
 
+	drm_dbg_kms(&i915->drm,
+		    "Retrying Link training with link rate %d and lane count
 %d\n",
+		    intel_dp->max_link_rate, intel_dp->max_link_lane_count);
+
 	return 0;

}

--
2.25.1

#4 lore raw
Quoted 8 lines

-----Original Message-----
From: Kandpal, Suraj <[email protected]>
Sent: Tuesday, June 20, 2023 4:35 PM
To: Murthy, Arun R <[email protected]>; intel- [email protected]
Subject: RE: [Intel-gfx] [PATCH] drm/i915/display/dp: Add fallback on LT failure for DP2.0

Quoted 6 lines
Quoted 3 lines

For DP2.0 as per the Spec on LT failure we need to reduce the lane count if the lane count is not equal to 1. If lane count is 1 then need to retry with reducing the link rate.

Maybe adding the section where one can refer this in DP 2.0 spec can help.

Ok Sure!

Quoted 16 lines
Quoted 12 lines
---
 drivers/gpu/drm/i915/display/intel_dp.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 54ddc953e5bc..2b12ca45596d 100644
@@ -657,8 +657,20 @@ int
Quoted 3 lines

intel_dp_get_link_train_fallback_values(struct
intel_dp *intel_dp,
"Retrying Link training for eDP with same

parameters\n");

Quoted 8 lines

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp, · line 661

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -1
 			return 0;
 		}
-		intel_dp->max_link_rate = intel_dp_common_rate(intel_dp,

index - 1);

drivers/gpu/drm/i915/display/intel_dp.c +0 -1
-		intel_dp->max_link_lane_count = lane_count;

NIT: Can we add a small comment here on what is being done.

Comments are added below as to what each if condition is doing or is it something different that you are referring to?

Quoted 16 lines
Quoted 16 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
+		if (intel_dp->dpcd[DP_MAIN_LINK_CHANNEL_CODING] &

DP_CAP_ANSI_128B132B) {

drivers/gpu/drm/i915/display/intel_dp.c +3 -0
+			if (lane_count > 1) {
+				/* Reduce the lane count */
+				intel_dp->max_link_lane_count = lane_count
Quoted 1 line
Quoted 1 line

1;

drivers/gpu/drm/i915/display/intel_dp.c +1 -0
+				intel_dp->max_link_rate =

intel_dp_common_rate(intel_dp, index);

drivers/gpu/drm/i915/display/intel_dp.c +3 -0
+			} else {
+				/* Reduce the link rate */
+				intel_dp->max_link_rate =

intel_dp_common_rate(intel_dp, index - 1);

drivers/gpu/drm/i915/display/intel_dp.c +1 -0
+				intel_dp->max_link_lane_count =

intel_dp_max_common_lane_count(intel_dp);

drivers/gpu/drm/i915/display/intel_dp.c +2 -0
+			}
+		} else {
Quoted 9 lines

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp, · line 673

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
+			intel_dp->max_link_rate =

intel_dp_common_rate(intel_dp, index - 1);

drivers/gpu/drm/i915/display/intel_dp.c +2 -0
+			intel_dp->max_link_lane_count = lane_count;
+		}

Also I see a little issue here so previously what used to happen was we reduced the Link rate first and once we were at the lowest only then proceed to reduce the lane count so has this been reversed in DP2.0 spec.

Yes here we reduce the lane count until 1 and then reduce the link rate.
Ref: Table 3-31 of DP2.1 Spec

Thanks and Regards,
Arun R Murthy
--------------------

Quoted 22 lines

Regards,
Suraj Kandpal

Quoted 19 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 	} else if (lane_count > 1) {
 		if (intel_dp_is_edp(intel_dp) &&
 		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
@@ -675,6 +687,10 @@ int

intel_dp_get_link_train_fallback_values(struct
intel_dp *intel_dp,

drivers/gpu/drm/i915/display/intel_dp.c +2 -0
 		return -1;
 	}
 
+	drm_dbg_kms(&i915->drm,
+		    "Retrying Link training with link rate %d and lane count

%d\n",

drivers/gpu/drm/i915/display/intel_dp.c +2 -1
+		    intel_dp->max_link_rate, intel_dp->max_link_lane_count);
+
 	return 0;
 }
 
--

2.25.1

#5 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/dp: Add fallback on LT failure for DP2.0

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: drm/i915/display/dp: Add fallback on LT failure for DP2.0
URL : https://patchwork.freedesktop.org/series/119567/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13290_full -> Patchwork_119567v1_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (7 -> 8)
------------------------------

Additional (1): shard-rkl0

Known issues
------------

Here are the changes found in Patchwork_119567v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_close_race@multigpu-basic-threads:
- shard-tglu: NOTRUN -> [SKIP][1] ([i915#7697])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@gem_ctx_sseu@invalid-sseu:
- shard-tglu: NOTRUN -> [SKIP][2] ([i915#280])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-tglu: NOTRUN -> [FAIL][3] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-rkl: [PASS][4] -> [FAIL][5] ([i915#2842])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-1/igt@gem_exec_fair@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-tglu: [PASS][6] -> [INCOMPLETE][7] ([i915#6755] / [i915#7392] / [i915#7663])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-tglu-5/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-10/igt@[email protected]

* igt@gem_lmem_swapping@random-engines:
- shard-tglu: NOTRUN -> [SKIP][8] ([i915#4613])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@gem_mmap_gtt@coherency:
- shard-tglu: NOTRUN -> [SKIP][9] ([fdo#111656])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-off-1:
- shard-tglu: NOTRUN -> [SKIP][10] ([i915#4270])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@gen7_exec_parse@chained-batch:
- shard-tglu: NOTRUN -> [SKIP][11] ([fdo#109289])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-tglu: NOTRUN -> [WARN][12] ([i915#2681])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-rkl: [PASS][13] -> [SKIP][14] ([i915#1397])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-7/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-tglu: NOTRUN -> [SKIP][15] ([fdo#111615] / [i915#5286])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglu: NOTRUN -> [SKIP][16] ([fdo#111615])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglu: NOTRUN -> [SKIP][17] ([i915#3689] / [i915#3886] / [i915#5354] / [i915#6095])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-tglu: NOTRUN -> [SKIP][18] ([fdo#111615] / [i915#3689] / [i915#5354] / [i915#6095])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs.html

* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs:
- shard-tglu: NOTRUN -> [SKIP][19] ([i915#3689] / [i915#5354] / [i915#6095]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs.html

* igt@kms_ccs@pipe-c-crc-primary-rotation-180-4_tiled_mtl_mc_ccs:
- shard-tglu: NOTRUN -> [SKIP][20] ([i915#5354] / [i915#6095]) +5 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@kms_ccs@pipe-c-crc-primary-rotation-180-4_tiled_mtl_mc_ccs.html

* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3886])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-apl2/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_chamelium_color@degamma:
- shard-tglu: NOTRUN -> [SKIP][22] ([fdo#111827])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_chamelium_hpd@dp-hpd-after-suspend:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271]) +9 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-apl7/igt@[email protected]

* igt@kms_chamelium_hpd@hdmi-hpd-storm-disable:
- shard-tglu: NOTRUN -> [SKIP][24] ([i915#7828]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_content_protection@srm:
- shard-tglu: NOTRUN -> [SKIP][25] ([i915#4579] / [i915#6944] / [i915#7116] / [i915#7118])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size:
- shard-tglu: NOTRUN -> [SKIP][26] ([fdo#109274]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#2346]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-glk5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-glk5/igt@[email protected]
- shard-apl: [PASS][29] -> [FAIL][30] ([i915#2346])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-apl7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-apl3/igt@[email protected]

* igt@kms_cursor_legacy@single-bo@pipe-b:
- shard-rkl: [PASS][31] -> [INCOMPLETE][32] ([i915#8011])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-4/igt@kms_cursor_legacy@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-7/igt@kms_cursor_legacy@[email protected]

* igt@kms_dsc@dsc-with-bpc:
- shard-tglu: NOTRUN -> [SKIP][33] ([i915#3840] / [i915#4579])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-snb: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111767])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-snb4/igt@[email protected]

* igt@kms_flip@2x-nonexisting-fb:
- shard-tglu: NOTRUN -> [SKIP][35] ([fdo#109274] / [i915#3637])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][36] -> [FAIL][37] ([i915#2122])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-glk6/igt@kms_flip@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-glk2/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][38] ([i915#2587] / [i915#2672] / [i915#4579]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
- shard-tglu: NOTRUN -> [SKIP][39] ([fdo#109280]) +9 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_hdr@invalid-metadata-sizes:
- shard-tglu: NOTRUN -> [SKIP][40] ([i915#4579] / [i915#6953] / [i915#8228])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_plane_scaling@invalid-num-scalers@pipe-a-hdmi-a-1-invalid-num-scalers:
- shard-snb: NOTRUN -> [SKIP][41] ([fdo#109271]) +15 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-snb1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][42] ([i915#4579] / [i915#5176]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-3/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-b-hdmi-a-2.html

* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][43] ([i915#5176]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#4579]) +14 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-snb5/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][45] ([i915#5235])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-2.html

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][46] ([i915#4579] / [i915#5235])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2.html

* igt@kms_psr@sprite_blt:
- shard-tglu: NOTRUN -> [SKIP][47] ([fdo#110189]) +6 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@kms_psr@sprite_blt.html

* igt@kms_scaling_modes@scaling-mode-full:
- shard-tglu: NOTRUN -> [SKIP][48] ([i915#3555] / [i915#4579]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@[email protected]

* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][49] ([i915#5465]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-snb4/igt@kms_setmode@[email protected]

* igt@kms_tv_load_detect@load-detect:
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-glk6/igt@[email protected]

* igt@v3d/v3d_job_submission@multiple-singlesync-to-multisync:
- shard-tglu: NOTRUN -> [SKIP][51] ([fdo#109315] / [i915#2575]) +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@v3d/[email protected]

* igt@vc4/vc4_tiling@get-bad-flags:
- shard-tglu: NOTRUN -> [SKIP][52] ([i915#2575])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@vc4/[email protected]

#### Possible fixes ####

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglu: [FAIL][53] ([i915#6268]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-tglu-2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-5/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@vcs1:
- {shard-dg1}: [DMESG-WARN][55] ([i915#4391] / [i915#4423]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-dg1-18/igt@gem_ctx_isolation@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-dg1-14/igt@gem_ctx_isolation@[email protected]

* igt@gem_eio@reset-stress:
- {shard-dg1}: [FAIL][57] ([i915#5784]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-dg1-17/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-dg1-13/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][59] ([i915#2846]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-glk7/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-glk3/igt@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-rkl: [FAIL][61] ([i915#2842]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-2/igt@gem_exec_fair@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-tglu: [ABORT][63] ([i915#7975] / [i915#8213]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-tglu-10/igt@gem_exec_suspend@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-6/igt@gem_exec_suspend@[email protected]

* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-snb: [INCOMPLETE][65] ([i915#8295]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-snb6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-snb6/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-tglu: [SKIP][67] ([i915#4281]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-tglu-5/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-2/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- {shard-dg1}: [FAIL][69] ([i915#3591]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-dg1-18/igt@i915_pm_rc6_residency@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-dg1-18/igt@i915_pm_rc6_residency@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-rkl: [SKIP][71] ([i915#1397]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-1/igt@[email protected]

* igt@kms_cursor_legacy@single-move@pipe-b:
- {shard-dg1}: [INCOMPLETE][73] ([i915#8011] / [i915#8347]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-dg1-19/igt@kms_cursor_legacy@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-dg1-16/igt@kms_cursor_legacy@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [ABORT][75] ([i915#180]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-apl2/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-apl2/igt@[email protected]

#### Warnings ####

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
- shard-snb: [SKIP][77] ([fdo#109271] / [i915#4579]) -> [SKIP][78] ([fdo#109271] / [i915#1769] / [i915#4579]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-snb7/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-snb1/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
- shard-tglu: [SKIP][79] ([i915#3555] / [i915#4579]) -> [SKIP][80] ([i915#1769] / [i915#3555] / [i915#4579]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-tglu-8/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-8/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
- shard-glk: [SKIP][81] ([fdo#109271] / [i915#4579]) -> [SKIP][82] ([fdo#109271] / [i915#1769] / [i915#4579]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-glk9/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-glk4/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html

* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-rkl: [SKIP][83] ([i915#3555] / [i915#4579]) -> [SKIP][84] ([i915#1769] / [i915#3555] / [i915#4579]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-4/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-6/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
- shard-apl: [SKIP][85] ([fdo#109271] / [i915#4579]) -> [SKIP][86] ([fdo#109271] / [i915#1769] / [i915#4579]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-apl7/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-apl3/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html

* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-rkl: [SKIP][87] ([fdo#111825]) -> [SKIP][88] ([fdo#111767] / [fdo#111825]) +5 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-1/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-6/igt@[email protected]
- shard-apl: [SKIP][89] ([fdo#109271]) -> [SKIP][90] ([fdo#109271] / [fdo#111767]) +5 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-apl2/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-apl2/igt@[email protected]
- shard-snb: [SKIP][91] ([fdo#109271]) -> [SKIP][92] ([fdo#109271] / [fdo#111767]) +4 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-snb6/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-snb6/igt@[email protected]
- shard-tglu: [SKIP][93] ([fdo#109274]) -> [SKIP][94] ([fdo#109274] / [fdo#111767]) +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-tglu-6/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-10/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][95] ([fdo#110189] / [i915#3955]) -> [SKIP][96] ([i915#3955])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-1/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-blocking-wf-vblank:
- shard-tglu: [SKIP][97] ([fdo#109274] / [i915#3637]) -> [SKIP][98] ([fdo#109274] / [fdo#111767] / [i915#3637]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-tglu-2/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-tglu-7/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][99] ([fdo#109285] / [i915#4098]) -> [SKIP][100] ([fdo#109285])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-2/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-7/igt@[email protected]

* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][101] ([i915#4816]) -> [SKIP][102] ([i915#4070] / [i915#4816])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13290/shard-rkl-4/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/shard-rkl-2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7663]: https://gitlab.freedesktop.org/drm/intel/issues/7663
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347

Build changes
-------------

* Linux: CI_DRM_13290 -> Patchwork_119567v1

CI-20190529: 20190529
CI_DRM_13290: d8109039969700315ed327adfab8732c3c882bd6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7338: 4f2f4b61eafc613ec58fd07bb11be7072b41c6bf @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119567v1: d8109039969700315ed327adfab8732c3c882bd6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119567v1/index.html

maintainer
#6 lore raw
In reply to Arun R Murthy
Quoted 14 lines · Arun R Murthy

For DP2.0 as per the Spec on LT failure we need to reduce the lane count if the lane count is not equal to 1. If lane count is 1 then need to retry with reducing the link rate.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 54ddc953e5bc..2b12ca45596d 100644

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp, · line 660

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp.c +1 -2
@@ -657,8 +657,20 @@ int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 				    "Retrying Link training for eDP with same parameters\n");
 			return 0;
 		}
-		intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
-		intel_dp->max_link_lane_count = lane_count;
+		if (intel_dp->dpcd[DP_MAIN_LINK_CHANNEL_CODING] & DP_CAP_ANSI_128B132B) {

This doesn't mean we're actually using UHBR. And we don't get here for UHBR because it's always mst. And this doesn't handle mst (it should). There are a lot of gaps here.

The whole thing has been discussed before, and my previous idea was that we'd generate a list of {link rate, link lane count} pairs up front, in the correct order, and just have one an index to that list for the fallback. Because the logic here is complicated to follow.

Eventually we'd need to be able to switch between UHBR and non-UHBR in the fallback too, which we aren't capable of doing at the moment.

BR,
Jani.

Quoted 26 lines
drivers/gpu/drm/i915/display/intel_dp.c +17 -0
+			if (lane_count > 1) {
+				/* Reduce the lane count */
+				intel_dp->max_link_lane_count = lane_count >> 1;
+				intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index);
+			} else {
+				/* Reduce the link rate */
+				intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
+				intel_dp->max_link_lane_count = intel_dp_max_common_lane_count(intel_dp);
+			}
+		} else {
+			intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
+			intel_dp->max_link_lane_count = lane_count;
+		}
 	} else if (lane_count > 1) {
 		if (intel_dp_is_edp(intel_dp) &&
 		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
@@ -675,6 +687,10 @@ int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 		return -1;
 	}
 
+	drm_dbg_kms(&i915->drm,
+		    "Retrying Link training with link rate %d and lane count %d\n",
+		    intel_dp->max_link_rate, intel_dp->max_link_lane_count);
+
 	return 0;
 }
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#7 lore raw
Quoted 32 lines

-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, June 20, 2023 7:26 PM
To: Murthy, Arun R <[email protected]>; intel- [email protected]
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/dp: Add fallback on LT failure for DP2.0

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct

Quoted 15 lines · Arun R Murthy

For DP2.0 as per the Spec on LT failure we need to reduce the lane count if the lane count is not equal to 1. If lane count is 1 then need to retry with reducing the link rate.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
index 54ddc953e5bc..2b12ca45596d 100644
@@ -657,8 +657,20 @@ int intel_dp_get_link_train_fallback_values(struct

intel_dp *intel_dp,

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct · line 657

Quoted 1 line
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 				    "Retrying Link training for eDP with same

parameters\n");

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -1
 			return 0;
 		}
-		intel_dp->max_link_rate = intel_dp_common_rate(intel_dp,

index - 1);

Quoted 7 lines

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct · line 661

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp.c +2 -1
-		intel_dp->max_link_lane_count = lane_count;
+		if (intel_dp->dpcd[DP_MAIN_LINK_CHANNEL_CODING] &
+DP_CAP_ANSI_128B132B) {

This doesn't mean we're actually using UHBR. And we don't get here for UHBR because it's always mst. And this doesn't handle mst (it should). There are a lot of gaps here.

Agree, this patch is not trying to fill the entire gaps and instead trying to have a fallback within the UHBR range.

Quoted 9 lines

The whole thing has been discussed before, and my previous idea was that we'd generate a list of {link rate, link lane count} pairs up front, in the correct order, and just have one an index to that list for the fallback. Because the logic here is complicated to follow.

Eventually we'd need to be able to switch between UHBR and non-UHBR in the fallback too, which we aren't capable of doing at the moment.

Yes agree on this.
Will drop this patch over here for now!

Thanks and Regards,
Arun R Murthy
--------------------

Quoted 41 lines

BR,
Jani.

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct · line 666

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +4 -0
+			if (lane_count > 1) {
+				/* Reduce the lane count */
+				intel_dp->max_link_lane_count = lane_count
 > 1;
+				intel_dp->max_link_rate =

intel_dp_common_rate(intel_dp, index);

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp.c +3 -0
+			} else {
+				/* Reduce the link rate */
+				intel_dp->max_link_rate =

intel_dp_common_rate(intel_dp, index - 1);

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct · line 670

Quoted 1 line
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
+				intel_dp->max_link_lane_count =

intel_dp_max_common_lane_count(intel_dp);

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp.c +3 -0
+			}
+		} else {
+			intel_dp->max_link_rate =

intel_dp_common_rate(intel_dp, index - 1);

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp.c +2 -0
+			intel_dp->max_link_lane_count = lane_count;
+		}
 	} else if (lane_count > 1) {
 		if (intel_dp_is_edp(intel_dp) &&
 		    !intel_dp_can_link_train_fallback_for_edp(intel_dp,
@@ -675,6 +687,10 @@ int intel_dp_get_link_train_fallback_values(struct

intel_dp *intel_dp,

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dp.c +2 -0
 		return -1;
 	}
 
+	drm_dbg_kms(&i915->drm,
+		    "Retrying Link training with link rate %d and lane count

%d\n",

drivers/gpu/drm/i915/display/intel_dp.c int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp, · line 695

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp.c +2 -0
+		    intel_dp->max_link_rate, intel_dp->max_link_lane_count);
+
 	return 0;
 }

--
Jani Nikula, Intel Open Source Graphics Center