dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required
Subsystems (5)
Geert Uytterhoeven
maintainercover dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required
Hi all,
The Renesas R-Car CAN FD Controller always uses two or more interrupts. Hence it makes sense to make the interrupt-names property a required property, to make it easier to identify the individual interrupts, and validate the mapping.
- The first patch updates the various R-Car Gen3 and RZ/G2 DTS files to add interrupt-names properties, and is intended for the renesas-devel tree,
- The second patch updates the CAN-FD DT bindings to mark the interrupt-names property required, and is intended for the DT or net tree.
Thanks!
Geert Uytterhoeven (2):
arm64: dts: renesas: Add interrupt-names to CANFD nodes
dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required
.../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 3 ++- arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77951.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77960.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77961.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77990.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77995.dtsi | 1 + 13 files changed, 14 insertions(+), 1 deletion(-)
Signature · 12 lines
2.25.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsGeert Uytterhoeven
maintainerPATCH 1/2 arm64: dts: renesas: Add interrupt-names to CANFD nodes
The Renesas R-Car CAN FD Controller on R-Car Gen3 and RZ/G2 SoCs has two interrupts. Add interrupt-names properties to all CAN-FD device nodes to identify the individual interrupts, so we can make this property a required property in the DT bindings.
--- arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77951.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77960.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77961.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77990.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77995.dtsi | 1 + 12 files changed, 12 insertions(+)
arch/arm64/boot/dts/renesas/r8a774a1.dtsi +1 -0
@@ -1179,6 +1179,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A774A1_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a774b1.dtsi +1 -0
@@ -1052,6 +1052,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A774B1_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a774c0.dtsi +1 -0
@@ -1009,6 +1009,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A774C0_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a774e1.dtsi +1 -0
@@ -1280,6 +1280,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A774E1_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a77951.dtsi +1 -0
@@ -1368,6 +1368,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A7795_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a77960.dtsi +1 -0
@@ -1240,6 +1240,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A7796_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a77961.dtsi +1 -0
@@ -1229,6 +1229,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A77961_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a77965.dtsi +1 -0
@@ -1103,6 +1103,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A77965_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a77970.dtsi +1 -0
@@ -557,6 +557,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A77970_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a77980.dtsi +1 -0
@@ -609,6 +609,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A77980_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a77990.dtsi +1 -0
@@ -1052,6 +1052,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A77990_CLK_CANFD>, <&can_clk>;
arch/arm64/boot/dts/renesas/r8a77995.dtsi +1 -0
@@ -557,6 +557,7 @@ canfd: can@e66c0000 { reg = <0 0xe66c0000 0 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A77995_CLK_CANFD>, <&can_clk>;
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerPATCH 2/2 dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required
In reply to Geert UytterhoevenThe Renesas R-Car CAN FD Controller always uses two or more interrupts. Make the interrupt-names properties a required property, to make it easier to identify the individual interrupts.
Update the example accordingly.
--- .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml +2 -1
@@ -88,6 +88,7 @@ required: - compatible - reg - interrupts + - interrupt-names - clocks - clock-names - power-domains
@@ -136,7 +137,6 @@ then: - const: rstc_n required: - - interrupt-names - reset-names else: properties:
@@ -167,6 +167,7 @@ examples: reg = <0xe66c0000 0x8000>; interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch_int", "g_int"; clocks = <&cpg CPG_MOD 914>, <&cpg CPG_CORE R8A7795_CLK_CANFD>, <&can_clk>;
Signature · 1 line
2.25.1
Marc Kleine-Budde
maintainerQuoted 7 lines · Geert Uytterhoeven
The Renesas R-Car CAN FD Controller always uses two or more interrupts. Make the interrupt-names properties a required property, to make it easier to identify the individual interrupts.
Update the example accordingly.
Signed-off-by Geert Uytterhoeven <[email protected]>
Applied to linux-can-next/testing.
regards,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Marc Kleine-Budde
maintainerQuoted 7 lines · Geert Uytterhoeven
Hi all,
The Renesas R-Car CAN FD Controller always uses two or more interrupts. Hence it makes sense to make the interrupt-names property a required property, to make it easier to identify the individual interrupts, and validate the mapping.
Quoted 8 lines
- The first patch updates the various R-Car Gen3 and RZ/G2 DTS files to add interrupt-names properties, and is intended for the renesas-devel tree,
- The second patch updates the CAN-FD DT bindings to mark the interrupt-names property required, and is intended for the DT or net tree.Thanks!
LGTM. Who takes this series?
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Hi Marc,
Quoted 13 lines · Marc Kleine-Budde
Quoted 12 lines · Geert Uytterhoeven
The Renesas R-Car CAN FD Controller always uses two or more interrupts. Hence it makes sense to make the interrupt-names property a required property, to make it easier to identify the individual interrupts, and validate the mapping.
- The first patch updates the various R-Car Gen3 and RZ/G2 DTS files to add interrupt-names properties, and is intended for the renesas-devel tree,
- The second patch updates the CAN-FD DT bindings to mark the interrupt-names property required, and is intended for the DT or net tree.
Quoted 3 lines
Quoted 1 line
Thanks!
LGTM. Who takes this series?
I'll take the first patch.
The second patch is up to you and the DT maintainers.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Marc Kleine-Budde
maintainerQuoted 16 lines · Geert Uytterhoeven
Hi Marc,
Quoted 13 lines · Marc Kleine-Budde
Quoted 12 lines · Geert Uytterhoeven
The Renesas R-Car CAN FD Controller always uses two or more interrupts. Hence it makes sense to make the interrupt-names property a required property, to make it easier to identify the individual interrupts, and validate the mapping.
- The first patch updates the various R-Car Gen3 and RZ/G2 DTS files to add interrupt-names properties, and is intended for the renesas-devel tree,
- The second patch updates the CAN-FD DT bindings to mark the interrupt-names property required, and is intended for the DT or net tree.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Thanks!
LGTM. Who takes this series?
I'll take the first patch.
The second patch is up to you and the DT maintainers.
Sounds good.
regards,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |