Skip to contentSkip to conversation

package/rauc: d-bus support is optional

PATCH In review Peter Korsgaard 1 participant 2 messages Feb 5, 2022 – Feb 7, 2022

lore
Share & tools
lore

Peter Korsgaard

author
#0 lore raw

PATCH 1/1 package/rauc: d-bus support is optional

As pointed out by Jan Lübbe, D-Bus support is optional:

Quoted 1 line

You can build without D-Bus (./configure --disable-service).

So drop it from the required dependencies and add a RAUC_DBUS sub option like it is done for network/json.

Signed-off-by Peter Korsgaard <[email protected]>
---
 package/rauc/Config.in | 8 +++++++-
 package/rauc/rauc.mk   | 9 ++++++++-
 2 files changed, 15 insertions(+), 2 deletions(-)
package/rauc/Config.in +7 -1
index 676ff42b51..b4f7b81948 100644
@@ -5,7 +5,6 @@ config BR2_PACKAGE_RAUC
 	depends on BR2_USE_WCHAR # glib2
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_OPENSSL
-	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_SQUASHFS # run-time dependency
 	select BR2_PACKAGE_UBOOT_TOOLS if BR2_TARGET_UBOOT # run-time dependency
 	select BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV if BR2_TARGET_UBOOT

@@ -19,6 +18,13 @@ config BR2_PACKAGE_RAUC
 
 if BR2_PACKAGE_RAUC
 
+config BR2_PACKAGE_RAUC_DBUS
+	bool "dbus support"
+	select BR2_PACKAGE_DBUS
+	help
+	  This option enables support for controlling rauc through
+	  D-Bus.
+
 config BR2_PACKAGE_RAUC_NETWORK
 	bool "network support"
 	select BR2_PACKAGE_LIBCURL
package/rauc/rauc.mk +8 -1
index 4fb3ddde3e..99efc16c2f 100644
@@ -10,7 +10,14 @@ RAUC_SOURCE = rauc-$(RAUC_VERSION).tar.xz
 RAUC_LICENSE = LGPL-2.1
 RAUC_LICENSE_FILES = COPYING
 RAUC_CPE_ID_VENDOR = pengutronix
-RAUC_DEPENDENCIES = host-pkgconf openssl libglib2 dbus
+RAUC_DEPENDENCIES = host-pkgconf openssl libglib2
+
+ifeq ($(BR2_PACKAGE_RAUC_DBUS),y)
+RAUC_CONF_OPTS += --enable-service
+RAUC_DEPENDENCIES += dbus
+else
+RAUC_CONF_OPTS += --disable-service
+endif
 
 ifeq ($(BR2_PACKAGE_RAUC_NETWORK),y)
 RAUC_CONF_OPTS += --enable-network
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#1 lore raw
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

As pointed out by Jan Lübbe, D-Bus support is optional:

Quoted 1 line

You can build without D-Bus (./configure --disable-service).

So drop it from the required dependencies and add a RAUC_DBUS sub option like it is done for network/json.

Signed-off-by Peter Korsgaard <[email protected]>

Committed, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot