Skip to contentSkip to conversation

RISC-V: Make stub compile without c extension

PATCH In review Florian Wagner 6 participants 7 messages Jan 17, 2022 – Jan 20, 2022 RISC-V

lore
Share & tools
lore
#0 lore raw

cover RISC-V: Make stub compile without c extension

This is a small patch to get the head.S for riscv compiling without the compressed instructions extension for riscv. Specifically a magic number in a signature field was described as an instruction instead of a constant in the assembly. The patch changes this to encode the value via .ascii which is closer to the original specification.

The generated code should is byte-by-byte equal.

Best Regards
Florian

Florian Wagner (1):
RISC-V: Change signature header field to use .ascii instead of
opcode

 arch/riscv/kernel/head.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 16 lines
2.25.1


-- 
This e-mail message and any attachments thereto are intended only for the 
person or entity to which it is addressed and may contain confidential 
and/or privileged material. Any retransmission, dissemination, copying or 
other use of, or taking of any action in reliance upon this information is 
prohibited. If you are not the intended addressee, please contact the 
sender immediately and delete the materials and information from your 
device and system and confirm the deletion by reply e-mail.

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#1 lore raw

PATCH 1/1 RISC-V: Change signature header field to use `.ascii` instead of opcode

The MZ in the signature header field is now encoded via .ascii to make the kernel compile without the c extension.

---
 arch/riscv/kernel/head.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/kernel/head.S +1 -1
index f52f01ecbeea..931b63464b90 100644
@@ -48,7 +48,7 @@ ENTRY(_start)
 	/*
 	 * This instruction decodes to "MZ" ASCII required by UEFI.
 	 */
-	c.li s4,-13
+	.ascii "MZ"
 	j _start_kernel
 #else
 	/* jump to start kernel */
Signature · 16 lines
2.25.1


-- 
This e-mail message and any attachments thereto are intended only for the 
person or entity to which it is addressed and may contain confidential 
and/or privileged material. Any retransmission, dissemination, copying or 
other use of, or taking of any action in reliance upon this information is 
prohibited. If you are not the intended addressee, please contact the 
sender immediately and delete the materials and information from your 
device and system and confirm the deletion by reply e-mail.

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#2 lore raw

Re: [PATCH 1/1] RISC-V: Change signature header field to use `.ascii` instead of opcode

arch/riscv/kernel/head.S ENTRY(_start) · line 51

Quoted 10 lines · Florian Wagner
arch/riscv/kernel/head.S +1 -1
index f52f01ecbeea..931b63464b90 100644
@@ -48,7 +48,7 @@ ENTRY(_start)
 	/*
 	 * This instruction decodes to "MZ" ASCII required by UEFI.
 	 */
-	c.li s4,-13
+	.ascii "MZ"

The comment above no longer makes sense.

Signature · 8 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#3 lore raw

Re: [PATCH 1/1] RISC-V: Change signature header field to use `.ascii` instead of opcode

In reply to Florian Wagner
Quoted 15 lines · Florian Wagner

The MZ in the signature header field is now encoded via .ascii to make the kernel compile without the c extension.

---
arch/riscv/kernel/head.S | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/kernel/head.S +0 -0
index f52f01ecbeea..931b63464b90 100644

arch/riscv/kernel/head.S ENTRY(_start) · line 52

Quoted 6 lines
arch/riscv/kernel/head.S +1 -1
@@ -48,7 +48,7 @@ ENTRY(_start)
 	/*
 	 * This instruction decodes to "MZ" ASCII required by UEFI.
 	 */
-	c.li s4,-13
+	.ascii "MZ"
 	j _start_kernel

CONFIG_EFI has select RISCV_ISA_C, so this doesn’t seem to achieve anything? If you then remove that select, well, you get an EFI binary that works, but if you jump to it directly as a non-EFI binary then you’ll trap on a non-RVC system as that won’t be a valid instruction. So I think this needs more explanation and discussion.

Jess

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#4 lore raw

Re: [PATCH 1/1] RISC-V: Change signature header field to use `.ascii` instead of opcode

Quoted 10 lines · Jessica Clarke
Quoted 9 lines · Florian Wagner

The MZ in the signature header field is now encoded via .ascii to make the kernel compile without the c extension.

---
arch/riscv/kernel/head.S | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines

arch/riscv/kernel/head.S ENTRY(_start) · line 52

Quoted 11 lines
arch/riscv/kernel/head.S +1 -1
index f52f01ecbeea..931b63464b90 100644
@@ -48,7 +48,7 @@ ENTRY(_start)
 	/*
 	 * This instruction decodes to "MZ" ASCII required by UEFI.
 	 */
-	c.li s4,-13
+	.ascii "MZ"
 	j _start_kernel

CONFIG_EFI has select RISCV_ISA_C, so this doesn’t seem to achieve anything? If you then remove that select, well, you get an EFI binary that works, but if you jump to it directly as a non-EFI binary then you’ll trap on a non-RVC system as that won’t be a valid instruction. So I think this needs more explanation and discussion.

I sent a question[1] before, and there are some advises from Arnd and Palmer.

[1] https://lore.kernel.org/linux-riscv/[email protected]/

Quoted 7 lines

Jess

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#5 lore raw

Re: [PATCH 1/1] RISC-V: Change signature header field to use `.ascii` instead of opcode

In reply to Jessica Clarke
Quoted 21 lines · Jessica Clarke
Quoted 19 lines · Florian Wagner

The MZ in the signature header field is now encoded via .ascii to make the kernel compile without the c extension.

---
arch/riscv/kernel/head.S | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/kernel/head.S +0 -1
index f52f01ecbeea..931b63464b90 100644
@@ -48,7 +48,7 @@ ENTRY(_start)
      /*
       * This instruction decodes to "MZ" ASCII required by UEFI.
       */
-     c.li s4,-13
Quoted 9 lines

arch/riscv/kernel/head.S ENTRY(_start) · line 52

Quoted 2 lines
arch/riscv/kernel/head.S +1 -0
+     .ascii "MZ"
      j _start_kernel

CONFIG_EFI has select RISCV_ISA_C, so this doesn’t seem to achieve anything? If you then remove that select, well, you get an EFI binary that works, but if you jump to it directly as a non-EFI binary then you’ll trap on a non-RVC system as that won’t be a valid instruction. So I think this needs more explanation and discussion.

Here is the previous discussion regarding this.

http://lists.infradead.org/pipermail/linux-riscv/2021-March/004998.html

TLDR, there is no cleaner way to support both EFI & non-UEFI booting on a platform
without C extension. Linux kernel anyways recommend rv64gc for platforms.

Quoted 7 lines

Jess

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

Signature · 7 lines
Regards,
Atish

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
maintainer
#6 lore raw

Re: [PATCH 1/1] RISC-V: Change signature header field to use `.ascii` instead of opcode

Quoted 32 lines · On Mon, 17 Jan 2022 17:25:40 PST (-0800), [email protected] wrote:
Quoted 21 lines · Jessica Clarke
Quoted 19 lines · Florian Wagner

The MZ in the signature header field is now encoded via .ascii to make the kernel compile without the c extension.

---
arch/riscv/kernel/head.S | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/kernel/head.S +0 -1
index f52f01ecbeea..931b63464b90 100644
@@ -48,7 +48,7 @@ ENTRY(_start)
      /*
       * This instruction decodes to "MZ" ASCII required by UEFI.
       */
-     c.li s4,-13
Quoted 9 lines

arch/riscv/kernel/head.S ENTRY(_start) · line 52

Quoted 2 lines
arch/riscv/kernel/head.S +1 -0
+     .ascii "MZ"
      j _start_kernel

CONFIG_EFI has select RISCV_ISA_C, so this doesn’t seem to achieve anything? If you then remove that select, well, you get an EFI binary that works, but if you jump to it directly as a non-EFI binary then you’ll trap on a non-RVC system as that won’t be a valid instruction. So I think this needs more explanation and discussion.

Quoted 7 lines

Here is the previous discussion regarding this.

http://lists.infradead.org/pipermail/linux-riscv/2021-March/004998.html

TLDR, there is no cleaner way to support both EFI & non-UEFI booting on a platform
without C extension. Linux kernel anyways recommend rv64gc for platforms.

Yep, though if there's a use case for yes-EFI, no-C then we could always allow users to build EFI-only kernels (as pointed out in the thread). Is there hardware that actually does that?

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv