Skip to contentSkip to conversation

spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jun 21, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe

It seems that the proper structure field to use in this particular case is *regmap_pushr* instead of regmap.

Addresses-Coverity-ID: 1470126 ("Copy-paste error")

Fixes 58ba07ec79e6 ("spi: spi-fsl-dspi: Add support for XSPI mode registers")
---
 drivers/spi/spi-fsl-dspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-fsl-dspi.c +1 -1
index 1f85dcd..ff7456b 100644
@@ -1066,7 +1066,7 @@ static int dspi_probe(struct platform_device *pdev)
 			dev_err(&pdev->dev,
 				"failed to init pushr regmap: %ld\n",
 				PTR_ERR(dspi->regmap_pushr));
-			ret = PTR_ERR(dspi->regmap);
+			ret = PTR_ERR(dspi->regmap_pushr);
 			goto out_master_put;
 		}
 	}
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Gustavo A. R. Silva

It seems that the proper structure field to use in this particular case is *regmap_pushr* instead of regmap.

Addresses-Coverity-ID: 1470126 ("Copy-paste error")

Fixes 58ba07ec79e6 ("spi: spi-fsl-dspi: Add support for XSPI mode registers")
---
 drivers/spi/spi-fsl-dspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-fsl-dspi.c +0 -0
index 1f85dcd..ff7456b 100644

drivers/spi/spi-fsl-dspi.c static int dspi_probe(struct platform_device *pdev) · line 1072

Quoted 8 lines
drivers/spi/spi-fsl-dspi.c +1 -1
@@ -1066,7 +1066,7 @@ static int dspi_probe(struct platform_device *pdev)
 			dev_err(&pdev->dev,
 				"failed to init pushr regmap: %ld\n",
 				PTR_ERR(dspi->regmap_pushr));
-			ret = PTR_ERR(dspi->regmap);
+			ret = PTR_ERR(dspi->regmap_pushr);
 			goto out_master_put;
 		}
 	}