Skip to contentSkip to conversation

dash: fix static link with libedit

PATCH New Baruch Siach 2 participants 2 messages Mar 2, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dash: fix static link with libedit

libedit is an optional dependency of dash since commit 651af57cf011e (dash: enable line editting if libedit is selected). Unfortunately, the dash build system does not take into account the ncurses dependency of libedit. Use pkgconf to get that right.

Fixes:
http://autobuild.buildroot.net/results/801/801e8bc06277978556a301ddf54f609169de37bb/
http://autobuild.buildroot.net/results/123/12367267735b9165afef77289460c247aaad494a/
http://autobuild.buildroot.net/results/aa7/aa7cc7315d778c15c5165ca6423257a84b957482/

---
 package/dash/dash.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/dash/dash.mk +2 -1
index 87c9cc9f8b87..2ee292b8d3e7 100644
@@ -10,8 +10,9 @@ DASH_LICENSE = BSD-3-Clause, GPL-2.0+ (mksignames.c)
 DASH_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_PACKAGE_LIBEDIT),y)
-DASH_DEPENDENCIES += libedit
+DASH_DEPENDENCIES += libedit host-pkgconf
 DASH_CONF_OPTS += --with-libedit
+DASH_CONF_ENV += LIBS=`pkg-config --libs libedit`
 
 # Enable line editing, Emacs style
 define DASH_INSTALL_PROFILE
Signature · 1 line
2.16.1
#1 lore raw

PATCH 1/1 dash: fix static link with libedit

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

libedit is an optional dependency of dash since commit 651af57cf011e (dash: enable line editting if libedit is selected). Unfortunately, the dash build system does not take into account the ncurses dependency of libedit. Use pkgconf to get that right.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/801/801e8bc06277978556a301ddf54f609169de37bb/
http://autobuild.buildroot.net/results/123/12367267735b9165afef77289460c247aaad494a/
http://autobuild.buildroot.net/results/aa7/aa7cc7315d778c15c5165ca6423257a84b957482/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard